ALSA: hda/cs35l56: Remove dependency on COMPILE_TEST
PATCH 1/1 ALSA: hda/cs35l56: Remove dependency on COMPILE_TEST
Change the Kconfig dependency on ACPI || COMPILE_TEST to only depend on ACPI.
The alternate dependency on COMPILE_TEST was a fudge to enable building KUnit tests for modules that are selected by the CS35L56 driver but don't depend on ACPI. This was based on a misunderstanding that KUNIT_ALL_TESTS meant "all tests". Actually KUNIT_ALL_TESTS only means "tests for modules that have satisfied dependencies" so it shouldn't be overriding dependencies.
--- sound/pci/hda/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
sound/pci/hda/Kconfig +2 -2
@@ -151,7 +151,7 @@ config SND_HDA_SCODEC_CS35L56 config SND_HDA_SCODEC_CS35L56_I2C tristate "Build CS35L56 HD-audio side codec support for I2C Bus" depends on I2C - depends on ACPI || COMPILE_TEST + depends on ACPI depends on SND_SOC select FW_CS_DSP imply SERIAL_MULTI_INSTANTIATE
@@ -167,7 +167,7 @@ config SND_HDA_SCODEC_CS35L56_I2C config SND_HDA_SCODEC_CS35L56_SPI tristate "Build CS35L56 HD-audio side codec support for SPI Bus" depends on SPI_MASTER - depends on ACPI || COMPILE_TEST + depends on ACPI depends on SND_SOC select FW_CS_DSP imply SERIAL_MULTI_INSTANTIATE
Signature · 1 line
2.43.0
Quoted 4 lines · Richard Fitzgerald
Change the
Kconfigdependency on ACPI ||COMPILE_TESTto only depend on ACPI.
Quoted 8 lines
The alternate dependency on
COMPILE_TESTwas a fudge to enable building KUnit tests for modules that are selected by the CS35L56 driver but don't depend on ACPI. This was based on a misunderstanding thatKUNIT_ALL_TESTSmeant "all tests". ActuallyKUNIT_ALL_TESTSonly means "tests for modules that have satisfied dependencies" so it shouldn't be overriding dependencies.Signed-off-by Richard Fitzgerald <[email protected]>
Applied now. Thanks.
Takashi