Skip to contentSkip to conversation

bus: fsl-mc: Use strscpy() instead of strscpy_pad()

PATCH RESEND Applied Thorsten Blum 3 participants 5 messages Apr 29, 2025 – May 17, 2025 QorIQ DPAA2 fsl-mc bus driver

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 bus: fsl-mc: Use strscpy() instead of strscpy_pad()

Both destination buffers are already zero-initialized, making strscpy() sufficient for safely copying 'obj_type'. The additional NUL-padding performed by strscpy_pad() is unnecessary.

If the destination buffer has a fixed length, strscpy() automatically determines its size using sizeof() when the argument is omitted. This makes the explicit size arguments unnecessary.

No functional changes intended.

---
 drivers/bus/fsl-mc/dprc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/bus/fsl-mc/dprc.c +2 -2
index dd1b5c0fb7e2..38d40c09b719 100644
@@ -489,7 +489,7 @@ int dprc_set_obj_irq(struct fsl_mc_io *mc_io,
 	cmd_params->irq_addr = cpu_to_le64(irq_cfg->paddr);
 	cmd_params->irq_num = cpu_to_le32(irq_cfg->irq_num);
 	cmd_params->obj_id = cpu_to_le32(obj_id);
-	strscpy_pad(cmd_params->obj_type, obj_type, 16);
+	strscpy(cmd_params->obj_type, obj_type);
 
 	/* send command to mc*/
 	return mc_send_command(mc_io, &cmd);
@@ -561,7 +561,7 @@ int dprc_get_obj_region(struct fsl_mc_io *mc_io,
 	cmd_params = (struct dprc_cmd_get_obj_region *)cmd.params;
 	cmd_params->obj_id = cpu_to_le32(obj_id);
 	cmd_params->region_index = region_index;
-	strscpy_pad(cmd_params->obj_type, obj_type, 16);
+	strscpy(cmd_params->obj_type, obj_type);
 
 	/* send command to mc*/
 	err = mc_send_command(mc_io, &cmd);
Signature · 1 line
2.49.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Thorsten Blum

Both destination buffers are already zero-initialized, making strscpy() sufficient for safely copying 'obj_type'. The additional NUL-padding performed by strscpy_pad() is unnecessary.

If the destination buffer has a fixed length, strscpy() automatically determines its size using sizeof() when the argument is omitted. This makes the explicit size arguments unnecessary.

No functional changes intended.

Christophe, could you also pick-up this patch when you have a chance?

Thank you,
Ioana

#2 lore raw

Le 29/04/2025 à 13:47, Ioana Ciornei a écrit :

Quoted 9 lines · Thorsten Blum
Quoted 8 lines

Both destination buffers are already zero-initialized, making strscpy() sufficient for safely copying 'obj_type'. The additional NUL-padding performed by strscpy_pad() is unnecessary.

If the destination buffer has a fixed length, strscpy() automatically determines its size using sizeof() when the argument is omitted. This makes the explicit size arguments unnecessary.

Quoted 8 lines
Quoted 3 lines

No functional changes intended.

Christophe, could you also pick-up this patch when you have a chance?

Sure I will take it when time comes, but again I'd expect an explanation inside the patch (below the ---) for the resend. I now have this patch twice in the list and don't know why, see https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=&submitter=&state=&q=&archive=&delegate=61610

Christophe

#3 lore raw

Hi Christophe,

Quoted 10 lines · Christophe Leroy
Quoted 9 lines · Ioana Ciornei
Quoted 8 lines · Thorsten Blum

Both destination buffers are already zero-initialized, making strscpy() sufficient for safely copying 'obj_type'. The additional NUL-padding performed by strscpy_pad() is unnecessary.

If the destination buffer has a fixed length, strscpy() automatically determines its size using sizeof() when the argument is omitted. This makes the explicit size arguments unnecessary.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

No functional changes intended.

Christophe, could you also pick-up this patch when you have a chance?

Sure I will take it when time comes, but again I'd expect an explanation inside the patch (below the ---) for the resend. I now have this patch twice in the list and don't know why, see https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=&submitter=&state=&q=&archive=&delegate=61610

A "resend" is meant as a "ping" and the patch is always unmodified, at least that's my understanding of it. So there's no particular reason other than: "Did you see my patch? Let me send it again just to be sure you didn't miss it."

From [1]: "Don’t add “RESEND” when you are submitting a modified version of your patch or patch series - “RESEND” only applies to resubmission of a patch or patch series which have not been modified in any way from the previous submission."

The patches are identical - just pick one.

Thanks,
Thorsten

[1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#don-t-get-discouraged-or-impatient

#4 lore raw
In reply to Thorsten Blum
Quoted 9 lines · Thorsten Blum

Both destination buffers are already zero-initialized, making strscpy() sufficient for safely copying 'obj_type'. The additional NUL-padding performed by strscpy_pad() is unnecessary.

If the destination buffer has a fixed length, strscpy() automatically determines its size using sizeof() when the argument is omitted. This makes the explicit size arguments unnecessary.

[...]

Applied, thanks!

[1/1] bus: fsl-mc: Use strscpy() instead of strscpy_pad()

      commit: 61ddf5faa7cc091b409936d571ec1af34ce487a1

Best regards,

Signature · 1 line
Christophe Leroy <[email protected]>