Skip to contentSkip to conversation

fsconfig04.c: Use FSCONFIG_SET_FD set overlayfs

PATCH In review Wei Gao via ltp 1 participant 3 messages Apr 30, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fsconfig04.c: Use FSCONFIG_SET_FD set overlayfs

---
 runtest/syscalls                              |   1 +
 testcases/kernel/syscalls/fsconfig/.gitignore |   1 +
 .../kernel/syscalls/fsconfig/fsconfig04.c     | 132 ++++++++++++++++++
 3 files changed, 134 insertions(+)
 create mode 100644 testcases/kernel/syscalls/fsconfig/fsconfig04.c
runtest/syscalls +1 -0
index e369536ea..658ab24c4 100644
@@ -410,6 +410,7 @@ fremovexattr02 fremovexattr02
 fsconfig01 fsconfig01
 fsconfig02 fsconfig02
 fsconfig03 fsconfig03
+fsconfig04 fsconfig04
 
 fsmount01 fsmount01
 fsmount02 fsmount02
testcases/kernel/syscalls/fsconfig/.gitignore +1 -0
index cfedae5f7..bd3754c34 100644
@@ -1,3 +1,4 @@
 /fsconfig01
 /fsconfig02
 /fsconfig03
+/fsconfig04
testcases/kernel/syscalls/fsconfig/fsconfig04.c new file +132 -0

132 lines not on this page · raw message

Signature · 5 lines
2.49.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

Hi!

We miss a description for the commit.

Quoted 35 lines · Wei Gao via ltp
---
  runtest/syscalls                              |   1 +
  testcases/kernel/syscalls/fsconfig/.gitignore |   1 +
  .../kernel/syscalls/fsconfig/fsconfig04.c     | 132 ++++++++++++++++++
  3 files changed, 134 insertions(+)

create mode 100644 testcases/kernel/syscalls/fsconfig/fsconfig04.c

runtest/syscalls +1 -0
index e369536ea..658ab24c4 100644
@@ -410,6 +410,7 @@ fremovexattr02 fremovexattr02
  fsconfig01 fsconfig01
  fsconfig02 fsconfig02
  fsconfig03 fsconfig03
+fsconfig04 fsconfig04
 
  fsmount01 fsmount01
  fsmount02 fsmount02
testcases/kernel/syscalls/fsconfig/.gitignore +1 -0
index cfedae5f7..bd3754c34 100644
@@ -1,3 +1,4 @@
  /fsconfig01
  /fsconfig02
  /fsconfig03
+/fsconfig04
testcases/kernel/syscalls/fsconfig/fsconfig04.c new file +0 -0
new file mode 100644
index 000000000..c77dc9e3a

testcases/kernel/syscalls/fsconfig/fsconfig04.c line 5

Quoted 5 lines
testcases/kernel/syscalls/fsconfig/fsconfig04.c new file +5 -0
@@ -0,0 +1,132 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (c) 2025 Wei Gao <[email protected]>
+ *
+ * Basic fsconfig() test include use FSCONFIG_SET_FD set overlayfs

The description doesn't explain what test is doing. Also, we are not testing only overlayfs inside it due to .all_filesystems=1, so I'm a bit confused.

testcases/kernel/syscalls/fsconfig/fsconfig04.c line 6

Quoted 1 line
testcases/kernel/syscalls/fsconfig/fsconfig04.c new file +1 -0
+ * Refer to selftests/filesystems/overlayfs/set_layers_via_fds.c

I checked the selftests but I don't see a 1:1 with our test. Is this a port? If it's not we probably don't need this comment.

testcases/kernel/syscalls/fsconfig/fsconfig04.c line 17

Quoted 11 lines
testcases/kernel/syscalls/fsconfig/fsconfig04.c new file +11 -0
+ */
+
+#include "tst_test.h"
+#include "lapi/fsmount.h"
+#include "tst_safe_file_at.h"
+#include "tst_safe_stdio.h"
+
+#define MNTPOINT	"mntpoint"
+#define OVERLAYMNT	"set_layers_via_fds"
+
+static int fd, fd_context, fd_overlay;

They are not initialized to -1, so we are going to fail SAFE_CLOSE inside cleanup function. Also it's better to define variables on multiple lines.

Quoted 10 lines
testcases/kernel/syscalls/fsconfig/fsconfig04.c new file +10 -0
+
+static void cleanup(void)
+{
+	if (fd != -1)
+		SAFE_CLOSE(fd);
+
+	if (fd_context != -1)
+		SAFE_CLOSE(fd_context);
+
+	if (fd_overlay != -1)

testcases/kernel/syscalls/fsconfig/fsconfig04.c line 37

Quoted 10 lines
testcases/kernel/syscalls/fsconfig/fsconfig04.c new file +10 -0
+		SAFE_CLOSE(fd_overlay);
+}
+
+static void run(void)
+{
+	int fsmfd;
+
+	fd = TST_EXP_FD(fsopen(tst_device->fs_type, 0));
+
+	TST_EXP_PASS(fsconfig(fd, FSCONFIG_SET_STRING, "source", tst_device->dev, 0));

This should be tested separately.

testcases/kernel/syscalls/fsconfig/fsconfig04.c line 39

Quoted 2 lines
testcases/kernel/syscalls/fsconfig/fsconfig04.c new file +2 -0
+
+	TST_EXP_PASS(fsconfig(fd, FSCONFIG_CMD_CREATE, NULL, NULL, 0));

Also this.

Quoted 9 lines
testcases/kernel/syscalls/fsconfig/fsconfig04.c new file +9 -0
+
+	fsmfd = TST_EXP_FD(fsmount(fd, 0, 0));
+
+	TST_EXP_PASS(mkdirat(fsmfd, "w", 0755));
+	TST_EXP_PASS(mkdirat(fsmfd, "u", 0755));
+	TST_EXP_PASS(mkdirat(fsmfd, "l1", 0755));
+	TST_EXP_PASS(mkdirat(fsmfd, "l2", 0755));
+
+	int layer_fds[] = { [0 ... 3] = -EBADF };

testcases/kernel/syscalls/fsconfig/fsconfig04.c line 58

Quoted 10 lines
testcases/kernel/syscalls/fsconfig/fsconfig04.c new file +10 -0
+
+	layer_fds[0] = SAFE_OPENAT(fsmfd, "w", O_DIRECTORY);
+	layer_fds[1] = SAFE_OPENAT(fsmfd, "u", O_DIRECTORY);
+	layer_fds[2] = SAFE_OPENAT(fsmfd, "l1", O_DIRECTORY);
+	layer_fds[3] = SAFE_OPENAT(fsmfd, "l2", O_DIRECTORY);
+
+	TST_EXP_PASS(move_mount(fsmfd, "", AT_FDCWD, MNTPOINT,
+			MOVE_MOUNT_F_EMPTY_PATH));
+
+	SAFE_CLOSE(fsmfd);

This is one test case.

Quoted 35 lines
testcases/kernel/syscalls/fsconfig/fsconfig04.c new file +35 -0
+
+	fd_context = TST_EXP_FD(fsopen("overlay", 0));
+
+	TST_EXP_PASS(fsconfig(fd_context, FSCONFIG_SET_FD, "workdir", NULL, layer_fds[0]));
+	TST_EXP_PASS(fsconfig(fd_context, FSCONFIG_SET_FD, "upperdir", NULL, layer_fds[1]));
+	TST_EXP_PASS(fsconfig(fd_context, FSCONFIG_SET_FD, "lowerdir+", NULL, layer_fds[2]));
+	TST_EXP_PASS(fsconfig(fd_context, FSCONFIG_SET_FD, "lowerdir+", NULL, layer_fds[3]));
+
+	TST_EXP_PASS(fsconfig(fd_context, FSCONFIG_CMD_CREATE, NULL, NULL, 0));
+
+	SAFE_MKDIR(OVERLAYMNT, 0555);
+
+	fd_overlay = TST_EXP_FD(fsmount(fd_context, 0, 0));
+	SAFE_CLOSE(fd_context);
+
+	TST_EXP_PASS(move_mount(fd_overlay, "", AT_FDCWD, OVERLAYMNT,
+			MOVE_MOUNT_F_EMPTY_PATH));
+
+	char line[PATH_MAX];
+	FILE *file;
+	int ret = 0;
+	char workdir[PATH_MAX], upperdir[PATH_MAX], lowerdir1[PATH_MAX], lowerdir2[PATH_MAX];
+	char *tmpdir_path = tst_tmpdir_path();
+
+	sprintf(workdir, "workdir=%s/%s/w", tmpdir_path, MNTPOINT);
+	sprintf(upperdir, "upperdir=%s/%s/u", tmpdir_path, MNTPOINT);
+	sprintf(lowerdir1, "lowerdir+=%s/%s/l1", tmpdir_path, MNTPOINT);
+	sprintf(lowerdir2, "lowerdir+=%s/%s/l2", tmpdir_path, MNTPOINT);
+
+	file = SAFE_FOPEN("/proc/mounts", "r");
+	while (fgets(line, sizeof(line), file)) {
+		if (strstr(line, workdir) && strstr(line, upperdir)
+				&& strstr(line, lowerdir1) && strstr(line, lowerdir2)) {
+			ret = 1;
+			break;

testcases/kernel/syscalls/fsconfig/fsconfig04.c line 103

Quoted 10 lines
testcases/kernel/syscalls/fsconfig/fsconfig04.c new file +10 -0
+		}
+	}
+
+	if (ret == 1)
+		tst_res(TPASS, "overlay mount check pass");
+	else
+		tst_res(TFAIL, "overlay mount check failed");
+
+	TST_EXP_PASS_SILENT(system("ls -l"));
+

This is not needed.

testcases/kernel/syscalls/fsconfig/fsconfig04.c line 107

Quoted 4 lines
testcases/kernel/syscalls/fsconfig/fsconfig04.c new file +4 -0
+	char rmcmd[PATH_MAX];
+
+	sprintf(rmcmd, "rm -r ./%s/*", MNTPOINT);
+	TST_EXP_PASS_SILENT(system(rmcmd));

Why we try to remove the whole mnpoint via rm command?

Quoted 15 lines
testcases/kernel/syscalls/fsconfig/fsconfig04.c new file +15 -0
+
+	SAFE_CLOSE(fd_overlay);
+	SAFE_UMOUNT(OVERLAYMNT);
+	SAFE_RMDIR(OVERLAYMNT);
+
+	SAFE_CLOSE(fd);
+
+	for (int i = 0; i < 4; i++)
+		SAFE_CLOSE(layer_fds[i]);
+
+	if (tst_is_mounted_at_tmpdir(MNTPOINT)) {
+		SAFE_UMOUNT(MNTPOINT);
+	}
+}
+

testcases/kernel/syscalls/fsconfig/fsconfig04.c line 132

Quoted 10 lines
testcases/kernel/syscalls/fsconfig/fsconfig04.c new file +10 -0
+static struct tst_test test = {
+	.test_all = run,
+	.setup = fsopen_supported_by_kernel,
+	.cleanup = cleanup,
+	.needs_root = 1,
+	.format_device = 1,
+	.mntpoint = MNTPOINT,
+	.all_filesystems = 1,
+	.skip_filesystems = (const char *const []){"ntfs", "vfat", "exfat", NULL},
+};

In general I think we are not achieving the goal given by https://github.com/linux-test-project/ltp/issues/1169 so this patch can't be considered valid. There are many issues due to the mix of different flags usage and the broken execution of the test as well.

The idea is to test the following flags, each one separately in order to verify if they are correctly working:

- FSCONFIG_SET_PATH
- FSCONFIG_SET_BINARY
- FSCONFIG_SET_FD

All of them should be tested with a separate test in an atomic way: we open a new filesystem context object using fsopen(), then we set its key/keys via fsconfig() using one of the flags above and we verify that they affected the filesystem context.

There are also many other flags. I suggest you to take a look at include/uapi/linux/mount.h in case we need to cover more of them.

- Andrea

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#2 lore raw
Quoted 46 lines · Andrea Cervesato

Hi!

We miss a description for the commit.

Quoted 34 lines · Wei Gao via ltp
---
  runtest/syscalls                              |   1 +
  testcases/kernel/syscalls/fsconfig/.gitignore |   1 +
  .../kernel/syscalls/fsconfig/fsconfig04.c     | 132 ++++++++++++++++++
  3 files changed, 134 insertions(+)

create mode 100644 testcases/kernel/syscalls/fsconfig/fsconfig04.c

runtest/syscalls +1 -0
index e369536ea..658ab24c4 100644
@@ -410,6 +410,7 @@ fremovexattr02 fremovexattr02
  fsconfig01 fsconfig01
  fsconfig02 fsconfig02
  fsconfig03 fsconfig03
+fsconfig04 fsconfig04
  fsmount01 fsmount01
  fsmount02 fsmount02
testcases/kernel/syscalls/fsconfig/.gitignore +1 -0
index cfedae5f7..bd3754c34 100644
@@ -1,3 +1,4 @@
  /fsconfig01
  /fsconfig02
  /fsconfig03
+/fsconfig04
testcases/kernel/syscalls/fsconfig/fsconfig04.c new file +0 -0
new file mode 100644
index 000000000..c77dc9e3a

testcases/kernel/syscalls/fsconfig/fsconfig04.c line 5

Quoted 5 lines
testcases/kernel/syscalls/fsconfig/fsconfig04.c new file +5 -0
@@ -0,0 +1,132 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (c) 2025 Wei Gao <[email protected]>
+ *
+ * Basic fsconfig() test include use FSCONFIG_SET_FD set overlayfs

The description doesn't explain what test is doing. Also, we are not testing only overlayfs inside it due to .all_filesystems=1, so I'm a bit confused.

Quoted 3 lines

testcases/kernel/syscalls/fsconfig/fsconfig04.c line 6

Quoted 1 line
testcases/kernel/syscalls/fsconfig/fsconfig04.c new file +1 -0
+ * Refer to selftests/filesystems/overlayfs/set_layers_via_fds.c

I checked the selftests but I don't see a 1:1 with our test. Is this a port? If it's not we probably don't need this comment.

The main logic is refer to TEST_F(set_layers_via_fds, set_override_creds) in kernel selftest.

Quoted 104 lines

testcases/kernel/syscalls/fsconfig/fsconfig04.c line 17

Quoted 11 lines
testcases/kernel/syscalls/fsconfig/fsconfig04.c new file +11 -0
+ */
+
+#include "tst_test.h"
+#include "lapi/fsmount.h"
+#include "tst_safe_file_at.h"
+#include "tst_safe_stdio.h"
+
+#define MNTPOINT	"mntpoint"
+#define OVERLAYMNT	"set_layers_via_fds"
+
+static int fd, fd_context, fd_overlay;

They are not initialized to -1, so we are going to fail SAFE_CLOSE inside cleanup function.
Also it's better to define variables on multiple lines.

Quoted 10 lines
testcases/kernel/syscalls/fsconfig/fsconfig04.c new file +10 -0
+
+static void cleanup(void)
+{
+	if (fd != -1)
+		SAFE_CLOSE(fd);
+
+	if (fd_context != -1)
+		SAFE_CLOSE(fd_context);
+
+	if (fd_overlay != -1)

testcases/kernel/syscalls/fsconfig/fsconfig04.c line 37

Quoted 10 lines
testcases/kernel/syscalls/fsconfig/fsconfig04.c new file +10 -0
+		SAFE_CLOSE(fd_overlay);
+}
+
+static void run(void)
+{
+	int fsmfd;
+
+	fd = TST_EXP_FD(fsopen(tst_device->fs_type, 0));
+
+	TST_EXP_PASS(fsconfig(fd, FSCONFIG_SET_STRING, "source", tst_device->dev, 0));

This should be tested separately.

testcases/kernel/syscalls/fsconfig/fsconfig04.c line 39

Quoted 2 lines
testcases/kernel/syscalls/fsconfig/fsconfig04.c new file +2 -0
+
+	TST_EXP_PASS(fsconfig(fd, FSCONFIG_CMD_CREATE, NULL, NULL, 0));

Also this.

Quoted 9 lines
testcases/kernel/syscalls/fsconfig/fsconfig04.c new file +9 -0
+
+	fsmfd = TST_EXP_FD(fsmount(fd, 0, 0));
+
+	TST_EXP_PASS(mkdirat(fsmfd, "w", 0755));
+	TST_EXP_PASS(mkdirat(fsmfd, "u", 0755));
+	TST_EXP_PASS(mkdirat(fsmfd, "l1", 0755));
+	TST_EXP_PASS(mkdirat(fsmfd, "l2", 0755));
+
+	int layer_fds[] = { [0 ... 3] = -EBADF };

testcases/kernel/syscalls/fsconfig/fsconfig04.c line 58

Quoted 10 lines
testcases/kernel/syscalls/fsconfig/fsconfig04.c new file +10 -0
+
+	layer_fds[0] = SAFE_OPENAT(fsmfd, "w", O_DIRECTORY);
+	layer_fds[1] = SAFE_OPENAT(fsmfd, "u", O_DIRECTORY);
+	layer_fds[2] = SAFE_OPENAT(fsmfd, "l1", O_DIRECTORY);
+	layer_fds[3] = SAFE_OPENAT(fsmfd, "l2", O_DIRECTORY);
+
+	TST_EXP_PASS(move_mount(fsmfd, "", AT_FDCWD, MNTPOINT,
+			MOVE_MOUNT_F_EMPTY_PATH));
+
+	SAFE_CLOSE(fsmfd);

This is one test case.

Quoted 35 lines
testcases/kernel/syscalls/fsconfig/fsconfig04.c new file +35 -0
+
+	fd_context = TST_EXP_FD(fsopen("overlay", 0));
+
+	TST_EXP_PASS(fsconfig(fd_context, FSCONFIG_SET_FD, "workdir", NULL, layer_fds[0]));
+	TST_EXP_PASS(fsconfig(fd_context, FSCONFIG_SET_FD, "upperdir", NULL, layer_fds[1]));
+	TST_EXP_PASS(fsconfig(fd_context, FSCONFIG_SET_FD, "lowerdir+", NULL, layer_fds[2]));
+	TST_EXP_PASS(fsconfig(fd_context, FSCONFIG_SET_FD, "lowerdir+", NULL, layer_fds[3]));
+
+	TST_EXP_PASS(fsconfig(fd_context, FSCONFIG_CMD_CREATE, NULL, NULL, 0));
+
+	SAFE_MKDIR(OVERLAYMNT, 0555);
+
+	fd_overlay = TST_EXP_FD(fsmount(fd_context, 0, 0));
+	SAFE_CLOSE(fd_context);
+
+	TST_EXP_PASS(move_mount(fd_overlay, "", AT_FDCWD, OVERLAYMNT,
+			MOVE_MOUNT_F_EMPTY_PATH));
+
+	char line[PATH_MAX];
+	FILE *file;
+	int ret = 0;
+	char workdir[PATH_MAX], upperdir[PATH_MAX], lowerdir1[PATH_MAX], lowerdir2[PATH_MAX];
+	char *tmpdir_path = tst_tmpdir_path();
+
+	sprintf(workdir, "workdir=%s/%s/w", tmpdir_path, MNTPOINT);
+	sprintf(upperdir, "upperdir=%s/%s/u", tmpdir_path, MNTPOINT);
+	sprintf(lowerdir1, "lowerdir+=%s/%s/l1", tmpdir_path, MNTPOINT);
+	sprintf(lowerdir2, "lowerdir+=%s/%s/l2", tmpdir_path, MNTPOINT);
+
+	file = SAFE_FOPEN("/proc/mounts", "r");
+	while (fgets(line, sizeof(line), file)) {
+		if (strstr(line, workdir) && strstr(line, upperdir)
+				&& strstr(line, lowerdir1) && strstr(line, lowerdir2)) {
+			ret = 1;
+			break;

testcases/kernel/syscalls/fsconfig/fsconfig04.c line 103

Quoted 10 lines
testcases/kernel/syscalls/fsconfig/fsconfig04.c new file +10 -0
+		}
+	}
+
+	if (ret == 1)
+		tst_res(TPASS, "overlay mount check pass");
+	else
+		tst_res(TFAIL, "overlay mount check failed");
+
+	TST_EXP_PASS_SILENT(system("ls -l"));
+

This is not needed.

Quoted 5 lines

testcases/kernel/syscalls/fsconfig/fsconfig04.c line 107

Quoted 4 lines
testcases/kernel/syscalls/fsconfig/fsconfig04.c new file +4 -0
+	char rmcmd[PATH_MAX];
+
+	sprintf(rmcmd, "rm -r ./%s/*", MNTPOINT);
+	TST_EXP_PASS_SILENT(system(rmcmd));

Why we try to remove the whole mnpoint via rm command?

When you run with -i2 without above remove action you will encounter following error, the mkdirat report EEXIST even after close fsmfd. Maybe contain potentail bug, so i put this workaround here.

tst_test.c:1831: TINFO: === Testing on ext2 ===
tst_test.c:1170: TINFO: Formatting /dev/loop2 with ext2 opts='' extra opts=''
mke2fs 1.47.2 (1-Jan-2025)
fsconfig04.c:35: TPASS: fsopen(tst_device->fs_type, 0) returned fd 3
fsconfig04.c:37: TPASS: fsconfig(fd, FSCONFIG_SET_STRING, "source", tst_device->dev, 0) passed fsconfig04.c:39: TPASS: fsconfig(fd, FSCONFIG_CMD_CREATE, NULL, NULL, 0) passed fsconfig04.c:41: TPASS: fsmount(fd, 0, 0) returned fd 4
fsconfig04.c:43: TPASS: mkdirat(fsmfd, "w", 0755) passed
fsconfig04.c:44: TPASS: mkdirat(fsmfd, "u", 0755) passed
fsconfig04.c:45: TPASS: mkdirat(fsmfd, "l1", 0755) passed
fsconfig04.c:46: TPASS: mkdirat(fsmfd, "l2", 0755) passed
fsconfig04.c:55: TPASS: move_mount(fsmfd, "", AT_FDCWD, MNTPOINT, MOVE_MOUNT_F_EMPTY_PATH) passed fsconfig04.c:60: TPASS: fsopen("overlay", 0) returned fd 4
fsconfig04.c:62: TPASS: fsconfig(fd_context, FSCONFIG_SET_FD, "workdir", NULL, layer_fds[0]) passed fsconfig04.c:63: TPASS: fsconfig(fd_context, FSCONFIG_SET_FD, "upperdir", NULL, layer_fds[1]) passed fsconfig04.c:64: TPASS: fsconfig(fd_context, FSCONFIG_SET_FD, "lowerdir+", NULL, layer_fds[2]) passed fsconfig04.c:65: TPASS: fsconfig(fd_context, FSCONFIG_SET_FD, "lowerdir+", NULL, layer_fds[3]) passed fsconfig04.c:67: TPASS: fsconfig(fd_context, FSCONFIG_CMD_CREATE, NULL, NULL, 0) passed fsconfig04.c:71: TPASS: fsmount(fd_context, 0, 0) returned fd 9
fsconfig04.c:74: TPASS: move_mount(fd_overlay, "", AT_FDCWD, OVERLAYMNT, MOVE_MOUNT_F_EMPTY_PATH) passed tst_buffers.c:57: TINFO: Test is using guarded buffers
fsconfig04.c:98: TPASS: overlay mount check pass
total 19794
drwxr-xr-x 7 root root 1024 Apr 30 19:43 mntpoint
drwxr-xr-x 1 root root 1024 Apr 30 19:43 set_layers_via_fds
-rw------- 1 root root 314572800 Apr 30 19:43 test_dev.img
fsconfig04.c:110: TINFO: Umounting /tmp/LTP_fscv0Sg2g/set_layers_via_fds fsconfig04.c:119: TINFO: Umounting /tmp/LTP_fscv0Sg2g/mntpoint
fsconfig04.c:35: TPASS: fsopen(tst_device->fs_type, 0) returned fd 3
fsconfig04.c:37: TPASS: fsconfig(fd, FSCONFIG_SET_STRING, "source", tst_device->dev, 0) passed fsconfig04.c:39: TPASS: fsconfig(fd, FSCONFIG_CMD_CREATE, NULL, NULL, 0) passed fsconfig04.c:41: TPASS: fsmount(fd, 0, 0) returned fd 5
fsconfig04.c:43: TFAIL: mkdirat(fsmfd, "w", 0755) failed: EEXIST (17)
fsconfig04.c:44: TFAIL: mkdirat(fsmfd, "u", 0755) failed: EEXIST (17)
fsconfig04.c:45: TFAIL: mkdirat(fsmfd, "l1", 0755) failed: EEXIST (17)
fsconfig04.c:46: TFAIL: mkdirat(fsmfd, "l2", 0755) failed: EEXIST (17)
fsconfig04.c:55: TPASS: move_mount(fsmfd, "", AT_FDCWD, MNTPOINT, MOVE_MOUNT_F_EMPTY_PATH) passed fsconfig04.c:60: TPASS: fsopen("overlay", 0) returned fd 5
fsconfig04.c:62: TPASS: fsconfig(fd_context, FSCONFIG_SET_FD, "workdir", NULL, layer_fds[0]) passed fsconfig04.c:63: TPASS: fsconfig(fd_context, FSCONFIG_SET_FD, "upperdir", NULL, layer_fds[1]) passed fsconfig04.c:64: TPASS: fsconfig(fd_context, FSCONFIG_SET_FD, "lowerdir+", NULL, layer_fds[2]) passed fsconfig04.c:65: TPASS: fsconfig(fd_context, FSCONFIG_SET_FD, "lowerdir+", NULL, layer_fds[3]) passed fsconfig04.c:67: TPASS: fsconfig(fd_context, FSCONFIG_CMD_CREATE, NULL, NULL, 0) passed fsconfig04.c:71: TPASS: fsmount(fd_context, 0, 0) returned fd 10
fsconfig04.c:74: TPASS: move_mount(fd_overlay, "", AT_FDCWD, OVERLAYMNT, MOVE_MOUNT_F_EMPTY_PATH) passed fsconfig04.c:98: TPASS: overlay mount check pass
total 19794

Quoted 33 lines
Quoted 15 lines
testcases/kernel/syscalls/fsconfig/fsconfig04.c new file +15 -0
+
+	SAFE_CLOSE(fd_overlay);
+	SAFE_UMOUNT(OVERLAYMNT);
+	SAFE_RMDIR(OVERLAYMNT);
+
+	SAFE_CLOSE(fd);
+
+	for (int i = 0; i < 4; i++)
+		SAFE_CLOSE(layer_fds[i]);
+
+	if (tst_is_mounted_at_tmpdir(MNTPOINT)) {
+		SAFE_UMOUNT(MNTPOINT);
+	}
+}
+

testcases/kernel/syscalls/fsconfig/fsconfig04.c line 132

Quoted 10 lines
testcases/kernel/syscalls/fsconfig/fsconfig04.c new file +10 -0
+static struct tst_test test = {
+	.test_all = run,
+	.setup = fsopen_supported_by_kernel,
+	.cleanup = cleanup,
+	.needs_root = 1,
+	.format_device = 1,
+	.mntpoint = MNTPOINT,
+	.all_filesystems = 1,
+	.skip_filesystems = (const char *const []){"ntfs", "vfat", "exfat", NULL},
+};

In general I think we are not achieving the goal given by
https://github.com/linux-test-project/ltp/issues/1169 so this patch can't be considered valid. There are many issues due to the mix of different flags usage and the broken execution of the test as well.

The idea is to test the following flags, each one separately in order to verify if they are correctly working:

Quoted 8 lines

- FSCONFIG_SET_PATH
- FSCONFIG_SET_BINARY
- FSCONFIG_SET_FD

All of them should be tested with a separate test in an atomic way: we open a new filesystem context object using fsopen(), then we set its key/keys via fsconfig() using one of the flags above and we verify that they affected the filesystem context.

Thanks for point out, since currently i have trouble to find correct API like fs_getconfig to check the real effect, so above heavy scenario introduced by me :) Will rethinking how to check with simple set / get for each cmd operation.

Quoted 3 lines

There are also many other flags. I suggest you to take a look at include/uapi/linux/mount.h in case we need to cover more of them.

Will check it.

Quoted 2 lines

- Andrea

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp