ALSA: hda: Remove unused snd_hdac_stream_get_spbmaxfifo
PATCH 1/1 ALSA: hda: Remove unused snd_hdac_stream_get_spbmaxfifo
From: "Dr. David Alan Gilbert" <[email protected]>
snd_hdac_stream_get_spbmaxfifo() was originally added in 2015 in commit ee8bc4df1b5a ("ALSA: hdac: Add support to enable SPIB for hdac ext stream")
when it was originally called snd_hdac_ext_stream_set_spbmaxfifo, it was renamed snd_hdac_ext_stream_get_spbmaxfifo shortly after and was finally renamed to snd_hdac_stream_get_spbmaxfifo in 2022. But it was never used.
Remove it.
--- include/sound/hdaudio.h | 2 -- sound/hda/hdac_stream.c | 19 ------------------- 2 files changed, 21 deletions(-)
include/sound/hdaudio.h +0 -2
@@ -598,8 +598,6 @@ void snd_hdac_stream_spbcap_enable(struct hdac_bus *chip, bool enable, int index);int snd_hdac_stream_set_spib (struct hdac_bus *bus,struct hdac_stream *azx_dev,u32 value); -int snd_hdac_stream_get_spbmaxfifo (struct hdac_bus *bus, -struct hdac_stream *azx_dev);void snd_hdac_stream_drsm_enable (struct hdac_bus *bus,bool enable,int index);int snd_hdac_stream_wait_drsm (struct hdac_stream *azx_dev);
sound/hda/hdac_stream.c +0 -19
@@ -825,25 +825,6 @@ int snd_hdac_stream_set_spib(struct hdac_bus *bus, }EXPORT_SYMBOL_GPL (snd_hdac_stream_set_spib); -/** -* snd_hdac_stream_get_spbmaxfifo - gets the spib value of a stream -* @bus: HD-audio core bus -* @azx_dev: hdac_stream -* -* Return maxfifo for the stream -*/ -int snd_hdac_stream_get_spbmaxfifo (struct hdac_bus *bus, -struct hdac_stream *azx_dev) -{ -if (!bus->spbcap) { -dev_err (bus->dev,"Address of SPB capability is NULL\n" ); -return -EINVAL ; - } - -return readl (azx_dev->fifo_addr); -} -EXPORT_SYMBOL_GPL (snd_hdac_stream_get_spbmaxfifo); -/** * snd_hdac_stream_drsm_enable - enable DMA resume for a stream * @bus: HD-audio core bus
Signature · 1 line
2.49.0
Takashi Iwai
AppliedQuoted 7 lines · On Mon, 05 May 2025 03:10:37 +0200, [email protected] wrote:
From: "Dr. David Alan Gilbert" <[email protected]>
snd_hdac_stream_get_spbmaxfifo()was originally added in 2015 in commitee8bc4df1b5a("ALSA: hdac: Add support to enable SPIB for hdac ext stream")
Quoted 8 lines
when it was originally called
snd_hdac_ext_stream_set_spbmaxfifo, it was renamedsnd_hdac_ext_stream_get_spbmaxfifoshortly after and was finally renamed tosnd_hdac_stream_get_spbmaxfifoin 2022. But it was never used.Remove it.
Signed-off-by Dr. David Alan Gilbert <[email protected]>
Thanks, applied now.
Takashi