IB/hfi1: Remove unused sc_drop and sdma_all_idle
Subsystems (2)
PATCH 1/1 IB/hfi1: Remove unused sc_drop and sdma_all_idle
From: "Dr. David Alan Gilbert" <[email protected]>
sc_drop() and sdma_all_idle() were both added in 2015's commit 7724105686e7 ("IB/hfi1: add driver files")
but have remained unused.
Remove them.
Signed-off-by Dr. David Alan Gilbert <[email protected]>
--- drivers/infiniband/hw/hfi1/pio.c | 10 ---------- drivers/infiniband/hw/hfi1/pio.h | 1 - drivers/infiniband/hw/hfi1/sdma.c | 18 ------------------ drivers/infiniband/hw/hfi1/sdma.h | 1 - 4 files changed, 30 deletions(-)
drivers/infiniband/hw/hfi1/pio.c +0 -10
@@ -1361,16 +1361,6 @@ void sc_flush(struct send_context *sc)sc_wait_for_packet_egress (sc,1 ); } -/* drop all packets on the context, no waiting until they are sent */ -void sc_drop (struct send_context *sc) -{ -if (!sc) -return ; - -dd_dev_info (sc->dd,"%s: context %u(%u) - not implemented\n" , - __func__, sc->sw_index, sc->hw_context); -} -/* * Start the software reaction to a context halt or SPC freeze: * - mark the context as halted or frozen
drivers/infiniband/hw/hfi1/pio.h +0 -1
@@ -246,7 +246,6 @@ void sc_disable(struct send_context *sc);int sc_restart (struct send_context *sc);void sc_return_credits (struct send_context *sc);void sc_flush (struct send_context *sc); -void sc_drop (struct send_context *sc);void sc_stop (struct send_context *sc,int bit);struct pio_buf *sc_buffer_alloc (struct send_context *sc,u32 dw_len,pio_release_cb cb,void *arg);
drivers/infiniband/hw/hfi1/sdma.c +0 -18
@@ -1520,24 +1520,6 @@ void sdma_all_running(struct hfi1_devdata *dd) } } -/** -* sdma_all_idle() - called when the link goes down -* @dd: hfi1_devdata -* -* This routine moves all engines to the idle state. -*/ -void sdma_all_idle (struct hfi1_devdata *dd) -{ -struct sdma_engine *sde; -unsigned int i; - -/* idle all engines */ -for (i =0 ; i < dd->num_sdma; ++i) { - sde = &dd->per_sdma[i]; -sdma_process_event (sde, sdma_event_e70_go_idle); - } -} -/** * sdma_start() - called to kick off state processing for all engines * @dd: hfi1_devdata
drivers/infiniband/hw/hfi1/sdma.h +0 -1
@@ -373,7 +373,6 @@ void sdma_start(struct hfi1_devdata *dd);void sdma_exit (struct hfi1_devdata *dd);void sdma_clean (struct hfi1_devdata *dd,size_t num_engines);void sdma_all_running (struct hfi1_devdata *dd); -void sdma_all_idle (struct hfi1_devdata *dd);void sdma_freeze_notify (struct hfi1_devdata *dd,int go_idle);void sdma_freeze (struct hfi1_devdata *dd);void sdma_unfreeze (struct hfi1_devdata *dd);
Signature · 1 line
2.49.0
Quoted 9 lines · On Mon, May 05, 2025 at 09:54:19PM +0100, [email protected] wrote:
From: "Dr. David Alan Gilbert" <[email protected]>
sc_drop()andsdma_all_idle()were both added in 2015's commit7724105686e7("IB/hfi1: add driver files")but have remained unused.
Remove them.
Quoted 7 lines
Signed-off-by Dr. David Alan Gilbert <[email protected]>--- drivers/infiniband/hw/hfi1/pio.c | 10 ---------- drivers/infiniband/hw/hfi1/pio.h | 1 - drivers/infiniband/hw/hfi1/sdma.c | 18 ------------------ drivers/infiniband/hw/hfi1/sdma.h | 1 - 4 files changed, 30 deletions(-)
Applied to for-next, thanks
Jason