Skip to contentSkip to conversation

ufs: core: behavior change of hwq_id type and value

PATCH Superseded [email protected] 2 participants 3 messages May 8, 2025 – May 9, 2025

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ufs: core: behavior change of hwq_id type and value

From: Peter Wang <[email protected]>

Because the member id of struct ufs_hw_queue is u32 (hwq->id) and the trace entry hwq_id is also u32, the type should be changed to u32. If mcq is not supported, SDB mode only supports one hardware queue, for which setting the hwq_id to 0 is more suitable.

---
 drivers/ufs/core/ufshcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ufs/core/ufshcd.c +1 -1
index 7735421e3991..14e4cfbcb9eb 100644
@@ -432,7 +432,7 @@ static void ufshcd_add_command_trace(struct ufs_hba *hba, unsigned int tag,
 	u8 opcode = 0, group_id = 0;
 	u32 doorbell = 0;
 	u32 intr;
-	int hwq_id = -1;
+	u32 hwq_id = 0;
 	struct ufshcd_lrb *lrbp = &hba->lrb[tag];
 	struct scsi_cmnd *cmd = lrbp->cmd;
 	struct request *rq = scsi_cmd_to_rq(cmd);
Signature · 1 line
2.45.2
#2 lore raw
Quoted 5 lines · Bart Van Assche

External email : Please do not click links or open attachments until you have verified the sender or the content.

Quoted 7 lines
Quoted 1 line · On 5/8/25 2:18 AM, [email protected] wrote:

From: Peter Wang <[email protected]>

Patch descriptions, including the subject, should use the imperative mood. Anyway:

Hi Bart,

Okay, I will use the imperative mood for patch descriptions. Thanks for the review.

Peter