f2fs/013: test to check potential corruption on atomic_write file
PATCH v3 1/1 f2fs/013: test to check potential corruption on atomic_write file
This is a regression testcase to check whether we will handle database inode dirty status correctly:
1. mount f2fs image w/ timeout fault injection option
2. create a regular file, and write data into the file
3. start transaction on the file (via F2FS_IOC_START_ATOMIC_WRITE)
4. write transaction data to the file
5. commit and end the transaction (via F2FS_IOC_COMMIT_ATOMIC_WRITE)
6. meanwhile loop call fsync in parallel
Before f098aeba04c9 ("f2fs: fix to avoid atomicity corruption of atomic file"), database file may become corrupted after atomic write while there is concurrent dirty inode flush in background.
---
v3:
- fix typo: s/relis/relies
tests/f2fs/013 | 71 ++++++++++++++++++++++++++++++++++++++++++++++ tests/f2fs/013.out | 2 ++ 2 files changed, 73 insertions(+) create mode 100755 tests/f2fs/013 create mode 100644 tests/f2fs/013.out
tests/f2fs/013 new file +71 -0
@@ -0,0 +1,71 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2025 Chao Yu. All Rights Reserved. +# +# FS QA Test No. f2fs/013 +# +# This is a regression testcase to check whether we will handle database +# inode dirty status correctly: +# 1. mount f2fs image w/ timeout fault injection option +# 2. create a regular file, and write data into the file +# 3. start transaction on the file (via F2FS_IOC_START_ATOMIC_WRITE) +# 4. write transaction data to the file +# 5. commit and end the transaction (via F2FS_IOC_COMMIT_ATOMIC_WRITE) +# 6. meanwhile loop call fsync in parallel +# Before f098aeba04c9 ("f2fs: fix to avoid atomicity corruption of atomic +# file"), database file may become corrupted after atomic write while +# there is concurrent dirty inode flush in background. +# +. ./common/preamble +_begin_fstest auto quick +_require_kernel_config CONFIG_F2FS_FAULT_INJECTION +_require_command "$F2FS_IO_PROG" f2fs_io + +_cleanup() +{ + [ -n "$atomic_write_pid" ] && kill -9 $atomic_write_pid + wait + cd / + rm -r -f $tmp.* +} + +_fixed_by_kernel_commit f098aeba04c9 \ + "f2fs: fix to avoid atomicity corruption of atomic file" + +_require_scratch + +_scratch_mkfs >> $seqres.full +# note that it relies on FAULT_TIMEOUT fault injection support in f2fs +_scratch_mount "-o fault_injection=1,fault_type=4194304" >> $seqres.full + +dbfile=$SCRATCH_MNT/file.db + +# initialize database file +$XFS_IO_PROG -c "pwrite 0 4k" -c "fsync" -f $dbfile >> $seqres.full + +# sync filesystem to clear dirty inode +sync + +# start atomic_write on src.db database file and commit transaction +$F2FS_IO_PROG write 1 0 2 zero atomic_commit $dbfile >> $seqres.full & +atomic_write_pid=$! + +# call fsync to flush dirty inode of database file in parallel +for ((j=0;j<1000;j++)) do + $F2FS_IO_PROG fsync $dbfile >> $seqres.full +done + +wait $atomic_write_pid +unset atomic_write_pid + +# flush dirty data and drop cache +sync +echo 3 > /proc/sys/vm/drop_caches + +stat $dbfile -c %s + +rm $dbfile +sync + +status=0 +exit
tests/f2fs/013.out new file +2 -0
@@ -0,0 +1,2 @@ +QA output created by 013 +8192
Signature · 1 line
2.49.0
Quoted 12 lines · Chao Yu
This is a regression testcase to check whether we will handle database inode dirty status correctly:
1. mount f2fs image w/ timeout fault injection option
2. create a regular file, and write data into the file
3. start transaction on the file (viaF2FS_IOC_START_ATOMIC_WRITE)
4. write transaction data to the file
5. commit and end the transaction (viaF2FS_IOC_COMMIT_ATOMIC_WRITE)
6. meanwhile loop call fsync in parallel
Beforef098aeba04c9("f2fs: fix to avoid atomicity corruption of atomic file"), database file may become corrupted after atomic write while there is concurrent dirty inode flush in background.
Quoted 3 lines
Cc Jaegeuk Kim <[email protected]>Cc Daeho Jeong <[email protected]>Signed-off-by Chao Yu <[email protected]>
Looks good.
Quoted 12 lines · Chao Yu
This is a regression testcase to check whether we will handle database inode dirty status correctly:
1. mount f2fs image w/ timeout fault injection option
2. create a regular file, and write data into the file
3. start transaction on the file (viaF2FS_IOC_START_ATOMIC_WRITE)
4. write transaction data to the file
5. commit and end the transaction (viaF2FS_IOC_COMMIT_ATOMIC_WRITE)
6. meanwhile loop call fsync in parallel
Beforef098aeba04c9("f2fs: fix to avoid atomicity corruption of atomic file"), database file may become corrupted after atomic write while there is concurrent dirty inode flush in background.
Quoted 6 lines
Cc Jaegeuk Kim <[email protected]>Cc Daeho Jeong <[email protected]>Signed-off-by Chao Yu <[email protected]>---
v3:
- fix typo: s/relis/relies
This version is good to me, thanks!
Quoted 95 lines
tests/f2fs/013 | 71 ++++++++++++++++++++++++++++++++++++++++++++++ tests/f2fs/013.out | 2 ++ 2 files changed, 73 insertions(+) create mode 100755 tests/f2fs/013 create mode 100644 tests/f2fs/013.outtests/f2fs/013 new file +71
-0@@ -0,0 +1,71 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2025 Chao Yu. All Rights Reserved. +# +# FS QA Test No. f2fs/013 +# +# This is a regression testcase to check whether we will handle database +# inode dirty status correctly: +# 1. mount f2fs image w/ timeout fault injection option +# 2. create a regular file, and write data into the file +# 3. start transaction on the file (via F2FS_IOC_START_ATOMIC_WRITE) +# 4. write transaction data to the file +# 5. commit and end the transaction (via F2FS_IOC_COMMIT_ATOMIC_WRITE) +# 6. meanwhile loop call fsync in parallel +# Before f098aeba04c9 ("f2fs: fix to avoid atomicity corruption of atomic +# file"), database file may become corrupted after atomic write while +# there is concurrent dirty inode flush in background. +# +. ./common/preamble +_begin_fstest auto quick +_require_kernel_config CONFIG_F2FS_FAULT_INJECTION +_require_command "$F2FS_IO_PROG" f2fs_io + +_cleanup() +{ + [ -n "$atomic_write_pid" ] && kill -9 $atomic_write_pid + wait + cd / + rm -r -f $tmp.* +} + +_fixed_by_kernel_commit f098aeba04c9 \ + "f2fs: fix to avoid atomicity corruption of atomic file" + +_require_scratch + +_scratch_mkfs >> $seqres.full +# note that it relies on FAULT_TIMEOUT fault injection support in f2fs +_scratch_mount "-o fault_injection=1,fault_type=4194304" >> $seqres.full + +dbfile=$SCRATCH_MNT/file.db + +# initialize database file +$XFS_IO_PROG -c "pwrite 0 4k" -c "fsync" -f $dbfile >> $seqres.full + +# sync filesystem to clear dirty inode +sync + +# start atomic_write on src.db database file and commit transaction +$F2FS_IO_PROG write 1 0 2 zero atomic_commit $dbfile >> $seqres.full & +atomic_write_pid=$! + +# call fsync to flush dirty inode of database file in parallel +for ((j=0;j<1000;j++)) do + $F2FS_IO_PROG fsync $dbfile >> $seqres.full +done + +wait $atomic_write_pid +unset atomic_write_pid + +# flush dirty data and drop cache +sync +echo 3 > /proc/sys/vm/drop_caches + +stat $dbfile -c %s + +rm $dbfile +sync + +status=0 +exittests/f2fs/013.out new file +2
-0@@ -0,0 +1,2 @@ +QA output created by 013 +8192Signature · 1 line
2.49.0