Skip to contentSkip to conversation

uvcvideo improvements

GIT PULL Laurent Pinchart 2 participants 3 messages May 9, 2025 – May 27, 2025 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

Hi Mauro, Hans,

The following changes since commit 0af2f6be1b4281385b618cb86ad946eded089ac8:

Linux 6.15-rc1 (2025-04-06 13:11:33 -0700)

are available in the Git repository at:

https://gitlab.freedesktop.org/linux-media/users/pinchartl.git tags/next-media-uvc-20250509

for you to fetch changes up to 9882222fa76450e545aeb625522ced7a78ff79a0:

media: uvcvideo: Use dev_err_probe for devm_gpiod_get_optional (2025-04-07 15:31:55 +0200)

----------------------------------------------------------------
uvcvideo improvements:

- Granular power saving
- Controls cache sync fix
- GPIO deferred probe error fix

----------------------------------------------------------------
Ricardo Ribalda (10):
media: uvcvideo: Keep streaming state in the file handle
media: uvcvideo: Create uvc_pm_(get|put) functions
media: uvcvideo: Increase/decrease the PM counter per IOCTL
media: uvcvideo: Make power management granular
media: uvcvideo: Do not turn on the camera for some ioctls
media: uvcvideo: Return the number of processed controls
media: uvcvideo: Send control events for partial succeeds
media: uvcvideo: Rollback non processed entities on error
media: uvcvideo: Fix deferred probing error
media: uvcvideo: Use dev_err_probe for devm_gpiod_get_optional

 drivers/media/usb/uvc/uvc_ctrl.c   |  91 +++++++++++++++++++++--------
 drivers/media/usb/uvc/uvc_driver.c |  38 ++++++++----
 drivers/media/usb/uvc/uvc_v4l2.c   | 117 +++++++++++++++++++++++++++++--------
 drivers/media/usb/uvc/uvcvideo.h   |   5 ++
 4 files changed, 190 insertions(+), 61 deletions(-)
Signature · 3 lines
Regards,

Laurent Pinchart
#1 lore raw

Hi Laurent,

Em Fri, 9 May 2025 14:46:15 +0200
Laurent Pinchart <[email protected]> escreveu:

Quoted 12 lines

Hi Mauro, Hans,

The following changes since commit 0af2f6be1b4281385b618cb86ad946eded089ac8:

Linux 6.15-rc1 (2025-04-06 13:11:33 -0700)

are available in the Git repository at:

https://gitlab.freedesktop.org/linux-media/users/pinchartl.git tags/next-media-uvc-20250509

for you to fetch changes up to 9882222fa76450e545aeb625522ced7a78ff79a0:

Quoted 8 lines

media: uvcvideo: Use dev_err_probe for devm_gpiod_get_optional (2025-04-07 15:31:55 +0200)

----------------------------------------------------------------
uvcvideo improvements:

- Granular power saving
- Controls cache sync fix
- GPIO deferred probe error fix

It doesn't seem to be the case of this PR, since it sounds mostly fixes, but if a driver is getting some relevant improvement from user's perspective, please be a little bit more verbose at the e-mail's subject. Something like:

Subject: uvcvideo: added support for xxx

As otherwise, I'll simply ignore the PR's subject when submitting upstream pull requests.

Regards,
Mauro

Quoted 14 lines

----------------------------------------------------------------
Ricardo Ribalda (10):
media: uvcvideo: Keep streaming state in the file handle
media: uvcvideo: Create uvc_pm_(get|put) functions
media: uvcvideo: Increase/decrease the PM counter per IOCTL
media: uvcvideo: Make power management granular
media: uvcvideo: Do not turn on the camera for some ioctls
media: uvcvideo: Return the number of processed controls
media: uvcvideo: Send control events for partial succeeds
media: uvcvideo: Rollback non processed entities on error
media: uvcvideo: Fix deferred probing error
media: uvcvideo: Use dev_err_probe for devm_gpiod_get_optional

Quoted 6 lines
 drivers/media/usb/uvc/uvc_ctrl.c   |  91 +++++++++++++++++++++--------
 drivers/media/usb/uvc/uvc_driver.c |  38 ++++++++----
 drivers/media/usb/uvc/uvc_v4l2.c   | 117 +++++++++++++++++++++++++++++--------
 drivers/media/usb/uvc/uvcvideo.h   |   5 ++
 4 files changed, 190 insertions(+), 61 deletions(-)

Thanks,
Mauro

#2 lore raw

Hi Mauro,

Quoted 23 lines · Mauro Carvalho Chehab

Em Fri, 9 May 2025 14:46:15 +0200 Laurent Pinchart escreveu:

Quoted 12 lines

Hi Mauro, Hans,

The following changes since commit 0af2f6be1b4281385b618cb86ad946eded089ac8:

Linux 6.15-rc1 (2025-04-06 13:11:33 -0700)

are available in the Git repository at:

https://gitlab.freedesktop.org/linux-media/users/pinchartl.git tags/next-media-uvc-20250509

for you to fetch changes up to 9882222fa76450e545aeb625522ced7a78ff79a0:

Quoted 8 lines

media: uvcvideo: Use dev_err_probe for devm_gpiod_get_optional (2025-04-07 15:31:55 +0200)

----------------------------------------------------------------
uvcvideo improvements:

- Granular power saving
- Controls cache sync fix
- GPIO deferred probe error fix

Quoted 8 lines

It doesn't seem to be the case of this PR, since it sounds mostly fixes, but if a driver is getting some relevant improvement from user's perspective, please be a little bit more verbose at the e-mail's subject. Something like:

Subject: uvcvideo: added support for xxx

As otherwise, I'll simply ignore the PR's subject when submitting upstream pull requests.

Do you mean the subject line of the pull request, as in "[GIT PULL FOR v6.16] ..." ? There's very little space there to list all changes, which is why the pull request body contains a summary for your convenience that you can integrate in merge commit messages or in pull requests mails to Linus.

Quoted 18 lines
Quoted 18 lines

----------------------------------------------------------------
Ricardo Ribalda (10):
media: uvcvideo: Keep streaming state in the file handle
media: uvcvideo: Create uvc_pm_(get|put) functions
media: uvcvideo: Increase/decrease the PM counter per IOCTL
media: uvcvideo: Make power management granular
media: uvcvideo: Do not turn on the camera for some ioctls
media: uvcvideo: Return the number of processed controls
media: uvcvideo: Send control events for partial succeeds
media: uvcvideo: Rollback non processed entities on error
media: uvcvideo: Fix deferred probing error
media: uvcvideo: Use dev_err_probe for devm_gpiod_get_optional

 drivers/media/usb/uvc/uvc_ctrl.c   |  91 +++++++++++++++++++++--------
 drivers/media/usb/uvc/uvc_driver.c |  38 ++++++++----
 drivers/media/usb/uvc/uvc_v4l2.c   | 117 +++++++++++++++++++++++++++++--------
 drivers/media/usb/uvc/uvcvideo.h   |   5 ++
 4 files changed, 190 insertions(+), 61 deletions(-)
Signature · 3 lines
Regards,

Laurent Pinchart