xfs: remove some EXPERIMENTAL warnings
PATCH 1/1 xfs: remove some EXPERIMENTAL warnings
From: Darrick J. Wong <[email protected]>
Online fsck was finished a year ago, in Linux 6.10. The exchange-range syscall and parent pointers were merged in the same cycle. None of these have encountered any serious errors in the year that they've been in the kernel (or the many many years they've been under development) so let's drop the shouty warnings.
--- fs/xfs/xfs_message.h | 3 --- fs/xfs/scrub/scrub.c | 2 -- fs/xfs/xfs_message.c | 12 ------------ fs/xfs/xfs_super.c | 7 ------- 4 files changed, 24 deletions(-)
fs/xfs/xfs_message.h +0 -3
@@ -92,12 +92,9 @@ void xfs_buf_alert_ratelimited(struct xfs_buf *bp, const char *rlmsg,enum xfs_experimental_feat {XFS_EXPERIMENTAL_PNFS , -XFS_EXPERIMENTAL_SCRUB ,XFS_EXPERIMENTAL_SHRINK ,XFS_EXPERIMENTAL_LARP ,XFS_EXPERIMENTAL_LBS , -XFS_EXPERIMENTAL_EXCHRANGE , -XFS_EXPERIMENTAL_PPTR ,XFS_EXPERIMENTAL_METADIR ,XFS_EXPERIMENTAL_ZONED ,
fs/xfs/scrub/scrub.c +0 -2
@@ -680,8 +680,6 @@ xfs_scrub_metadata(if (error) goto out; -xfs_warn_experimental (mp,XFS_EXPERIMENTAL_SCRUB ); - sc =kzalloc (sizeof (struct xfs_scrub ),XCHK_GFP_FLAGS );if (!sc) { error = -ENOMEM ;
fs/xfs/xfs_message.c +0 -12
@@ -145,10 +145,6 @@ xfs_warn_experimental( .opstate = XFS_OPSTATE_WARNED_PNFS, .name = "pNFS", }, - [XFS_EXPERIMENTAL_SCRUB] = { - .opstate = XFS_OPSTATE_WARNED_SCRUB, - .name = "online scrub", - }, [XFS_EXPERIMENTAL_SHRINK] = { .opstate = XFS_OPSTATE_WARNED_SHRINK, .name = "online shrink",
@@ -161,14 +157,6 @@ xfs_warn_experimental( .opstate = XFS_OPSTATE_WARNED_LBS, .name = "large block size", }, - [XFS_EXPERIMENTAL_EXCHRANGE] = { - .opstate = XFS_OPSTATE_WARNED_EXCHRANGE, - .name = "exchange range", - }, - [XFS_EXPERIMENTAL_PPTR] = { - .opstate = XFS_OPSTATE_WARNED_PPTR, - .name = "parent pointer", - }, [XFS_EXPERIMENTAL_METADIR] = { .opstate = XFS_OPSTATE_WARNED_METADIR, .name = "metadata directory tree",
fs/xfs/xfs_super.c +0 -7
@@ -1953,13 +1953,6 @@ xfs_fs_fill_super( } } - -if (xfs_has_exchange_range (mp)) -xfs_warn_experimental (mp,XFS_EXPERIMENTAL_EXCHRANGE ); - -if (xfs_has_parent (mp)) -xfs_warn_experimental (mp,XFS_EXPERIMENTAL_PPTR ); -/* * If no quota mount options were provided, maybe we'll try to pick * up the quota accounting and enforcement flags from the ondisk sb.
Quoted 7 lines · Darrick J. Wong
From: Darrick J. Wong <[email protected]>
Online fsck was finished a year ago, in Linux 6.10. The exchange-range syscall and parent pointers were merged in the same cycle. None of these have encountered any serious errors in the year that they've been in the kernel (or the many many years they've been under development) so let's drop the shouty warnings.
Looks good. Talking about experimental warnings, I'd also like to drop the pnfs warning. The code has been around forever, and while we found occasional issues in the nfsd side of it, they were quickly fixed.
Quoted 9 lines · Christoph Hellwig
Quoted 7 lines · Darrick J. Wong
From: Darrick J. Wong <[email protected]>
Online fsck was finished a year ago, in Linux 6.10. The exchange-range syscall and parent pointers were merged in the same cycle. None of these have encountered any serious errors in the year that they've been in the kernel (or the many many years they've been under development) so let's drop the shouty warnings.
Quoted 4 lines
Looks good. Talking about experimental warnings, I'd also like to drop the pnfs warning. The code has been around forever, and while we found occasional issues in the nfsd side of it, they were quickly fixed.
I agree, let's drop the pnfs warning since warts or not the code has been stable for a long time. However, would you (hch) mind writing that patch since you're the author of xfs_pnfs.c and I've never even used it.
--D
Quoted 3 lines · Darrick J. Wong
I agree, let's drop the pnfs warning since warts or not the code has been stable for a long time. However, would you (hch) mind writing that patch since you're the author of
xfs_pnfs.cand I've never even used it.
Sure, I'll take care of it.
Quoted 9 lines · Darrick J. Wong
From: Darrick J. Wong <[email protected]>
Online fsck was finished a year ago, in Linux 6.10. The exchange-range syscall and parent pointers were merged in the same cycle. None of these have encountered any serious errors in the year that they've been in the kernel (or the many many years they've been under development) so let's drop the shouty warnings.
Signed-off-by "Darrick J. Wong" <[email protected]>
Seems reasonable to me. I haven't encountered any problems with them over the past few months, so no objections here.
Signature · 2 lines
Dave Chinner [email protected]
Quoted 9 lines · Darrick J. Wong
From: Darrick J. Wong <[email protected]>
Online fsck was finished a year ago, in Linux 6.10. The exchange-range syscall and parent pointers were merged in the same cycle. None of these have encountered any serious errors in the year that they've been in the kernel (or the many many years they've been under development) so let's drop the shouty warnings.
Signed-off-by "Darrick J. Wong" <[email protected]>
No objections either.
Quoted 86 lines
--- fs/xfs/xfs_message.h | 3 --- fs/xfs/scrub/scrub.c | 2 -- fs/xfs/xfs_message.c | 12 ------------ fs/xfs/xfs_super.c | 7 ------- 4 files changed, 24 deletions(-)fs/xfs/xfs_message.h +0
-3@@ -92,12 +92,9 @@ void xfs_buf_alert_ratelimited(struct xfs_buf *bp, const char *rlmsg,enum xfs_experimental_feat {XFS_EXPERIMENTAL_PNFS , -XFS_EXPERIMENTAL_SCRUB ,XFS_EXPERIMENTAL_SHRINK ,XFS_EXPERIMENTAL_LARP ,XFS_EXPERIMENTAL_LBS , -XFS_EXPERIMENTAL_EXCHRANGE , -XFS_EXPERIMENTAL_PPTR ,XFS_EXPERIMENTAL_METADIR ,XFS_EXPERIMENTAL_ZONED ,fs/xfs/scrub/scrub.c +0
-2@@ -680,8 +680,6 @@ xfs_scrub_metadata(if (error) goto out; -xfs_warn_experimental (mp,XFS_EXPERIMENTAL_SCRUB ); - sc =kzalloc (sizeof (struct xfs_scrub ),XCHK_GFP_FLAGS );if (!sc) { error = -ENOMEM ;fs/xfs/xfs_message.c +0
-12@@ -145,10 +145,6 @@ xfs_warn_experimental( .opstate = XFS_OPSTATE_WARNED_PNFS, .name = "pNFS", }, - [XFS_EXPERIMENTAL_SCRUB] = { - .opstate = XFS_OPSTATE_WARNED_SCRUB, - .name = "online scrub", - }, [XFS_EXPERIMENTAL_SHRINK] = { .opstate = XFS_OPSTATE_WARNED_SHRINK, .name = "online shrink",@@ -161,14 +157,6 @@ xfs_warn_experimental( .opstate = XFS_OPSTATE_WARNED_LBS, .name = "large block size", }, - [XFS_EXPERIMENTAL_EXCHRANGE] = { - .opstate = XFS_OPSTATE_WARNED_EXCHRANGE, - .name = "exchange range", - }, - [XFS_EXPERIMENTAL_PPTR] = { - .opstate = XFS_OPSTATE_WARNED_PPTR, - .name = "parent pointer", - }, [XFS_EXPERIMENTAL_METADIR] = { .opstate = XFS_OPSTATE_WARNED_METADIR, .name = "metadata directory tree",fs/xfs/xfs_super.c +0
-7@@ -1953,13 +1953,6 @@ xfs_fs_fill_super( } } - -if (xfs_has_exchange_range (mp)) -xfs_warn_experimental (mp,XFS_EXPERIMENTAL_EXCHRANGE ); - -if (xfs_has_parent (mp)) -xfs_warn_experimental (mp,XFS_EXPERIMENTAL_PPTR ); -/* * If no quota mount options were provided, maybe we'll try to pick * up the quota accounting and enforcement flags from the ondisk sb.
Quoted 8 lines · Darrick J. Wong
Online fsck was finished a year ago, in Linux 6.10. The exchange-range syscall and parent pointers were merged in the same cycle. None of these have encountered any serious errors in the year that they've been in the kernel (or the many many years they've been under development) so let's drop the shouty warnings.
[...]
Applied to for-next, thanks!
[1/1] xfs: remove some EXPERIMENTAL warnings
(no commit info)
Best regards,
Signature · 1 line
Carlos Maiolino <[email protected]>
Quoted 8 lines · Carlos Maiolino
Quoted 7 lines · Darrick J. Wong
Online fsck was finished a year ago, in Linux 6.10. The exchange-range syscall and parent pointers were merged in the same cycle. None of these have encountered any serious errors in the year that they've been in the kernel (or the many many years they've been under development) so let's drop the shouty warnings.
Quoted 6 lines
Quoted 1 line
[...]
Applied to for-next, thanks!
[1/1] xfs: remove some EXPERIMENTAL warnings
(no commit info)
Er... there's a V2 out with slightly more aggressive cleanups of now-defunct OPSTATE bits.
--D
Quoted 4 lines
Best regards,
Signature · 1 line
Carlos Maiolino <[email protected]>
Carlos Maiolino
maintainerQuoted 8 lines · Carlos Maiolino
Quoted 7 lines · Darrick J. Wong
Online fsck was finished a year ago, in Linux 6.10. The exchange-range syscall and parent pointers were merged in the same cycle. None of these have encountered any serious errors in the year that they've been in the kernel (or the many many years they've been under development) so let's drop the shouty warnings.
Quoted 7 lines
Quoted 1 line
[...]
Applied to for-next, thanks!
[1/1] xfs: remove some EXPERIMENTAL warnings
(no commit info)
My apologies Darrick, this message was triggered by accident. I didn't merge it yet. You'll see this patch is not in the ANNOUNCE email.
Quoted 5 lines
Best regards,
--
Carlos Maiolino <[email protected]>