Skip to contentSkip to conversation

dt-bindings: ata: Convert arasan,cf-spear1340 to DT schema

PATCH Applied Rob Herring (Arm) 2 participants 2 messages May 12, 2025 – May 15, 2025

Subsystems (2)
Device tree bindings libata
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: ata: Convert arasan,cf-spear1340 to DT schema

Convert the Arasan/SPEAr Compact Flash Controller to DT schema format.

The "clock-frequency" property isn't actually used. Add a single "clocks" entry as the Linux driver supports a single clock though the platform still doesn't have clocks in DT.

Signed-off-by Rob Herring (Arm) <[email protected]>
---
 .../bindings/ata/arasan,cf-spear1340.yaml     | 70 +++++++++++++++++++
 .../devicetree/bindings/ata/pata-arasan.txt   | 37 ----------
 2 files changed, 70 insertions(+), 37 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/ata/arasan,cf-spear1340.yaml
 delete mode 100644 Documentation/devicetree/bindings/ata/pata-arasan.txt
Documentation/devicetree/bindings/ata/arasan,cf-spear1340.yaml new file +70 -0
new file mode 100644
index 000000000000..4d7017452dda
@@ -0,0 +1,70 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/ata/arasan,cf-spear1340.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Arasan PATA Compact Flash Controller
+
+maintainers:
+  - Viresh Kumar <[email protected]>
+
+properties:
+  compatible:
+    const: arasan,cf-spear1340
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  arasan,broken-udma:
+    description: UDMA mode is unusable
+    type: boolean
+
+  arasan,broken-mwdma:
+    description: MWDMA mode is unusable
+    type: boolean
+
+  arasan,broken-pio:
+    description: PIO mode is unusable
+    type: boolean
+
+  dmas:
+    maxItems: 1
+
+  dma-names:
+    items:
+      - const: data
+
+required:
+  - compatible
+  - reg
+  - interrupts
+
+additionalProperties: false
+
+allOf:
+  - if:
+      not:
+        required:
+          - arasan,broken-udma
+          - arasan,broken-mwdma
+    then:
+      required:
+        - dmas
+        - dma-names
+
+examples:
+  - |
+    cf@fc000000 {
+        compatible = "arasan,cf-spear1340";
+        reg = <0xfc000000 0x1000>;
+        interrupts = <12>;
+        dmas = <&dma 23>;
+        dma-names = "data";
+    };
Documentation/devicetree/bindings/ata/pata-arasan.txt deleted +0 -37
deleted file mode 100644
index 872edc105680..000000000000
@@ -1,37 +0,0 @@
-* ARASAN PATA COMPACT FLASH CONTROLLER
-
-Required properties:
-- compatible: "arasan,cf-spear1340"
-- reg: Address range of the CF registers
-- interrupt: Should contain the CF interrupt number
-- clock-frequency: Interface clock rate, in Hz, one of
-       25000000
-       33000000
-       40000000
-       50000000
-       66000000
-       75000000
-      100000000
-      125000000
-      150000000
-      166000000
-      200000000
-
-Optional properties:
-- arasan,broken-udma: if present, UDMA mode is unusable
-- arasan,broken-mwdma: if present, MWDMA mode is unusable
-- arasan,broken-pio: if present, PIO mode is unusable
-- dmas: one DMA channel, as described in bindings/dma/dma.txt
-  required unless both UDMA and MWDMA mode are broken
-- dma-names: the corresponding channel name, must be "data"
-
-Example:
-
-	cf@fc000000 {
-		compatible = "arasan,cf-spear1340";
-		reg = <0xfc000000 0x1000>;
-		interrupt-parent = <&vic1>;
-		interrupts = <12>;
-		dmas = <&dma-controller 23>;
-		dma-names = "data";
-	};
Signature · 1 line
2.47.2
maintainer Applied
#1 lore raw
Quoted 7 lines · Rob Herring (Arm)

Convert the Arasan/SPEAr Compact Flash Controller to DT schema format.

The "clock-frequency" property isn't actually used. Add a single "clocks" entry as the Linux driver supports a single clock though the platform still doesn't have clocks in DT.

Signed-off-by Rob Herring (Arm) <[email protected]>

Applied to for-6.16. Thanks !

Signature · 2 lines
Damien Le Moal
Western Digital Research