drm/amd/display: Avoid flooding unnecessary info messages

PATCH In review Wayne Lin 5 participants 5 messages May 13, 2025 – May 14, 2025

Subsystems (4)

Stable branch DRM drivers Radeon and amdgpu DRM drivers AMD display core

lore

Share & tools

lore

Wayne Lin

author

2025-05-13 03:20 UTC #0 lore raw

PATCH 1/1 drm/amd/display: Avoid flooding unnecessary info messages

It's expected that we'll encounter temporary exceptions during aux transactions. Adjust logging from drm_info to drm_dbg_dp to prevent flooding with unnecessary log messages.

Fixes 6285f12bc54c ("drm/amd/display: Fix wrong handling for AUX_DEFER case")

Cc [email protected]

Cc Mario Limonciello <[email protected]>

Cc Alex Deucher <[email protected]>

Signed-off-by Wayne Lin <[email protected]>

---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c +3 -3

index 0d7b72c75802..25e8befbcc47 100644
@@ -107,7 +107,7 @@ static ssize_t dm_dp_aux_transfer(struct drm_dp_aux *aux,
 	if (payload.write && result >= 0) {
 		if (result) {
 			/*one byte indicating partially written bytes*/
-			drm_info(adev_to_drm(adev), "amdgpu: AUX partially written\n");
+			drm_dbg_dp(adev_to_drm(adev), "amdgpu: AUX partially written\n");
 			result = payload.data[0];
 		} else if (!payload.reply[0])
 			/*I2C_ACK|AUX_ACK*/

@@ -133,11 +133,11 @@ static ssize_t dm_dp_aux_transfer(struct drm_dp_aux *aux,
 			break;
 		}
 
-		drm_info(adev_to_drm(adev), "amdgpu: DP AUX transfer fail:%d\n", operation_result);
+		drm_dbg_dp(adev_to_drm(adev), "amdgpu: DP AUX transfer fail:%d\n", operation_result);
 	}
 
 	if (payload.reply[0])
-		drm_info(adev_to_drm(adev), "amdgpu: AUX reply command not ACK: 0x%02x.",
+		drm_dbg_dp(adev_to_drm(adev), "amdgpu: AUX reply command not ACK: 0x%02x.",
 			payload.reply[0]);
 
 	return result;

Signature · 1 line

2.43.0

Alex Deucher

Acked-by on v1 1/1

2025-05-13 12:37 UTC #1 lore raw

Quoted 10 lines · Wayne Lin

It's expected that we'll encounter temporary exceptions during aux transactions. Adjust logging from drm_info to drm_dbg_dp to prevent flooding with unnecessary log messages.
Fixes 6285f12bc54c ("drm/amd/display: Fix wrong handling for AUX_DEFER case")
Cc [email protected]
Cc Mario Limonciello <[email protected]>
Cc Alex Deucher <[email protected]>
Signed-off-by Wayne Lin <[email protected]>

Acked-by Alex Deucher <[email protected]>

Quoted 34 lines

---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c +3 -4

index 0d7b72c75802..25e8befbcc47 100644
@@ -107,7 +107,7 @@ static ssize_t dm_dp_aux_transfer(struct drm_dp_aux *aux,
        if (payload.write && result >= 0) {
                if (result) {
                        /*one byte indicating partially written bytes*/
-                       drm_info(adev_to_drm(adev), "amdgpu: AUX partially written\n");
+                       drm_dbg_dp(adev_to_drm(adev), "amdgpu: AUX partially written\n");
                        result = payload.data[0];
                } else if (!payload.reply[0])
                        /*I2C_ACK|AUX_ACK*/

@@ -133,11 +133,11 @@ static ssize_t dm_dp_aux_transfer(struct drm_dp_aux *aux,
                        break;
                }
 
-               drm_info(adev_to_drm(adev), "amdgpu: DP AUX transfer fail:%d\n", operation_result);
+               drm_dbg_dp(adev_to_drm(adev), "amdgpu: DP AUX transfer fail:%d\n", operation_result);
        }
 
        if (payload.reply[0])
-               drm_info(adev_to_drm(adev), "amdgpu: AUX reply command not ACK: 0x%02x.",
+               drm_dbg_dp(adev_to_drm(adev), "amdgpu: AUX reply command not ACK: 0x%02x.",
                        payload.reply[0]);
 
        return result;
--

2.43.0

Harry Wentland

maintainer Reviewed-by on v1 1/1

2025-05-13 13:35 UTC #2 lore raw

In reply to Wayne Lin

Quoted 9 lines · Wayne Lin

It's expected that we'll encounter temporary exceptions during aux transactions. Adjust logging from drm_info to drm_dbg_dp to prevent flooding with unnecessary log messages.
Fixes 6285f12bc54c ("drm/amd/display: Fix wrong handling for AUX_DEFER case")
Cc [email protected]
Cc Mario Limonciello <[email protected]>
Cc Alex Deucher <[email protected]>
Signed-off-by Wayne Lin <[email protected]>

Reviewed-by Harry Wentland <[email protected]>

Harry

Quoted 31 lines

---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c +3 -3

index 0d7b72c75802..25e8befbcc47 100644
@@ -107,7 +107,7 @@ static ssize_t dm_dp_aux_transfer(struct drm_dp_aux *aux,
 	if (payload.write && result >= 0) {
 		if (result) {
 			/*one byte indicating partially written bytes*/
-			drm_info(adev_to_drm(adev), "amdgpu: AUX partially written\n");
+			drm_dbg_dp(adev_to_drm(adev), "amdgpu: AUX partially written\n");
 			result = payload.data[0];
 		} else if (!payload.reply[0])
 			/*I2C_ACK|AUX_ACK*/

@@ -133,11 +133,11 @@ static ssize_t dm_dp_aux_transfer(struct drm_dp_aux *aux,
 			break;
 		}
 
-		drm_info(adev_to_drm(adev), "amdgpu: DP AUX transfer fail:%d\n", operation_result);
+		drm_dbg_dp(adev_to_drm(adev), "amdgpu: DP AUX transfer fail:%d\n", operation_result);
 	}
 
 	if (payload.reply[0])
-		drm_info(adev_to_drm(adev), "amdgpu: AUX reply command not ACK: 0x%02x.",
+		drm_dbg_dp(adev_to_drm(adev), "amdgpu: AUX reply command not ACK: 0x%02x.",
 			payload.reply[0]);
 
 	return result;

Yadav, Arvind

Acked-by Arvind Yadav

2025-05-13 13:49 UTC #3 lore raw

These log messages are overwhelming during the boot process.

Acked-by Arvind Yadav <[email protected]>

~arvind

Quoted 46 lines · Harry Wentland

Quoted 9 lines · Wayne Lin

It's expected that we'll encounter temporary exceptions during aux transactions. Adjust logging from drm_info to drm_dbg_dp to prevent flooding with unnecessary log messages.
Fixes 6285f12bc54c ("drm/amd/display: Fix wrong handling for AUX_DEFER case")
Cc [email protected]
Cc Mario Limonciello <[email protected]>
Cc Alex Deucher <[email protected]>
Signed-off-by Wayne Lin <[email protected]>

Reviewed-by Harry Wentland <[email protected]>

Harry

Quoted 31 lines

---
  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c +3 -3

index 0d7b72c75802..25e8befbcc47 100644
@@ -107,7 +107,7 @@ static ssize_t dm_dp_aux_transfer(struct drm_dp_aux *aux,
  	if (payload.write && result >= 0) {
  		if (result) {
  			/*one byte indicating partially written bytes*/
-			drm_info(adev_to_drm(adev), "amdgpu: AUX partially written\n");
+			drm_dbg_dp(adev_to_drm(adev), "amdgpu: AUX partially written\n");
  			result = payload.data[0];
  		} else if (!payload.reply[0])
  			/*I2C_ACK|AUX_ACK*/

@@ -133,11 +133,11 @@ static ssize_t dm_dp_aux_transfer(struct drm_dp_aux *aux,
  			break;
  		}
 
-		drm_info(adev_to_drm(adev), "amdgpu: DP AUX transfer fail:%d\n", operation_result);
+		drm_dbg_dp(adev_to_drm(adev), "amdgpu: DP AUX transfer fail:%d\n", operation_result);
  	}
 
  	if (payload.reply[0])
-		drm_info(adev_to_drm(adev), "amdgpu: AUX reply command not ACK: 0x%02x.",
+		drm_dbg_dp(adev_to_drm(adev), "amdgpu: AUX reply command not ACK: 0x%02x.",
  			payload.reply[0]);
 
  	return result;

Christian Heusel

2025-05-14 08:11 UTC #4 lore raw

In reply to Wayne Lin

Quoted 4 lines · Wayne Lin

It's expected that we'll encounter temporary exceptions during aux transactions. Adjust logging from drm_info to drm_dbg_dp to prevent flooding with unnecessary log messages.

Quoted 8 lines

Fixes 6285f12bc54c ("drm/amd/display: Fix wrong handling for AUX_DEFER case")
Cc [email protected]
Cc Mario Limonciello <[email protected]>
Cc Alex Deucher <[email protected]>
Signed-off-by Wayne Lin <[email protected]>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

If it's not already applied it would of course be nice if credit for my report could be added to the change:

Reported-by Christian Heusel <[email protected]>

Link https://lore.kernel.org/all/[email protected]/ open here

Have a nice day everyone!
Chris