Skip to contentSkip to conversation

i2ctransfer: Don't link with libi2c

PATCH Applied Jean Delvare 2 participants 2 messages May 13, 2025 – May 19, 2025 I2C subsystem host drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i2ctransfer: Don't link with libi2c

i2ctransfer doesn't make use of any function from libi2c so it should not link with that library.

Fixes 9fc53a7fc669 ("i2c-tools: add new tool 'i2ctransfer'")
---
 tools/Module.mk |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tools/Module.mk +2 -2
@@ -36,8 +36,8 @@ $(TOOLS_DIR)/i2cset: $(TOOLS_DIR)/i2cset
 $(TOOLS_DIR)/i2cget: $(TOOLS_DIR)/i2cget.o $(TOOLS_DIR)/i2cbusses.o $(TOOLS_DIR)/util.o $(LIB_DEPS)
 	$(CC) $(LDFLAGS) -o $@ $^ $(TOOLS_LDFLAGS)
 
-$(TOOLS_DIR)/i2ctransfer: $(TOOLS_DIR)/i2ctransfer.o $(TOOLS_DIR)/i2cbusses.o $(TOOLS_DIR)/util.o $(LIB_DEPS)
-	$(CC) $(LDFLAGS) -o $@ $^ $(TOOLS_LDFLAGS)
+$(TOOLS_DIR)/i2ctransfer: $(TOOLS_DIR)/i2ctransfer.o $(TOOLS_DIR)/i2cbusses.o $(TOOLS_DIR)/util.o
+	$(CC) $(LDFLAGS) -o $@ $^
 
 #
 # Objects
Signature · 2 lines
Jean Delvare
SUSE L3 Support
Applied
#1 lore raw
Quoted 5 lines · Jean Delvare

i2ctransfer doesn't make use of any function from libi2c so it should not link with that library.

Fixes 9fc53a7fc669 ("i2c-tools: add new tool 'i2ctransfer'")

Applied, thanks!