scripts: headers_install: fix a false positive
PATCH 1/1 scripts: headers_install: fix a false positive
The current implementation only handles C89 style comments (/*... */) in the code, and there are false positives for C99 style comments (//...).
This patch fixes this issue.
--- scripts/headers_install.sh | 1 + 1 file changed, 1 insertion(+)
scripts/headers_install.sh +1 -0
@@ -44,6 +44,7 @@ scripts/unifdef -U__KERNEL__ -D__EXPORTED_HEADERS__ $TMPFILE > $OUTFILE # Remove /* ... */ style comments, and find CONFIG_ references in code configs=$(sed -e ' :comment + s://.*:: s:/\*[^*][^*]*:/*: s:/\*\*\**\([^/]\):/*\1: t comment
Signature · 1 line
2.25.1
Quoted 24 lines · Wen Yang
The current implementation only handles C89 style comments (/*... */) in the code, and there are false positives for C99 style comments (//...).
This patch fixes this issue.
Signed-off-by Wen Yang <[email protected]>--- scripts/headers_install.sh | 1 + 1 file changed, 1 insertion(+)scripts/headers_install.sh +1
-0@@ -44,6 +44,7 @@ scripts/unifdef -U__KERNEL__ -D__EXPORTED_HEADERS__ $TMPFILE > $OUTFILE # Remove /* ... */ style comments, and find CONFIG_ references in code configs=$(sed -e ' :comment + s://.*:: s:/\*[^*][^*]*:/*: s:/\*\*\**\([^/]\):/*\1: t commentSignature · 1 line
2.25.1
thanks. The patch looks good to me, but I cannot find any false positives. Have you found any concrete?
Kind regards,
Nicolas
Quoted 20 lines · Nicolas Schier
Quoted 19 lines · Wen Yang
The current implementation only handles C89 style comments (/*... */) in the code, and there are false positives for C99 style comments (//...).
This patch fixes this issue.
Signed-off-by Wen Yang <[email protected]>--- scripts/headers_install.sh | 1 + 1 file changed, 1 insertion(+)scripts/headers_install.sh +1
-0@@ -44,6 +44,7 @@ scripts/unifdef -U__KERNEL__ -D__EXPORTED_HEADERS__ $TMPFILE > $OUTFILE # Remove /* ... */ style comments, and find CONFIG_ references in code configs=$(sed -e ' :comment + s://.*::
Quoted 9 lines
Quoted 5 lines
scripts/headers_install.sh +0
-0s:/\*[^*][^*]*:/*: s:/\*\*\**\([^/]\):/*\1: t commentSignature · 1 line
2.25.1thanks. The patch looks good to me, but I cannot find any false positives. Have you found any concrete?
Thanks. We have enhanced dmabuf on our SoC platform and modified the include/uapi/linux/dma-buf.h file, and then found this issue.
--
Best wishes,
Wen
Quoted 34 lines · Wen Yang
Quoted 20 lines · Nicolas Schier
Quoted 19 lines · Wen Yang
The current implementation only handles C89 style comments (/*... */) in the code, and there are false positives for C99 style comments (//...).
This patch fixes this issue.
Signed-off-by Wen Yang <[email protected]>--- scripts/headers_install.sh | 1 + 1 file changed, 1 insertion(+)scripts/headers_install.sh +1
-0@@ -44,6 +44,7 @@ scripts/unifdef -U__KERNEL__ -D__EXPORTED_HEADERS__ $TMPFILE > $OUTFILE # Remove /* ... */ style comments, and find CONFIG_ references in code configs=$(sed -e ' :comment + s://.*::Quoted 9 lines
Quoted 5 lines
scripts/headers_install.sh +0
-1s:/\*[^*][^*]*:/*: s:/\*\*\**\([^/]\):/*\1: t comment --2.25.1
thanks. The patch looks good to me, but I cannot find any false positives. Have you found any concrete?
Quoted 2 lines
Thanks. We have enhanced dmabuf on our SoC platform and modified the
include/uapi/linux/dma-buf.hfile, and then found this issue.
The SPDX License Identifier in UAPI headers use
/* ... */, and never C++ style comments.
In my understanding, the idea behind this is
UAPI headers follow more strict C.
Signature · 2 lines
Best Regards Masahiro Yamada