Skip to contentSkip to conversation

lib/crc32: add SPDX license identifier

PATCH In review Eric Biggers 3 participants 4 messages May 14, 2025

Subsystems (3)
lore
Share & tools
lore

Eric Biggers

author maintainer
#0 lore raw

PATCH 1/1 lib/crc32: add SPDX license identifier

From: Eric Biggers <[email protected]>

lib/crc32.c and include/linux/crc32.h got missed by the bulk SPDX conversion because of the nonstandard explanation of the license. However, crc32.c clearly states that it's licensed under the GNU General Public License, Version 2. And the comment in crc32.h clearly indicates that it's meant to have the same license as crc32.c. Therefore, apply
SPDX-License-Identifier: GPL-2.0-only to both files.

---
 include/linux/crc32.h | 5 +----
 lib/crc32.c           | 4 +---
 2 files changed, 2 insertions(+), 7 deletions(-)
include/linux/crc32.h +1 -4
index 69c2e8bb37829..569dc13f139fc 100644
@@ -1,9 +1,6 @@
-/*
- * crc32.h
- * See linux/lib/crc32.c for license and changes
- */
+/* SPDX-License-Identifier: GPL-2.0-only */
 #ifndef _LINUX_CRC32_H
 #define _LINUX_CRC32_H
 
 #include <linux/types.h>
 #include <linux/bitrev.h>
lib/crc32.c +1 -3
index fddd424ff2245..e690026f44f7a 100644
@@ -1,5 +1,6 @@
+// SPDX-License-Identifier: GPL-2.0-only
 /*
  * Aug 8, 2011 Bob Pearson with help from Joakim Tjernlund and George Spelvin
  * cleaned up code to current version of sparse and added the slicing-by-8
  * algorithm to the closely similar existing slicing-by-4 algorithm.
  *
@@ -17,13 +18,10 @@
  * seed as an argument, and doesn't xor at the end.  Then individual
  * users can do whatever they need.
  *   drivers/net/smc9194.c uses seed ~0, doesn't xor with ~0.
  *   fs/jffs2 uses seed 0, doesn't xor with ~0.
  *   fs/partitions/efi.c uses seed ~0, xor's with ~0.
- *
- * This source code is licensed under the GNU General Public License,
- * Version 2.  See the file COPYING for more details.
  */
 
 /* see: Documentation/staging/crc32.rst for a description of algorithms */
 
 #include <linux/crc32.h>

base-commit: 3937f6db6e932c560a0f9ee2cd2a4fdcc314dadf

Signature · 1 line
2.49.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Eric Biggers

From: Eric Biggers <[email protected]>

lib/crc32.c and include/linux/crc32.h got missed by the bulk SPDX conversion because of the nonstandard explanation of the license. However, crc32.c clearly states that it's licensed under the GNU General Public License, Version 2. And the comment in crc32.h clearly indicates that it's meant to have the same license as crc32.c. Therefore, apply
SPDX-License-Identifier: GPL-2.0-only to both files.

author maintainer
#2 lore raw
Quoted 11 lines · Thomas Gleixner
Quoted 9 lines · Eric Biggers

From: Eric Biggers <[email protected]>

lib/crc32.c and include/linux/crc32.h got missed by the bulk SPDX conversion because of the nonstandard explanation of the license. However, crc32.c clearly states that it's licensed under the GNU General Public License, Version 2. And the comment in crc32.h clearly indicates that it's meant to have the same license as crc32.c. Therefore, apply
SPDX-License-Identifier: GPL-2.0-only to both files.

Quoted 3 lines
Quoted 1 line

Thanks.

I forgot to mention: I'm planning to take this patch through the crc tree.

- Eric

Reviewed-by Greg Kroah-Hartman
#3 lore raw
Quoted 12 lines · Eric Biggers
Quoted 11 lines · Thomas Gleixner
Quoted 9 lines · Eric Biggers

From: Eric Biggers <[email protected]>

lib/crc32.c and include/linux/crc32.h got missed by the bulk SPDX conversion because of the nonstandard explanation of the license. However, crc32.c clearly states that it's licensed under the GNU General Public License, Version 2. And the comment in crc32.h clearly indicates that it's meant to have the same license as crc32.c. Therefore, apply
SPDX-License-Identifier: GPL-2.0-only to both files.

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

Thanks.

I forgot to mention: I'm planning to take this patch through the crc tree.

Great!