media: saa7115: Replace open-coded parity calculation with parity8()
PATCH v5 1/1 media: saa7115: Replace open-coded parity calculation with parity8()
Refactor parity calculations to use the standard parity8() helper. This change eliminates redundant implementations.
Co-developed-by Yu-Chun Lin <[email protected]>
Signed-off-by Yu-Chun Lin <[email protected]>
Signed-off-by Kuan-Wei Chiu <[email protected]>
Reviewed-by Hans Verkuil <[email protected]>
---
Changes in v5:
- Dropped changes to bitops.h
- Switched to using existing parity8()
- Split parity8() conversion patch out of the series
drivers/media/i2c/saa7115.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-)
drivers/media/i2c/saa7115.c +2 -10
@@ -25,6 +25,7 @@#include "saa711x_regs.h" +#include <linux/bitops.h> #include <linux/kernel.h> #include <linux/module.h> #include <linux/slab.h>
@@ -664,15 +665,6 @@ static const unsigned char saa7115_init_misc[] = {0x00 ,0x00 }; -static int saa711x_odd_parity (u8 c) -{ - c ^= (c >>4 ); - c ^= (c >>2 ); - c ^= (c >>1 ); - -return c &1 ; -} -static int saa711x_decode_vps (u8 *dst,u8 *p) { static const u8 biphase_tbl[] = {
@@ -1227,7 +1219,7 @@ static int saa711x_decode_vbi_line(struct v4l2_subdev *sd, struct v4l2_decode_vb vbi->type =V4L2_SLICED_TELETEXT_B ;break ;case 4 : -if (!saa711x_odd_parity (p[0 ]) || !saa711x_odd_parity (p[1 ])) +if (!parity8 (p[0 ]) || !parity8 (p[1 ]))return 0 ; vbi->type =V4L2_SLICED_CAPTION_525 ;break ;
Signature · 1 line
2.34.1