Skip to contentSkip to conversation

Add some missing info registers

PATCH In review Mario Limonciello 2 participants 4 messages May 17, 2025 – May 19, 2025

Subsystems (2)
Crypto API AMD cryptographic coprocessor (CCP) driver
lore
Share & tools
lore

Mario Limonciello

author
#0 lore raw

cover Add some missing info registers

From: Mario Limonciello <[email protected]>

pspv5 and teev2 are missing the registers for version information.

Mario Limonciello (2):
crypto: ccp - Add missing bootloader info reg for pspv5
crypto: ccp - Add missing tee info reg for teev2

 drivers/crypto/ccp/sp-pci.c | 2 ++
 1 file changed, 2 insertions(+)
Signature · 1 line
2.43.0
author
#1 lore raw

PATCH 1/2 crypto: ccp - Add missing bootloader info reg for pspv5

From: Mario Limonciello <[email protected]>

The bootloader info reg for pspv5 is the same as pspv4.

Signed-off-by Mario Limonciello <[email protected]>
---
 drivers/crypto/ccp/sp-pci.c | 1 +
 1 file changed, 1 insertion(+)
drivers/crypto/ccp/sp-pci.c +1 -0
index 2ebc878da1609..e8d2bb646f3f4 100644
@@ -440,6 +440,7 @@ static const struct psp_vdata pspv5 = {
 	.cmdresp_reg		= 0x10944,	/* C2PMSG_17 */
 	.cmdbuff_addr_lo_reg	= 0x10948,	/* C2PMSG_18 */
 	.cmdbuff_addr_hi_reg	= 0x1094c,	/* C2PMSG_19 */
+	.bootloader_info_reg	= 0x109ec,	/* C2PMSG_59 */
 	.feature_reg		= 0x109fc,	/* C2PMSG_63 */
 	.inten_reg		= 0x10510,	/* P2CMSG_INTEN */
 	.intsts_reg		= 0x10514,	/* P2CMSG_INTSTS */
Signature · 1 line
2.43.0
author
#2 lore raw

PATCH 2/2 crypto: ccp - Add missing tee info reg for teev2

In reply to Mario Limonciello

From: Mario Limonciello <[email protected]>

The tee info reg for teev2 is the same as teev1.

Signed-off-by Mario Limonciello <[email protected]>
---
 drivers/crypto/ccp/sp-pci.c | 1 +
 1 file changed, 1 insertion(+)
drivers/crypto/ccp/sp-pci.c +1 -0
index e8d2bb646f3f4..fa5283b05323c 100644
@@ -375,6 +375,7 @@ static const struct tee_vdata teev1 = {
 static const struct tee_vdata teev2 = {
 	.ring_wptr_reg		= 0x10950,	/* C2PMSG_20 */
 	.ring_rptr_reg		= 0x10954,	/* C2PMSG_21 */
+	.info_reg		= 0x109e8,	/* C2PMSG_58 */
 };
 
 static const struct platform_access_vdata pa_v1 = {
Signature · 1 line
2.43.0
maintainer
#3 lore raw
In reply to Mario Limonciello
Quoted 5 lines · Mario Limonciello

From: Mario Limonciello <[email protected]>

pspv5 and teev2 are missing the registers for version information.

Quoted 9 lines

Mario Limonciello (2):
crypto: ccp - Add missing bootloader info reg for pspv5
crypto: ccp - Add missing tee info reg for teev2

 drivers/crypto/ccp/sp-pci.c | 2 ++
 1 file changed, 2 insertions(+)
Signature · 1 line
2.43.0

All applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt