Skip to contentSkip to conversation

ASoC: rt722: make regmap cache-only in probe

PATCH In review [email protected] 4 participants 4 messages May 19, 2025 – May 20, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: rt722: make regmap cache-only in probe

From: Shuming Fan <[email protected]>

This patch makes sure the access to the codecs is cached until the device is enumerated.

---
 sound/soc/codecs/rt722-sdca-sdw.h | 1 +
 sound/soc/codecs/rt722-sdca.c     | 4 +++-
 2 files changed, 4 insertions(+), 1 deletion(-)
sound/soc/codecs/rt722-sdca-sdw.h +1 -0
index 80b014456940..c5dd472a2c00 100644
@@ -34,6 +34,7 @@ static const struct reg_default rt722_sdca_reg_defaults[] = {
 	{ 0x200003c, 0xc214 },
 	{ 0x2000046, 0x8004 },
 	{ 0x5810000, 0x702d },
+	{ 0x6100000, 0x0201 },
 	{ 0x6100006, 0x0005 },
 	{ 0x6100010, 0x2630 },
 	{ 0x6100011, 0x152f },
sound/soc/codecs/rt722-sdca.c +3 -1
index f0d3fd9b3d95..ac9588284a95 100644
@@ -1309,6 +1309,8 @@ int rt722_sdca_init(struct device *dev, struct regmap *regmap, struct sdw_slave
 	rt722->slave = slave;
 	rt722->regmap = regmap;
 
+	regcache_cache_only(rt722->regmap, true);
+
 	mutex_init(&rt722->calibrate_mutex);
 	mutex_init(&rt722->disable_irq_lock);
 
@@ -1521,8 +1523,8 @@ int rt722_sdca_io_init(struct device *dev, struct sdw_slave *slave)
 	if (rt722->hw_init)
 		return 0;
 
+	regcache_cache_only(rt722->regmap, false);
 	if (rt722->first_hw_init) {
-		regcache_cache_only(rt722->regmap, false);
 		regcache_cache_bypass(rt722->regmap, true);
 	} else {
 		/*
Signature · 1 line
2.34.1
Tested-by on v1 1/1
#1 lore raw
Quoted 5 lines · On 19/05/25 14:36, [email protected] wrote:

From: Shuming Fan <[email protected]>

This patch makes sure the access to the codecs is cached until the device is enumerated.

Quoted 40 lines
---
 sound/soc/codecs/rt722-sdca-sdw.h | 1 +
 sound/soc/codecs/rt722-sdca.c     | 4 +++-
 2 files changed, 4 insertions(+), 1 deletion(-)
sound/soc/codecs/rt722-sdca-sdw.h +1 -0
index 80b014456940..c5dd472a2c00 100644
@@ -34,6 +34,7 @@ static const struct reg_default rt722_sdca_reg_defaults[] = {
 	{ 0x200003c, 0xc214 },
 	{ 0x2000046, 0x8004 },
 	{ 0x5810000, 0x702d },
+	{ 0x6100000, 0x0201 },
 	{ 0x6100006, 0x0005 },
 	{ 0x6100010, 0x2630 },
 	{ 0x6100011, 0x152f },
sound/soc/codecs/rt722-sdca.c +3 -1
index f0d3fd9b3d95..ac9588284a95 100644
@@ -1309,6 +1309,8 @@ int rt722_sdca_init(struct device *dev, struct regmap *regmap, struct sdw_slave
 	rt722->slave = slave;
 	rt722->regmap = regmap;
 
+	regcache_cache_only(rt722->regmap, true);
+
 	mutex_init(&rt722->calibrate_mutex);
 	mutex_init(&rt722->disable_irq_lock);
 
@@ -1521,8 +1523,8 @@ int rt722_sdca_io_init(struct device *dev, struct sdw_slave *slave)
 	if (rt722->hw_init)
 		return 0;
 
+	regcache_cache_only(rt722->regmap, false);
 	if (rt722->first_hw_init) {
-		regcache_cache_only(rt722->regmap, false);
 		regcache_cache_bypass(rt722->regmap, true);
 	} else {
 		/*
maintainer
#3 lore raw
In reply to [email protected]
Quoted 3 lines · On Mon, 19 May 2025 17:06:45 +0800, [email protected] wrote:

This patch makes sure the access to the codecs is cached until the device is enumerated.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: rt722: make regmap cache-only in probe

      commit: 152c773fb4d200985705218e0314fbd7875a3292

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark