ALSA: hda/cs35l56: select FW_CS_DSP
PATCH 1/1 ALSA: hda/cs35l56: select FW_CS_DSP
From: Arnd Bergmann <[email protected]>
When compile-testing this driver, the missing FW_CS_DSP module causes a link failure:
aarch64-linux-ld: sound/pci/hda/cs35l41_hda.o: in function `cs35l41_shutdown_dsp':
cs35l41_hda.c:(.text+0x7e4): undefined reference to `cs_dsp_stop'
aarch64-linux-ld: cs35l41_hda.c:(.text+0x7ec): undefined reference to `cs_dsp_power_down'
aarch64-linux-ld: sound/pci/hda/cs35l41_hda.o: in function `cs35l41_hda_remove':
cs35l41_hda.c:(.text+0x14b4): undefined reference to `cs_dsp_remove'
aarch64-linux-ld: sound/pci/hda/cs35l41_hda.o: in function `cs35l41_smart_amp.isra.0':
cs35l41_hda.c:(.text+0x189c): undefined reference to `cs_dsp_halo_init'
aarch64-linux-ld: cs35l41_hda.c:(.text+0x1bd4): undefined reference to `cs_dsp_power_up'
aarch64-linux-ld: cs35l41_hda.c:(.text+0x1c38): undefined reference to `cs_dsp_run'
aarch64-linux-ld: cs35l41_hda.c:(.text+0x1c80): undefined reference to `cs_dsp_get_ctl'
aarch64-linux-ld: cs35l41_hda.c:(.text+0x1c90): undefined reference to `cs_dsp_coeff_read_ctrl'
aarch64-linux-ld: cs35l41_hda.c:(.text+0x1cd4): undefined reference to `cs_dsp_get_ctl'
aarch64-linux-ld: cs35l41_hda.c:(.text+0x1ce4): undefined reference to `cs_dsp_coeff_read_ctrl'
--- sound/pci/hda/Kconfig | 1 + 1 file changed, 1 insertion(+)
sound/pci/hda/Kconfig +1 -0
@@ -109,6 +109,7 @@ config SND_HDA_SCODEC_CS35L41 tristate select SND_HDA_GENERIC select REGMAP_IRQ + select FW_CS_DSP config SND_HDA_SCODEC_COMPONENT tristate
Signature · 1 line
2.39.5
Quoted 19 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
When compile-testing this driver, the missing
FW_CS_DSPmodule causes a link failure:aarch64-linux-ld:
sound/pci/hda/cs35l41_hda.o: in function `cs35l41_shutdown_dsp':
cs35l41_hda.c:(.text+0x7e4): undefined reference to `cs_dsp_stop'
aarch64-linux-ld: cs35l41_hda.c:(.text+0x7ec): undefined reference to `cs_dsp_power_down'
aarch64-linux-ld:sound/pci/hda/cs35l41_hda.o: in function `cs35l41_hda_remove':
cs35l41_hda.c:(.text+0x14b4): undefined reference to `cs_dsp_remove'
aarch64-linux-ld:sound/pci/hda/cs35l41_hda.o: in function `cs35l41_smart_amp.isra.0':
cs35l41_hda.c:(.text+0x189c): undefined reference to `cs_dsp_halo_init'
aarch64-linux-ld: cs35l41_hda.c:(.text+0x1bd4): undefined reference to `cs_dsp_power_up'
aarch64-linux-ld: cs35l41_hda.c:(.text+0x1c38): undefined reference to `cs_dsp_run'
aarch64-linux-ld: cs35l41_hda.c:(.text+0x1c80): undefined reference to `cs_dsp_get_ctl'
aarch64-linux-ld: cs35l41_hda.c:(.text+0x1c90): undefined reference to `cs_dsp_coeff_read_ctrl'
aarch64-linux-ld: cs35l41_hda.c:(.text+0x1cd4): undefined reference to `cs_dsp_get_ctl'
aarch64-linux-ld: cs35l41_hda.c:(.text+0x1ce4): undefined reference to `cs_dsp_coeff_read_ctrl'
Quoted 1 line
Fixes 849c83fe4991 ("ALSA: hda/cs35l56: Remove dependency on COMPILE_TEST")
But the error messages above and the change below are for CS35L41
Quoted 17 lines
Signed-off-by Arnd Bergmann <[email protected]>--- sound/pci/hda/Kconfig | 1 + 1 file changed, 1 insertion(+)sound/pci/hda/Kconfig +1
-0@@ -109,6 +109,7 @@ config SND_HDA_SCODEC_CS35L41 tristate select SND_HDA_GENERIC select REGMAP_IRQ + select FW_CS_DSP config SND_HDA_SCODEC_COMPONENT tristate
Quoted 6 lines · Richard Fitzgerald
Quoted 3 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Fixes 849c83fe4991 ("ALSA: hda/cs35l56: Remove dependency on COMPILE_TEST")But the error messages above and the change below are for CS35L41
Sorry about that, I think I found the correct cause now and sent a v2.
Arnd