Skip to contentSkip to conversation

crypto: qat - add missing header inclusion

PATCH In review Arnd Bergmann 3 participants 4 messages May 20, 2025 – May 23, 2025

Subsystems (2)
Crypto API QAT driver
lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 crypto: qat - add missing header inclusion

From: Arnd Bergmann <[email protected]>

Without this header, building the new driver fails with:

In file included from drivers/crypto/intel/qat/qat_common/adf_gen6_shared.c:7:
drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h: In function 'adf_gen4_init_pf_pfvf_ops':
drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h:13:34: error: 'adf_pfvf_comms_disabled' undeclared (first use in this function)

   13 |         pfvf_ops->enable_comms = adf_pfvf_comms_disabled;
      |                                  ^~~~~~~~~~~~~~~~~~~~~~~
Fixes 17fd7514ae68 ("crypto: qat - add qat_6xxx driver")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h | 1 +
 drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h | 1 +
 2 files changed, 2 insertions(+)
drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h +1 -0
index a716545a764c..9efee0053f3a 100644
@@ -4,6 +4,7 @@
 #define ADF_GEN2_PFVF_H
 
 #include <linux/types.h>
+#include "adf_common_drv.h"
 #include "adf_accel_devices.h"
 
 #define ADF_GEN2_ERRSOU3 (0x3A000 + 0x0C)
drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h +1 -0
index 17d1b774d4a8..2c8708117f70 100644
@@ -4,6 +4,7 @@
 #define ADF_GEN4_PFVF_H
 
 #include "adf_accel_devices.h"
+#include "adf_common_drv.h"
 
 #ifdef CONFIG_PCI_IOV
 void adf_gen4_init_pf_pfvf_ops(struct adf_pfvf_ops *pfvf_ops);
Signature · 1 line
2.39.5
maintainer
#1 lore raw
Quoted 4 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

Without this header, building the new driver fails with:

Quoted 8 lines

In file included from drivers/crypto/intel/qat/qat_common/adf_gen6_shared.c:7:
drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h: In function 'adf_gen4_init_pf_pfvf_ops':
drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h:13:34: error: 'adf_pfvf_comms_disabled' undeclared (first use in this function)

   13 |         pfvf_ops->enable_comms = adf_pfvf_comms_disabled;
      |                                  ^~~~~~~~~~~~~~~~~~~~~~~
Fixes 17fd7514ae68 ("crypto: qat - add qat_6xxx driver")
Signed-off-by Arnd Bergmann <[email protected]>

Thanks Arnd. This occurs with CONFIG_PCI_IOV not set. Can this be added to the commit message?

Quoted 10 lines
---
 drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h | 1 +
 drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h | 1 +
 2 files changed, 2 insertions(+)
drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h +0 -0
index a716545a764c..9efee0053f3a 100644

drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h line 8

Quoted 5 lines
drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h +1 -0
@@ -4,6 +4,7 @@
 #define ADF_GEN2_PFVF_H
 
 #include <linux/types.h>
+#include "adf_common_drv.h"
 #include "adf_accel_devices.h"

NIT. Can this be in alphabetical order?

Quoted 7 lines
drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h +0 -0
 #define ADF_GEN2_ERRSOU3 (0x3A000 + 0x0C)
drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h +0 -0
index 17d1b774d4a8..2c8708117f70 100644

drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h line 10

Quoted 7 lines
drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h +1 -0
@@ -4,6 +4,7 @@
 #define ADF_GEN4_PFVF_H
 
 #include "adf_accel_devices.h"
+#include "adf_common_drv.h"
 
 #ifdef CONFIG_PCI_IOV
 void adf_gen4_init_pf_pfvf_ops(struct adf_pfvf_ops *pfvf_ops);

Thanks,

Signature · 1 line
Giovanni
maintainer
#2 lore raw

PATCH v2 1/1 crypto: qat - add missing header inclusion

Quoted 28 lines · Giovanni
Quoted 4 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

Without this header, building the new driver fails with:

Quoted 8 lines

In file included from drivers/crypto/intel/qat/qat_common/adf_gen6_shared.c:7:
drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h: In function 'adf_gen4_init_pf_pfvf_ops':
drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h:13:34: error: 'adf_pfvf_comms_disabled' undeclared (first use in this function)

   13 |         pfvf_ops->enable_comms = adf_pfvf_comms_disabled;
      |                                  ^~~~~~~~~~~~~~~~~~~~~~~
Fixes 17fd7514ae68 ("crypto: qat - add qat_6xxx driver")
Signed-off-by Arnd Bergmann <[email protected]>

Thanks Arnd. This occurs with CONFIG_PCI_IOV not set. Can this be added to the commit message?

Quoted 12 lines
---
 drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h | 1 +
 drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h | 1 +
 2 files changed, 2 insertions(+)
drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h +0 -0
index a716545a764c..9efee0053f3a 100644
@@ -4,6 +4,7 @@
 #define ADF_GEN2_PFVF_H
Quoted 4 lines

drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h line 8

Quoted 3 lines
drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h +1 -0
 #include <linux/types.h>
+#include "adf_common_drv.h"
 #include "adf_accel_devices.h"

NIT. Can this be in alphabetical order?

---8<---

From: Arnd Bergmann <[email protected]>
Subject: [PATCH] crypto: qat - add missing header inclusion

Without this header, the build of the new qat_6xxx driver fails when CONFIG_PCI_IOV is not set:

In file included from drivers/crypto/intel/qat/qat_common/adf_gen6_shared.c:7:
drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h: In function 'adf_gen4_init_pf_pfvf_ops':
drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h:13:34: error: 'adf_pfvf_comms_disabled' undeclared (first use in this function)
13 | pfvf_ops->enable_comms = adf_pfvf_comms_disabled;
| ^~~~~~~~~~~~~~~~~~~~~~~

Fixes 17fd7514ae68 ("crypto: qat - add qat_6xxx driver")
Signed-off-by Arnd Bergmann <[email protected]>
Acked-by Giovanni Cabiddu <[email protected]>
---
 drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h | 1 +
 drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h | 1 +
 2 files changed, 2 insertions(+)
drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h +1 -0
index a716545a764c..34a63cf40db2 100644
@@ -5,6 +5,7 @@
 
 #include <linux/types.h>
 #include "adf_accel_devices.h"
+#include "adf_common_drv.h"
 
 #define ADF_GEN2_ERRSOU3 (0x3A000 + 0x0C)
 #define ADF_GEN2_ERRSOU5 (0x3A000 + 0xD8)
drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h +1 -0
index 17d1b774d4a8..2c8708117f70 100644
@@ -4,6 +4,7 @@
 #define ADF_GEN4_PFVF_H
 
 #include "adf_accel_devices.h"
+#include "adf_common_drv.h"
 
 #ifdef CONFIG_PCI_IOV
 void adf_gen4_init_pf_pfvf_ops(struct adf_pfvf_ops *pfvf_ops);
Signature · 1 line
2.49.0
maintainer
#3 lore raw
Quoted 10 lines · Giovanni

Without this header, the build of the new qat_6xxx driver fails when CONFIG_PCI_IOV is not set:

In file included from drivers/crypto/intel/qat/qat_common/adf_gen6_shared.c:7:
drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h: In function 'adf_gen4_init_pf_pfvf_ops':
drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h:13:34: error: 'adf_pfvf_comms_disabled' undeclared (first use in this function)
13 | pfvf_ops->enable_comms = adf_pfvf_comms_disabled;
| ^~~~~~~~~~~~~~~~~~~~~~~

Quoted 7 lines
Fixes 17fd7514ae68 ("crypto: qat - add qat_6xxx driver")
Signed-off-by Arnd Bergmann <[email protected]>
Acked-by Giovanni Cabiddu <[email protected]>
---
 drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h | 1 +
 drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h | 1 +
 2 files changed, 2 insertions(+)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt