Skip to contentSkip to conversation

alpha: Replace strcpy() with strscpy() in setup_arch()

PATCH RESEND Superseded Thorsten Blum 1 participant 1 message May 21, 2025 Alpha port

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 alpha: Replace strcpy() with strscpy() in setup_arch()

strcpy() is deprecated; use strscpy() instead.

Since the destination buffer 'command_line' has a fixed length, strscpy() automatically determines its size using sizeof() when the size argument is omitted. This makes the explicit size argument for the existing strscpy() call unnecessary - remove it.

No functional changes intended.

---
 arch/alpha/kernel/setup.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/alpha/kernel/setup.c +3 -3
index bebdffafaee8..8b51e6ca83d6 100644
@@ -468,8 +468,8 @@ setup_arch(char **cmdline_p)
 	/* 
 	 * Locate the command line.
 	 */
-	strscpy(command_line, COMMAND_LINE, sizeof(command_line));
-	strcpy(boot_command_line, command_line);
+	strscpy(command_line, COMMAND_LINE);
+	strscpy(boot_command_line, command_line, COMMAND_LINE_SIZE);
 	*cmdline_p = command_line;
 
 	/* 
@@ -511,7 +511,7 @@ setup_arch(char **cmdline_p)
 	}
 
 	/* Replace the command line, now that we've killed it with strsep.  */
-	strcpy(command_line, boot_command_line);
+	strscpy(command_line, boot_command_line);
 
 	/* If we want SRM console printk echoing early, do it now. */
 	if (alpha_using_srm && srmcons_output) {
Signature · 1 line
2.49.0