usb: typec: tipd: fix typo in TPS_STATUS_HIGH_VOLAGE_WARNING macro
Subsystems (2)
PATCH 1/1 usb: typec: tipd: fix typo in TPS_STATUS_HIGH_VOLAGE_WARNING macro
"VOLAGE" should become "VOLTAGE"
--- drivers/usb/typec/tipd/tps6598x.h | 2 +- drivers/usb/typec/tipd/trace.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/usb/typec/tipd/tps6598x.h +1 -1
@@ -27,7 +27,7 @@#define TPS_STATUS_OVERCURRENT BIT(16)#define TPS_STATUS_GOTO_MIN_ACTIVE BIT(26)#define TPS_STATUS_BIST BIT(27) -#define TPS_STATUS_HIGH_VOLAGE_WARNING BIT(28) +#define TPS_STATUS_HIGH_VOLTAGE_WARNING BIT(28)#define TPS_STATUS_HIGH_LOW_VOLTAGE_WARNING BIT(29)#define TPS_STATUS_CONN_STATE_MASK GENMASK(3, 1)
drivers/usb/typec/tipd/trace.h +1 -1
@@ -153,7 +153,7 @@ { TPS_STATUS_OVERCURRENT, "OVERCURRENT" }, \ { TPS_STATUS_GOTO_MIN_ACTIVE, "GOTO_MIN_ACTIVE" }, \ { TPS_STATUS_BIST, "BIST" }, \ - { TPS_STATUS_HIGH_VOLAGE_WARNING, "HIGH_VOLAGE_WARNING" }, \ + { TPS_STATUS_HIGH_VOLTAGE_WARNING, "HIGH_VOLTAGE_WARNING" }, \ { TPS_STATUS_HIGH_LOW_VOLTAGE_WARNING, "HIGH_LOW_VOLTAGE_WARNING" }) #define show_tps25750_status_flags(flags) \
Signature · 1 line
2.39.5
Quoted 3 lines · Jihed Chaibi
"VOLAGE" should become "VOLTAGE"
Signed-off-by Jihed Chaibi <[email protected]>
Nice work! I was able to successfully compile this driver with your changes and I don't see any further references to the misspelled macro.
Patches which fix issues which were introduced in some previous commit typically indicate the offending commit via the "Fixes" tag. Admittedly, I don't know if the tag is reserved for technical bugs rather than typos such as the one you addressed, but such a tag would look like the following for this patch:
Quoted 23 lines
--- drivers/usb/typec/tipd/tps6598x.h | 2 +- drivers/usb/typec/tipd/trace.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/usb/typec/tipd/tps6598x.h +1
-1@@ -27,7 +27,7 @@#define TPS_STATUS_OVERCURRENT BIT(16)#define TPS_STATUS_GOTO_MIN_ACTIVE BIT(26)#define TPS_STATUS_BIST BIT(27) -#define TPS_STATUS_HIGH_VOLAGE_WARNING BIT(28) +#define TPS_STATUS_HIGH_VOLTAGE_WARNING BIT(28)#define TPS_STATUS_HIGH_LOW_VOLTAGE_WARNING BIT(29)#define TPS_STATUS_CONN_STATE_MASK GENMASK(3, 1)drivers/usb/typec/tipd/trace.h +0
-0
drivers/usb/typec/tipd/trace.h line 157
Quoted 6 lines
drivers/usb/typec/tipd/trace.h +1
-1@@ -153,7 +153,7 @@ { TPS_STATUS_OVERCURRENT, "OVERCURRENT" }, \ { TPS_STATUS_GOTO_MIN_ACTIVE, "GOTO_MIN_ACTIVE" }, \ { TPS_STATUS_BIST, "BIST" }, \ - { TPS_STATUS_HIGH_VOLAGE_WARNING, "HIGH_VOLAGE_WARNING" }, \ + { TPS_STATUS_HIGH_VOLTAGE_WARNING, "HIGH_VOLTAGE_WARNING" }, \ { TPS_STATUS_HIGH_LOW_VOLTAGE_WARNING, "HIGH_LOW_VOLTAGE_WARNING" })
Consider making "HIGH_LOW_VOLTAGE_WARNING" inline with "HIGH_VOLTAGE_WARNING", or vice versa.
drivers/usb/typec/tipd/trace.h line 159
Quoted 2 lines
drivers/usb/typec/tipd/trace.h +0
-0#define show_tps25750_status_flags (flags) \
Greg KH
maintainerQuoted 8 lines · Brigham Campbell
Quoted 3 lines · Jihed Chaibi
"VOLAGE" should become "VOLTAGE"
Signed-off-by Jihed Chaibi <[email protected]>Nice work! I was able to successfully compile this driver with your changes and I don't see any further references to the misspelled macro.
Quoted 7 lines
Patches which fix issues which were introduced in some previous commit typically indicate the offending commit via the "Fixes" tag. Admittedly, I don't know if the tag is reserved for technical bugs rather than typos such as the one you addressed, but such a tag would look like the following for this patch:
Fixes e011178579b57c03 ("usb: typec: tipd: fix typo in TPS_STATUS_HIGH_VOLAGE_WARNING macro")
Too many characters for that sha1 value :)
thanks,
greg k-hj
Quoted 16 lines · Greg KH
Quoted 14 lines · Brigham Campbell
Quoted 3 lines · Jihed Chaibi
"VOLAGE" should become "VOLTAGE"
Signed-off-by Jihed Chaibi <[email protected]>Nice work! I was able to successfully compile this driver with your changes and I don't see any further references to the misspelled macro.
Patches which fix issues which were introduced in some previous commit typically indicate the offending commit via the "Fixes" tag. Admittedly, I don't know if the tag is reserved for technical bugs rather than typos such as the one you addressed, but such a tag would look like the following for this patch:
Quoted 7 lines
Quoted 1 line
Fixes e011178579b57c03 ("usb: typec: tipd: fix typo in TPS_STATUS_HIGH_VOLAGE_WARNING macro")Too many characters for that sha1 value :)
thanks,
greg k-hj
Thanks for the feedback!
I assumed this tiny typo fix might not need a "Fixes:" tag since it doesn’t really "fix" any functional issue—just let me know if you disagree. I’m just beginning my kernel contribution journey, so I appreciate any guidance.
Cheers,
Quoted 2 lines · Greg KH
Too many characters for that sha1 value :)
I heard recently about concerns regarding the collision of 12-character sha1 abbreviations [1] and had assumed that using 16 characters is acceptable. Regrettably, I neglected to read Linus's response to the email which rose those concerns. After reading his response, I'm satisfied knowing that there is still very little risk of a collision between the abbreviations of commit objects specifically.
I'll modify my git config to use 12 character abbrevs.
Thanks,
Brigham
Greg KH
maintainerQuoted 4 lines · Brigham Campbell
Quoted 2 lines · Greg KH
Too many characters for that sha1 value :)
Quoted 8 lines
I heard recently about concerns regarding the collision of 12-character sha1 abbreviations [1] and had assumed that using 16 characters is acceptable. Regrettably, I neglected to read Linus's response to the email which rose those concerns. After reading his response, I'm satisfied knowing that there is still very little risk of a collision between the abbreviations of commit objects specifically.
I'll modify my git config to use 12 character abbrevs.
The documentation should have the git config settings that are needed:
[core] abbrev = 12