ALSA: hda: acpi: Use SYSTEM_SLEEP_PM_OPS()
PATCH 1/1 ALSA: hda: acpi: Use SYSTEM_SLEEP_PM_OPS()
The dev_pm_ops definition must be SYSTEM_SLEEP_PM_OPS() instead of SET_SYSTEM_SLEEP_PM_OPS(); otherwise it leads compile warnings without CONFIG_PM_SLEEP. The latest patch version I took was back to an old macro (likely mistakenly), and I overlooked it at applying. Fix it now.
--- sound/pci/hda/hda_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/pci/hda/hda_acpi.c +1 -1
@@ -293,7 +293,7 @@ static int hda_acpi_resume(struct device *dev) }static const struct dev_pm_ops hda_acpi_pm = { -SET_SYSTEM_SLEEP_PM_OPS (hda_acpi_suspend, hda_acpi_resume) +SYSTEM_SLEEP_PM_OPS (hda_acpi_suspend, hda_acpi_resume) };struct hda_data nvidia_hda_data = {
Signature · 1 line
2.49.0
Mea culpa.
Quoted 30 lines · Takashi Iwai
The
dev_pm_opsdefinition must beSYSTEM_SLEEP_PM_OPS()instead ofSET_SYSTEM_SLEEP_PM_OPS(); otherwise it leads compile warnings withoutCONFIG_PM_SLEEP. The latest patch version I took was back to an old macro (likely mistakenly), and I overlooked it at applying. Fix it now.Fixes 4b214c9bbe26 ("ALSA: hda - Add new driver for HDA controllers listed via ACPI")Reported-by Randy Dunlap <[email protected]>Signed-off-by Takashi Iwai <[email protected]>--- sound/pci/hda/hda_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)sound/pci/hda/hda_acpi.c +1
-1@@ -293,7 +293,7 @@ static int hda_acpi_resume(struct device *dev) }static const struct dev_pm_ops hda_acpi_pm = { -SET_SYSTEM_SLEEP_PM_OPS (hda_acpi_suspend, hda_acpi_resume) +SYSTEM_SLEEP_PM_OPS (hda_acpi_suspend, hda_acpi_resume) };struct hda_data nvidia_hda_data = {Signature · 1 line
2.49.0
Quoted 10 lines · Takashi Iwai
The
dev_pm_opsdefinition must beSYSTEM_SLEEP_PM_OPS()instead ofSET_SYSTEM_SLEEP_PM_OPS(); otherwise it leads compile warnings withoutCONFIG_PM_SLEEP. The latest patch version I took was back to an old macro (likely mistakenly), and I overlooked it at applying. Fix it now.Fixes 4b214c9bbe26 ("ALSA: hda - Add new driver for HDA controllers listed via ACPI")Reported-by Randy Dunlap <[email protected]>Signed-off-by Takashi Iwai <[email protected]>
Thanks.
Quoted 17 lines
--- sound/pci/hda/hda_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)sound/pci/hda/hda_acpi.c +1
-1@@ -293,7 +293,7 @@ static int hda_acpi_resume(struct device *dev) }static const struct dev_pm_ops hda_acpi_pm = { -SET_SYSTEM_SLEEP_PM_OPS (hda_acpi_suspend, hda_acpi_resume) +SYSTEM_SLEEP_PM_OPS (hda_acpi_suspend, hda_acpi_resume) };struct hda_data nvidia_hda_data = {
Signature · 1 line
~Randy