kernel-fitimage: Cope with FIT_CONF_DEFAULT_DTB being empty
PATCH 1/1 kernel-fitimage: Cope with FIT_CONF_DEFAULT_DTB being empty
From: Mike Crowe <[email protected]>
Quote both sides of the comparison of ${FIT_CONF_DEFAULT_DTB} and $DTB consistently to avoid parse errors if either side is empty.
--- meta/classes-recipe/kernel-fitimage.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes-recipe/kernel-fitimage.bbclass +1 -1
@@ -593,7 +593,7 @@ fitimage_assemble() { for DTB in $(find "${EXTERNAL_KERNEL_DEVICETREE}" -name '*.dtb' -printf '%P\n' | sort) \ $(find "${EXTERNAL_KERNEL_DEVICETREE}" -name '*.dtbo' -printf '%P\n' | sort); do # Set the default dtb image if it exists in the devicetree. - if [ ${FIT_CONF_DEFAULT_DTB} = $DTB ];then + if [ "${FIT_CONF_DEFAULT_DTB}" = "$DTB" ];then default_dtb_image=$(echo "$DTB" | tr '/' '_') fi
Signature · 1 line
2.39.5
Quoted 8 lines · Mike Crowe via lists.openembedded.org
From: Mike Crowe <[email protected]>
Quote both sides of the comparison of ${FIT_CONF_DEFAULT_DTB} and $DTB consistently to avoid parse errors if either side is empty.
Signed-off-by Mike Crowe <[email protected]>Reviewed-by Jack Mitchell <[email protected]>---
Hi Mike,
Thanks for your patch.
Just a note: this patch is conflicting with the "FIT image improvements" series:
https://lists.openembedded.org/g/openembedded-core/message/217192
As this series is most likely going to be merged soon, can you rewrite your patch on top of it?
Thanks!
Signature · 3 lines
Mathieu Dubois-Briand, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Quoted 12 lines · Mathieu Dubois-Briand
Quoted 8 lines · Mike Crowe via lists.openembedded.org
From: Mike Crowe <[email protected]>
Quote both sides of the comparison of ${FIT_CONF_DEFAULT_DTB} and $DTB consistently to avoid parse errors if either side is empty.
Signed-off-by Mike Crowe <[email protected]>Reviewed-by Jack Mitchell <[email protected]>---
Hi Mike,
Quoted 8 lines
Thanks for your patch.
Just a note: this patch is conflicting with the "FIT image improvements" series:
https://lists.openembedded.org/g/openembedded-core/message/217192As this series is most likely going to be merged soon, can you rewrite your patch on top of it?
Hi Mathieu,
I spotted that not long after I posted my patch. I replied, but somehow I only managed to send that reply to Adrian Freihofer, the author of the
Quoted 5 lines · here's what I
It looks like Adrian Freihofer's
"[PATCH v5 14/17] kernel-fitimage: re-write its code in Python" in <[email protected]> removes this code and replaces it with Python which won't suffer from the problem. That's much better than my fix above.
So my patch can be ignored.
Thanks and sorry for the hassle.
Mike.
Quoted 34 lines · Mike Crowe
Quoted 12 lines · Mathieu Dubois-Briand
Quoted 8 lines · Mike Crowe via lists.openembedded.org
From: Mike Crowe <[email protected]>
Quote both sides of the comparison of ${FIT_CONF_DEFAULT_DTB} and $DTB consistently to avoid parse errors if either side is empty.
Signed-off-by Mike Crowe <[email protected]>Reviewed-by Jack Mitchell <[email protected]>---
Hi Mike,
Quoted 8 lines
Thanks for your patch.
Just a note: this patch is conflicting with the "FIT image improvements" series:
https://lists.openembedded.org/g/openembedded-core/message/217192As this series is most likely going to be merged soon, can you rewrite your patch on top of it?
Hi Mathieu,
I spotted that not long after I posted my patch. I replied, but somehow I only managed to send that reply to Adrian Freihofer, the author of the
Quoted 5 lines · here's what I
It looks like Adrian Freihofer's
"[PATCH v5 14/17] kernel-fitimage: re-write its code in Python" in <[email protected]> removes this code and replaces it with Python which won't suffer from the problem. That's much better than my fix above.
Quoted 5 lines
So my patch can be ignored.
Thanks and sorry for the hassle.
Mike.
No problem, thanks for the update!
Signature · 3 lines
Mathieu Dubois-Briand, Bootlin Embedded Linux and Kernel engineering https://bootlin.com