Skip to contentSkip to conversation

ASoC: codecs: fix out-of-bounds access on invalid clock config

PATCH In review Qasim Ijaz 2 participants 2 messages May 26, 2025 – May 27, 2025

Subsystems (2)
lore
Share & tools
lore

Qasim Ijaz

author
#0 lore raw

PATCH 1/1 ASoC: codecs: fix out-of-bounds access on invalid clock config

get_coeff() returns –EINVAL when no table entry matches. The driver then uses that value as an index into coeff_div[], causing an OOB access.

To fix lets abort the hw_params call instead.

Fixes de2b3119f9f7 ("ASoC: codecs: add support for ES8375")
---
 sound/soc/codecs/es8375.c | 1 +
 1 file changed, 1 insertion(+)
sound/soc/codecs/es8375.c +1 -0
index decc86c92427..009259632107 100644
@@ -319,6 +319,7 @@ static int es8375_hw_params(struct snd_pcm_substream *substream,
 	coeff = get_coeff(es8375->vddd, dmic_enable, es8375->mclk_freq, params_rate(params));
 	if (coeff < 0) {
 		dev_warn(component->dev, "Clock coefficients do not match");
+		return coeff;
 	}
 	regmap_write(es8375->regmap, ES8375_CLK_MGR4,
 			coeff_div[coeff].Reg0x04);
Signature · 1 line
2.39.5
maintainer
#1 lore raw
Quoted 8 lines · Qasim Ijaz

get_coeff() returns –EINVAL when no table entry matches. The driver then uses that value as an index into coeff_div[], causing an OOB access.

To fix lets abort the hw_params call instead.

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: codecs: fix out-of-bounds access on invalid clock config

      commit: 16719d48197bbd8cff121b32acec67d954335437

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark