Skip to contentSkip to conversation

dt-bindings: interconnect: add mt7988-cci compatible

RFC Superseded Frank Wunderlich 2 participants 3 messages May 28, 2025 – May 30, 2025

Subsystems (4)
Device tree bindings Arm MediaTek Device frequency (devfreq) Interconnect API

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Frank Wunderlich

author
#0 lore raw

RFC 1/1 dt-bindings: interconnect: add mt7988-cci compatible

From: Frank Wunderlich <[email protected]>

Add compatible for Mediatek MT7988 SoC with mediatek,mt8183-cci fallback which is taken by driver.

Signed-off-by Frank Wunderlich <[email protected]>
---
 .../bindings/interconnect/mediatek,cci.yaml          | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml +9 -3
index 58611ba2a0f4..2c6785c588e9 100644
@@ -17,9 +17,15 @@ description: |
 
 properties:
   compatible:
-    enum:
-      - mediatek,mt8183-cci
-      - mediatek,mt8186-cci
+    oneOf:
+      - items:
+          - enum:
+              - mediatek,mt8183-cci
+              - mediatek,mt8186-cci
+      - items:
+          - enum:
+              - mediatek,mt7988-cci
+          - const: mediatek,mt8183-cci
 
   clocks:
     items:
Signature · 1 line
2.43.0
#1 lore raw
Quoted 4 lines · Frank Wunderlich

From: Frank Wunderlich <[email protected]>

Add compatible for Mediatek MT7988 SoC with mediatek,mt8183-cci fallback which is taken by driver.

What's RFC about the patch?

Quoted 11 lines
Signed-off-by Frank Wunderlich <[email protected]>
---
 .../bindings/interconnect/mediatek,cci.yaml          | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml +0 -0
index 58611ba2a0f4..2c6785c588e9 100644

Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml description: | · line 21

Quoted 8 lines
Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml +2 -3
@@ -17,9 +17,15 @@ description: |
 
 properties:
   compatible:
-    enum:
-      - mediatek,mt8183-cci
-      - mediatek,mt8186-cci
+    oneOf:
+      - items:

This "- items:" is redundant.

Quoted 13 lines
Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml +7 -0
+          - enum:
+              - mediatek,mt8183-cci
+              - mediatek,mt8186-cci
+      - items:
+          - enum:
+              - mediatek,mt7988-cci
+          - const: mediatek,mt8183-cci
 
   clocks:
     items:
Signature · 1 line
2.43.0
author
#2 lore raw

Hi

Thank you for review.

Am 30. Mai 2025 17:57:20 MESZ schrieb Conor Dooley <[email protected]>:

Quoted 7 lines · Frank Wunderlich
Quoted 4 lines

From: Frank Wunderlich <[email protected]>

Add compatible for Mediatek MT7988 SoC with mediatek,mt8183-cci fallback which is taken by driver.

What's RFC about the patch?

We have merge window,but maybe this rule is
net(-next) only. And i was unsure if enum for
new compatible is right or if i should use 2
const.

Quoted 12 lines
Quoted 12 lines
Signed-off-by Frank Wunderlich <[email protected]>
---
 .../bindings/interconnect/mediatek,cci.yaml          | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml +0 -0
index 58611ba2a0f4..2c6785c588e9 100644
@@ -17,9 +17,15 @@ description: |
Quoted 9 lines

Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml description: | · line 21

Quoted 7 lines
Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml +2 -3
 properties:
   compatible:
-    enum:
-      - mediatek,mt8183-cci
-      - mediatek,mt8186-cci
+    oneOf:
+      - items:

This "- items:" is redundant.

Ok,i try without it.

Quoted 8 lines
Quoted 8 lines
Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml +7 -0
+          - enum:
+              - mediatek,mt8183-cci
+              - mediatek,mt8186-cci
+      - items:
+          - enum:
+              - mediatek,mt7988-cci
+          - const: mediatek,mt8183-cci
Quoted 5 lines
Quoted 5 lines
Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml +0 -0
   clocks:
     items:
Signature · 1 line
2.43.0

regards Frank