efi/libstub: use 'targets' instead of extra-y in Makefile
PATCH 1/1 efi/libstub: use 'targets' instead of extra-y in Makefile
These objects are built as prerequisites of %.stub.o files. There is no need to use extra-y, which is planned for deprecation.
---
drivers/firmware/efi/libstub/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/firmware/efi/libstub/Makefile +1 -1
@@ -102,7 +102,7 @@ lib-$(CONFIG_EFI_ZBOOT) += zboot.o $(zboot-obj-y) lib-$(CONFIG_UNACCEPTED_MEMORY) += unaccepted_memory.o bitmap.o find.o -extra-y := $(lib-y) +targets := $(lib-y) lib-y := $(patsubst %.o,%.stub.o,$(lib-y)) # Even when -mbranch-protection=none is set, Clang will generate a
Signature · 1 line
2.43.0
Quoted 5 lines · Masahiro Yamada
These objects are built as prerequisites of %.stub.o files. There is no need to use extra-y, which is planned for deprecation.
Signed-off-by Masahiro Yamada <[email protected]>
I misunderstood what extra-y was for - note thatarch/arm64/kernel/pi/Makefile has the same issue.
Quoted 21 lines
---
drivers/firmware/efi/libstub/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/firmware/efi/libstub/Makefile +1
-2@@ -102,7 +102,7 @@ lib-$(CONFIG_EFI_ZBOOT) += zboot.o $(zboot-obj-y) lib-$(CONFIG_UNACCEPTED_MEMORY) += unaccepted_memory.o bitmap.o find.o -extra-y := $(lib-y) +targets := $(lib-y) lib-y := $(patsubst %.o,%.stub.o,$(lib-y)) # Even when -mbranch-protection=none is set, Clang will generate a --2.43.0
Quoted 6 lines · Ard Biesheuvel
Quoted 4 lines · Masahiro Yamada
These objects are built as prerequisites of %.stub.o files. There is no need to use extra-y, which is planned for deprecation.
Quoted 6 lines
Quoted 1 line
Signed-off-by Masahiro Yamada <[email protected]>Acked-by Ard Biesheuvel <[email protected]>I misunderstood what extra-y was for - note that
arch/arm64/kernel/pi/Makefilehas the same issue.
Applied to linux-kbuild.
A patch exists for arm64 too
https://lore.kernel.org/lkml/[email protected]/
Signature · 2 lines
Best Regards Masahiro Yamada