fstests: generic/730: exclude btrfs for now
PATCH v2 1/1 fstests: generic/730: exclude btrfs for now
The test case always fail for btrfs:
generic/730 - output mismatch (see /home/adam/xfstests-dev/results//generic/730.out.bad)
--- tests/generic/730.out 2024-04-25 18:13:45.203549435 +0930
+++ /home/adam/xfstests-dev/results//generic/730.out.bad 2025-06-04 15:10:39.062430952 +0930
@@ -1,2 +1 @@
QA output created by 730
-cat: -: Input/output error
...The root reason is that, btrfs doesn't implement its blk_holder_ops when opening a block device.
Thus when the underlying block device is marked dead, btrfs is never going to know thus no way to shutdown (nor btrfs has a way to shutdown either).
I'm trying to improve the situation, but until then just exlucde btrfs from the test case for now.
---
Changelog:
v2:
- Update the root reason
It's not the sb->s_op->shutdown, that is only for single device fs (through fs_bdev_mark_dead()).
For a multi-devices fs, it should provide a blk_holder_ops when opening the block device.
--- tests/generic/730 | 4 ++++ 1 file changed, 4 insertions(+)
tests/generic/730 +4 -0
@@ -26,6 +26,10 @@ _require_test _require_block_device $TEST_DEV _require_scsi_debug +if [ "$FSTYP" = "btrfs" ]; then + _notrun "btrfs doesn't support per-fs shutdown yet" +fi + size=$(_small_fs_size_mb 256) SCSI_DEBUG_DEV=`_get_scsi_debug_dev 512 512 0 $size` test -b "$SCSI_DEBUG_DEV" || _notrun "Failed to initialize scsi debug device"
Signature · 1 line
2.49.0
Quoted 9 lines · Qu Wenruo
The test case always fail for btrfs:
generic/730 - output mismatch (see /home/adam/xfstests-dev/results//generic/730.out.bad) --- tests/generic/730.out 2024-04-25 18:13:45.203549435 +0930 +++ /home/adam/xfstests-dev/results//generic/730.out.bad 2025-06-04 15:10:39.062430952 +0930 @@ -1,2 +1 @@ QA output created by 730 -cat: -: Input/output error ...
[PATCH v1 5/7] generic/730: add _require_scratch_shutdown
Fixed it.
Quoted 11 lines
The root reason is that, btrfs doesn't implement its
blk_holder_opswhen opening a block device.
Thus when the underlying block device is marked dead, btrfs is never going to know thus no way to shutdown (nor btrfs has a way to shutdown either).I'm trying to improve the situation, but until then just exlucde btrfs from the test case for now.
Signed-off-by Qu Wenruo <[email protected]>
Quoted 8 lines
---
Changelog:
v2:
- Update the root reason
It's not thesb->s_op->shutdown, that is only for single device fs (throughfs_bdev_mark_dead()).
For a multi-devices fs, it should provide ablk_holder_opswhen opening the block device.
Along with that, I think it is a good idea to bring XFS_IOC_GOINGDOWN, per fs (all devices in a multi-device fs) and vfs level so that we could support unmount --force.
tests/generic/730 _require_test · line 32
Quoted 5 lines
tests/generic/730 +4
-0+if [ "$FSTYP" = "btrfs" ]; then + _notrun "btrfs doesn't support per-fs shutdown yet" +fi +
_require_scratch_shutdown() will take care.
Thanks, Anand
Quoted 13 lines · Anand Jain
Quoted 9 lines · Qu Wenruo
The test case always fail for btrfs:
generic/730 - output mismatch (see
/home/adam/xfstests-dev/results//generic/730.out.bad) --- tests/generic/730.out 2024-04-25 18:13:45.203549435 +0930
+++/home/adam/xfstests-dev/results//generic/730.out.bad2025-06-04 15:10:39.062430952 +0930
@@ -1,2 +1 @@
QA output created by 730
-cat: -: Input/output error
...
Quoted 1 line
[PATCH v1 5/7] generic/730: add
_require_scratch_shutdown
That works fine for btrfs, but that's only for now.
The _require_scratch_shutdown is only going to check the shutdown ioctl, not the per-block-device shutdown.
I guess this means for fs supporting per-bdev shutdown, it must have a dedicated shutdown ioctl.
Thanks,
Qu>
Quoted 35 lines
Fixed it.
Quoted 11 lines
The root reason is that, btrfs doesn't implement its
blk_holder_opswhen opening a block device.
Thus when the underlying block device is marked dead, btrfs is never going to know thus no way to shutdown (nor btrfs has a way to shutdown either).I'm trying to improve the situation, but until then just exlucde btrfs from the test case for now.
Signed-off-by Qu Wenruo <[email protected]>Quoted 8 lines
---
Changelog:
v2:
- Update the root reason
It's not thesb->s_op->shutdown, that is only for single device fs (throughfs_bdev_mark_dead()).
For a multi-devices fs, it should provide ablk_holder_opswhen opening the block device.Along with that, I think it is a good idea to bring
XFS_IOC_GOINGDOWN, per fs (all devices in a multi-device fs) and vfs level so that we could support unmount --force.tests/generic/730 _require_test · line 32
Quoted 4 lines
tests/generic/730 +4
-0+if [ "$FSTYP" = "btrfs" ]; then + _notrun "btrfs doesn't support per-fs shutdown yet" +fi +
_require_scratch_shutdown()will take care.Thanks, Anand