Skip to contentSkip to conversation

ARM: imx: mxs: Add support for imx287 based BTT devices

PATCH Superseded Lukasz Majewski 2 participants 3 messages Jun 4, 2025

Subsystems (3)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ARM: imx: mxs: Add support for imx287 based BTT devices

The btt[c3] devices are based on imx287 SoC.

U-Boot SPL 2025.04-01081-g07e086681d26 (Apr 16 2025 - 12:24:36 +0200) Trying to boot from MMC1

U-Boot 2025.04-01081-g07e086681d26 (Apr 16 2025 - 12:24:36 +0200)

CPU:   Freescale i.MX28 rev1.2 at 454 MHz
BOOT:  SSP SPI #3, master, 3V3 NOR
Model: BTT3
Board: LWE BTT SoM HW rev 0
DRAM:  256 MiB
Core:  86 devices, 15 uclasses, devicetree: separate
MMC:   MXS MMC: 0
Loading Environment from SPIFlash... SF: Detected is25lp128 with page
                    size 256 Bytes, erase size 64 KiB, total 16 MiB
OK
In:    serial@80074000
Out:   serial@80074000
Err:   serial@80074000
Net:   eth0: ethernet@800f0000
Hit any key to stop autoboot:  0

---
Changes for v2:
- Replace README with entry in doc/boards (*.rst files)

---
 arch/arm/dts/imx28-btt3-0-u-boot.dtsi |   7 +
 arch/arm/dts/imx28-btt3-1-u-boot.dtsi |   7 +
 arch/arm/dts/imx28-btt3-2-u-boot.dtsi |   7 +
 arch/arm/dts/imx28-btt3-u-boot.dtsi   |  90 ++++++
 arch/arm/mach-imx/mxs/Kconfig         |   6 +
 board/liebherr/btt/Kconfig            |  24 ++
 board/liebherr/btt/MAINTAINERS        |   6 +
 board/liebherr/btt/Makefile           |   9 +
 board/liebherr/btt/boot_img_scr.h     |  27 ++
 board/liebherr/btt/btt.c              | 449 ++++++++++++++++++++++++++
 board/liebherr/btt/btt.env            | 139 ++++++++
 board/liebherr/btt/spl_btt.c          | 316 ++++++++++++++++++
 configs/imx28_btt3_defconfig          | 140 ++++++++
 doc/board/index.rst                   |   1 +
 doc/board/liebherr/btt.rst            |  34 ++
 doc/board/liebherr/index.rst          |   9 +
 include/configs/btt.h                 |  17 +
 17 files changed, 1288 insertions(+)
 create mode 100644 arch/arm/dts/imx28-btt3-0-u-boot.dtsi
 create mode 100644 arch/arm/dts/imx28-btt3-1-u-boot.dtsi
 create mode 100644 arch/arm/dts/imx28-btt3-2-u-boot.dtsi
 create mode 100644 arch/arm/dts/imx28-btt3-u-boot.dtsi
 create mode 100644 board/liebherr/btt/Kconfig
 create mode 100644 board/liebherr/btt/MAINTAINERS
 create mode 100644 board/liebherr/btt/Makefile
 create mode 100644 board/liebherr/btt/boot_img_scr.h
 create mode 100644 board/liebherr/btt/btt.c
 create mode 100644 board/liebherr/btt/btt.env
 create mode 100644 board/liebherr/btt/spl_btt.c
 create mode 100644 configs/imx28_btt3_defconfig
 create mode 100644 doc/board/liebherr/btt.rst
 create mode 100644 doc/board/liebherr/index.rst
 create mode 100644 include/configs/btt.h
arch/arm/dts/imx28-btt3-0-u-boot.dtsi new file +7 -0
new file mode 100644
index 00000000000..b128eef9e17
@@ -0,0 +1,7 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright 2025
+ * Lukasz Majewski, DENX Software Engineering, [email protected]
+ */
+
+#include "imx28-btt3-u-boot.dtsi"
arch/arm/dts/imx28-btt3-1-u-boot.dtsi new file +7 -0
new file mode 100644
index 00000000000..b128eef9e17
@@ -0,0 +1,7 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright 2025
+ * Lukasz Majewski, DENX Software Engineering, [email protected]
+ */
+
+#include "imx28-btt3-u-boot.dtsi"
arch/arm/dts/imx28-btt3-2-u-boot.dtsi new file +7 -0
new file mode 100644
index 00000000000..b128eef9e17
@@ -0,0 +1,7 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright 2025
+ * Lukasz Majewski, DENX Software Engineering, [email protected]
+ */
+
+#include "imx28-btt3-u-boot.dtsi"
arch/arm/dts/imx28-btt3-u-boot.dtsi new file +90 -0

90 lines not on this page · raw message

arch/arm/mach-imx/mxs/Kconfig +6 -0
index d2e4205c5ce..6d466868fe4 100644
@@ -38,6 +38,11 @@ choice
 	prompt "MX28 board select"
 	optional
 
+config TARGET_BTT
+	bool "Support BTT"
+	select PL01X_SERIAL
+	imply OF_UPSTREAM
+
 config TARGET_MX28EVK
 	bool "Support mx28evk"
 	select PL01X_SERIAL
@@ -69,6 +74,7 @@ config SPL_MXS_PMU_ENABLE_4P2_LINEAR_REGULATOR
 	  This option enables the 4P2 linear regulator (derived
 	  from VDD5V) - so the VDD4P2 power source is operational.
 
+source "board/liebherr/btt/Kconfig"
 source "board/freescale/mx28evk/Kconfig"
 source "board/liebherr/xea/Kconfig"
 
board/liebherr/btt/Kconfig new file +24 -0
new file mode 100644
index 00000000000..ff35dd04532
@@ -0,0 +1,24 @@
+if TARGET_BTT
+
+config SYS_BOARD
+	default "btt"
+
+config SYS_VENDOR
+	default "liebherr"
+
+config SYS_SOC
+	default "mxs"
+
+config SYS_CONFIG_NAME
+	default "btt"
+
+config ENV_SIZE
+	default 0x2000
+
+config ENV_SECT_SIZE
+	default 0x10000 if ENV_IS_IN_SPI_FLASH
+
+config ENV_OFFSET
+	default 0x80000 if ENV_IS_IN_SPI_FLASH
+
+endif
board/liebherr/btt/MAINTAINERS new file +6 -0
new file mode 100644
index 00000000000..b4afed5aaeb
@@ -0,0 +1,6 @@
+BTT BOARD
+M:	Lukasz Majewski <[email protected]>
+S:	Maintained
+F:	board/liebherr/btt/
+F:	include/configs/btt.h
+F:	configs/imx28_btt3_defconfig
board/liebherr/btt/Makefile new file +9 -0
new file mode 100644
index 00000000000..a8ab657a9e0
@@ -0,0 +1,9 @@
+#
+# (C) Copyright 2025
+# Lukasz Majewski, DENX Software Engineering, [email protected].
+#
+# SPDX-License-Identifier:	GPL-2.0+
+#
+
+obj-y	:= btt.o
+obj-$(CONFIG_XPL_BUILD) += spl_btt.o
board/liebherr/btt/boot_img_scr.h new file +27 -0
new file mode 100644
index 00000000000..baa3072b49c
@@ -0,0 +1,27 @@
+/* SPDX-License-Identifier:     GPL-2.0+ */
+/*
+ * Struct for boot image source description for placing in last
+ * two SPI NOR flash sectors on legcom.
+ */
+
+struct boot_img_src {
+	u8 magic;	/* Must be 'B' = 0x42 */
+	u8 flags;	/* flags to specify mmcblk[0|1] boot[0|1] */
+	u8 crc8;	/* CRC-8 over above two bytes */
+} __packed;
+
+/*
+ * Bit definition in boot_img_src.flags:
+ *  Bit 0: mmcblk device 0 or 1 (1 - if this bit set)
+ *  Bit 1: mmcblk boot partition 0 or 1.
+ *         for eMMC: boot0 if this bit is cleared, boot1 - if set
+ *         for SD-card the boot partition value will always be 0
+ *         (independent of the value of this bit)
+ *
+ */
+#define BOOT_SRC_MMC1	BIT(0)
+#define BOOT_SRC_PART1	BIT(1)
+
+/* Offset of the first boot image source descriptor in SPI NOR */
+#define SPI_FLASH_BOOT_SRC_OFFS	0xFE0000
+#define SPI_FLASH_SECTOR_SIZE	0x10000
board/liebherr/btt/btt.c new file +449 -0

449 lines not on this page · raw message

board/liebherr/btt/btt.env new file +139 -0

139 lines not on this page · raw message

board/liebherr/btt/spl_btt.c new file +316 -0

316 lines not on this page · raw message

configs/imx28_btt3_defconfig new file +140 -0

140 lines not on this page · raw message

doc/board/index.rst +1 -0
index 3c5a2c7d1cf..e084c7fb1df 100644
@@ -38,6 +38,7 @@ Board-specific doc
    kontron/index
    lenovo/index
    lg/index
+   liebherr/index
    mediatek/index
    microchip/index
    microsoft/index
doc/board/liebherr/btt.rst new file +34 -0
new file mode 100644
index 00000000000..d22ffa205bd
@@ -0,0 +1,34 @@
+.. SPDX-License-Identifier: GPL-2.0+
+.. sectionauthor:: Lukasz Majewski <[email protected]>
+
+BTT devices
+===========
+
+Those devices are based on IMX's IMX287 SoC. The description regarding the
+**btt** family of boards (i.e. `btt3` and `bttc`) is identical as the one for
+the already supported **xea** board.
+
+Building
+--------
+
+Make sure that `CROSS_COMPILE` is set appropriately:
+
+.. code-block:: text
+
+ $ make imx28_btt3_defconfig
+ $ make -j4 u-boot.sb u-boot.img
+
+Now you should see `u-boot.sb` and `u-boot.img` files in the build directory.
+
+For initial bringup - one can use `uuu` utulity to boot till u-boot prompt
+(USB connection with the board is required).
+
+Flashing
+--------
+
+Via U-Boot:
+
+.. code-block:: text
+
+ => run update_spl
+ => run update_uboot
doc/board/liebherr/index.rst new file +9 -0
new file mode 100644
index 00000000000..d8db6bd188c
@@ -0,0 +1,9 @@
+.. SPDX-License-Identifier: GPL-2.0+
+
+Liebherr
+========
+
+.. toctree::
+   :maxdepth: 2
+
+   btt
include/configs/btt.h new file +17 -0
new file mode 100644
index 00000000000..0e15e7299fb
@@ -0,0 +1,17 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * Copyright (C) 2025 DENX Software Engineering
+ * Lukasz Majewski, DENX Software Engineering, [email protected]
+ */
+#ifndef __CONFIGS_BTT_H__
+#define __CONFIGS_BTT_H__
+
+/* Memory configuration */
+#define PHYS_SDRAM_1			0x40000000	/* Base address */
+#define PHYS_SDRAM_1_SIZE		0x10000000	/* Max 256 MB RAM */
+#define CFG_SYS_SDRAM_BASE		PHYS_SDRAM_1
+
+/* The rest of the configuration is shared */
+#include <configs/mxs.h>
+
+#endif /* __CONFIGS_BTT_H__ */
Signature · 1 line
2.39.5
reviewer
#1 lore raw

Hi Lukasz,

Quoted 3 lines · Lukasz Majewski

+source "board/liebherr/btt/Kconfig"
source "board/freescale/mx28evk/Kconfig"
source "board/liebherr/xea/Kconfig"

Please keep the entries sorted.

Quoted 18 lines
board/liebherr/btt/btt.c new file +15 -0
@@ -0,0 +1,449 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * BTT[3C] iMX28 board
+ *
+ * Copyright (C) 2025 DENX Software Engineering
+ * Lukasz Majewski, DENX Software Engineering, [email protected]
+ */
+
+#include <fdt_support.h>
+#include <init.h>
+#include <log.h>
+#include <net.h>
+#include <asm/global_data.h>
+#include <asm/gpio.h>
+#include <asm/io.h>

board/liebherr/btt/btt.c line 25

Quoted 10 lines
board/liebherr/btt/btt.c new file +10 -0
+#include <asm/arch/imx-regs.h>
+#include <asm/arch/iomux-mx28.h>
+#include <asm/arch/clock.h>
+#include <asm/arch/sys_proto.h>
+#include <linux/delay.h>
+#include <linux/mii.h>
+#include <miiphy.h>
+#include <netdev.h>
+#include <errno.h>
+#include <usb.h>

Please double-check if all these are necessary. USB seems not to be used on this file.

Quoted 47 lines
board/liebherr/btt/btt.c new file +47 -0
+void spl_board_init(void)
+{
+       struct gpio_desc phy_rst, boot, rescue, wifi_en, bt_en;
+       int ret, i;
+
+       /*
+        * On the new HW version of BTTC/3 (with LAN8720ai PHY) the !RST pin
+        * (15) is pulled LOW by external resistor. As a result it needs to be
+        * set HIGH as soon as possible to allow correct generation of RESET
+        * pulse.
+        *
+        * In the old BTTC (with TLK105 PHY) the RC circuit was used instead
+        * to set the RESET pin to HIGH after 100us, so there was no need to
+        * set it explicitly.
+        */
+       ret = dm_gpio_lookup_name("GPIO4_12", &phy_rst);
+       if (ret)
+               printf("Cannot get GPIO4_12\n");
+
+       ret = dm_gpio_request(&phy_rst, "phy-rst");
+       if (ret)
+               printf("Cannot request GPIO4_12\n");
+
+       dm_gpio_set_dir_flags(&phy_rst, GPIOD_IS_OUT | GPIOD_IS_OUT_ACTIVE);
+
+       /*
+        * Explicitly set GPIO, which controls WL_EN (wifi) to LOW. On the BTT3
+        * it is directly connected to Jody module without any externa pull up
+        * down register.
+        */
+       ret = dm_gpio_lookup_name("GPIO0_27", &wifi_en);
+       if (ret)
+               printf("Cannot get GPIO0_27\n");
+
+       ret = dm_gpio_request(&wifi_en, "wifi-en");
+       if (ret)
+               printf("Cannot request GPIO0_27\n");
+
+       dm_gpio_set_dir_flags(&wifi_en, GPIOD_IS_OUT | GPIOD_ACTIVE_LOW |
+                             GPIOD_IS_OUT_ACTIVE);
+
+       /*
+        * Explicitly set GPIO, which controls BT_EN (Bluetooth) to LOW. On the
+        * BTT3 it is connected to Jody module via RC circuit (after some R*C
+        * time this pin is set to HIGH). However, the manual recommends setting
+        * it high from LOW state.
+        */

board/liebherr/btt/btt.c line 171

Quoted 10 lines
board/liebherr/btt/btt.c new file +10 -0
+       ret = dm_gpio_lookup_name("GPIO3_27", &bt_en);
+       if (ret)
+               printf("Cannot get GPIO3_27\n");
+
+       ret = dm_gpio_request(&bt_en, "bt-en");
+       if (ret)
+               printf("Cannot request GPIO3_27\n");
+
+       dm_gpio_set_dir_flags(&bt_en, GPIOD_IS_OUT | GPIOD_ACTIVE_LOW |
+                             GPIOD_IS_OUT_ACTIVE);

Since U-Boot does not support Wi-Fi/Bluetooth, should these pins be configured in U-Boot?

Why can't the kernel take care of them instead?

Quoted 7 lines
board/liebherr/btt/btt.c new file +7 -0
+
+       /* Address of boot parameters */
+       gd->bd->bi_boot_params = PHYS_SDRAM_1 + 0x100;
+
+       cpu_eth_init(NULL);
+
+       /* PHY INT#/PWDN# */

board/liebherr/btt/btt.c line 353

Quoted 10 lines
board/liebherr/btt/btt.c new file +10 -0
+       ret = dm_gpio_lookup_name("GPIO4_13", &phy_rst);
+       if (ret) {
+               printf("Cannot get GPIO4_13\n");
+               return ret;
+       }
+
+       ret = dm_gpio_request(&phy_rst, "phy-rst");
+       if (ret) {
+               printf("Cannot request GPIO4_13\n");
+               return ret;

Can't U-Boot DM handle the Ethernet PHY reset instead?

Quoted 7 lines
board/liebherr/btt/btt.c new file +7 -0
+ * NOTE:
+ *
+ * IMX28 clock "stub" DM driver!
+ *
+ * Only used for SPL stage, which is NOT using DM; serial and
+ * eMMC configuration.
+ */

board/liebherr/btt/btt.c line 448

Quoted 10 lines
board/liebherr/btt/btt.c new file +10 -0
+static const struct udevice_id imx28_clk_ids[] = {
+       { .compatible = "fsl,imx28-clkctrl", },
+       { }
+};
+
+U_BOOT_DRIVER(fsl_imx28_clkctrl) = {
+       .name           = "fsl_imx28_clkctrl",
+       .id             = UCLASS_CLK,
+       .of_match       = imx28_clk_ids,
+};

A separate patch should add this.

board/liebherr/btt/btt.c line 123

Quoted 7 lines
board/liebherr/btt/btt.c new file +7 -0
+#define        MUX_CONFIG_LCD  (MXS_PAD_3V3 | MXS_PAD_4MA | MXS_PAD_NOPULL)
+#define        MUX_CONFIG_BOOT (MXS_PAD_3V3)
+#define        MUX_CONFIG_TSC  (MXS_PAD_3V3 | MXS_PAD_8MA | MXS_PAD_PULLUP)
+#define        MUX_CONFIG_SSP0 (MXS_PAD_3V3 | MXS_PAD_12MA | MXS_PAD_PULLUP)
+#define        MUX_CONFIG_SSP2 (MXS_PAD_3V3 | MXS_PAD_4MA | MXS_PAD_PULLUP)
+#define        MUX_CONFIG_ENET (MXS_PAD_3V3 | MXS_PAD_8MA | MXS_PAD_NOPULL)
+#define        MUX_CONFIG_EMI  (MXS_PAD_3V3 | MXS_PAD_12MA | MXS_PAD_NOPULL)

Indentation looks strange here.

board/liebherr/btt/btt.c line 125

Quoted 2 lines
board/liebherr/btt/btt.c new file +2 -0
+
+const iomux_cfg_t iomux_setup[] = {

static?

Quoted 212 lines
board/liebherr/btt/btt.c new file +212 -0
+       /* AUART0 IRDA */
+       MX28_PAD_AUART0_RX__AUART0_RX,
+       MX28_PAD_AUART0_TX__AUART0_TX,
+
+       /* AUART 4 RS422 */
+       MX28_PAD_AUART0_CTS__AUART4_RX,
+       MX28_PAD_AUART0_RTS__AUART4_TX,
+
+       /* USB0 */
+       MX28_PAD_AUART1_CTS__USB0_OVERCURRENT,
+       MX28_PAD_AUART1_RTS__USB0_ID,
+       MX28_PAD_LCD_VSYNC__GPIO_1_28, /* PRW_On */
+
+       /* USB1 */
+       MX28_PAD_PWM2__USB1_OVERCURRENT,
+
+       /* eMMC */
+       MX28_PAD_SSP0_CMD__SSP0_CMD | MUX_CONFIG_SSP0,
+       MX28_PAD_SSP0_DATA0__SSP0_D0 | MUX_CONFIG_SSP0,
+       MX28_PAD_SSP0_DATA1__SSP0_D1 | MUX_CONFIG_SSP0,
+       MX28_PAD_SSP0_DATA2__SSP0_D2 | MUX_CONFIG_SSP0,
+       MX28_PAD_SSP0_DATA3__SSP0_D3 | MUX_CONFIG_SSP0,
+       MX28_PAD_SSP0_DATA4__SSP0_D4 | MUX_CONFIG_SSP0,
+       MX28_PAD_SSP0_DATA5__SSP0_D5 | MUX_CONFIG_SSP0,
+       MX28_PAD_SSP0_DATA6__SSP0_D6 | MUX_CONFIG_SSP0,
+       MX28_PAD_SSP0_DATA7__SSP0_D7 | MUX_CONFIG_SSP0,
+       MX28_PAD_SSP0_DETECT__GPIO_2_9, /* Reset for eMMC */
+       MX28_PAD_SSP0_SCK__SSP0_SCK | MUX_CONFIG_SSP0,
+
+       /* DIG Keys */
+       MX28_PAD_GPMI_D00__GPIO_0_0,
+       MX28_PAD_GPMI_D01__GPIO_0_1,
+       MX28_PAD_GPMI_D02__GPIO_0_2,
+       MX28_PAD_GPMI_D03__GPIO_0_3,
+       MX28_PAD_GPMI_D04__GPIO_0_4,
+       MX28_PAD_GPMI_D05__GPIO_0_5,
+       MX28_PAD_GPMI_D06__GPIO_0_6,
+       MX28_PAD_GPMI_D07__GPIO_0_7,
+
+       /* ADR_0-2 */
+       MX28_PAD_GPMI_CE1N__GPIO_0_17,
+       MX28_PAD_GPMI_CE2N__GPIO_0_18,
+       MX28_PAD_GPMI_CE3N__GPIO_0_19,
+
+       /* Read Keys */
+       MX28_PAD_GPMI_RDY0__GPIO_0_20,
+
+       /* LATCH_EN */
+       MX28_PAD_GPMI_RDY1__GPIO_0_21,
+
+       /* Power off */
+       MX28_PAD_GPMI_RDN__GPIO_0_24,
+
+       /* WIFI EN */
+       MX28_PAD_GPMI_CLE__GPIO_0_27,
+
+       /* I2C1 Touch */
+       MX28_PAD_AUART2_CTS__GPIO_3_10,
+       MX28_PAD_AUART2_RTS__GPIO_3_11,
+       MX28_PAD_GPMI_RDY2__GPIO_0_22, /* Touch Reset */
+       MX28_PAD_GPMI_RDY3__GPIO_0_23, /* Touch INT */
+
+       /* TIVA */
+       MX28_PAD_AUART1_RX__SSP2_CARD_DETECT,
+       MX28_PAD_SSP2_MISO__SSP2_D0,
+       MX28_PAD_SSP2_MOSI__SSP2_CMD,
+       MX28_PAD_SSP2_SCK__SSP2_SCK,
+       MX28_PAD_SSP2_SS0__SSP2_D3,
+       MX28_PAD_SSP2_SS1__GPIO_2_20,
+       MX28_PAD_SSP2_SS2__GPIO_2_21,
+
+       /* SPI3 NOR-Flash */
+       MX28_PAD_AUART1_TX__SSP3_CARD_DETECT,
+       MX28_PAD_AUART2_RX__SSP3_D1,
+       MX28_PAD_AUART2_TX__SSP3_D2,
+       MX28_PAD_SSP3_MISO__SSP3_D0,
+       MX28_PAD_SSP3_MOSI__SSP3_CMD,
+       MX28_PAD_SSP3_SCK__SSP3_SCK,
+       MX28_PAD_SSP3_SS0__SSP3_D3,
+
+       /* NOR-Flash CMD */
+       MX28_PAD_LCD_RS__GPIO_1_26, /* Hold */
+       MX28_PAD_LCD_WR_RWN__GPIO_1_25, /* write protect */
+
+       /* I2C0 Codec */
+       MX28_PAD_I2C0_SCL__I2C0_SCL,
+       MX28_PAD_I2C0_SDA__I2C0_SDA,
+
+       /* I2S Codec */
+       MX28_PAD_SAIF0_BITCLK__SAIF0_BITCLK,
+       MX28_PAD_SAIF0_LRCLK__SAIF0_LRCLK,
+       MX28_PAD_SAIF0_MCLK__SAIF0_MCLK,
+       MX28_PAD_SAIF0_SDATA0__SAIF0_SDATA0,
+       MX28_PAD_SAIF1_SDATA0__SAIF1_SDATA0,
+
+       /* BT_EN */
+       MX28_PAD_SPDIF__GPIO_3_27,
+
+       /* EMI */
+       MX28_PAD_EMI_D00__EMI_DATA0 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_D01__EMI_DATA1 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_D02__EMI_DATA2 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_D03__EMI_DATA3 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_D04__EMI_DATA4 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_D05__EMI_DATA5 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_D06__EMI_DATA6 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_D07__EMI_DATA7 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_D08__EMI_DATA8 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_D09__EMI_DATA9 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_D10__EMI_DATA10 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_D11__EMI_DATA11 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_D12__EMI_DATA12 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_D13__EMI_DATA13 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_D14__EMI_DATA14 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_D15__EMI_DATA15 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_ODT0__EMI_ODT0 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_DQM0__EMI_DQM0 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_ODT1__EMI_ODT1 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_DQM1__EMI_DQM1 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_DDR_OPEN_FB__EMI_DDR_OPEN_FEEDBACK | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_CLK__EMI_CLK | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_DQS0__EMI_DQS0 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_DQS1__EMI_DQS1 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_DDR_OPEN__EMI_DDR_OPEN | MUX_CONFIG_EMI,
+
+       MX28_PAD_EMI_A00__EMI_ADDR0 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_A01__EMI_ADDR1 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_A02__EMI_ADDR2 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_A03__EMI_ADDR3 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_A04__EMI_ADDR4 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_A05__EMI_ADDR5 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_A06__EMI_ADDR6 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_A07__EMI_ADDR7 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_A08__EMI_ADDR8 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_A09__EMI_ADDR9 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_A10__EMI_ADDR10 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_A11__EMI_ADDR11 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_A12__EMI_ADDR12 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_A13__EMI_ADDR13 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_A14__EMI_ADDR14 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_BA0__EMI_BA0 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_BA1__EMI_BA1 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_BA2__EMI_BA2 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_CASN__EMI_CASN | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_RASN__EMI_RASN | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_WEN__EMI_WEN | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_CE0N__EMI_CE0N | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_CE1N__EMI_CE1N | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_CKE__EMI_CKE | MUX_CONFIG_EMI,
+
+       /* Uart3 Bluetooth-Interface */
+       MX28_PAD_AUART3_CTS__AUART3_CTS,
+       MX28_PAD_AUART3_RTS__AUART3_RTS,
+       MX28_PAD_AUART3_RX__AUART3_RX,
+       MX28_PAD_AUART3_TX__AUART3_TX,
+
+       /* framebuffer */
+       MX28_PAD_LCD_CS__LCD_CS | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D00__LCD_D0 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D01__LCD_D1 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D02__LCD_D2 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D03__LCD_D3 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D04__LCD_D4 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D05__LCD_D5 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D06__LCD_D6 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D07__LCD_D7 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D08__LCD_D8 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D09__LCD_D9 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D10__LCD_D10 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D11__LCD_D11 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D12__LCD_D12 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D13__LCD_D13 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D14__LCD_D14 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D15__LCD_D15 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D16__LCD_D16 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D17__LCD_D17 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D18__LCD_D18 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D19__LCD_D19 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D20__LCD_D20 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D21__LCD_D21 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D22__LCD_D22 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D23__LCD_D23 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_DOTCLK__LCD_DOTCLK | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_ENABLE__LCD_ENABLE | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_HSYNC__LCD_HSYNC | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_RD_E__LCD_VSYNC | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_RESET__LCD_RESET | MUX_CONFIG_LCD,
+
+       /* DUART RS232 */
+       MX28_PAD_PWM0__DUART_RX,
+       MX28_PAD_PWM1__DUART_TX,
+
+       /* Backlight */
+       MX28_PAD_PWM3__PWM_3,
+
+       /* FEC Ethernet */
+       MX28_PAD_ENET_CLK__CLKCTRL_ENET | MUX_CONFIG_ENET,
+       MX28_PAD_ENET0_COL__ENET1_TX_EN | MUX_CONFIG_ENET,
+       MX28_PAD_ENET0_CRS__ENET1_RX_EN | MUX_CONFIG_ENET,
+       MX28_PAD_ENET0_MDC__ENET0_MDC | MUX_CONFIG_ENET,
+       MX28_PAD_ENET0_MDIO__ENET0_MDIO | MUX_CONFIG_ENET,
+       MX28_PAD_ENET0_RX_CLK__GPIO_4_13, /* Phy Interrupt */
+       MX28_PAD_ENET0_RX_EN__ENET0_RX_EN | MUX_CONFIG_ENET,
+       MX28_PAD_ENET0_RXD0__ENET0_RXD0 | MUX_CONFIG_ENET,
+       MX28_PAD_ENET0_RXD1__ENET0_RXD1 | MUX_CONFIG_ENET,
+       MX28_PAD_ENET0_RXD3__ENET1_RXD1 | MUX_CONFIG_ENET,
+       MX28_PAD_ENET0_TX_CLK__GPIO_4_5, /* n.c. */
+       MX28_PAD_ENET0_TX_EN__ENET0_TX_EN | MUX_CONFIG_ENET,
+       MX28_PAD_ENET0_TXD0__ENET0_TXD0 | MUX_CONFIG_ENET,
+       MX28_PAD_ENET0_TXD1__ENET0_TXD1 | MUX_CONFIG_ENET,
+       MX28_PAD_ENET0_TXD3__ENET1_TXD1 | MUX_CONFIG_ENET,
+       MX28_PAD_ENET0_TXD3__GPIO_4_12, /* PHY reset */

board/liebherr/btt/btt.c line 347

Quoted 10 lines
board/liebherr/btt/btt.c new file +10 -0
+
+       /* boot/rescue pins */
+       MX28_PAD_ENET0_RXD2__GPIO_4_9,
+       MX28_PAD_ENET0_TXD2__GPIO_4_11,
+
+       /* HW revision setup pins - by default pullup DISABLED */
+       MX28_PAD_ENET0_RXD3__GPIO_4_10,
+       MX28_PAD_ENET0_TX_CLK__GPIO_4_5,
+       MX28_PAD_ENET0_COL__GPIO_4_14,
+       MX28_PAD_ENET0_CRS__GPIO_4_15,

What is the reason for doing a complete pinctrl configuration inside SPL?

Can't you configure only the pins that SPL needs?

Quoted 4 lines
board/liebherr/btt/btt.c new file +4 -0
+#ifndef CONFIG_SPL_FRAMEWORK
+void board_init_ll(const u32 arg, const uint32_t *resptr)
+{
+       mxs_common_spl_init(arg, resptr, iomux_setup, ARRAY_SIZE(iomux_setup));

board/liebherr/btt/btt.c line 361

Quoted 10 lines
board/liebherr/btt/btt.c new file +10 -0
+}
+#else
+void lowlevel_init(void)
+{
+       struct mxs_pinctrl_regs *pinctrl_regs =
+               (struct mxs_pinctrl_regs *)MXS_PINCTRL_BASE;
+
+       /* Set EMI drive strength */
+       writel(0x00003fff, &pinctrl_regs->hw_pinctrl_emi_ds_ctrl_clr);
+       writel(0x00002aaa, &pinctrl_regs->hw_pinctrl_emi_ds_ctrl_set);

Please use defines instead of hardcoded values.

board/liebherr/btt/btt.c line 11

Quoted 12 lines
board/liebherr/btt/btt.c new file +11 -0
@@ -0,0 +1,17 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * Copyright (C) 2025 DENX Software Engineering
+ * Lukasz Majewski, DENX Software Engineering, [email protected]
+ */
+#ifndef __CONFIGS_BTT_H__
+#define __CONFIGS_BTT_H__
+
+/* Memory configuration */
+#define PHYS_SDRAM_1                   0x40000000      /* Base address */
+#define PHYS_SDRAM_1_SIZE              0x10000000      /* Max 256 MB RAM */

You could use SZ_256M and remove the comment.

#2 lore raw

Hi Fabio,

Quoted 9 lines

Hi Lukasz,

Quoted 3 lines · Lukasz Majewski

+source "board/liebherr/btt/Kconfig"
source "board/freescale/mx28evk/Kconfig"
source "board/liebherr/xea/Kconfig"

Please keep the entries sorted.

Ok.

Quoted 24 lines
Quoted 24 lines
board/liebherr/btt/btt.c new file +20 -0
@@ -0,0 +1,449 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * BTT[3C] iMX28 board
+ *
+ * Copyright (C) 2025 DENX Software Engineering
+ * Lukasz Majewski, DENX Software Engineering, [email protected]
+ */
+
+#include <fdt_support.h>
+#include <init.h>
+#include <log.h>
+#include <net.h>
+#include <asm/global_data.h>
+#include <asm/gpio.h>
+#include <asm/io.h>
+#include <asm/arch/imx-regs.h>
+#include <asm/arch/iomux-mx28.h>
+#include <asm/arch/clock.h>
+#include <asm/arch/sys_proto.h>
+#include <linux/delay.h>
Quoted 8 lines

board/liebherr/btt/btt.c line 25

Quoted 5 lines
board/liebherr/btt/btt.c new file +5 -0
+#include <linux/mii.h>
+#include <miiphy.h>
+#include <netdev.h>
+#include <errno.h>
+#include <usb.h>  

Please double-check if all these are necessary. USB seems not to be used on this file.

Ok.

Quoted 74 lines
Quoted 68 lines
board/liebherr/btt/btt.c new file +7 -0
+void spl_board_init(void)
+{
+       struct gpio_desc phy_rst, boot, rescue, wifi_en, bt_en;
+       int ret, i;
+
+       /*
+        * On the new HW version of BTTC/3 (with LAN8720ai PHY) the

!RST pin
+ * (15) is pulled LOW by external resistor. As a result it
needs to be
+ * set HIGH as soon as possible to allow correct generation
of RESET

board/liebherr/btt/btt.c new file +3 -0
+        * pulse.
+        *
+        * In the old BTTC (with TLK105 PHY) the RC circuit was

used instead
+ * to set the RESET pin to HIGH after 100us, so there was
no need to

board/liebherr/btt/btt.c new file +11 -0
+        * set it explicitly.
+        */
+       ret = dm_gpio_lookup_name("GPIO4_12", &phy_rst);
+       if (ret)
+               printf("Cannot get GPIO4_12\n");
+
+       ret = dm_gpio_request(&phy_rst, "phy-rst");
+       if (ret)
+               printf("Cannot request GPIO4_12\n");
+
+       dm_gpio_set_dir_flags(&phy_rst, GPIOD_IS_OUT |

GPIOD_IS_OUT_ACTIVE); +

board/liebherr/btt/btt.c new file +2 -0
+       /*
+        * Explicitly set GPIO, which controls WL_EN (wifi) to LOW.

On the BTT3
+ * it is directly connected to Jody module without any
externa pull up

board/liebherr/btt/btt.c new file +11 -0
+        * down register.
+        */
+       ret = dm_gpio_lookup_name("GPIO0_27", &wifi_en);
+       if (ret)
+               printf("Cannot get GPIO0_27\n");
+
+       ret = dm_gpio_request(&wifi_en, "wifi-en");
+       if (ret)
+               printf("Cannot request GPIO0_27\n");
+
+       dm_gpio_set_dir_flags(&wifi_en, GPIOD_IS_OUT |

GPIOD_ACTIVE_LOW |

board/liebherr/btt/btt.c new file +4 -0
+                             GPIOD_IS_OUT_ACTIVE);
+
+       /*
+        * Explicitly set GPIO, which controls BT_EN (Bluetooth) to

LOW. On the
+ * BTT3 it is connected to Jody module via RC circuit
(after some R*C
+ * time this pin is set to HIGH). However, the manual
recommends setting

board/liebherr/btt/btt.c new file +11 -0
+        * it high from LOW state.
+        */
+       ret = dm_gpio_lookup_name("GPIO3_27", &bt_en);
+       if (ret)
+               printf("Cannot get GPIO3_27\n");
+
+       ret = dm_gpio_request(&bt_en, "bt-en");
+       if (ret)
+               printf("Cannot request GPIO3_27\n");
+
+       dm_gpio_set_dir_flags(&bt_en, GPIOD_IS_OUT |
Quoted 2 lines

GPIOD_ACTIVE_LOW |
+ GPIOD_IS_OUT_ACTIVE);

Since U-Boot does not support Wi-Fi/Bluetooth, should these pins be configured in U-Boot?

Quoted 1 line

Why can't the kernel take care of them instead?

This board (and XEA also) uses falcon boot.

In short - we use SPL, and then the Linux is called (uImage + dts).

What I'm trying to solve here is to have _always_, no matter if we execute Linux from u-boot proper or directly from SPL, the same HW state.

That is why some pins needs to be setup in SPL. Please also be aware, that there also can be a "recovery" system run from net or USB, which can also reboot the board (and we would need consistent state).

Quoted 12 lines
Quoted 12 lines
board/liebherr/btt/btt.c new file +11 -0
+
+       /* Address of boot parameters */
+       gd->bd->bi_boot_params = PHYS_SDRAM_1 + 0x100;
+
+       cpu_eth_init(NULL);
+
+       /* PHY INT#/PWDN# */
+       ret = dm_gpio_lookup_name("GPIO4_13", &phy_rst);
+       if (ret) {
+               printf("Cannot get GPIO4_13\n");
+               return ret;
Quoted 8 lines

board/liebherr/btt/btt.c line 353

Quoted 6 lines
board/liebherr/btt/btt.c new file +6 -0
+       }
+
+       ret = dm_gpio_request(&phy_rst, "phy-rst");
+       if (ret) {
+               printf("Cannot request GPIO4_13\n");
+               return ret;  

Can't U-Boot DM handle the Ethernet PHY reset instead?

Please see the above remark.

Quoted 12 lines
Quoted 12 lines

+ * NOTE:
+ *
+ * IMX28 clock "stub" DM driver!
+ *
+ * Only used for SPL stage, which is NOT using DM; serial and
+ * eMMC configuration.
+ */

board/liebherr/btt/btt.c new file +4 -0
+static const struct udevice_id imx28_clk_ids[] = {
+       { .compatible = "fsl,imx28-clkctrl", },
+       { }
+};
Quoted 8 lines

board/liebherr/btt/btt.c line 448

Quoted 6 lines
board/liebherr/btt/btt.c new file +6 -0
+
+U_BOOT_DRIVER(fsl_imx28_clkctrl) = {
+       .name           = "fsl_imx28_clkctrl",
+       .id             = UCLASS_CLK,
+       .of_match       = imx28_clk_ids,
+};  

A separate patch should add this.

This shall stay IMHO, as this is a CLK stub for u-boot.sb (which in fact is very constrained in terms of size - IIRC < 40KiB). It is required for proper of_platform generation (*.c and *.h files) for SPL.

Quoted 12 lines
Quoted 10 lines
+#define        MUX_CONFIG_LCD  (MXS_PAD_3V3 | MXS_PAD_4MA |
MXS_PAD_NOPULL) +#define        MUX_CONFIG_BOOT (MXS_PAD_3V3)
+#define        MUX_CONFIG_TSC  (MXS_PAD_3V3 | MXS_PAD_8MA |
MXS_PAD_PULLUP) +#define        MUX_CONFIG_SSP0 (MXS_PAD_3V3 |

MXS_PAD_12MA | MXS_PAD_PULLUP) +#define MUX_CONFIG_SSP2
(MXS_PAD_3V3 | MXS_PAD_4MA | MXS_PAD_PULLUP) +#define MUX_CONFIG_ENET (MXS_PAD_3V3 | MXS_PAD_8MA | MXS_PAD_NOPULL)
+#define MUX_CONFIG_EMI (MXS_PAD_3V3 | MXS_PAD_12MA |
MXS_PAD_NOPULL)

Indentation looks strange here.

Ok, I will look on that.

Quoted 5 lines

board/liebherr/btt/btt.c

Quoted 3 lines
board/liebherr/btt/btt.c new file +2 -0
+
+const iomux_cfg_t iomux_setup[] = {  

static?

Ok.

Quoted 228 lines
Quoted 214 lines
board/liebherr/btt/btt.c new file +120 -0
+       /* AUART0 IRDA */
+       MX28_PAD_AUART0_RX__AUART0_RX,
+       MX28_PAD_AUART0_TX__AUART0_TX,
+
+       /* AUART 4 RS422 */
+       MX28_PAD_AUART0_CTS__AUART4_RX,
+       MX28_PAD_AUART0_RTS__AUART4_TX,
+
+       /* USB0 */
+       MX28_PAD_AUART1_CTS__USB0_OVERCURRENT,
+       MX28_PAD_AUART1_RTS__USB0_ID,
+       MX28_PAD_LCD_VSYNC__GPIO_1_28, /* PRW_On */
+
+       /* USB1 */
+       MX28_PAD_PWM2__USB1_OVERCURRENT,
+
+       /* eMMC */
+       MX28_PAD_SSP0_CMD__SSP0_CMD | MUX_CONFIG_SSP0,
+       MX28_PAD_SSP0_DATA0__SSP0_D0 | MUX_CONFIG_SSP0,
+       MX28_PAD_SSP0_DATA1__SSP0_D1 | MUX_CONFIG_SSP0,
+       MX28_PAD_SSP0_DATA2__SSP0_D2 | MUX_CONFIG_SSP0,
+       MX28_PAD_SSP0_DATA3__SSP0_D3 | MUX_CONFIG_SSP0,
+       MX28_PAD_SSP0_DATA4__SSP0_D4 | MUX_CONFIG_SSP0,
+       MX28_PAD_SSP0_DATA5__SSP0_D5 | MUX_CONFIG_SSP0,
+       MX28_PAD_SSP0_DATA6__SSP0_D6 | MUX_CONFIG_SSP0,
+       MX28_PAD_SSP0_DATA7__SSP0_D7 | MUX_CONFIG_SSP0,
+       MX28_PAD_SSP0_DETECT__GPIO_2_9, /* Reset for eMMC */
+       MX28_PAD_SSP0_SCK__SSP0_SCK | MUX_CONFIG_SSP0,
+
+       /* DIG Keys */
+       MX28_PAD_GPMI_D00__GPIO_0_0,
+       MX28_PAD_GPMI_D01__GPIO_0_1,
+       MX28_PAD_GPMI_D02__GPIO_0_2,
+       MX28_PAD_GPMI_D03__GPIO_0_3,
+       MX28_PAD_GPMI_D04__GPIO_0_4,
+       MX28_PAD_GPMI_D05__GPIO_0_5,
+       MX28_PAD_GPMI_D06__GPIO_0_6,
+       MX28_PAD_GPMI_D07__GPIO_0_7,
+
+       /* ADR_0-2 */
+       MX28_PAD_GPMI_CE1N__GPIO_0_17,
+       MX28_PAD_GPMI_CE2N__GPIO_0_18,
+       MX28_PAD_GPMI_CE3N__GPIO_0_19,
+
+       /* Read Keys */
+       MX28_PAD_GPMI_RDY0__GPIO_0_20,
+
+       /* LATCH_EN */
+       MX28_PAD_GPMI_RDY1__GPIO_0_21,
+
+       /* Power off */
+       MX28_PAD_GPMI_RDN__GPIO_0_24,
+
+       /* WIFI EN */
+       MX28_PAD_GPMI_CLE__GPIO_0_27,
+
+       /* I2C1 Touch */
+       MX28_PAD_AUART2_CTS__GPIO_3_10,
+       MX28_PAD_AUART2_RTS__GPIO_3_11,
+       MX28_PAD_GPMI_RDY2__GPIO_0_22, /* Touch Reset */
+       MX28_PAD_GPMI_RDY3__GPIO_0_23, /* Touch INT */
+
+       /* TIVA */
+       MX28_PAD_AUART1_RX__SSP2_CARD_DETECT,
+       MX28_PAD_SSP2_MISO__SSP2_D0,
+       MX28_PAD_SSP2_MOSI__SSP2_CMD,
+       MX28_PAD_SSP2_SCK__SSP2_SCK,
+       MX28_PAD_SSP2_SS0__SSP2_D3,
+       MX28_PAD_SSP2_SS1__GPIO_2_20,
+       MX28_PAD_SSP2_SS2__GPIO_2_21,
+
+       /* SPI3 NOR-Flash */
+       MX28_PAD_AUART1_TX__SSP3_CARD_DETECT,
+       MX28_PAD_AUART2_RX__SSP3_D1,
+       MX28_PAD_AUART2_TX__SSP3_D2,
+       MX28_PAD_SSP3_MISO__SSP3_D0,
+       MX28_PAD_SSP3_MOSI__SSP3_CMD,
+       MX28_PAD_SSP3_SCK__SSP3_SCK,
+       MX28_PAD_SSP3_SS0__SSP3_D3,
+
+       /* NOR-Flash CMD */
+       MX28_PAD_LCD_RS__GPIO_1_26, /* Hold */
+       MX28_PAD_LCD_WR_RWN__GPIO_1_25, /* write protect */
+
+       /* I2C0 Codec */
+       MX28_PAD_I2C0_SCL__I2C0_SCL,
+       MX28_PAD_I2C0_SDA__I2C0_SDA,
+
+       /* I2S Codec */
+       MX28_PAD_SAIF0_BITCLK__SAIF0_BITCLK,
+       MX28_PAD_SAIF0_LRCLK__SAIF0_LRCLK,
+       MX28_PAD_SAIF0_MCLK__SAIF0_MCLK,
+       MX28_PAD_SAIF0_SDATA0__SAIF0_SDATA0,
+       MX28_PAD_SAIF1_SDATA0__SAIF1_SDATA0,
+
+       /* BT_EN */
+       MX28_PAD_SPDIF__GPIO_3_27,
+
+       /* EMI */
+       MX28_PAD_EMI_D00__EMI_DATA0 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_D01__EMI_DATA1 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_D02__EMI_DATA2 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_D03__EMI_DATA3 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_D04__EMI_DATA4 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_D05__EMI_DATA5 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_D06__EMI_DATA6 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_D07__EMI_DATA7 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_D08__EMI_DATA8 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_D09__EMI_DATA9 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_D10__EMI_DATA10 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_D11__EMI_DATA11 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_D12__EMI_DATA12 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_D13__EMI_DATA13 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_D14__EMI_DATA14 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_D15__EMI_DATA15 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_ODT0__EMI_ODT0 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_DQM0__EMI_DQM0 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_ODT1__EMI_ODT1 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_DQM1__EMI_DQM1 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_DDR_OPEN_FB__EMI_DDR_OPEN_FEEDBACK |

MUX_CONFIG_EMI,

board/liebherr/btt/btt.c new file +92 -0
+       MX28_PAD_EMI_CLK__EMI_CLK | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_DQS0__EMI_DQS0 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_DQS1__EMI_DQS1 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_DDR_OPEN__EMI_DDR_OPEN | MUX_CONFIG_EMI,
+
+       MX28_PAD_EMI_A00__EMI_ADDR0 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_A01__EMI_ADDR1 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_A02__EMI_ADDR2 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_A03__EMI_ADDR3 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_A04__EMI_ADDR4 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_A05__EMI_ADDR5 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_A06__EMI_ADDR6 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_A07__EMI_ADDR7 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_A08__EMI_ADDR8 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_A09__EMI_ADDR9 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_A10__EMI_ADDR10 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_A11__EMI_ADDR11 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_A12__EMI_ADDR12 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_A13__EMI_ADDR13 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_A14__EMI_ADDR14 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_BA0__EMI_BA0 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_BA1__EMI_BA1 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_BA2__EMI_BA2 | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_CASN__EMI_CASN | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_RASN__EMI_RASN | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_WEN__EMI_WEN | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_CE0N__EMI_CE0N | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_CE1N__EMI_CE1N | MUX_CONFIG_EMI,
+       MX28_PAD_EMI_CKE__EMI_CKE | MUX_CONFIG_EMI,
+
+       /* Uart3 Bluetooth-Interface */
+       MX28_PAD_AUART3_CTS__AUART3_CTS,
+       MX28_PAD_AUART3_RTS__AUART3_RTS,
+       MX28_PAD_AUART3_RX__AUART3_RX,
+       MX28_PAD_AUART3_TX__AUART3_TX,
+
+       /* framebuffer */
+       MX28_PAD_LCD_CS__LCD_CS | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D00__LCD_D0 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D01__LCD_D1 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D02__LCD_D2 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D03__LCD_D3 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D04__LCD_D4 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D05__LCD_D5 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D06__LCD_D6 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D07__LCD_D7 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D08__LCD_D8 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D09__LCD_D9 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D10__LCD_D10 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D11__LCD_D11 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D12__LCD_D12 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D13__LCD_D13 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D14__LCD_D14 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D15__LCD_D15 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D16__LCD_D16 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D17__LCD_D17 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D18__LCD_D18 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D19__LCD_D19 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D20__LCD_D20 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D21__LCD_D21 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D22__LCD_D22 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_D23__LCD_D23 | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_DOTCLK__LCD_DOTCLK | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_ENABLE__LCD_ENABLE | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_HSYNC__LCD_HSYNC | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_RD_E__LCD_VSYNC | MUX_CONFIG_LCD,
+       MX28_PAD_LCD_RESET__LCD_RESET | MUX_CONFIG_LCD,
+
+       /* DUART RS232 */
+       MX28_PAD_PWM0__DUART_RX,
+       MX28_PAD_PWM1__DUART_TX,
+
+       /* Backlight */
+       MX28_PAD_PWM3__PWM_3,
+
+       /* FEC Ethernet */
+       MX28_PAD_ENET_CLK__CLKCTRL_ENET | MUX_CONFIG_ENET,
+       MX28_PAD_ENET0_COL__ENET1_TX_EN | MUX_CONFIG_ENET,
+       MX28_PAD_ENET0_CRS__ENET1_RX_EN | MUX_CONFIG_ENET,
+       MX28_PAD_ENET0_MDC__ENET0_MDC | MUX_CONFIG_ENET,
+       MX28_PAD_ENET0_MDIO__ENET0_MDIO | MUX_CONFIG_ENET,
+       MX28_PAD_ENET0_RX_CLK__GPIO_4_13, /* Phy Interrupt */
+       MX28_PAD_ENET0_RX_EN__ENET0_RX_EN | MUX_CONFIG_ENET,
+       MX28_PAD_ENET0_RXD0__ENET0_RXD0 | MUX_CONFIG_ENET,
+       MX28_PAD_ENET0_RXD1__ENET0_RXD1 | MUX_CONFIG_ENET,
+       MX28_PAD_ENET0_RXD3__ENET1_RXD1 | MUX_CONFIG_ENET,
+       MX28_PAD_ENET0_TX_CLK__GPIO_4_5, /* n.c. */
+       MX28_PAD_ENET0_TX_EN__ENET0_TX_EN | MUX_CONFIG_ENET,
+       MX28_PAD_ENET0_TXD0__ENET0_TXD0 | MUX_CONFIG_ENET,
+       MX28_PAD_ENET0_TXD1__ENET0_TXD1 | MUX_CONFIG_ENET,
+       MX28_PAD_ENET0_TXD3__ENET1_TXD1 | MUX_CONFIG_ENET,
+       MX28_PAD_ENET0_TXD3__GPIO_4_12, /* PHY reset */

board/liebherr/btt/btt.c

Quoted 10 lines
board/liebherr/btt/btt.c new file +10 -0
+
+       /* boot/rescue pins */
+       MX28_PAD_ENET0_RXD2__GPIO_4_9,
+       MX28_PAD_ENET0_TXD2__GPIO_4_11,
+
+       /* HW revision setup pins - by default pullup DISABLED */
+       MX28_PAD_ENET0_RXD3__GPIO_4_10,
+       MX28_PAD_ENET0_TX_CLK__GPIO_4_5,
+       MX28_PAD_ENET0_COL__GPIO_4_14,
+       MX28_PAD_ENET0_CRS__GPIO_4_15,  

What is the reason for doing a complete pinctrl configuration inside SPL?

Quoted 1 line

Can't you configure only the pins that SPL needs?

The reason is as I've mentioned above.

Quoted 11 lines
Quoted 11 lines
board/liebherr/btt/btt.c new file +4 -0
+#ifndef CONFIG_SPL_FRAMEWORK
+void board_init_ll(const u32 arg, const uint32_t *resptr)
+{
+       mxs_common_spl_init(arg, resptr, iomux_setup,

ARRAY_SIZE(iomux_setup)); +}

board/liebherr/btt/btt.c new file +5 -0
+#else
+void lowlevel_init(void)
+{
+       struct mxs_pinctrl_regs *pinctrl_regs =
+               (struct mxs_pinctrl_regs *)MXS_PINCTRL_BASE;
Quoted 8 lines
Quoted 6 lines
board/liebherr/btt/btt.c new file +3 -0
+
+       /* Set EMI drive strength */
+       writel(0x00003fff,

&pinctrl_regs->hw_pinctrl_emi_ds_ctrl_clr);
+ writel(0x00002aaa,
&pinctrl_regs->hw_pinctrl_emi_ds_ctrl_set);

Please use defines instead of hardcoded values.

To be honest - this is probably took from first imx28-evk ports.... Probably people who wrote them are now retired :-)

Quoted 16 lines
Quoted 12 lines
board/liebherr/btt/btt.c new file +10 -0
@@ -0,0 +1,17 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * Copyright (C) 2025 DENX Software Engineering
+ * Lukasz Majewski, DENX Software Engineering, [email protected]
+ */
+#ifndef __CONFIGS_BTT_H__
+#define __CONFIGS_BTT_H__
+
+/* Memory configuration */
+#define PHYS_SDRAM_1                   0x40000000      /* Base
Quoted 2 lines

address */ +#define PHYS_SDRAM_1_SIZE 0x10000000
/* Max 256 MB RAM */

You could use SZ_256M and remove the comment.

Ok.

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: [email protected]