Skip to contentSkip to conversation

Decrease `AcpiExTracePoint` verbosity

PATCH In review Mario Limonciello 2 participants 4 messages Jun 9, 2025 – Jun 26, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Decrease `AcpiExTracePoint` verbosity

From: Mario Limonciello <[email protected]>

Early in kernel boot pointers can't be used and so %p shows up incorrectly:

```
extrace-0138 ex_trace_point        : Method Begin [0x(____ptrval____):\M460] execution.
```

Later in the boot %p works, but it's not really actually useful when the pathname can resolve properly. Adjust the debug print so that if the Pathname resolves that the pointer isn't also printed:

```
extrace-0138 ex_trace_point        : Method Begin [\M460] execution.
```
---
 drivers/acpi/acpica/extrace.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/acpi/acpica/extrace.c +2 -2
index d34497f3576a4..36934d4f26fb4 100644
@@ -136,9 +136,9 @@ acpi_ex_trace_point(acpi_trace_event_type type,
 
 	if (pathname) {
 		ACPI_DEBUG_PRINT((ACPI_DB_TRACE_POINT,
-				  "%s %s [0x%p:%s] execution.\n",
+				  "%s %s [%s] execution.\n",
 				  acpi_ex_get_trace_event_name(type),
-				  begin ? "Begin" : "End", aml, pathname));
+				  begin ? "Begin" : "End", pathname));
 	} else {
 		ACPI_DEBUG_PRINT((ACPI_DB_TRACE_POINT,
 				  "%s %s [0x%p] execution.\n",
Signature · 1 line
2.43.0
#1 lore raw
Quoted 14 lines · Mario Limonciello

From: Mario Limonciello <[email protected]>

Early in kernel boot pointers can't be used and so %p shows up incorrectly:

```
extrace-0138 ex_trace_point        : Method Begin [0x(____ptrval____):\M460] execution.
```

Later in the boot %p works, but it's not really actually useful when the pathname can resolve properly. Adjust the debug print so that if the Pathname resolves that the pointer isn't also printed:

Quoted 7 lines
```
extrace-0138 ex_trace_point        : Method Begin [\M460] execution.
```

This is an ACPICA change, so it should be made upstream first unless there is a good enough reason to make it directly in Linux. In which case that reason should be mentioned in the changelog.

Quoted 24 lines
---
 drivers/acpi/acpica/extrace.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/acpi/acpica/extrace.c +2 -3
index d34497f3576a4..36934d4f26fb4 100644
@@ -136,9 +136,9 @@ acpi_ex_trace_point(acpi_trace_event_type type,
 
        if (pathname) {
                ACPI_DEBUG_PRINT((ACPI_DB_TRACE_POINT,
-                                 "%s %s [0x%p:%s] execution.\n",
+                                 "%s %s [%s] execution.\n",
                                  acpi_ex_get_trace_event_name(type),
-                                 begin ? "Begin" : "End", aml, pathname));
+                                 begin ? "Begin" : "End", pathname));
        } else {
                ACPI_DEBUG_PRINT((ACPI_DB_TRACE_POINT,
                                  "%s %s [0x%p] execution.\n",
--

2.43.0

#2 lore raw
Quoted 19 lines · Rafael J. Wysocki
Quoted 18 lines · Mario Limonciello

From: Mario Limonciello <[email protected]>

Early in kernel boot pointers can't be used and so %p shows up incorrectly:

```
extrace-0138 ex_trace_point        : Method Begin [0x(____ptrval____):\M460] execution.
```

Later in the boot %p works, but it's not really actually useful when the pathname can resolve properly. Adjust the debug print so that if the Pathname resolves that the pointer isn't also printed:

```
extrace-0138 ex_trace_point        : Method Begin [\M460] execution.
```
Quoted 7 lines
Quoted 3 lines

This is an ACPICA change, so it should be made upstream first unless there is a good enough reason to make it directly in Linux. In which case that reason should be mentioned in the changelog.

The patches were from ACPICA (I included the links above). I wasn't sure if it needed to be a manual application here or if you'll do it the next cycle. If you're going to automatically do it then we can disregard this patch for now.

Quoted 25 lines
Quoted 25 lines
---
  drivers/acpi/acpica/extrace.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/acpi/acpica/extrace.c +2 -3
index d34497f3576a4..36934d4f26fb4 100644
@@ -136,9 +136,9 @@ acpi_ex_trace_point(acpi_trace_event_type type,
 
         if (pathname) {
                 ACPI_DEBUG_PRINT((ACPI_DB_TRACE_POINT,
-                                 "%s %s [0x%p:%s] execution.\n",
+                                 "%s %s [%s] execution.\n",
                                   acpi_ex_get_trace_event_name(type),
-                                 begin ? "Begin" : "End", aml, pathname));
+                                 begin ? "Begin" : "End", pathname));
         } else {
                 ACPI_DEBUG_PRINT((ACPI_DB_TRACE_POINT,
                                   "%s %s [0x%p] execution.\n",
--

2.43.0

#3 lore raw
Quoted 25 lines · Mario Limonciello
Quoted 23 lines · Rafael J. Wysocki
Quoted 21 lines · Mario Limonciello

From: Mario Limonciello <[email protected]>

Early in kernel boot pointers can't be used and so %p shows up incorrectly:

```
extrace-0138 ex_trace_point        : Method Begin [0x(____ptrval____):\M460] execution.
```

Later in the boot %p works, but it's not really actually useful when the pathname can resolve properly. Adjust the debug print so that if the Pathname resolves that the pointer isn't also printed:

```
extrace-0138 ex_trace_point        : Method Begin [\M460] execution.
```
Quoted 5 lines
Quoted 3 lines

This is an ACPICA change, so it should be made upstream first unless there is a good enough reason to make it directly in Linux. In which case that reason should be mentioned in the changelog.

The patches were from ACPICA (I included the links above).

OK, applied as 6.17 material, thanks!