Skip to contentSkip to conversation

mm/memfd: Clarify error handling labels in memfd_create()

PATCH Applied Ye Liu 1 participant 1 message Jun 10, 2025

Subsystems (2)
lore
Share & tools
lore

Ye Liu

author
#0 lore raw

PATCH v2 1/1 mm/memfd: Clarify error handling labels in memfd_create()

From: Ye Liu <[email protected]>

err_name --> err_free_name (fd failure case)
err_fd --> err_free_fd (file failure case)

Changes in v2:
- Rename Subject.
- Use "err_free_name" and "err_free_fd".
- Link to v1:https://lore.kernel.org/all/[email protected]/

---
 mm/memfd.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
mm/memfd.c +4 -4
index ab367e61553d..4fc98abe6627 100644
@@ -475,22 +475,22 @@ SYSCALL_DEFINE2(memfd_create,
 	fd = get_unused_fd_flags((flags & MFD_CLOEXEC) ? O_CLOEXEC : 0);
 	if (fd < 0) {
 		error = fd;
-		goto err_name;
+		goto err_free_name;
 	}
 
 	file = alloc_file(name, flags);
 	if (IS_ERR(file)) {
 		error = PTR_ERR(file);
-		goto err_fd;
+		goto err_free_fd;
 	}
 
 	fd_install(fd, file);
 	kfree(name);
 	return fd;
 
-err_fd:
+err_free_fd:
 	put_unused_fd(fd);
-err_name:
+err_free_name:
 	kfree(name);
 	return error;
 }
Signature · 1 line
2.25.1