Skip to contentSkip to conversation

tools:perf: Remove excess variable declarations

PATCH Applied Bhaskar Chowdhury 2 participants 2 messages Jun 11, 2025 – Jun 25, 2025 perf events

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools:perf: Remove excess variable declarations

I thought array declaration might be done in the same line as assigning the value to it.

Hence, getting rid of extra steps of reiterating the array name.

---
 tools/perf/check-headers.sh | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
tools/perf/check-headers.sh +3 -6
index e9fab20e9330..d0029a109b6e 100755
@@ -4,8 +4,7 @@
 YELLOW='\033[0;33m'
 NC='\033[0m' # No Color
 
-declare -a FILES
-FILES=(
+declare -a FILES=(
   "include/uapi/linux/const.h"
   "include/uapi/drm/drm.h"
   "include/uapi/drm/i915_drm.h"
@@ -73,8 +72,7 @@ FILES=(
   "scripts/syscall.tbl"
 )
 
-declare -a SYNC_CHECK_FILES
-SYNC_CHECK_FILES=(
+declare -a SYNC_CHECK_FILES=(
   "arch/x86/include/asm/inat.h"
   "arch/x86/include/asm/insn.h"
   "arch/x86/lib/inat.c"
@@ -86,8 +84,7 @@ SYNC_CHECK_FILES=(
 # tables that then gets included in .c files for things like id->string syscall
 # tables (and the reverse lookup as well: string -> id)
 
-declare -a BEAUTY_FILES
-BEAUTY_FILES=(
+declare -a BEAUTY_FILES=(
   "arch/x86/include/asm/irq_vectors.h"
   "arch/x86/include/uapi/asm/prctl.h"
   "include/linux/socket.h"

--
2.49.0

maintainer Applied
#1 lore raw
Quoted 6 lines · Bhaskar Chowdhury

I thought array declaration might be done in the same line as assigning the value to it.

Hence, getting rid of extra steps of reiterating the array name.

Applied to perf-tools-next, thanks!

Best regards,
Namhyung