exfat: fdatasync flag should be same like generic_write_sync()
Subsystems (2)
PATCH 1/1 exfat: fdatasync flag should be same like generic_write_sync()
From: Zhengxu Zhang <[email protected]>
Test: androbench by default setting, use 64GB sdcard.
the random write speed:
without this patch 3.5MB/s
with this patch 7MB/s
After patch "11a347fb6cef", the random write speed decreased significantly. the .write_iter() interface had been modified, and check the differences with generic_file_write_iter(), when calling generic_rite_sync() and exfat_file_write_iter() to call vfs_fsync_range(), the fdatasync flag is wrong, and make not use the fdatasync mode, and make random write speed decreased.
so make the fdatasync flag like generic_write_sync().
--- fs/exfat/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/exfat/file.c +1 -1
@@ -625,7 +625,7 @@ static ssize_t exfat_file_write_iter(struct kiocb *iocb, struct iov_iter *iter)if (iocb_is_dsync (iocb) && iocb->ki_pos > pos) {ssize_t err =vfs_fsync_range (file, pos, iocb->ki_pos -1 , - iocb->ki_flags &IOCB_SYNC ); + (iocb->ki_flags &IOCB_SYNC ) ?0 :1 );if (err <0 )return err; }
Signature · 1 line
2.25.1
[email protected]
reviewerQuoted 1 line
generic_file_write_iter(), when callinggeneric_rite_sync()and
s/_rite/_write
fs/exfat/file.c static ssize_t exfat_file_write_iter(struct kiocb *iocb, struct iov_iter *iter) · line 628
Quoted 8 lines
fs/exfat/file.c +1
-1@@ -625,7 +625,7 @@ static ssize_t exfat_file_write_iter(struct kiocb *iocb, struct iov_iter *iter)if (iocb_is_dsync (iocb) && iocb->ki_pos > pos) {ssize_t err =vfs_fsync_range (file, pos, iocb->ki_pos -1 , - iocb->ki_flags &IOCB_SYNC ); + (iocb->ki_flags &IOCB_SYNC ) ?0 :1 );
How about calling generic_write_sync() instead of vfs_fsync_range(), like in generic_file_write_iter()?
Quoted 13 lines
-----邮件原件-----
发件人: [email protected] <[email protected]>
发送时间: 2025年6月13日 18:14
收件人: Cixi Geng <[email protected]>; [email protected]; [email protected]
抄送: [email protected]; [email protected]; 张政旭 (Zhengxu Zhang) <[email protected]>
主题: Re: [PATCH] exfat: fdatasync flag should be same likegeneric_write_sync()
Quoted 4 lines
Quoted 1 line
generic_file_write_iter(), when callinggeneric_rite_sync()ands/_rite/_write
I will fix this by next patch.
Quoted 5 lines
fs/exfat/file.c static ssize_t exfat_file_write_iter(struct kiocb *iocb,
Quoted 3 lines
fs/exfat/file.c +0
-0@@ -625,7 +625,7 @@ static ssize_t exfat_file_write_iter(struct kiocb *iocb,struct
iov_iter*iter)Quoted 1 line
Quoted 7 lines
fs/exfat/file.c static ssize_t exfat_file_write_iter(struct kiocb *iocb, struct iov_iter *iter) · line 628
Quoted 4 lines
if (iocb_is_dsync(iocb) && iocb->ki_pos > pos) { ssize_t err = vfs_fsync_range(file, pos, iocb->ki_pos - 1,fs/exfat/file.c +1
-1- iocb->ki_flags & IOCB_SYNC); + (iocb->ki_flags & IOCB_SYNC) ? 0 : 1);How about calling
generic_write_sync()instead ofvfs_fsync_range(), like ingeneric_file_write_iter()?
The second arg of vfs_fsync_range "pos" maybe changed by valid_size (if pos > valid_size). It can not replace by iocb->ki_pos - ret (ret by __generic_file_write_iter). So current way maybe better.
[email protected]
reviewerQuoted 12 lines
Quoted 5 lines
Quoted 5 lines
fs/exfat/file.c +0
-0@@ -625,7 +625,7 @@ static ssize_t exfat_file_write_iter(struct kiocb *iocb, struct iov_iter *iter)Quoted 7 lines
fs/exfat/file.c static ssize_t exfat_file_write_iter(struct kiocb *iocb, struct iov_iter *iter) · line 628
Quoted 4 lines
fs/exfat/file.c +1
-1if (iocb_is_dsync (iocb) && iocb->ki_pos > pos) {ssize_t err =vfs_fsync_range (file, pos, iocb->ki_pos -1 , - iocb->ki_flags &IOCB_SYNC ); + (iocb->ki_flags &IOCB_SYNC ) ?0 :1 );How about calling
generic_write_sync()instead ofvfs_fsync_range(), like ingeneric_file_write_iter()?
Quoted 3 lines
The second arg of
vfs_fsync_range"pos" maybe changed byvalid_size(if pos >valid_size). It can not replace byiocb->ki_pos- ret (ret by__generic_file_write_iter). So current way maybe better.
Here we synchronize the areas written by exfat_extend_valid_size() and __generic_file_write_iter() if valid_size < pos.
The lengths of these two write areas are 'pos-valid_size' and 'ret'. We can use generic_write_sync() and pass it the sum of these two lengths.
Of course, regardless of whether valid_size < pos, exfat_file_write_iter() only needs to return the length written by __generic_file_write_iter().
Quoted 30 lines
-----邮件原件-----
发件人: [email protected] <[email protected]>
发送时间: 2025年6月17日 11:32
收件人: 张政旭 (Zhengxu Zhang) <[email protected]>; Cixi Geng <[email protected]>; [email protected]; [email protected] 抄送: [email protected]; [email protected]; 王皓 (Hao_haoWang) <[email protected]>
主题: Re: [PATCH] exfat: fdatasync flag should be same likegeneric_write_sync()Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
fs/exfat/file.c +0
-0@@ -625,7 +625,7 @@ static ssize_t exfat_file_write_iter(struct kiocb *iocb, struct iov_iter *iter)Quoted 8 lines
Quoted 7 lines
fs/exfat/file.c static ssize_t exfat_file_write_iter(struct kiocb *iocb, struct iov_iter *iter) · line 628
Quoted 4 lines
fs/exfat/file.c +1
-1if (iocb_is_dsync (iocb) && iocb->ki_pos > pos) {ssize_t err =vfs_fsync_range (file, pos, iocb->ki_pos -1 , - iocb->ki_flags &IOCB_SYNC ); + (iocb->ki_flags &IOCB_SYNC ) ?0 :1 );How about calling
generic_write_sync()instead ofvfs_fsync_range(), like ingeneric_file_write_iter()?The second arg of
vfs_fsync_range"pos" maybe changed byvalid_size(if pos >
valid_size).Quoted 2 lines
It can not replace by
iocb->ki_pos- ret (ret by__generic_file_write_iter). So current way maybe better.
Quoted 8 lines
Here we synchronize the areas written by
exfat_extend_valid_size()and__generic_file_write_iter()ifvalid_size< pos.The lengths of these two write areas are 'pos-valid_size' and 'ret'. We can use
generic_write_sync()and pass it the sum of these two lengths.
Of course, regardless of whethervalid_size< pos,exfat_file_write_iter()only needs to return the length written by__generic_file_write_iter().
I try the sum of 'pos-valid_size' and 'ret',like this:
if (iocb->ki_pos > pos) {
ssize_t err = generic_write_sync(iocb, pos + ret - valid_size);
if (err < 0)
return err;
}
The test crashed, that maybe io error.
So I try a simple way that use iocb->ki_pos - pos. like this:
if (iocb->ki_pos > pos) {
ssize_t err = generic_write_sync(iocb, iocb->ki_pos - pos);
if (err < 0)
return err;
}The test pass. pls check again.
[email protected]
reviewerQuoted 26 lines
Quoted 17 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
fs/exfat/file.c +0
-0@@ -625,7 +625,7 @@ static ssize_t exfat_file_write_iter(struct kiocb *iocb, struct iov_iter *iter)Quoted 8 lines
Quoted 7 lines
fs/exfat/file.c static ssize_t exfat_file_write_iter(struct kiocb *iocb, struct iov_iter *iter) · line 628
Quoted 4 lines
fs/exfat/file.c +1
-1if (iocb_is_dsync (iocb) && iocb->ki_pos > pos) {ssize_t err =vfs_fsync_range (file, pos, iocb->ki_pos -1 , - iocb->ki_flags &IOCB_SYNC ); + (iocb->ki_flags &IOCB_SYNC ) ?0 :1 );How about calling
generic_write_sync()instead ofvfs_fsync_range(), like ingeneric_file_write_iter()?The second arg of
vfs_fsync_range"pos" maybe changed byvalid_size(if pos >
valid_size).Quoted 2 lines
It can not replace by
iocb->ki_pos- ret (ret by__generic_file_write_iter). So current way maybe better.Quoted 8 lines
Here we synchronize the areas written by
exfat_extend_valid_size()and__generic_file_write_iter()ifvalid_size< pos.The lengths of these two write areas are 'pos-valid_size' and 'ret'. We can use
generic_write_sync()and pass it the sum of these two lengths.
Of course, regardless of whethervalid_size< pos,exfat_file_write_iter()only needs to return the length written by__generic_file_write_iter().
Quoted 7 lines
I try the sum of 'pos-valid_size' and 'ret',like this:
if (iocb->ki_pos > pos) { ssize_t err = generic_write_sync(iocb, pos + ret - valid_size); if (err < 0) return err; }The test crashed, that maybe io error.
I think the crash happens when pos < valid_size, because exfat_extend_valid_size() does not write data in this case.
Quoted 7 lines
So I try a simple way that use
iocb->ki_pos- pos. like this:if (iocb->ki_pos > pos) { ssize_t err = generic_write_sync(iocb, iocb->ki_pos - pos); if (err < 0) return err; }The test pass. pls check again.
'pos' is set to the write position of exfat_extend_valid_size() by:
if (pos > valid_size)
pos = valid_size;
'iocb->ki_pos - pos' is the total write length, this way is fine.