Skip to contentSkip to conversation

scsi: ufs: core: Do clk scaling conditionally in reset and restore

PATCH Superseded Anvith Dosapati 2 participants 2 messages Jun 13, 2025

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: ufs: core: Do clk scaling conditionally in reset and restore

From: anvithdosapati <[email protected]>

In ufshcd_host_reset_and_restore, scale up clocks only when clock scaling is supported. Without this change cpu latency is voted for 0 (ufshcd_pm_qos_update) during resume unconditionally.

---
 drivers/ufs/core/ufshcd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/ufs/core/ufshcd.c +2 -1
index 4410e7d93b7d..fac381ea2b3a 100644
@@ -7802,7 +7802,8 @@ static int ufshcd_host_reset_and_restore(struct ufs_hba *hba)
 	hba->silence_err_logs = false;
 
 	/* scale up clocks to max frequency before full reinitialization */
-	ufshcd_scale_clks(hba, ULONG_MAX, true);
+	if (ufshcd_is_clkscaling_supported(hba))
+		ufshcd_scale_clks(hba, ULONG_MAX, true);
 
 	err = ufshcd_hba_enable(hba);
 
Signature · 1 line
2.50.0.rc1.591.g9c95f17f64-goog
#1 lore raw
Quoted 3 lines · Anvith Dosapati

In ufshcd_host_reset_and_restore, scale up clocks only when clock scaling is supported. Without this change cpu latency is voted for 0 (ufshcd_pm_qos_update) during resume unconditionally.

Since this patch is a bug fix, please add "Cc: [email protected]" and "Fixes:" tags. See also Documentation/process/stable-kernel-rules.rst in the kernel tree.

Thanks,

Bart.