staging: rtl8723bs: remove return from void function
PATCH 1/1 staging: rtl8723bs: remove return from void function
Remove exit label and return statement from a void function. After the exit label no cleanup is done, so it is safe to remove it and return early in the only place where the label is used. This simplifies the code and clears a checkpatch warning.
WARNING: void function return statements are not generally useful
Signed-off-by Michael Straube <[email protected]>
--- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
drivers/staging/rtl8723bs/os_dep/os_intfs.c +1 -5
@@ -1112,7 +1112,7 @@ void rtw_suspend_common(struct adapter *padapter)if ((!padapter->bup) || (padapter->bDriverStopped) || (padapter->bSurpriseRemoved)) { pdbgpriv->dbg_suspend_error_cnt++; - goto exit; +return ; }rtw_ps_deny (padapter,PS_DENY_SUSPEND );
@@ -1134,10 +1134,6 @@ void rtw_suspend_common(struct adapter *padapter)netdev_dbg (padapter->pnetdev,"rtw suspend success in %d ms\n" ,jiffies_to_msecs (jiffies - start_time)); - -exit: - -return ; }static int rtw_resume_process_normal (struct adapter *padapter)
Signature · 1 line
2.49.0
Hi,
Quoted 8 lines · Michael Straube
Remove exit label and return statement from a void function. After the exit label no cleanup is done, so it is safe to remove it and return early in the only place where the label is used. This simplifies the code and clears a checkpatch warning.
WARNING: void function return statements are not generally useful
Signed-off-by Michael Straube <[email protected]>
Thanks, patch looks good to me:
Reviewed-by Hans de Goede <[email protected]>
Regards,
Hans
Quoted 28 lines
--- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)drivers/staging/rtl8723bs/os_dep/os_intfs.c +1
-5@@ -1112,7 +1112,7 @@ void rtw_suspend_common(struct adapter *padapter)if ((!padapter->bup) || (padapter->bDriverStopped) || (padapter->bSurpriseRemoved)) { pdbgpriv->dbg_suspend_error_cnt++; - goto exit; +return ; }rtw_ps_deny (padapter,PS_DENY_SUSPEND );@@ -1134,10 +1134,6 @@ void rtw_suspend_common(struct adapter *padapter)netdev_dbg (padapter->pnetdev,"rtw suspend success in %d ms\n" ,jiffies_to_msecs (jiffies - start_time)); - -exit: - -return ; }static int rtw_resume_process_normal (struct adapter *padapter)