dt-bindings: arm: qcom: document r0q board binding
PATCH v2 1/1 dt-bindings: arm: qcom: document r0q board binding
Adds compatible for the Samsung Galaxy S22 (SM-S901E) (r0q), based on the Snapdragon 8 Gen 1 SoC.
--- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/qcom.yaml +1 -0
@@ -1092,6 +1092,7 @@ properties: - qcom,sm8450-qrd - sony,pdx223 - sony,pdx224 + - samsung,r0q - const: qcom,sm8450 - items:
Signature · 1 line
2.49.0
PATCH v2 1/1 arm64: dts: qcom: add initial tree for Samsung Galaxy S22
Adds new device support for the Samsung Galaxy S22 (SM-S901E) phone
Working features:
- simple-framebuffer
- side buttons
- storage
- usb
--- arch/arm64/boot/dts/qcom/Makefile | 1 + .../boot/dts/qcom/sm8450-samsung-r0q.dts | 365 ++++++++++++++++++ 2 files changed, 366 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts
arch/arm64/boot/dts/qcom/Makefile +1 -0
@@ -287,6 +287,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8450-hdk.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8450-qrd.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8450-sony-xperia-nagara-pdx223.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8450-sony-xperia-nagara-pdx224.dtb +dtb-$(CONFIG_ARCH_QCOM) += sm8450-samsung-r0q.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8550-hdk.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8550-mtp.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8550-qrd.dtb
arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts new file +365 -0
365 lines not on this page · raw message
Signature · 1 line
2.49.0
Re: [PATCH v2] arm64: dts: qcom: add initial tree for Samsung Galaxy S22
Quoted 7 lines · Eric Gonçalves
Adds new device support for the Samsung Galaxy S22 (SM-S901E) phone
Working features:
- simple-framebuffer
- side buttons
- storage
- usb
Thread and name your patches correctly, e.g. use b4 or git format-patch -vX -2, and add changelog in cover letter or under '---' of individual patches describing changes from previous version.
<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC (and consider --no-git-fallback argument, so you will not CC people just because they made one commit years ago). It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.
Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember about b4 prep --auto-to-cc if you added new patches to the patchset.
</form letter>
Quoted 55 lines
Signed-off-by Eric Gonçalves <[email protected]>--- arch/arm64/boot/dts/qcom/Makefile | 1 + .../boot/dts/qcom/sm8450-samsung-r0q.dts | 365 ++++++++++++++++++ 2 files changed, 366 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dtsarch/arm64/boot/dts/qcom/Makefile +1
-0@@ -287,6 +287,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8450-hdk.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8450-qrd.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8450-sony-xperia-nagara-pdx223.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8450-sony-xperia-nagara-pdx224.dtb +dtb-$(CONFIG_ARCH_QCOM) += sm8450-samsung-r0q.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8550-hdk.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8550-mtp.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8550-qrd.dtbarch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts new file +29
-0@@ -0,0 +1,365 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright (c) 2025, Eric Gonçalves <[email protected]> + * Copyright (c) 2025, Arthur Aligon <[email protected]> + */ + +/dts-v1/; + +#include <dt-bindings/input/linux-event-codes.h> +#include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/regulator/qcom,rpmh-regulator.h> + +#include "sm8450.dtsi" +#include "pm8350.dtsi" +#include "pm8350b.dtsi" +#include "pm8350c.dtsi" +#include "pm8450.dtsi" +#include "pmk8350.dtsi" +#include "pmr735a.dtsi" + +/delete-node/ &xbl_ramdump_mem; +/delete-node/ &xbl_sc_mem; +/delete-node/ &adsp_mem; +/delete-node/ &rmtfs_mem; +/delete-node/ &mte_mem; +/delete-node/ &trusted_apps_mem; +/delete-node/ &trusted_apps_ext_mem; + +/ {
arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts line 39
Quoted 10 lines
arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts new file +10
-0+ chassis-type = "handset"; + model = "Samsung Galaxy S22 (SM-S901E)"; + compatible = "samsung,r0q", "qcom,sm8450"; + + chosen { + #address-cells = <2>; + #size-cells = <2>; + ranges; + + bootargs = "clk_ignore_unused pd_ignore_unused";
This is not really part of mainline DTS. If it is, then you need to clearly document the reasons with comment.
arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts line 41
Quoted 2 lines
arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts new file +2
-0+ linux,initrd-start = <0x00 0xb6915000>; + linux,initrd-end = <0x00 0xb7fff22c>;
Why this has to be in DTS?
Best regards,
Krzysztof
Quoted 1 line · Eric Gonçalves
Adds compatible for the Samsung Galaxy S22 (SM-S901E) (r0q), based on the Snapdragon 8 Gen 1 SoC.
Please run scripts/checkpatch.pl on the patches and fix reported warnings. After that, run also 'scripts/checkpatch.pl --strict' on the patches and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear.
Documentation/devicetree/bindings/arm/qcom.yaml properties: · line 1095
Quoted 13 lines
--- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/arm/qcom.yaml +1
-0@@ -1092,6 +1092,7 @@ properties: - qcom,sm8450-qrd - sony,pdx223 - sony,pdx224 + - samsung,r0q
Keep alphabetical order.
Best regards,
Krzysztof