HID: appletb-kbd: fix "appletb_backlight" backlight device reference counting
Subsystems (2)
PATCH 1/1 HID: appletb-kbd: fix "appletb_backlight" backlight device reference counting
During appletb_kbd_probe, probe attempts to get the backlight device by name. When this happens backlight_device_get_by_name looks for a device in the backlight class which has name "appletb_backlight" and upon finding a match it increments the reference count for the device and returns it to the caller. However this reference is never released leading to a reference leak.
Fix this by decrementing the backlight device reference count on removal via put_device and on probe failure.
--- drivers/hid/hid-appletb-kbd.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/hid/hid-appletb-kbd.c +5 -0
@@ -438,6 +438,8 @@ static int appletb_kbd_probe(struct hid_device *hdev, const struct hid_device_idreturn 0 ; close_hw: +if (kbd->backlight_dev) +put_device (&kbd->backlight_dev->dev);hid_hw_close (hdev); stop_hw:hid_hw_stop (hdev);
@@ -453,6 +455,9 @@ static void appletb_kbd_remove(struct hid_device *hdev)input_unregister_handler (&kbd->inp_handler);timer_delete_sync (&kbd->inactivity_timer); +if (kbd->backlight_dev) +put_device (&kbd->backlight_dev->dev); +hid_hw_close (hdev);hid_hw_stop (hdev); }
Signature · 1 line
2.39.5
Hi Qasim
Quoted 6 lines
During
appletb_kbd_probe, probe attempts to get the backlight device by name. When this happensbacklight_device_get_by_namelooks for a device in the backlight class which has name "appletb_backlight" and upon finding a match it increments the reference count for the device and returns it to the caller. However this reference is never released leading to a reference leak.
Good catch.
Quoted 2 lines
Fix this by decrementing the backlight device reference count on removal via
put_deviceand on probe failure.
Thanks for the fix!
Quoted 3 lines
Fixes 93a0fc489481 ("HID: hid-appletb-kbd: add support for automatic brightness control while using the touchbar")Signed-off-by Qasim Ijaz <[email protected]>
Quoted 7 lines · Qasim Ijaz
During
appletb_kbd_probe, probe attempts to get the backlight device by name. When this happensbacklight_device_get_by_namelooks for a device in the backlight class which has name "appletb_backlight" and upon finding a match it increments the reference count for the device and returns it to the caller. However this reference is never released leading to a reference leak.
Quoted 6 lines
Fix this by decrementing the backlight device reference count on removal via
put_deviceand on probe failure.Fixes 93a0fc489481 ("HID: hid-appletb-kbd: add support for automatic brightness control while using the touchbar")Signed-off-by Qasim Ijaz <[email protected]>
Applied, thanks.
Signature · 2 lines
Jiri Kosina SUSE Labs