nouveau/gsp: get zeroed pages for any device allocations we need
Subsystems (3)
Dave Airlie
maintainerPATCH 1/1 nouveau/gsp: get zeroed pages for any device allocations we need
From: Dave Airlie <[email protected]>
This seems to remove some random behaviour around suspend/resume operations, and ordering of memory allocations.
Reviewed-by Ben Skeggs <[email protected]>
Signed-off-by Dave Airlie <[email protected]>
--- drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c +1 -1
@@ -1583,7 +1583,7 @@ nvkm_gsp_sg(struct nvkm_device *device, u64 size, struct sg_table *sgt)return ret;for_each_sgtable_sg (sgt, sgl, i) { -struct page *page =alloc_page (GFP_KERNEL ); +struct page *page =alloc_page (GFP_KERNEL | __GFP_ZERO);if (!page) {nvkm_gsp_sg_free (device, sgt);
Signature · 1 line
2.49.0
Danilo Krummrich
maintainerQuoted 4 lines · Dave Airlie
From: Dave Airlie <[email protected]>
This seems to remove some random behaviour around suspend/resume operations, and ordering of memory allocations.
What do you mean with ordering of memory allocations?
Quoted 2 lines
I think we should add:
Fixes 176fdcbddfd2 ("drm/nouveau/gsp/r535: add support for booting GSP-RM")
Quoted 19 lines
Reviewed-by Ben Skeggs <[email protected]>Signed-off-by Dave Airlie <[email protected]>--- drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c +1
-1@@ -1583,7 +1583,7 @@ nvkm_gsp_sg(struct nvkm_device *device, u64 size, struct sg_table *sgt)return ret;for_each_sgtable_sg (sgt, sgl, i) { -struct page *page =alloc_page (GFP_KERNEL ); +struct page *page =alloc_page (GFP_KERNEL | __GFP_ZERO);if (!page) {nvkm_gsp_sg_free (device, sgt);