ufs: scsi: core: Send a NOP OUT to device before disabling AHIT
Subsystems (2)
PATCH 1/1 ufs: scsi: core: Send a NOP OUT to device before disabling AHIT
Synopsis databook recommends that the host must send a NOP OUT to device before disabling AHIT(setting AHIT.AH8ITV to 0), if already programmed to a non-zero value.
Signed-off-by Mriganka Chakravarty <[email protected]>
--- drivers/ufs/core/ufshcd.c | 10 ++++++++++ include/ufs/ufshcd.h | 7 +++++++ 2 files changed, 17 insertions(+)
drivers/ufs/core/ufshcd.c +10 -0
@@ -4507,9 +4507,19 @@ EXPORT_SYMBOL_GPL(ufshcd_uic_hibern8_exit);static void ufshcd_configure_auto_hibern8 (struct ufs_hba *hba) { +u32 reg_ahit; +if (!ufshcd_is_auto_hibern8_supported (hba))return ; +if (hba->quirks &UFSHCD_QUIRK_SEND_NOP_BEFORE_AHIT_DISABLE ) { + reg_ahit =ufshcd_readl (hba,REG_AUTO_HIBERNATE_IDLE_TIMER ); +if (hba->ahit ==0 && +FIELD_GET (UFSHCI_AHIBERN8_TIMER_MASK , reg_ahit) !=0 ) +ufshcd_exec_dev_cmd (hba,DEV_CMD_TYPE_NOP , + hba->nop_out_timeout); + } +ufshcd_writel (hba, hba->ahit,REG_AUTO_HIBERNATE_IDLE_TIMER ); }
include/ufs/ufshcd.h +7 -0
@@ -689,6 +689,13 @@ enum ufshcd_quirks {* single doorbell mode. */ UFSHCD_QUIRK_BROKEN_LSDBS_CAP =1 <<25 , + +/* +* This quirk indicates that host must send a NOP OUT to device before +* disabling AHIT(setting AHIT.AH8ITV to 0), if already programmed to a +* non-zero value. +*/ + UFSHCD_QUIRK_SEND_NOP_BEFORE_AHIT_DISABLE = 1 << 31, }; enum ufshcd_caps {
Signature · 1 line
2.50.0.rc2.692.g299adb8693-goog
Quoted 7 lines · Mriganka Chakravarty
Synopsis databook recommends that the host must send a NOP OUT to device
before disabling AHIT(setting AHIT.AH8ITV to 0), if already programmed
to a non-zero value.Signed-off-by Mriganka Chakravarty <[email protected]>
Hi Mriganka,
Please do not add a quirk without adding a user that needs the quirk.
Thanks.
Peter