Skip to contentSkip to conversation

scsi: pm80xx: Free allocated tags after failure

PATCH Applied Francisco Gutierrez 3 participants 4 messages Jun 17, 2025 – Jun 25, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: pm80xx: Free allocated tags after failure

This change frees resources after an error is detected.

---
 drivers/scsi/pm8001/pm80xx_hwi.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)
drivers/scsi/pm8001/pm80xx_hwi.c +10 -2
index 5b373c53c0369..c4074f062d931 100644
@@ -4677,8 +4677,12 @@ pm80xx_chip_phy_start_req(struct pm8001_hba_info *pm8001_ha, u8 phy_id)
 		&pm8001_ha->phy[phy_id].dev_sas_addr, SAS_ADDR_SIZE);
 	payload.sas_identify.phy_id = phy_id;
 
-	return pm8001_mpi_build_cmd(pm8001_ha, 0, opcode, &payload,
+	ret = pm8001_mpi_build_cmd(pm8001_ha, 0, opcode, &payload,
 				    sizeof(payload), 0);
+	if (ret < 0)
+		pm8001_tag_free(pm8001_ha, tag);
+
+	return ret;
 }
 
 /**
@@ -4704,8 +4708,12 @@ static int pm80xx_chip_phy_stop_req(struct pm8001_hba_info *pm8001_ha,
 	payload.tag = cpu_to_le32(tag);
 	payload.phy_id = cpu_to_le32(phy_id);
 
-	return pm8001_mpi_build_cmd(pm8001_ha, 0, opcode, &payload,
+	ret = pm8001_mpi_build_cmd(pm8001_ha, 0, opcode, &payload,
 				    sizeof(payload), 0);
+	if (ret < 0)
+		pm8001_tag_free(pm8001_ha, tag);
+
+	return ret;
 }
 
 /*
Signature · 1 line
2.50.0.rc2.696.g1fc2a0284f-goog
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Francisco Gutierrez

This change frees resources after an error is detected.

lgtm.

Quoted 39 lines
---
 drivers/scsi/pm8001/pm80xx_hwi.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)
drivers/scsi/pm8001/pm80xx_hwi.c +10 -3
index 5b373c53c0369..c4074f062d931 100644
@@ -4677,8 +4677,12 @@ pm80xx_chip_phy_start_req(struct pm8001_hba_info *pm8001_ha, u8 phy_id)
                &pm8001_ha->phy[phy_id].dev_sas_addr, SAS_ADDR_SIZE);
        payload.sas_identify.phy_id = phy_id;
 
-       return pm8001_mpi_build_cmd(pm8001_ha, 0, opcode, &payload,
+       ret = pm8001_mpi_build_cmd(pm8001_ha, 0, opcode, &payload,
                                    sizeof(payload), 0);
+       if (ret < 0)
+               pm8001_tag_free(pm8001_ha, tag);
+
+       return ret;
 }
 
 /**
@@ -4704,8 +4708,12 @@ static int pm80xx_chip_phy_stop_req(struct pm8001_hba_info *pm8001_ha,
        payload.tag = cpu_to_le32(tag);
        payload.phy_id = cpu_to_le32(phy_id);
 
-       return pm8001_mpi_build_cmd(pm8001_ha, 0, opcode, &payload,
+       ret = pm8001_mpi_build_cmd(pm8001_ha, 0, opcode, &payload,
                                    sizeof(payload), 0);
+       if (ret < 0)
+               pm8001_tag_free(pm8001_ha, tag);
+
+       return ret;
 }
 
 /*
--

2.50.0.rc2.696.g1fc2a0284f-goog