Expect Key error for module_load test in lockdown mode
PATCH 1/1 Expect Key error for module_load test in lockdown mode
From: Sindhu Karri <[email protected]>
--- tests/module_load/test | 38 ++++++++++++++++++++++++++++++++++---- 1 file changed, 34 insertions(+), 4 deletions(-)
tests/module_load/test +34 -4
@@ -25,10 +25,40 @@ BEGIN { plan tests => 17; } +# Read current lockdown mode +my $lockdown_mode; +if (open(my $fh, '<', '/sys/kernel/security/lockdown')) { + my $line = <$fh>; + close($fh); + + if ($line =~ /\[([^\]]+)\]/) { + $lockdown_mode = $1; + } else { + warn "Warning: Could not determine active lockdown mode, assuming lockdown mode is 'none'."; + $lockdown_mode = "none"; + } +} else { + warn "Warning: Cannot read /sys/kernel/security/lockdown, assuming lockdown mode is 'none'."; + $lockdown_mode = "none"; +} + +print "Current lockdown mode: $lockdown_mode\n"; + +# In cases 1 and 5, +# In lockdown integrity mode, the expected error code is 129 i.e. Key is rejected by the service error +# In lockdown none mode, no error is expected. +$expected_pass = ($lockdown_mode eq 'none') ? 0 : 129; + +# In cases 4 and 8, +# In lockdown integrity mode, the expected error code is 129 i.e. Key is rejected by the service error +# In lockdown none mode, the error expected is 13 i.e. EACCES +$expected_fail = ($lockdown_mode eq 'none') ? 13 : 129; + + print "Test finit_module(2)\n"; $result = system "runcon -t test_kmodule_t $basedir/finit_load $v $basedir setest_module_request"; -ok( $result eq 0 ); +ok( $result >> 8 eq $expected_pass ); # Deny capability { sys_module } - EPERM $result = system
@@ -43,12 +73,12 @@ ok( $result >> 8 eq 13 ); # Deny system { module_request } - EACCES $result = system "runcon -t test_kmodule_deny_module_request_t $basedir/finit_load $v $basedir setest_module_request 2>&1"; -ok( $result >> 8 eq 13 ); +ok( $result >> 8 eq $expected_fail ); print "Test init_module(2)\n"; $result = system "runcon -t test_kmodule_t $basedir/init_load $v $basedir setest_module_request"; -ok( $result eq 0 ); +ok( $result >> 8 eq $expected_pass ); # Deny capability { sys_module } - EPERM $result = system
@@ -63,7 +93,7 @@ ok( $result >> 8 eq 13 ); # Deny system { module_request } - EACCES $result = system "runcon -t test_kmodule_deny_module_request_t $basedir/init_load $v $basedir setest_module_request 2>&1"; -ok( $result >> 8 eq 13 ); +ok( $result >> 8 eq $expected_fail ); SKIP: { skip(
Signature · 1 line
2.33.8
Stephen Smalley
maintainerQuoted 2 lines · Sindhu Karri
From: Sindhu Karri <[email protected]>
Move your subject line here to the patch description, replace your subject line with something like:
[PATCH testsuite] tests/module_load/test: handle kernel lockdown correctly
Quoted 21 lines
Signed-off-by Sindhu Karri <[email protected]>--- tests/module_load/test | 38 ++++++++++++++++++++++++++++++++++---- 1 file changed, 34 insertions(+), 4 deletions(-)tests/module_load/test +8
-0@@ -25,10 +25,40 @@ BEGIN { plan tests => 17; } +# Read current lockdown mode +my $lockdown_mode; +if (open(my $fh, '<', '/sys/kernel/security/lockdown')) { + my $line = <$fh>; + close($fh); + + if ($line =~ /\[([^\]]+)\]/) { + $lockdown_mode = $1;
tests/module_load/test BEGIN { · line 45
Quoted 10 lines
tests/module_load/test +10
-0+ } else { + warn "Warning: Could not determine active lockdown mode, assuming lockdown mode is 'none'."; + $lockdown_mode = "none"; + } +} else { + warn "Warning: Cannot read /sys/kernel/security/lockdown, assuming lockdown mode is 'none'."; + $lockdown_mode = "none"; +} + +print "Current lockdown mode: $lockdown_mode\n";
Would remove this debugging output.
Quoted 47 lines
tests/module_load/test +16
-5+ +# In cases 1 and 5, +# In lockdown integrity mode, the expected error code is 129 i.e. Key is rejected by the service error +# In lockdown none mode, no error is expected. +$expected_pass = ($lockdown_mode eq 'none') ? 0 : 129; + +# In cases 4 and 8, +# In lockdown integrity mode, the expected error code is 129 i.e. Key is rejected by the service error +# In lockdown none mode, the error expected is 13 i.e. EACCES +$expected_fail = ($lockdown_mode eq 'none') ? 13 : 129; + + print "Test finit_module(2)\n"; $result = system "runcon -t test_kmodule_t $basedir/finit_load $v $basedir setest_module_request"; -ok( $result eq 0 ); +ok( $result >> 8 eq $expected_pass ); # Deny capability { sys_module } - EPERM $result = system@@ -43,12 +73,12 @@ ok( $result >> 8 eq 13 ); # Deny system { module_request } - EACCES $result = system "runcon -t test_kmodule_deny_module_request_t $basedir/finit_load $v $basedir setest_module_request 2>&1"; -ok( $result >> 8 eq 13 ); +ok( $result >> 8 eq $expected_fail ); print "Test init_module(2)\n"; $result = system "runcon -t test_kmodule_t $basedir/init_load $v $basedir setest_module_request"; -ok( $result eq 0 ); +ok( $result >> 8 eq $expected_pass ); # Deny capability { sys_module } - EPERM $result = system@@ -63,7 +93,7 @@ ok( $result >> 8 eq 13 ); # Deny system { module_request } - EACCES $result = system "runcon -t test_kmodule_deny_module_request_t $basedir/init_load $v $basedir setest_module_request 2>&1"; -ok( $result >> 8 eq 13 ); +ok( $result >> 8 eq $expected_fail ); SKIP: { skip( --2.33.8
Stephen Smalley
maintainerQuoted 34 lines · Stephen Smalley
Quoted 2 lines · Sindhu Karri
From: Sindhu Karri <[email protected]>
Move your subject line here to the patch description, replace your subject line with something like:
[PATCH testsuite] tests/module_load/test: handle kernel lockdown correctlyQuoted 25 lines
Signed-off-by Sindhu Karri <[email protected]>--- tests/module_load/test | 38 ++++++++++++++++++++++++++++++++++---- 1 file changed, 34 insertions(+), 4 deletions(-)tests/module_load/test +12
-0@@ -25,10 +25,40 @@ BEGIN { plan tests => 17; } +# Read current lockdown mode +my $lockdown_mode; +if (open(my $fh, '<', '/sys/kernel/security/lockdown')) { + my $line = <$fh>; + close($fh); + + if ($line =~ /\[([^\]]+)\]/) { + $lockdown_mode = $1; + } else { + warn "Warning: Could not determine active lockdown mode, assuming lockdown mode is 'none'."; + $lockdown_mode = "none"; + }
Quoted 8 lines
tests/module_load/test BEGIN { · line 45
Quoted 6 lines
tests/module_load/test +6
-0+} else { + warn "Warning: Cannot read /sys/kernel/security/lockdown, assuming lockdown mode is 'none'."; + $lockdown_mode = "none"; +} + +print "Current lockdown mode: $lockdown_mode\n";Would remove this debugging output.
Also, please run perltidy on the test script and ensure that tools/check-syntax runs cleanly.
Quoted 48 lines
Quoted 48 lines
tests/module_load/test +16
-5+ +# In cases 1 and 5, +# In lockdown integrity mode, the expected error code is 129 i.e. Key is rejected by the service error +# In lockdown none mode, no error is expected. +$expected_pass = ($lockdown_mode eq 'none') ? 0 : 129; + +# In cases 4 and 8, +# In lockdown integrity mode, the expected error code is 129 i.e. Key is rejected by the service error +# In lockdown none mode, the error expected is 13 i.e. EACCES +$expected_fail = ($lockdown_mode eq 'none') ? 13 : 129; + + print "Test finit_module(2)\n"; $result = system "runcon -t test_kmodule_t $basedir/finit_load $v $basedir setest_module_request"; -ok( $result eq 0 ); +ok( $result >> 8 eq $expected_pass ); # Deny capability { sys_module } - EPERM $result = system@@ -43,12 +73,12 @@ ok( $result >> 8 eq 13 ); # Deny system { module_request } - EACCES $result = system "runcon -t test_kmodule_deny_module_request_t $basedir/finit_load $v $basedir setest_module_request 2>&1"; -ok( $result >> 8 eq 13 ); +ok( $result >> 8 eq $expected_fail ); print "Test init_module(2)\n"; $result = system "runcon -t test_kmodule_t $basedir/init_load $v $basedir setest_module_request"; -ok( $result eq 0 ); +ok( $result >> 8 eq $expected_pass ); # Deny capability { sys_module } - EPERM $result = system@@ -63,7 +93,7 @@ ok( $result >> 8 eq 13 ); # Deny system { module_request } - EACCES $result = system "runcon -t test_kmodule_deny_module_request_t $basedir/init_load $v $basedir setest_module_request 2>&1"; -ok( $result >> 8 eq 13 ); +ok( $result >> 8 eq $expected_fail ); SKIP: { skip( --2.33.8