Crypto library fixes for v6.16-rc3

The following changes since commit 19272b37aa4f83ca52bdf9c16d5d81bdd1354494:

Linux 6.16-rc1 (2025-06-08 13:44:43 -0700)

are available in the Git repository at:

https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git tags/libcrypto-for-linus

for you to fetch changes up to 9d4204a8106fe7dc80e3f2e440c8f2ba1ba47319:

lib/crypto/poly1305: Fix arm64's poly1305_blocks_arch() (2025-06-16 12:51:34 -0700)

----------------------------------------------------------------

- Fix a regression in the arm64 Poly1305 code

- Fix a couple compiler warnings

----------------------------------------------------------------
Eric Biggers (1):

      lib/crypto/poly1305: Fix arm64's poly1305_blocks_arch()

Kees Cook (1):
lib/crypto: Annotate crypto strings with nonstring

Nathan Chancellor (1):
lib/crypto/curve25519-hacl64: Disable KASAN with clang-17 and older

 arch/arm64/lib/crypto/poly1305-glue.c |  4 +--
 lib/crypto/Makefile                   |  4 +++
 lib/crypto/aescfb.c                   |  8 +++---
 lib/crypto/aesgcm.c                   | 46 +++++++++++++++++------------------
 4 files changed, 33 insertions(+), 29 deletions(-)

Quoted 14 lines · Eric Biggers

The following changes since commit 19272b37aa4f83ca52bdf9c16d5d81bdd1354494:

Linux 6.16-rc1 (2025-06-08 13:44:43 -0700)

are available in the Git repository at:

https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git tags/libcrypto-for-linus

for you to fetch changes up to 9d4204a8106fe7dc80e3f2e440c8f2ba1ba47319:

lib/crypto/poly1305: Fix arm64's poly1305_blocks_arch() (2025-06-16 12:51:34 -0700)

----------------------------------------------------------------

Quoted 1 line

- Fix a regression in the arm64 Poly1305 code

Some more tests too, perhaps? :)

This was a bit of a scary one, since poly1305 was returning an inconsistent result, not total garbage. Meaning most of the tests passed, but fortunately the migrate tests read data written by userspace with a different library.

Quoted 15 lines · Kent Overstreet

Quoted 14 lines · Eric Biggers

The following changes since commit 19272b37aa4f83ca52bdf9c16d5d81bdd1354494:

Linux 6.16-rc1 (2025-06-08 13:44:43 -0700)

are available in the Git repository at:

https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git tags/libcrypto-for-linus

for you to fetch changes up to 9d4204a8106fe7dc80e3f2e440c8f2ba1ba47319:

lib/crypto/poly1305: Fix arm64's poly1305_blocks_arch() (2025-06-16 12:51:34 -0700)

----------------------------------------------------------------

Quoted 8 lines

Quoted 1 line

- Fix a regression in the arm64 Poly1305 code

Some more tests too, perhaps? :)

This was a bit of a scary one, since poly1305 was returning an inconsistent result, not total garbage. Meaning most of the tests passed, but fortunately the migrate tests read data written by userspace with a different library.

Yep, I have a KUnit test for Poly1305 planned. Actually, I already wrote a preliminary one and used it to test this patch. I just haven't sent it out for review quite yet, since so far it's just a one-off test that isn't too complete, and I'm not satisfied with it quite yet. I'd like to reuse the hash-test-template.h I'm adding for SHA-2
(https://lore.kernel.org/linux-crypto/[email protected]/)
which would result in a more complete test. I'd also like to include tests for some of the overflow cases that are specific to Poly1305.

So we're kind of still in an early stage where we're defining what the KUnit testing for lib/crypto/ is going to look like. I am working on it, though!

Quoted 34 lines · Eric Biggers

Quoted 15 lines · Kent Overstreet

Quoted 14 lines · Eric Biggers

The following changes since commit 19272b37aa4f83ca52bdf9c16d5d81bdd1354494:

Linux 6.16-rc1 (2025-06-08 13:44:43 -0700)

are available in the Git repository at:

https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git tags/libcrypto-for-linus

for you to fetch changes up to 9d4204a8106fe7dc80e3f2e440c8f2ba1ba47319:

lib/crypto/poly1305: Fix arm64's poly1305_blocks_arch() (2025-06-16 12:51:34 -0700)

----------------------------------------------------------------

Quoted 8 lines

Quoted 1 line

- Fix a regression in the arm64 Poly1305 code

Some more tests too, perhaps? :)

This was a bit of a scary one, since poly1305 was returning an inconsistent result, not total garbage. Meaning most of the tests passed, but fortunately the migrate tests read data written by userspace with a different library.

Yep, I have a KUnit test for Poly1305 planned. Actually, I already wrote a preliminary one and used it to test this patch. I just haven't sent it out for review quite yet, since so far it's just a one-off test that isn't too complete, and I'm not satisfied with it quite yet. I'd like to reuse the hash-test-template.h I'm adding for SHA-2
(https://lore.kernel.org/linux-crypto/[email protected]/)
which would result in a more complete test. I'd also like to include tests for some of the overflow cases that are specific to Poly1305.

Quoted 2 lines

So we're kind of still in an early stage where we're defining what the KUnit testing for lib/crypto/ is going to look like. I am working on it, though!

I do a little dance any time someeone says something like that about testing. Bravo :)

(And now, back to sifting through the rest of the rc1 breakage.)