perf test: Add basic callgraph test to record testing
Ian Rogers
reviewerPATCH 1/1 perf test: Add basic callgraph test to record testing
Give some basic perf record callgraph coverage.
--- tools/perf/tests/shell/record.sh | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
tools/perf/tests/shell/record.sh +20 -0
@@ -12,8 +12,10 @@ shelldir=$(dirname "$0") . "${shelldir}"/lib/perf_has_symbol.sh testsym="test_loop" +testsym2="brstack" skip_test_missing_symbol ${testsym} +skip_test_missing_symbol ${testsym2} err=0 perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX)
@@ -359,6 +361,23 @@ test_precise_max() { fi } +test_callgraph() { + echo "Callgraph test" + if ! perf record -o "${perfdata}" -g perf test -w brstack + then + echo "Callgraph test [Failed missing output]" + err=1 + return + fi + if ! perf report -i "${perfdata}" 2>&1 | grep "${testsym2}" + then + echo "Callgraph test [Failed missing symbol]" + err=1 + return + fi + echo "Callgraph test [Success]" +} + # raise the limit of file descriptors to minimum if [[ $default_fd_limit -lt $min_fd_limit ]]; then ulimit -Sn $min_fd_limit
@@ -374,6 +393,7 @@ test_uid test_leader_sampling test_topdown_leader_sampling test_precise_max +test_callgraph # restore the default value ulimit -Sn $default_fd_limit
Signature · 1 line
2.50.0.rc2.701.gf1e915cc24-goog
James Clark
reviewerQuoted 23 lines · Ian Rogers
Give some basic perf record callgraph coverage.
Signed-off-by Ian Rogers <[email protected]>--- tools/perf/tests/shell/record.sh | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)tools/perf/tests/shell/record.sh +2
-0@@ -12,8 +12,10 @@ shelldir=$(dirname "$0") . "${shelldir}"/lib/perf_has_symbol.sh testsym="test_loop" +testsym2="brstack" skip_test_missing_symbol ${testsym} +skip_test_missing_symbol ${testsym2} err=0 perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX)
tools/perf/tests/shell/record.sh test_precise_max() { · line 366
Quoted 6 lines
tools/perf/tests/shell/record.sh +3
-0@@ -359,6 +361,23 @@ test_precise_max() { fi } +test_callgraph() { + echo "Callgraph test" + if ! perf record -o "${perfdata}" -g perf test -w brstack
Looking at 2dac1f089 ("perf test: Fix 'perf script' tests on s390"), it looks like this won't work there. Although I'm not sure why the fix wasn't to change the default -g mode to dwarf on s390 if fp doesn't work at all. That wouldn't fix -e cpu-clock being required though.
Thanks
James
Namhyung Kim
maintainerQuoted 25 lines · James Clark
Quoted 22 lines · Ian Rogers
Give some basic perf record callgraph coverage.
Signed-off-by Ian Rogers <[email protected]>--- tools/perf/tests/shell/record.sh | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)tools/perf/tests/shell/record.sh +2
-0@@ -12,8 +12,10 @@ shelldir=$(dirname "$0") . "${shelldir}"/lib/perf_has_symbol.sh testsym="test_loop" +testsym2="brstack" skip_test_missing_symbol ${testsym} +skip_test_missing_symbol ${testsym2} err=0 perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX)@@ -359,6 +361,23 @@ test_precise_max() { fi }
Quoted 8 lines
tools/perf/tests/shell/record.sh test_precise_max() { · line 366
Quoted 3 lines
tools/perf/tests/shell/record.sh +3
-0+test_callgraph() { + echo "Callgraph test" + if ! perf record -o "${perfdata}" -g perf test -w brstackLooking at
2dac1f089("perf test: Fix 'perf script' tests on s390"), it looks like this won't work there. Although I'm not sure why the fix wasn't to change the default -g mode to dwarf on s390 if fp doesn't work at all. That wouldn't fix -e cpu-clock being required though.
Maybe we can add a new 'perf check callchain' subcommand to check the relevant information and display and/or verify them properly.
Thanks,
Namhyung