mm: add gpu active/reclaim per-node stat counters (v2)
Subsystems (10)
Dave Airlie
maintainerPATCH 1/2 mm: add gpu active/reclaim per-node stat counters (v2)
From: Dave Airlie <[email protected]>
While discussing memcg intergration with gpu memory allocations, it was pointed out that there was no numa/system counters for GPU memory allocations.
With more integrated memory GPU server systems turning up, and more requirements for memory tracking it seems we should start closing the gap.
Add two counters to track GPU per-node system memory allocations.
The first is currently allocated to GPU objects, and the second is for memory that is stored in GPU page pools that can be reclaimed, by the shrinker.
---
v2: add more info to the documentation on this memory.
I'd like to get acks to merge this via the drm tree, if possible,
Dave.
--- Documentation/filesystems/proc.rst | 8 ++++++++ drivers/base/node.c | 5 +++++ fs/proc/meminfo.c | 6 ++++++ include/linux/mmzone.h | 2 ++ mm/show_mem.c | 9 +++++++-- mm/vmstat.c | 2 ++ 6 files changed, 30 insertions(+), 2 deletions(-)
Documentation/filesystems/proc.rst +8 -0
@@ -1095,6 +1095,8 @@ Example output. You may not have all of these fields. CmaFree: 0 kB Unaccepted: 0 kB Balloon: 0 kB + GPUActive: 0 kB + GPUReclaim: 0 kB HugePages_Total: 0 HugePages_Free: 0 HugePages_Rsvd: 0
@@ -1273,6 +1275,12 @@ Unaccepted Memory that has not been accepted by the guest Balloon Memory returned to Host by VM Balloon Drivers +GPUActive + System memory allocated to active GPU objects +GPUReclaim + System memory stored in GPU pools for reuse. This memory is not + counted in GPUActive. It is shrinker reclaimable memory kept in a reuse + pool because it has non-standard page table attributes, like WC or UC. HugePages_Total, HugePages_Free, HugePages_Rsvd, HugePages_Surp, Hugepagesize, Hugetlb See Documentation/admin-guide/mm/hugetlbpage.rst. DirectMap4k, DirectMap2M, DirectMap1G
drivers/base/node.c +5 -0
@@ -463,6 +463,8 @@ static ssize_t node_read_meminfo(struct device *dev,#ifdef CONFIG_UNACCEPTED_MEMORY "Node %d Unaccepted: %8lu kB\n" #endif +"Node %d GPUActive: %8lu kB\n" +"Node %d GPUReclaim: %8lu kB\n" , nid,K (node_page_state (pgdat,NR_FILE_DIRTY )), nid, K(node_page_state(pgdat, NR_WRITEBACK)),
@@ -496,6 +498,9 @@ static ssize_t node_read_meminfo(struct device *dev, , nid,K (sum_zone_node_page_state (nid,NR_UNACCEPTED )) #endif + , + nid,K (node_page_state (pgdat,NR_GPU_ACTIVE )), + nid,K (node_page_state (pgdat,NR_GPU_RECLAIM )) ); len +=hugetlb_report_node_meminfo (buf, len, nid);return len;
fs/proc/meminfo.c +6 -0
@@ -164,6 +164,12 @@ static int meminfo_proc_show(struct seq_file *m, void *v)show_val_kb (m,"Balloon: " ,global_node_page_state (NR_BALLOON_PAGES )); +show_val_kb (m,"GPUActive: " , +global_node_page_state (NR_GPU_ACTIVE )); + +show_val_kb (m,"GPUReclaim: " , +global_node_page_state (NR_GPU_RECLAIM )); +hugetlb_report_meminfo (m);arch_report_meminfo (m);
include/linux/mmzone.h +2 -0
@@ -241,6 +241,8 @@ enum node_stat_item {NR_HUGETLB , #endifNR_BALLOON_PAGES , +NR_GPU_ACTIVE ,/* GPU pages assigned to an object */ +NR_GPU_RECLAIM ,/* GPU pages in shrinkable pools */ NR_VM_NODE_STAT_ITEMS };
mm/show_mem.c +7 -2
@@ -255,7 +255,9 @@ static void show_free_areas(unsigned int filter, nodemask_t *nodemask, int max_z" sec_pagetables:%lukB" " all_unreclaimable? %s" " Balloon:%lukB" -"\n" , +" gpu_active:%lukB" +" gpu_reclaim:%lukB" +"\n" , pgdat->node_id,K (node_page_state (pgdat,NR_ACTIVE_ANON )), K(node_page_state(pgdat, NR_INACTIVE_ANON)),
@@ -281,7 +283,10 @@ static void show_free_areas(unsigned int filter, nodemask_t *nodemask, int max_zK (node_page_state (pgdat,NR_PAGETABLE )),K (node_page_state (pgdat,NR_SECONDARY_PAGETABLE )),str_yes_no (pgdat->kswapd_failures >=MAX_RECLAIM_RETRIES ), - K(node_page_state(pgdat, NR_BALLOON_PAGES))); +K (node_page_state (pgdat,NR_BALLOON_PAGES )), +K (node_page_state (pgdat,NR_GPU_ACTIVE )), + K(node_page_state(pgdat, NR_GPU_RECLAIM))); + }for_each_populated_zone (zone) {
mm/vmstat.c +2 -0
@@ -1281,6 +1281,8 @@ const char * const vmstat_text[] = {"nr_hugetlb" , #endif"nr_balloon_pages" , +"nr_gpu_active" , +"nr_gpu_reclaim" ,/* system-wide enum vm_stat_item counters */ "nr_dirty_threshold" , "nr_dirty_background_threshold",
Signature · 1 line
2.49.0
Dave Airlie
maintainerPATCH 2/2 drm/ttm: use gpu mm stats to track gpu memory allocations.
From: Dave Airlie <[email protected]>
This uses the newly introduced per-node gpu tracking stats, to track GPU memory allocated via TTM and reclaimable memory in the TTM page pools.
These stats will be useful later for system information and later when mem cgroups are integrated.
--- drivers/gpu/drm/ttm/ttm_pool.c | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-)
drivers/gpu/drm/ttm/ttm_pool.c +21 -1
@@ -130,6 +130,16 @@ static struct list_head shrinker_list;static struct shrinker *mm_shrinker;static DECLARE_RWSEM (pool_shrink_rwsem); +/* helper to get a current valid node id from a pool */ +static int ttm_pool_nid (struct ttm_pool *pool) { +int nid =NUMA_NO_NODE ; +if (pool) + nid = pool->nid; +if (nid ==NUMA_NO_NODE ) + nid =numa_node_id (); +return nid; +} +/* Allocate pages of size 1 << order with the given gfp_flags */ static struct page *ttm_pool_alloc_page (struct ttm_pool *pool,gfp_t gfp_flags,unsigned int order)
@@ -149,8 +159,10 @@ static struct page *ttm_pool_alloc_page(struct ttm_pool *pool, gfp_t gfp_flags,if (!pool->use_dma_alloc) { p =alloc_pages_node (pool->nid, gfp_flags, order); -if (p) +if (p) { p->private = order; +mod_node_page_state (NODE_DATA (ttm_pool_nid (pool)),NR_GPU_ACTIVE , (1 << order)); + }return p; }
@@ -201,6 +213,7 @@ static void ttm_pool_free_page(struct ttm_pool *pool, enum ttm_caching caching,if (!pool || !pool->use_dma_alloc) {__free_pages (p, order); +mod_node_page_state (NODE_DATA (ttm_pool_nid (pool)),NR_GPU_ACTIVE , -(1 << order));return ; }
@@ -275,6 +288,7 @@ static void ttm_pool_unmap(struct ttm_pool *pool, dma_addr_t dma_addr,static void ttm_pool_type_give (struct ttm_pool_type *pt,struct page *p) {unsigned int i, num_pages =1 << pt->order; +int nid =ttm_pool_nid (pt->pool);for (i =0 ; i < num_pages; ++i) {if (PageHighMem (p))
@@ -287,17 +301,23 @@ static void ttm_pool_type_give(struct ttm_pool_type *pt, struct page *p)list_add (&p->lru, &pt->pages);spin_unlock (&pt->lock);atomic_long_add (1 << pt->order, &allocated_pages); + +mod_node_page_state (NODE_DATA (nid),NR_GPU_ACTIVE , -(1 << pt->order)); +mod_node_page_state (NODE_DATA (nid),NR_GPU_RECLAIM , (1 << pt->order)); }/* Take pages from a specific pool_type, return NULL when nothing available */ static struct page *ttm_pool_type_take (struct ttm_pool_type *pt) {struct page *p; +int nid =ttm_pool_nid (pt->pool);spin_lock (&pt->lock); p =list_first_entry_or_null (&pt->pages,typeof (*p), lru);if (p) {atomic_long_sub (1 << pt->order, &allocated_pages); +mod_node_page_state (NODE_DATA (nid),NR_GPU_ACTIVE , (1 << pt->order)); +mod_node_page_state (NODE_DATA (nid),NR_GPU_RECLAIM , -(1 << pt->order));list_del (&p->lru); }spin_unlock (&pt->lock);
Signature · 1 line
2.49.0
Quoted 9 lines · On Thu, 19 Jun 2025 17:20:25 +1000 Dave Airlie <[email protected]> wrote:
While discussing memcg intergration with gpu memory allocations, it was pointed out that there was no numa/system counters for GPU memory allocations.
With more integrated memory GPU server systems turning up, and more requirements for memory tracking it seems we should start closing the gap.
Quoted 6 lines
Add two counters to track GPU per-node system memory allocations.
The first is currently allocated to GPU objects, and the second is for memory that is stored in GPU page pools that can be reclaimed, by the shrinker.
Zi Yan
reviewerQuoted 39 lines · Dave Airlie
From: Dave Airlie <[email protected]>
While discussing memcg intergration with gpu memory allocations, it was pointed out that there was no numa/system counters for GPU memory allocations.
With more integrated memory GPU server systems turning up, and more requirements for memory tracking it seems we should start closing the gap.
Add two counters to track GPU per-node system memory allocations.
The first is currently allocated to GPU objects, and the second is for memory that is stored in GPU page pools that can be reclaimed, by the shrinker.
Cc Christian Koenig <[email protected]>Cc Matthew Brost <[email protected]>Cc Johannes Weiner <[email protected]>Cc Andrew Morton <[email protected]>Signed-off-by Dave Airlie <[email protected]>---
v2: add more info to the documentation on this memory.
I'd like to get acks to merge this via the drm tree, if possible,
Dave.
--- Documentation/filesystems/proc.rst | 8 ++++++++ drivers/base/node.c | 5 +++++ fs/proc/meminfo.c | 6 ++++++ include/linux/mmzone.h | 2 ++ mm/show_mem.c | 9 +++++++-- mm/vmstat.c | 2 ++ 6 files changed, 30 insertions(+), 2 deletions(-)
<snip>
include/linux/mmzone.h enum node_stat_item { · line 245
Quoted 10 lines
include/linux/mmzone.h +2
-0@@ -241,6 +241,8 @@ enum node_stat_item {NR_HUGETLB , #endifNR_BALLOON_PAGES , +NR_GPU_ACTIVE ,/* GPU pages assigned to an object */ + NR_GPU_RECLAIM, /* GPU pages in shrinkable pools */
"GPU pages" seems confusing. These are not pages from GPU memory, right? Would the comments below sound better?
/* Pages assigned to a GPU object */
/* Pages in shrinkable GPU pools */
Otherwise, Acked-by: Zi Yan <[email protected]>
--
Best Regards,
Yan, Zi
Quoted 16 lines · Dave Airlie
From: Dave Airlie <[email protected]>
While discussing memcg intergration with gpu memory allocations, it was pointed out that there was no numa/system counters for GPU memory allocations.
With more integrated memory GPU server systems turning up, and more requirements for memory tracking it seems we should start closing the gap.
Add two counters to track GPU per-node system memory allocations.
The first is currently allocated to GPU objects, and the second is for memory that is stored in GPU page pools that can be reclaimed, by the shrinker.
Quoted 6 lines
Cc Christian Koenig <[email protected]>Cc Matthew Brost <[email protected]>Cc Johannes Weiner <[email protected]>Cc Andrew Morton <[email protected]>Signed-off-by Dave Airlie <[email protected]>
With Zi's suggestion, you can add:
Quoted 44 lines · Dave Airlie
From: Dave Airlie <[email protected]>
While discussing memcg intergration with gpu memory allocations, it was pointed out that there was no numa/system counters for GPU memory allocations.
With more integrated memory GPU server systems turning up, and more requirements for memory tracking it seems we should start closing the gap.
Add two counters to track GPU per-node system memory allocations.
The first is currently allocated to GPU objects, and the second is for memory that is stored in GPU page pools that can be reclaimed, by the shrinker.
Cc Christian Koenig <[email protected]>Cc Matthew Brost <[email protected]>Cc Johannes Weiner <[email protected]>Cc Andrew Morton <[email protected]>Signed-off-by Dave Airlie <[email protected]>---
v2: add more info to the documentation on this memory.
I'd like to get acks to merge this via the drm tree, if possible,
Dave.
--- Documentation/filesystems/proc.rst | 8 ++++++++ drivers/base/node.c | 5 +++++ fs/proc/meminfo.c | 6 ++++++ include/linux/mmzone.h | 2 ++ mm/show_mem.c | 9 +++++++-- mm/vmstat.c | 2 ++ 6 files changed, 30 insertions(+), 2 deletions(-)Documentation/filesystems/proc.rst +0
-0
Documentation/filesystems/proc.rst Example output. You may not have all of these fields. · line 1099
Quoted 5 lines
Documentation/filesystems/proc.rst +2
-0@@ -1095,6 +1095,8 @@ Example output. You may not have all of these fields. CmaFree: 0 kB Unaccepted: 0 kB Balloon: 0 kB + GPUActive: 0 kB + GPUReclaim: 0 kB
Active certainly makes sense, but I think we should rather disable the pool on newer CPUs than adding reclaimable memory here.
Regards,
Christian.
Quoted 109 lines
Documentation/filesystems/proc.rst +6
-0HugePages_Total: 0 HugePages_Free: 0 HugePages_Rsvd: 0@@ -1273,6 +1275,12 @@ Unaccepted Memory that has not been accepted by the guest Balloon Memory returned to Host by VM Balloon Drivers +GPUActive + System memory allocated to active GPU objects +GPUReclaim + System memory stored in GPU pools for reuse. This memory is not + counted in GPUActive. It is shrinker reclaimable memory kept in a reuse + pool because it has non-standard page table attributes, like WC or UC. HugePages_Total, HugePages_Free, HugePages_Rsvd, HugePages_Surp, Hugepagesize, Hugetlb See Documentation/admin-guide/mm/hugetlbpage.rst. DirectMap4k, DirectMap2M, DirectMap1Gdrivers/base/node.c +5
-0@@ -463,6 +463,8 @@ static ssize_t node_read_meminfo(struct device *dev,#ifdef CONFIG_UNACCEPTED_MEMORY "Node %d Unaccepted: %8lu kB\n" #endif +"Node %d GPUActive: %8lu kB\n" +"Node %d GPUReclaim: %8lu kB\n" , nid,K (node_page_state (pgdat,NR_FILE_DIRTY )), nid, K(node_page_state(pgdat, NR_WRITEBACK)),@@ -496,6 +498,9 @@ static ssize_t node_read_meminfo(struct device *dev, , nid,K (sum_zone_node_page_state (nid,NR_UNACCEPTED )) #endif + , + nid,K (node_page_state (pgdat,NR_GPU_ACTIVE )), + nid,K (node_page_state (pgdat,NR_GPU_RECLAIM )) ); len +=hugetlb_report_node_meminfo (buf, len, nid);return len;fs/proc/meminfo.c +6
-0@@ -164,6 +164,12 @@ static int meminfo_proc_show(struct seq_file *m, void *v)show_val_kb (m,"Balloon: " ,global_node_page_state (NR_BALLOON_PAGES )); +show_val_kb (m,"GPUActive: " , +global_node_page_state (NR_GPU_ACTIVE )); + +show_val_kb (m,"GPUReclaim: " , +global_node_page_state (NR_GPU_RECLAIM )); +hugetlb_report_meminfo (m);arch_report_meminfo (m);include/linux/mmzone.h +2
-0@@ -241,6 +241,8 @@ enum node_stat_item {NR_HUGETLB , #endifNR_BALLOON_PAGES , +NR_GPU_ACTIVE ,/* GPU pages assigned to an object */ +NR_GPU_RECLAIM ,/* GPU pages in shrinkable pools */ NR_VM_NODE_STAT_ITEMS };mm/show_mem.c +7
-2@@ -255,7 +255,9 @@ static void show_free_areas(unsigned int filter, nodemask_t *nodemask, int max_z" sec_pagetables:%lukB" " all_unreclaimable? %s" " Balloon:%lukB" -"\n" , +" gpu_active:%lukB" +" gpu_reclaim:%lukB" +"\n" , pgdat->node_id,K (node_page_state (pgdat,NR_ACTIVE_ANON )), K(node_page_state(pgdat, NR_INACTIVE_ANON)),@@ -281,7 +283,10 @@ static void show_free_areas(unsigned int filter, nodemask_t *nodemask, int max_zK (node_page_state (pgdat,NR_PAGETABLE )),K (node_page_state (pgdat,NR_SECONDARY_PAGETABLE )),str_yes_no (pgdat->kswapd_failures >=MAX_RECLAIM_RETRIES ), - K(node_page_state(pgdat, NR_BALLOON_PAGES))); +K (node_page_state (pgdat,NR_BALLOON_PAGES )), +K (node_page_state (pgdat,NR_GPU_ACTIVE )), + K(node_page_state(pgdat, NR_GPU_RECLAIM))); + }for_each_populated_zone (zone) {mm/vmstat.c +2
-0@@ -1281,6 +1281,8 @@ const char * const vmstat_text[] = {"nr_hugetlb" , #endif"nr_balloon_pages" , +"nr_gpu_active" , +"nr_gpu_reclaim" ,/* system-wide enum vm_stat_item counters */ "nr_dirty_threshold" , "nr_dirty_background_threshold",
Quoted 41 lines · Christian König
Quoted 39 lines · Dave Airlie
From: Dave Airlie <[email protected]>
While discussing memcg intergration with gpu memory allocations, it was pointed out that there was no numa/system counters for GPU memory allocations.
With more integrated memory GPU server systems turning up, and more requirements for memory tracking it seems we should start closing the gap.
Add two counters to track GPU per-node system memory allocations.
The first is currently allocated to GPU objects, and the second is for memory that is stored in GPU page pools that can be reclaimed, by the shrinker.
Cc Christian Koenig <[email protected]>Cc Matthew Brost <[email protected]>Cc Johannes Weiner <[email protected]>Cc Andrew Morton <[email protected]>Signed-off-by Dave Airlie <[email protected]>---
v2: add more info to the documentation on this memory.
I'd like to get acks to merge this via the drm tree, if possible,
Dave.
--- Documentation/filesystems/proc.rst | 8 ++++++++ drivers/base/node.c | 5 +++++ fs/proc/meminfo.c | 6 ++++++ include/linux/mmzone.h | 2 ++ mm/show_mem.c | 9 +++++++-- mm/vmstat.c | 2 ++ 6 files changed, 30 insertions(+), 2 deletions(-)
Quoted 12 lines
Documentation/filesystems/proc.rst Example output. You may not have all of these fields. · line 1099
Quoted 10 lines
Documentation/filesystems/proc.rst +2
-0@@ -1095,6 +1095,8 @@ Example output. You may not have all of these fields. CmaFree: 0 kB Unaccepted: 0 kB Balloon: 0 kB + GPUActive: 0 kB + GPUReclaim: 0 kBActive certainly makes sense, but I think we should rather disable the pool on newer CPUs than adding reclaimable memory here.
I'm not just concerned about newer platforms though, even on Fedora 42 on my test ryzen1+7900xt machine, with a desktop session running
nr_gpu_active 7473nr_gpu_reclaim 6656
It's not an insignificant amount of memory. I also think if we get to some sort of discardable GTT objects with a shrinker they should probably be accounted in reclaim.
Dave.
Quoted 56 lines · David Airlie
Quoted 41 lines · Christian König
Quoted 39 lines · Dave Airlie
From: Dave Airlie <[email protected]>
While discussing memcg intergration with gpu memory allocations, it was pointed out that there was no numa/system counters for GPU memory allocations.
With more integrated memory GPU server systems turning up, and more requirements for memory tracking it seems we should start closing the gap.
Add two counters to track GPU per-node system memory allocations.
The first is currently allocated to GPU objects, and the second is for memory that is stored in GPU page pools that can be reclaimed, by the shrinker.
Cc Christian Koenig <[email protected]>Cc Matthew Brost <[email protected]>Cc Johannes Weiner <[email protected]>Cc Andrew Morton <[email protected]>Signed-off-by Dave Airlie <[email protected]>---
v2: add more info to the documentation on this memory.
I'd like to get acks to merge this via the drm tree, if possible,
Dave.
--- Documentation/filesystems/proc.rst | 8 ++++++++ drivers/base/node.c | 5 +++++ fs/proc/meminfo.c | 6 ++++++ include/linux/mmzone.h | 2 ++ mm/show_mem.c | 9 +++++++-- mm/vmstat.c | 2 ++ 6 files changed, 30 insertions(+), 2 deletions(-)Quoted 12 lines
Documentation/filesystems/proc.rst Example output. You may not have all of these fields. · line 1099
Quoted 10 lines
Documentation/filesystems/proc.rst +2
-0@@ -1095,6 +1095,8 @@ Example output. You may not have all of these fields. CmaFree: 0 kB Unaccepted: 0 kB Balloon: 0 kB + GPUActive: 0 kB + GPUReclaim: 0 kBActive certainly makes sense, but I think we should rather disable the pool on newer CPUs than adding reclaimable memory here.
Quoted 7 lines
I'm not just concerned about newer platforms though, even on Fedora 42 on my test ryzen1+7900xt machine, with a desktop session running
nr_gpu_active7473nr_gpu_reclaim6656It's not an insignificant amount of memory.
That was not what I meant, that you have quite a bunch of memory allocated to the GPU is correct.
But the problem is more that we used the pool for way to many thinks which is actually not necessary.
But granted this is orthogonal to that patch here.
Quoted 3 lines
I also think if we get to
some sort of discardable GTT objects with a shrinker they should probably be accounted in reclaim.
The problem is that this is extremely driver specific.
On amdgpu we have some temporary buffers which can be reclaimed immediately, but the really big chunk is for example what XE does with it's shrinker.
See Thomas TTM patches from a few month ago. If memory is active or reclaimable does not depend on how it is allocated, but on how it is used.
So the accounting need to be at the driver level if you really want to distinct between the two states.
Christian.
Quoted 3 lines
Dave.
Quoted 64 lines · Christian König
Quoted 62 lines · David Airlie
Quoted 41 lines · Christian König
Quoted 39 lines · Dave Airlie
From: Dave Airlie <[email protected]>
While discussing memcg intergration with gpu memory allocations, it was pointed out that there was no numa/system counters for GPU memory allocations.
With more integrated memory GPU server systems turning up, and more requirements for memory tracking it seems we should start closing the gap.
Add two counters to track GPU per-node system memory allocations.
The first is currently allocated to GPU objects, and the second is for memory that is stored in GPU page pools that can be reclaimed, by the shrinker.
Cc Christian Koenig <[email protected]>Cc Matthew Brost <[email protected]>Cc Johannes Weiner <[email protected]>Cc Andrew Morton <[email protected]>Signed-off-by Dave Airlie <[email protected]>---
v2: add more info to the documentation on this memory.
I'd like to get acks to merge this via the drm tree, if possible,
Dave.
--- Documentation/filesystems/proc.rst | 8 ++++++++ drivers/base/node.c | 5 +++++ fs/proc/meminfo.c | 6 ++++++ include/linux/mmzone.h | 2 ++ mm/show_mem.c | 9 +++++++-- mm/vmstat.c | 2 ++ 6 files changed, 30 insertions(+), 2 deletions(-)Quoted 12 lines
Documentation/filesystems/proc.rst Example output. You may not have all of these fields. · line 1099
Quoted 10 lines
Documentation/filesystems/proc.rst +2
-0@@ -1095,6 +1095,8 @@ Example output. You may not have all of these fields. CmaFree: 0 kB Unaccepted: 0 kB Balloon: 0 kB + GPUActive: 0 kB + GPUReclaim: 0 kBActive certainly makes sense, but I think we should rather disable the pool on newer CPUs than adding reclaimable memory here.
I'm not just concerned about newer platforms though, even on Fedora 42 on my test ryzen1+7900xt machine, with a desktop session running
nr_gpu_active7473nr_gpu_reclaim6656
Quoted 7 lines
Quoted 1 line
It's not an insignificant amount of memory.
That was not what I meant, that you have quite a bunch of memory allocated to the GPU is correct.
But the problem is more that we used the pool for way to many thinks which is actually not necessary.
But granted this is orthogonal to that patch here.
At least here this is all WC allocations, probably from userspace, so it feels like we are using it correctly, since we stopped pooling cached pages.
Quoted 5 lines
Quoted 4 lines
I also think if we get to
some sort of discardable GTT objects with a shrinker they should probably be accounted in reclaim.
Quoted 7 lines
The problem is that this is extremely driver specific.
On amdgpu we have some temporary buffers which can be reclaimed immediately, but the really big chunk is for example what XE does with it's shrinker.
See Thomas TTM patches from a few month ago. If memory is active or reclaimable does not depend on how it is allocated, but on how it is used.
So the accounting need to be at the driver level if you really want to distinct between the two states.
How the counters are used is fine to be done at the driver level on top of this, though I think for discardable there is grounds for ttm_tt having a discardable flag once we see a couple of drivers using it, and then maybe the counters could be moved, but it's also fine to use these counters in drivers outside TTM if they are done appropriately, just so we can see the memory allocations as part of the big picture.
Dave.
Quoted 23 lines · David Airlie
Quoted 23 lines
Quoted 13 lines
Quoted 4 lines
Quoted 4 lines
Documentation/filesystems/proc.rst +0
-0Quoted 8 lines
Documentation/filesystems/proc.rst Example output. You may not have all of these fields. · line 1099
Quoted 6 lines
Documentation/filesystems/proc.rst +2
-0@@ -1095,6 +1095,8 @@ Example output. You may not have all of these fields. CmaFree: 0 kB Unaccepted: 0 kB Balloon: 0 kB + GPUActive: 0 kB + GPUReclaim: 0 kBActive certainly makes sense, but I think we should rather disable the pool on newer CPUs than adding reclaimable memory here.
Quoted 7 lines
I'm not just concerned about newer platforms though, even on Fedora 42 on my test ryzen1+7900xt machine, with a desktop session running
nr_gpu_active7473nr_gpu_reclaim6656It's not an insignificant amount of memory.
That was not what I meant, that you have quite a bunch of memory allocated to the GPU is correct.
Quoted 7 lines
Quoted 3 lines
But the problem is more that we used the pool for way to many thinks which is actually not necessary.
But granted this is orthogonal to that patch here.
At least here this is all WC allocations, probably from userspace, so it feels like we are using it correctly, since we stopped pooling cached pages.
Well what the kernel does is technically correct, it's just that userspace wants to use WC because ~15 years ago that was state of the art.
On today's HW using WC has not the benefit it used to have, but the kernel still has to deal with all the complexity and overhead....
Just ignoring the WC flag when userspace sets it and only setting it when the kernel finds that it is necessary would still be technically correct.
Quoted 6 lines
Quoted 6 lines
Quoted 3 lines
I also think if we get to
some sort of discardable GTT objects with a shrinker they should probably be accounted in reclaim.The problem is that this is extremely driver specific.
Quoted 8 lines
Quoted 5 lines
On amdgpu we have some temporary buffers which can be reclaimed immediately, but the really big chunk is for example what XE does with it's shrinker.
See Thomas TTM patches from a few month ago. If memory is active or reclaimable does not depend on how it is allocated, but on how it is used.
So the accounting need to be at the driver level if you really want to distinct between the two states.
How the counters are used is fine to be done at the driver level on top of this
But then you have double accounting. E.g. the allocation backend says that this memory is GpuActive and the driver says that it is GpuReclaim.
Maybe making GpuReclaim a subset of GpuActive isn't such a bad idea? Alternatively the driver could decrease GpuActive in favor of increasing GpuReclaim when it has a separate shrinker.
Quoted 3 lines
, though I think for discardable there is grounds for
ttm_tthaving a discardable flag once we see a couple of drivers using it, and then maybe the counters could be moved,
Well it is certainly a good idea to have a discard able flag in TTM, but it isn't used that often and the last time this was brought up it was abandoned as to much work for to little gain.
Quoted 4 lines
but it's also fine to
use these counters in drivers outside TTM if they are done appropriately, just so we can see the memory allocations as part of the big picture.
Yeah, that is what I'm worrying about. In drivers we need to be super careful with that to not come up with incorrect numbers.
Christian.
Quoted 3 lines
Dave.