Skip to contentSkip to conversation

scsi: sysfs: replace scnprintf() with sysfs_emit() in sdev_show_blacklist()

PATCH In review Shankari Anand 3 participants 4 messages Jun 20, 2025 – Jul 2, 2025 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: sysfs: replace scnprintf() with sysfs_emit() in sdev_show_blacklist()

Documentation/filesystems/sysfs.rst mentions that show() should only use sysfs_emit() or sysfs_emit_at() when formating the value to be returned to user space. So replace scnprintf() with sysfs_emit().

---
 drivers/scsi/scsi_sysfs.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/scsi/scsi_sysfs.c +3 -3
index d772258e29ad..074b02e4cf9e 100644
@@ -1095,14 +1095,14 @@ sdev_show_blacklist(struct device *dev, struct device_attribute *attr,
 			name = sdev_bflags_name[i];
 
 		if (name)
-			len += scnprintf(buf + len, PAGE_SIZE - len,
+			len += sysfs_emit(buf + len,
 					 "%s%s", len ? " " : "", name);
 		else
-			len += scnprintf(buf + len, PAGE_SIZE - len,
+			len += sysfs_emit(buf + len,
 					 "%sINVALID_BIT(%d)", len ? " " : "", i);
 	}
 	if (len)
-		len += scnprintf(buf + len, PAGE_SIZE - len, "\n");
+		len += sysfs_emit(buf + len, "\n");
 	return len;
 }
 static DEVICE_ATTR(blacklist, S_IRUGO, sdev_show_blacklist, NULL);
Signature · 1 line
2.34.1
#1 lore raw

Hi,
I wanted to kindly follow up and ask if this patch could be picked up for review. Please let me know if there’s anything I should revise Thanks!

Quoted 35 lines · Shankari Anand

Documentation/filesystems/sysfs.rst mentions that show() should only use sysfs_emit() or sysfs_emit_at() when formating the value to be returned to user space. So replace scnprintf() with sysfs_emit().

---
 drivers/scsi/scsi_sysfs.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/scsi/scsi_sysfs.c +3 -4
index d772258e29ad..074b02e4cf9e 100644
@@ -1095,14 +1095,14 @@ sdev_show_blacklist(struct device *dev, struct device_attribute *attr,
                        name = sdev_bflags_name[i];
 
                if (name)
-                       len += scnprintf(buf + len, PAGE_SIZE - len,
+                       len += sysfs_emit(buf + len,
                                         "%s%s", len ? " " : "", name);
                else
-                       len += scnprintf(buf + len, PAGE_SIZE - len,
+                       len += sysfs_emit(buf + len,
                                         "%sINVALID_BIT(%d)", len ? " " : "", i);
        }
        if (len)
-               len += scnprintf(buf + len, PAGE_SIZE - len, "\n");
+               len += sysfs_emit(buf + len, "\n");
        return len;
 }
 static DEVICE_ATTR(blacklist, S_IRUGO, sdev_show_blacklist, NULL);
--

2.34.1

#2 lore raw
In reply to Shankari Anand
Quoted 21 lines · Shankari Anand

Documentation/filesystems/sysfs.rst mentions that show() should only use sysfs_emit() or sysfs_emit_at() when formating the value to be returned to user space. So replace scnprintf() with sysfs_emit().

---
  drivers/scsi/scsi_sysfs.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
drivers/scsi/scsi_sysfs.c +1 -1
index d772258e29ad..074b02e4cf9e 100644
@@ -1095,14 +1095,14 @@ sdev_show_blacklist(struct device *dev, struct device_attribute *attr,
  			name = sdev_bflags_name[i];
 
  		if (name)
-			len += scnprintf(buf + len, PAGE_SIZE - len,
+			len += sysfs_emit(buf + len,
  					 "%s%s", len ? " " : "", name);
  		else

drivers/scsi/scsi_sysfs.c sdev_show_blacklist(struct device *dev, struct device_attribute *attr, · line 1108

Quoted 10 lines
drivers/scsi/scsi_sysfs.c +2 -2
-			len += scnprintf(buf + len, PAGE_SIZE - len,
+			len += sysfs_emit(buf + len,
  					 "%sINVALID_BIT(%d)", len ? " " : "", i);
  	}
  	if (len)
-		len += scnprintf(buf + len, PAGE_SIZE - len, "\n");
+		len += sysfs_emit(buf + len, "\n");
  	return len;
  }
  static DEVICE_ATTR(blacklist, S_IRUGO, sdev_show_blacklist, NULL);

This patch changes correct code into broken code. Hence, to the SCSI maintainer, please do *not* apply this patch.

Bart.

#3 lore raw
In reply to Shankari Anand
kernel test robot noticed "blktests.scsi/005.fail" on:

Hello,

kernel test robot noticed "blktests.scsi/005.fail" on:

commit: 2f688d0bc23ecf97b4f5255343dc891b196d1360 ("[PATCH] scsi: sysfs: replace scnprintf() with sysfs_emit() in sdev_show_blacklist()")
url: https://github.com/intel-lab-lkp/linux/commits/Shankari-Anand/scsi-sysfs-replace-scnprintf-with-sysfs_emit-in-sdev_show_blacklist/20250620-190212
base: https://git.kernel.org/cgit/linux/kernel/git/jejb/scsi.git for-next
patch link: https://lore.kernel.org/all/[email protected]/
patch subject: [PATCH] scsi: sysfs: replace scnprintf() with sysfs_emit() in sdev_show_blacklist()

in testcase: blktests
version: blktests-x86_64-55d3d61-1_20250617
with following parameters:

	disk: 1HDD
	test: scsi-005

config: x86_64-rhel-9.4-func
compiler: gcc-12
test machine: 4 threads Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz (Skylake) with 32G memory

(please refer to attached dmesg/kmsg for entire log/backtrace)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-lkp/[email protected]

2025-06-30 16:29:51 echo scsi/005
2025-06-30 16:29:51 ./check scsi/005
scsi/005 (test SCSI device blacklisting)                    
scsi/005 (test SCSI device blacklisting)                     [failed]
    runtime    ...  6.188s
    --- tests/scsi/005.out	2025-06-17 17:08:29.000000000 +0000
    +++ /lkp/benchmarks/blktests/results/nodev/scsi/005.out.bad	2025-06-30 16:29:58.087863341 +0000
    @@ -1,7 +1,7 @@
     Running scsi/005
                               
     AAAAAAAA BBBBBBBBBBBBBBBB 
    -HITACHI  OPEN-V           REPORTLUN2 TRY_VPD_PAGES
    +HITACHI  OPEN-V           REPORTLUN2
              Scanner          NOLUN
     Inateck                   
    ...
    (Run 'diff -u tests/scsi/005.out /lkp/benchmarks/blktests/results/nodev/scsi/005.out.bad' to see the entire diff)

The kernel config and materials to reproduce are available at:
https://download.01.org/0day-ci/archive/20250702/[email protected]

Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki