leds: trigger: ledtrig-cpu:: enforce NR_CPUS limit in Kconfig
PATCH 1/1 leds: trigger: ledtrig-cpu:: enforce NR_CPUS limit in Kconfig
From: Arnd Bergmann <[email protected]>
This driver fails build testing with larger values of CONFIG_NR_CPUS:
drivers/leds/trigger/ledtrig-cpu.c: In function ‘ledtrig_cpu_init’:include/linux/compiler_types.h:571:45: error: call to ‘__compiletime_assert_726’ declared with attribute error: BUILD_BUG_ON failed: CONFIG_NR_CPUS > 9999 drivers/leds/trigger/ledtrig-cpu.c:137:9: note: in expansion of macro ‘BUILD_BUG_ON’
137 | BUILD_BUG_ON(CONFIG_NR_CPUS > 9999);
Enforce this limit in Kconfig instead to avoid the build failure.
--- drivers/leds/trigger/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/leds/trigger/Kconfig +1 -0
@@ -65,6 +65,7 @@ config LEDS_TRIGGER_BACKLIGHT config LEDS_TRIGGER_CPU bool "LED CPU Trigger" depends on !PREEMPT_RT + depends on NR_CPUS <= 9999 help This allows LEDs to be controlled by active CPUs. This shows the active CPUs across an array of LEDs so you can see which
Signature · 1 line
2.39.5
Lee Jones
maintainerQuoted 10 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
This driver fails build testing with larger values of
CONFIG_NR_CPUS:
drivers/leds/trigger/ledtrig-cpu.c: In function ‘ledtrig_cpu_init’:include/linux/compiler_types.h:571:45: error: call to ‘__compiletime_assert_726’ declared with attribute error:BUILD_BUG_ONfailed:CONFIG_NR_CPUS> 9999drivers/leds/trigger/ledtrig-cpu.c:137:9: note: in expansion of macro ‘BUILD_BUG_ON’
137 |BUILD_BUG_ON(CONFIG_NR_CPUS > 9999);Enforce this limit in
Kconfiginstead to avoid the build failure.
I have so many questions!
- This number seems arbitrary - what is the limiting factor?
- Character size for printing?
- What platform did you test this on to blow through that number?
- What if we really do want 10000+ CPUs?
- And what will that LED array look like to support them all?
- If we're enforcing here, is the BUILD_BUG_ON() now superfluous?
Quoted 20 lines
Signed-off-by Arnd Bergmann <[email protected]>--- drivers/leds/trigger/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/leds/trigger/Kconfig +1
-0@@ -65,6 +65,7 @@ config LEDS_TRIGGER_BACKLIGHT config LEDS_TRIGGER_CPU bool "LED CPU Trigger" depends on !PREEMPT_RT + depends on NR_CPUS <= 9999 help This allows LEDs to be controlled by active CPUs. This shows the active CPUs across an array of LEDs so you can see whichSignature · 1 line
2.39.5
Signature · 1 line
Lee Jones [李琼斯]
Quoted 8 lines · Lee Jones
Quoted 2 lines · Arnd Bergmann
Enforce this limit in
Kconfiginstead to avoid the build failure.I have so many questions!
- This number seems arbitrary - what is the limiting factor?
- Character size for printing?
That is my best guess, yes. The original commit 8f88731d052d ("led-triggers: create a trigger for CPU activity") already had this, plus
#define MAX_NAME_LEN 8snprintf(trig->name, MAX_NAME_LEN, "cpu%d", cpu);
which comes out to 10000 cpus (0 through 9999) in a NUL-terminated string. Obviously we could have a higher limit here but would technically still need to check that.
Quoted 1 line
- What platform did you test this on to blow through that number?
I was only compile-testing with a crazy number of CPUs, to see what would break, in particular when there are per-cpu structures or cpumask_t variables on the stack. I sent fixes for the ones that broke the build, but don't expect anything to actually need this at runtime. Some of the fixes I sent also address possible stack overflows that happen with a more realistic number of CPUs.
Quoted 2 lines
- What if we really do want 10000+ CPUs?
- And what will that LED array look like to support them all?
abcc131292aa ("ledtrig-cpu: Limit to 8 CPUs") actually added a runtime limit to eight CPUS, which is probably more reasonable.
Quoted 1 line
- If we're enforcing here, is the
BUILD_BUG_ON()now superfluous?
Yes, but it documents the requirement better than just the Kconfig dependency. Since there is a runtime limit, we could probably just drop the compile-time check and not add the Kconfig check.
Arnd
Lee Jones
maintainerQuoted 37 lines · Arnd Bergmann
Quoted 8 lines · Lee Jones
Quoted 2 lines · Arnd Bergmann
Enforce this limit in
Kconfiginstead to avoid the build failure.I have so many questions!
- This number seems arbitrary - what is the limiting factor?
- Character size for printing?That is my best guess, yes. The original commit
8f88731d052d("led-triggers: create a trigger for CPU activity") already had this, plus#define
MAX_NAME_LEN8snprintf(trig->name, MAX_NAME_LEN, "cpu%d", cpu);which comes out to 10000 cpus (0 through 9999) in a NUL-terminated string. Obviously we could have a higher limit here but would technically still need to check that.
Quoted 1 line
- What platform did you test this on to blow through that number?
I was only compile-testing with a crazy number of CPUs, to see what would break, in particular when there are per-cpu structures or
cpumask_tvariables on the stack. I sent fixes for the ones that broke the build, but don't expect anything to actually need this at runtime. Some of the fixes I sent also address possible stack overflows that happen with a more realistic number of CPUs.Quoted 2 lines
- What if we really do want 10000+ CPUs?
- And what will that LED array look like to support them all?
abcc131292aa("ledtrig-cpu: Limit to 8 CPUs") actually added a runtime limit to eight CPUS, which is probably more reasonable.
Quoted 6 lines
Quoted 1 line
- If we're enforcing here, is the
BUILD_BUG_ON()now superfluous?Yes, but it documents the requirement better than just the
Kconfigdependency. Since there is a runtime limit, we could probably just drop the compile-time check and not add theKconfigcheck.
Your call. I trust your judgement.
All of this was just a thought experiment.
Signature · 1 line
Lee Jones [李琼斯]