staging: media: atomisp: fix coding style in ia_css_output.host.c
Subsystems (4)
PATCH v3 1/1 staging: media: atomisp: fix coding style in ia_css_output.host.c
Fix multiple checkpatch.pl ERRORs and coding style issues:
- Use tabs instead of spaces for indentation
- Move trailing if statements to multiline format
- Remove excessive space between type and asterisk in function arguments
This cleanup improves code readability and follows Linux kernel coding standards.
---
This patch fixes coding style violations detected by checkpatch.pl in the atomisp driver under staging.
- Use tabs instead of spaces for indentation
- Move trailing if statements to multiline format
- Remove excessive spaces between type and asterisk in function parameters
This cleanup improves code readability and follows Linux kernel coding standards.
---
Changes in v3:
- Removed extra spaces between type and asterisk (e.g., *to) in function declarations, as pointed out by Andy Shevchenko
- Update commit message to reflect all the coding style fixes
- Link to v2: https://lore.kernel.org/r/[email protected]
Changes in v2:
- Fix patch subject prefix to "staging: media: atomisp:" to comply with media CI style.
- No other functional changes.
Link to v1: https://lore.kernel.org/r/[email protected]
--- .../atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c +4 -3
@@ -73,8 +73,8 @@ int ia_css_output0_config(struct sh_css_isp_output_isp_config *to,return ia_css_output_config (to, (const struct ia_css_output_configuration *)from, size); } -int ia_css_output1_config (struct sh_css_isp_output_isp_config *to, -const struct ia_css_output1_configuration *from, +int ia_css_output1_config (struct sh_css_isp_output_isp_config *to, +const struct ia_css_output1_configuration *from,unsigned int size) {return ia_css_output_config (to, (const struct ia_css_output_configuration *)from, size);
@@ -127,7 +127,8 @@ ia_css_output_dump( const struct sh_css_isp_output_params *output, unsigned int level) { - if (!output) return; + if (!output) + return;ia_css_debug_dtrace (level,"Horizontal Output Flip:\n" );ia_css_debug_dtrace (level,"\t%-32s = %d\n" ,"enable" , output->enable_hflip);
---
base-commit: 3f75bfff44be0646580fe4efda45d646f9c1693b
change-id: 20250621-bar-573b8b40fb80
Best regards,
Signature · 1 line
LiangCheng Wang <[email protected]>
Quoted 10 lines · LiangCheng Wang
Fix multiple checkpatch.pl ERRORs and coding style issues:
- Use tabs instead of spaces for indentation
- Move trailingifstatements to multiline format
- Remove excessive space between type and asterisk in function argumentsThis cleanup improves code readability and follows Linux kernel coding standards.
Change looks okay now. The question is are there only these problematic places or more? Can you double check the entire driver for these?
Signature · 2 lines
With Best Regards, Andy Shevchenko
Subject: Re: [PATCH v3] staging: media: atomisp: fix coding style in ia_css_output.host.c
In-Reply-To: <CAHp75VcFSbLwqot0Rrm=141Y-mCQUuFqNGn=DnfKSSYp-31vcg@mail.gmail.com>
Dear Andy,
Thank you for your review.
I'll go through the entire driver again and check for similar issues, such as extra spacing between types and asterisks. If I find more, I’ll send an updated v4 patch accordingly.
Best regards,
LiangCheng Wang