Skip to contentSkip to conversation

Remove the wl1273 FM Radio

PATCH Applied [email protected] 7 participants 33 messages Jun 25, 2025 – Oct 9, 2025 1 message not in the archive

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

cover Remove the wl1273 FM Radio

From: "Dr. David Alan Gilbert" <[email protected]>

I noticed that the wl1273 radio had an unused symbol, but then noticed it is on Arnd's unused driver list:
https://lore.kernel.org/lkml/[email protected]/

So, delete it.
The components seem pretty separable, except for Kconfig dependencies.

That lore URL is over 75 chars, which checkpatch warns about, suggestions welcome.

Dave

Dr. David Alan Gilbert (4):
media: radio-wl1273: Remove
ASoC: wl1273: Remove
mfd: wl1273-core: Remove
mfd: wl1273-core: Remove the header

 .../admin-guide/media/radio-cardlist.rst      |    1 -
 drivers/media/radio/Kconfig                   |   17 -
 drivers/media/radio/Makefile                  |    1 -
 drivers/media/radio/radio-wl1273.c            | 2159 -----------------
 drivers/mfd/Kconfig                           |   10 -
 drivers/mfd/Makefile                          |    1 -
 drivers/mfd/wl1273-core.c                     |  262 --
 include/linux/mfd/wl1273-core.h               |  277 ---
 sound/soc/codecs/Kconfig                      |    4 -
 sound/soc/codecs/Makefile                     |    4 +-
 sound/soc/codecs/wl1273.c                     |  500 ----
 sound/soc/codecs/wl1273.h                     |   16 -
 12 files changed, 1 insertion(+), 3251 deletions(-)
 delete mode 100644 drivers/media/radio/radio-wl1273.c
 delete mode 100644 drivers/mfd/wl1273-core.c
 delete mode 100644 include/linux/mfd/wl1273-core.h
 delete mode 100644 sound/soc/codecs/wl1273.c
 delete mode 100644 sound/soc/codecs/wl1273.h
Signature · 1 line
2.49.0
#1 lore raw

PATCH 1/4 media: radio-wl1273: Remove

From: "Dr. David Alan Gilbert" <[email protected]>

The wl1273 FM radio is on Arnd's unused driver list:
https://lore.kernel.org/lkml/[email protected]/

remove the radio component itself.

---
 drivers/media/radio/Kconfig        |   17 -
 drivers/media/radio/Makefile       |    1 -
 drivers/media/radio/radio-wl1273.c | 2159 ----------------------------
 3 files changed, 2177 deletions(-)
 delete mode 100644 drivers/media/radio/radio-wl1273.c
drivers/media/radio/Kconfig +0 -17
index 72776d08046a..bbbdd054ba64 100644
@@ -141,23 +141,6 @@ config RADIO_TIMBERDALE
 	  found behind the Timberdale FPGA on the Russellville board.
 	  Enabling this driver will automatically select the DSP and tuner.
 
-config RADIO_WL1273
-	tristate "Texas Instruments WL1273 I2C FM Radio"
-	depends on I2C
-	select MFD_CORE
-	select MFD_WL1273_CORE
-	select FW_LOADER
-	help
-	  Choose Y here if you have this FM radio chip.
-
-	  In order to control your radio card, you will need to use programs
-	  that are compatible with the Video For Linux 2 API.  Information on
-	  this API and pointers to "v4l2" programs may be found at
-	  <file:Documentation/userspace-api/media/index.rst>.
-
-	  To compile this driver as a module, choose M here: the
-	  module will be called radio-wl1273.
-
 config USB_DSBR
 	tristate "D-Link/GemTek USB FM radio support"
 	depends on USB
drivers/media/radio/Makefile +0 -1
index 1ff46f3a6ed3..f54693ebdb30 100644
@@ -30,7 +30,6 @@ obj-$(CONFIG_RADIO_TERRATEC) += radio-terratec.o
 obj-$(CONFIG_RADIO_TIMBERDALE) += radio-timb.o
 obj-$(CONFIG_RADIO_TRUST) += radio-trust.o
 obj-$(CONFIG_RADIO_TYPHOON) += radio-typhoon.o
-obj-$(CONFIG_RADIO_WL1273) += radio-wl1273.o
 obj-$(CONFIG_RADIO_ZOLTRIX) += radio-zoltrix.o
 
 obj-$(CONFIG_USB_DSBR) += dsbr100.o
drivers/media/radio/radio-wl1273.c deleted +0 -2159

2,159 lines not on this page · raw message

Signature · 1 line
2.49.0
#3 lore raw

PATCH 2/4 ASoC: wl1273: Remove

In reply to [email protected]

From: "Dr. David Alan Gilbert" <[email protected]>

The wl1273 FM radio is on Arnd's unused driver list:
https://lore.kernel.org/lkml/[email protected]/
Remove the codec component.

---
 sound/soc/codecs/Kconfig  |   4 -
 sound/soc/codecs/Makefile |   4 +-
 sound/soc/codecs/wl1273.c | 500 --------------------------------------
 sound/soc/codecs/wl1273.h |  16 --
 4 files changed, 1 insertion(+), 523 deletions(-)
 delete mode 100644 sound/soc/codecs/wl1273.c
 delete mode 100644 sound/soc/codecs/wl1273.h
sound/soc/codecs/Kconfig +0 -4
index 126f897312d4..0dbcda013a9d 100644
@@ -302,7 +302,6 @@ config SND_SOC_ALL_CODECS
 	imply SND_SOC_LPASS_MACRO_COMMON
 	imply SND_SOC_LPASS_RX_MACRO
 	imply SND_SOC_LPASS_TX_MACRO
-	imply SND_SOC_WL1273
 	imply SND_SOC_WM0010
 	imply SND_SOC_WM1250_EV1
 	imply SND_SOC_WM2000
@@ -2310,9 +2309,6 @@ config SND_SOC_WCD939X_SDW
 	  The WCD9390/9395 is a audio codec IC Integrated in
 	  Qualcomm SoCs like SM8650.
 
-config SND_SOC_WL1273
-	tristate
-
 config SND_SOC_WM0010
 	tristate
 	depends on SPI_MASTER
sound/soc/codecs/Makefile +1 -3
index 6d7aa109ede7..8ba43f224d47 100644
@@ -347,7 +347,6 @@ snd-soc-wcd938x-y := wcd938x.o
 snd-soc-wcd938x-sdw-y := wcd938x-sdw.o
 snd-soc-wcd939x-y := wcd939x.o
 snd-soc-wcd939x-sdw-y := wcd939x-sdw.o
-snd-soc-wl1273-y := wl1273.o
 snd-soc-wm-adsp-y := wm_adsp.o
 snd-soc-wm0010-y := wm0010.o
 snd-soc-wm1250-ev1-y := wm1250-ev1.o
@@ -777,7 +776,6 @@ ifdef CONFIG_SND_SOC_WCD939X_SDW
 # avoid link failure by forcing sdw code built-in when needed
 obj-$(CONFIG_SND_SOC_WCD939X) += snd-soc-wcd939x-sdw.o
 endif
-obj-$(CONFIG_SND_SOC_WL1273)	+= snd-soc-wl1273.o
 obj-$(CONFIG_SND_SOC_WM0010)	+= snd-soc-wm0010.o
 obj-$(CONFIG_SND_SOC_WM1250_EV1) += snd-soc-wm1250-ev1.o
 obj-$(CONFIG_SND_SOC_WM2000)	+= snd-soc-wm2000.o
@@ -853,4 +851,4 @@ obj-$(CONFIG_SND_SOC_LPASS_RX_MACRO)	+= snd-soc-lpass-rx-macro.o
 obj-$(CONFIG_SND_SOC_LPASS_TX_MACRO)	+= snd-soc-lpass-tx-macro.o
 
 # Mux
-obj-$(CONFIG_SND_SOC_SIMPLE_MUX)	+= snd-soc-simple-mux.o
\ No newline at end of file
+obj-$(CONFIG_SND_SOC_SIMPLE_MUX)	+= snd-soc-simple-mux.o
sound/soc/codecs/wl1273.c deleted +0 -500

500 lines not on this page · raw message

sound/soc/codecs/wl1273.h deleted +0 -16
deleted file mode 100644
index 66c312fa7eee..000000000000
@@ -1,16 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-/*
- * sound/soc/codec/wl1273.h
- *
- * ALSA SoC WL1273 codec driver
- *
- * Copyright (C) Nokia Corporation
- * Author: Matti Aaltonen <[email protected]>
- */
-
-#ifndef __WL1273_CODEC_H__
-#define __WL1273_CODEC_H__
-
-int wl1273_get_format(struct snd_soc_component *component, unsigned int *fmt);
-
-#endif	/* End of __WL1273_CODEC_H__ */
Signature · 1 line
2.49.0
#6 lore raw

PATCH 3/4 mfd: wl1273-core: Remove

In reply to [email protected]

From: "Dr. David Alan Gilbert" <[email protected]>

The wl1273 FM radio is on Arnd's unused driver list:

https://lore.kernel.org/lkml/[email protected]/

remove the core.

---
 drivers/mfd/Kconfig       |  10 --
 drivers/mfd/Makefile      |   1 -
 drivers/mfd/wl1273-core.c | 262 --------------------------------------
 3 files changed, 273 deletions(-)
 delete mode 100644 drivers/mfd/wl1273-core.c
drivers/mfd/Kconfig +0 -10
index 6fb3768e3d71..c635790afa75 100644
@@ -1889,16 +1889,6 @@ config MENELAUS
 	  and other features that are often used in portable devices like
 	  cell phones and PDAs.
 
-config MFD_WL1273_CORE
-	tristate "TI WL1273 FM radio"
-	depends on I2C
-	select MFD_CORE
-	default n
-	help
-	  This is the core driver for the TI WL1273 FM radio. This MFD
-	  driver connects the radio-wl1273 V4L2 module and the wl1273
-	  audio codec.
-
 config MFD_LM3533
 	tristate "TI/National Semiconductor LM3533 Lighting Power chip"
 	depends on I2C
drivers/mfd/Makefile +0 -1
index 79495f9f3457..ca351cb0ddcc 100644
@@ -200,7 +200,6 @@ obj-$(CONFIG_MFD_RDC321X)	+= rdc321x-southbridge.o
 obj-$(CONFIG_MFD_JANZ_CMODIO)	+= janz-cmodio.o
 obj-$(CONFIG_MFD_TPS6586X)	+= tps6586x.o
 obj-$(CONFIG_MFD_VX855)		+= vx855.o
-obj-$(CONFIG_MFD_WL1273_CORE)	+= wl1273-core.o
 
 si476x-core-y := si476x-cmd.o si476x-prop.o si476x-i2c.o
 obj-$(CONFIG_MFD_SI476X_CORE)	+= si476x-core.o
drivers/mfd/wl1273-core.c deleted +0 -262

262 lines not on this page · raw message

Signature · 1 line
2.49.0
#7 lore raw

PATCH 4/4 mfd: wl1273-core: Remove the header

In reply to [email protected]

From: "Dr. David Alan Gilbert" <[email protected]>

The wl1273 FM radio is on Arnd's unused driver list:
https://lore.kernel.org/lkml/[email protected]/

Other patches have removed the core, the ASoC code and the Radio code. With all those in, remove the header.

Also, tidy the ref in the docs.

---
 .../admin-guide/media/radio-cardlist.rst      |   1 -
 include/linux/mfd/wl1273-core.h               | 277 ------------------
 2 files changed, 278 deletions(-)
 delete mode 100644 include/linux/mfd/wl1273-core.h
Documentation/admin-guide/media/radio-cardlist.rst +0 -1
index a82a146bf912..cec724256812 100644
@@ -30,7 +30,6 @@ radio-terratec         TerraTec ActiveRadio ISA Standalone
 radio-timb             Enable the Timberdale radio driver
 radio-trust            Trust FM radio card
 radio-typhoon          Typhoon Radio (a.k.a. EcoRadio)
-radio-wl1273           Texas Instruments WL1273 I2C FM Radio
 fm_drv                 ISA radio devices
 fm_drv                 ISA radio devices
 radio-zoltrix          Zoltrix Radio
include/linux/mfd/wl1273-core.h deleted +0 -277

277 lines not on this page · raw message

Signature · 1 line
2.49.0
Acked-by on the v1 series
#8 lore raw
In reply to [email protected]
Quoted 5 lines · On Wed, Jun 25, 2025, at 15:32, [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

I noticed that the wl1273 radio had an unused symbol, but then noticed it is on Arnd's unused driver list:

Quoted 7 lines

https://lore.kernel.org/lkml/[email protected]/

So, delete it.
The components seem pretty separable, except for Kconfig dependencies.

That lore URL is over 75 chars, which checkpatch warns about, suggestions welcome.

For reference, the driver was added in 2010 with commit 383268a8e282 ("[media] MFD: WL1273 FM Radio: MFD driver for the FM radio"). It requires platform_data to be defined in a board file, but we never had any such board files doing this upstream.

The chip is apparently the Bluetooth/Wifi combo chip on the Nokia N9 and others, and is supported for those subsystems by the wlcore driver. Clearly nobody cared enough about FM radio functionality for the past 15 years to add the missing bits.

The author was last active on the mailing list in 2012.

Arnd

#10 lore raw
In reply to a message not in the archive
Quoted 10 lines · * Patchwork Integration ([email protected]) wrote:

Dear Dr. David Alan Gilbert:

Thanks for your patches! Unfortunately the Media CI robot detected some issues:

# Test checkpatch:./0001-media-radio-wl1273-Remove.patch checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #7:
https://lore.kernel.org/lkml/[email protected]/

Quoted 5 lines

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #61:
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 30 lines checked

I did check that, couldn't find any appropriate MAINTAINERS entry anyway

Quoted 4 lines

# Test checkpatch:./0002-ASoC-wl1273-Remove.patch checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #7:
https://lore.kernel.org/lkml/[email protected]/

Yep, said that in my cover letter; suggestions on how to refer to that URL in a better way are welcome.

Dave

Quoted 49 lines

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #71:
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 36 lines checked

# Test checkpatch:./0003-mfd-wl1273-core-Remove.patch checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #8:
https://lore.kernel.org/lkml/[email protected]/

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #55:
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 23 lines checked

# Test checkpatch:./0004-mfd-wl1273-core-Remove-the-header.patch checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #7:
https://lore.kernel.org/lkml/[email protected]/

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #35:
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 7 lines checked

Please fix your series, and upload a new version. If you have a patchwork account, do not forget to mark the current series as Superseded.

For more details, check the full report at:
https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/79088843/artifacts/report.htm .

Best regards, and Happy Hacking!
Media CI robot on behalf of the linux-media community.

---
Check the latest rules for contributing your patches at:
https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html

If you believe that the CI is wrong, kindly open an issue at
https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all to this message.

Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
maintainer Applied
#18 lore raw

Re: (subset) [PATCH 0/4] Remove the wl1273 FM Radio

In reply to [email protected]
Quoted 10 lines · On Wed, 25 Jun 2025 14:32:54 +0100, [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

I noticed that the wl1273 radio had an unused symbol, but then noticed it is on Arnd's unused driver list:
https://lore.kernel.org/lkml/[email protected]/

So, delete it.
The components seem pretty separable, except for Kconfig dependencies.

[...]

Applied, thanks!

[3/4] mfd: wl1273-core: Remove

      commit: efddd98938400a570bde5bc69b5ecc7e76cacbe1
[4/4] mfd: wl1273-core: Remove the header
      commit: d356033e7b1e94e0187bb0651f4a066a4646fbb9

--
Lee Jones [李琼斯]

#11 lore raw
In reply to Dr. David Alan Gilbert
Quoted 19 lines · Dr. David Alan Gilbert
Quoted 10 lines · * Patchwork Integration ([email protected]) wrote:

Dear Dr. David Alan Gilbert:

Thanks for your patches! Unfortunately the Media CI robot detected some issues:

# Test checkpatch:./0001-media-radio-wl1273-Remove.patch checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #7:
https://lore.kernel.org/lkml/[email protected]/

Quoted 5 lines

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #61:
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 30 lines checked

I did check that, couldn't find any appropriate MAINTAINERS entry anyway

Quoted 7 lines
Quoted 4 lines

# Test checkpatch:./0002-ASoC-wl1273-Remove.patch checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #7:
https://lore.kernel.org/lkml/[email protected]/

Yep, said that in my cover letter; suggestions on how to refer to that URL in a better way are welcome.

You can ignore those two warnings.

Quoted 55 lines
Quoted 49 lines

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #71:
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 36 lines checked

# Test checkpatch:./0003-mfd-wl1273-core-Remove.patch checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #8:
https://lore.kernel.org/lkml/[email protected]/

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #55:
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 23 lines checked

# Test checkpatch:./0004-mfd-wl1273-core-Remove-the-header.patch checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #7:
https://lore.kernel.org/lkml/[email protected]/

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #35:
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 7 lines checked

Please fix your series, and upload a new version. If you have a patchwork account, do not forget to mark the current series as Superseded.

For more details, check the full report at:
https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/79088843/artifacts/report.htm .

Best regards, and Happy Hacking!
Media CI robot on behalf of the linux-media community.

---
Check the latest rules for contributing your patches at:
https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html

If you believe that the CI is wrong, kindly open an issue at
https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all to this message.

Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
Signature · 3 lines
Regards,

Laurent Pinchart
#12 lore raw
Quoted 25 lines · * Laurent Pinchart ([email protected]) wrote:
Quoted 24 lines · Dr. David Alan Gilbert
Quoted 10 lines · * Patchwork Integration ([email protected]) wrote:

Dear Dr. David Alan Gilbert:

Thanks for your patches! Unfortunately the Media CI robot detected some issues:

# Test checkpatch:./0001-media-radio-wl1273-Remove.patch checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #7:
https://lore.kernel.org/lkml/[email protected]/

Quoted 5 lines

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #61:
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 30 lines checked

I did check that, couldn't find any appropriate MAINTAINERS entry anyway

Quoted 4 lines

# Test checkpatch:./0002-ASoC-wl1273-Remove.patch checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #7:
https://lore.kernel.org/lkml/[email protected]/

Quoted 4 lines
Quoted 2 lines

Yep, said that in my cover letter; suggestions on how to refer to that URL in a better way are welcome.

You can ignore those two warnings.

Thanks for confirming that.
Could you (or some other -media maintainer) pick 1/4 for linux-media please; Generally I think Lee tends only to pick the mfd specific bit up, so I need to get the specifics in through the other trees.

Thanks again.

Dave

Quoted 60 lines
Quoted 55 lines
Quoted 49 lines

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #71:
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 36 lines checked

# Test checkpatch:./0003-mfd-wl1273-core-Remove.patch checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #8:
https://lore.kernel.org/lkml/[email protected]/

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #55:
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 23 lines checked

# Test checkpatch:./0004-mfd-wl1273-core-Remove-the-header.patch checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #7:
https://lore.kernel.org/lkml/[email protected]/

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #35:
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 7 lines checked

Please fix your series, and upload a new version. If you have a patchwork account, do not forget to mark the current series as Superseded.

For more details, check the full report at:
https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/79088843/artifacts/report.htm .

Best regards, and Happy Hacking!
Media CI robot on behalf of the linux-media community.

---
Check the latest rules for contributing your patches at:
https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html

If you believe that the CI is wrong, kindly open an issue at
https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all to this message.

Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
Signature · 3 lines
Regards,

Laurent Pinchart
Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
#21 lore raw
In reply to [email protected]
Quoted 12 lines · On Wed, Jun 25, 2025 at 02:32:54PM +0100, [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

I noticed that the wl1273 radio had an unused symbol, but then noticed it is on Arnd's unused driver list:
https://lore.kernel.org/lkml/[email protected]/

So, delete it.
The components seem pretty separable, except for Kconfig dependencies.

That lore URL is over 75 chars, which checkpatch warns about, suggestions welcome.

Quoted 7 lines

Dave

Dr. David Alan Gilbert (4):
media: radio-wl1273: Remove
ASoC: wl1273: Remove
mfd: wl1273-core: Remove
mfd: wl1273-core: Remove the header

Mark, Lee, how would you like this to be merged ? I have a large patch series targetting v6.18 that depends on 1/4, and I would like to merge it in the media tree as soon as possible after -rc1 gets released. Patches 1/4, 2/4 and 3/4 are independent of each other, but patch 4/4 depends on the first three. Can we merge 1/4 in the media tree and provide a stable branch right on top of -rc1 ?

Quoted 18 lines
 .../admin-guide/media/radio-cardlist.rst      |    1 -
 drivers/media/radio/Kconfig                   |   17 -
 drivers/media/radio/Makefile                  |    1 -
 drivers/media/radio/radio-wl1273.c            | 2159 -----------------
 drivers/mfd/Kconfig                           |   10 -
 drivers/mfd/Makefile                          |    1 -
 drivers/mfd/wl1273-core.c                     |  262 --
 include/linux/mfd/wl1273-core.h               |  277 ---
 sound/soc/codecs/Kconfig                      |    4 -
 sound/soc/codecs/Makefile                     |    4 +-
 sound/soc/codecs/wl1273.c                     |  500 ----
 sound/soc/codecs/wl1273.h                     |   16 -
 12 files changed, 1 insertion(+), 3251 deletions(-)
 delete mode 100644 drivers/media/radio/radio-wl1273.c
 delete mode 100644 drivers/mfd/wl1273-core.c
 delete mode 100644 include/linux/mfd/wl1273-core.h
 delete mode 100644 sound/soc/codecs/wl1273.c
 delete mode 100644 sound/soc/codecs/wl1273.h
Signature · 3 lines
Regards,

Laurent Pinchart
#19 lore raw

Re: (subset) [PATCH 0/4] Remove the wl1273 FM Radio

In reply to Lee Jones

Hi Lee,

Quoted 10 lines · Lee Jones
Quoted 9 lines · On Wed, 25 Jun 2025 14:32:54 +0100, [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

I noticed that the wl1273 radio had an unused symbol, but then noticed it is on Arnd's unused driver list:
https://lore.kernel.org/lkml/[email protected]/

So, delete it.
The components seem pretty separable, except for Kconfig dependencies.

Quoted 8 lines
Quoted 1 line

[...]

Applied, thanks!

[3/4] mfd: wl1273-core: Remove

      commit: efddd98938400a570bde5bc69b5ecc7e76cacbe1
[4/4] mfd: wl1273-core: Remove the header
      commit: d356033e7b1e94e0187bb0651f4a066a4646fbb9

Ah, that may answer the question I just posted in another reply to the cover letter.

I think patch 4/4 will break build in -next until patches 1/4 and 2/4 get merged too. Should we get 1/4 and 2/4 merged in the media and sound trees ASAP, or would you prefer a different option ?

Signature · 3 lines
Regards,

Laurent Pinchart
Reviewed-by on v1 1/4
#2 lore raw

Re: [PATCH 1/4] media: radio-wl1273: Remove

In reply to [email protected]

Hi David,

Thank you for the patch.

Quoted 8 lines · On Wed, Jun 25, 2025 at 02:32:55PM +0100, [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

The wl1273 FM radio is on Arnd's unused driver list:
https://lore.kernel.org/lkml/[email protected]/

remove the radio component itself.

Quoted 2,212 lines
---
 drivers/media/radio/Kconfig        |   17 -
 drivers/media/radio/Makefile       |    1 -
 drivers/media/radio/radio-wl1273.c | 2159 ----------------------------
 3 files changed, 2177 deletions(-)
 delete mode 100644 drivers/media/radio/radio-wl1273.c
drivers/media/radio/Kconfig +0 -17
index 72776d08046a..bbbdd054ba64 100644
@@ -141,23 +141,6 @@ config RADIO_TIMBERDALE
 	  found behind the Timberdale FPGA on the Russellville board.
 	  Enabling this driver will automatically select the DSP and tuner.
 
-config RADIO_WL1273
-	tristate "Texas Instruments WL1273 I2C FM Radio"
-	depends on I2C
-	select MFD_CORE
-	select MFD_WL1273_CORE
-	select FW_LOADER
-	help
-	  Choose Y here if you have this FM radio chip.
-
-	  In order to control your radio card, you will need to use programs
-	  that are compatible with the Video For Linux 2 API.  Information on
-	  this API and pointers to "v4l2" programs may be found at
-	  <file:Documentation/userspace-api/media/index.rst>.
-
-	  To compile this driver as a module, choose M here: the
-	  module will be called radio-wl1273.
-
 config USB_DSBR
 	tristate "D-Link/GemTek USB FM radio support"
 	depends on USB
drivers/media/radio/Makefile +0 -1
index 1ff46f3a6ed3..f54693ebdb30 100644
@@ -30,7 +30,6 @@ obj-$(CONFIG_RADIO_TERRATEC) += radio-terratec.o
 obj-$(CONFIG_RADIO_TIMBERDALE) += radio-timb.o
 obj-$(CONFIG_RADIO_TRUST) += radio-trust.o
 obj-$(CONFIG_RADIO_TYPHOON) += radio-typhoon.o
-obj-$(CONFIG_RADIO_WL1273) += radio-wl1273.o
 obj-$(CONFIG_RADIO_ZOLTRIX) += radio-zoltrix.o
 
 obj-$(CONFIG_USB_DSBR) += dsbr100.o
drivers/media/radio/radio-wl1273.c deleted +0 -2159
deleted file mode 100644
index f55217ccf2b8..000000000000
@@ -1,2159 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0-only
-/*
- * Driver for the Texas Instruments WL1273 FM radio.
- *
- * Copyright (C) 2011 Nokia Corporation
- * Author: Matti J. Aaltonen <[email protected]>
- */
-
-#include <linux/delay.h>
-#include <linux/firmware.h>
-#include <linux/interrupt.h>
-#include <linux/mfd/wl1273-core.h>
-#include <linux/slab.h>
-#include <linux/module.h>
-#include <media/v4l2-common.h>
-#include <media/v4l2-ctrls.h>
-#include <media/v4l2-device.h>
-#include <media/v4l2-ioctl.h>
-
-#define DRIVER_DESC "Wl1273 FM Radio"
-
-#define WL1273_POWER_SET_OFF		0
-#define WL1273_POWER_SET_FM		BIT(0)
-#define WL1273_POWER_SET_RDS		BIT(1)
-#define WL1273_POWER_SET_RETENTION	BIT(4)
-
-#define WL1273_PUPD_SET_OFF		0x00
-#define WL1273_PUPD_SET_ON		0x01
-#define WL1273_PUPD_SET_RETENTION	0x10
-
-#define WL1273_FREQ(x)		(x * 10000 / 625)
-#define WL1273_INV_FREQ(x)	(x * 625 / 10000)
-
-/*
- * static int radio_nr - The number of the radio device
- *
- * The default is 0.
- */
-static int radio_nr;
-module_param(radio_nr, int, 0);
-MODULE_PARM_DESC(radio_nr, "The number of the radio device. Default = 0");
-
-struct wl1273_device {
-	char *bus_type;
-
-	u8 forbidden;
-	unsigned int preemphasis;
-	unsigned int spacing;
-	unsigned int tx_power;
-	unsigned int rx_frequency;
-	unsigned int tx_frequency;
-	unsigned int rangelow;
-	unsigned int rangehigh;
-	unsigned int band;
-	bool stereo;
-
-	/* RDS */
-	unsigned int rds_on;
-
-	wait_queue_head_t read_queue;
-	struct mutex lock; /* for serializing fm radio operations */
-	struct completion busy;
-
-	unsigned char *buffer;
-	unsigned int buf_size;
-	unsigned int rd_index;
-	unsigned int wr_index;
-
-	/* Selected interrupts */
-	u16 irq_flags;
-	u16 irq_received;
-
-	struct v4l2_ctrl_handler ctrl_handler;
-	struct v4l2_device v4l2dev;
-	struct video_device videodev;
-	struct device *dev;
-	struct wl1273_core *core;
-	struct file *owner;
-	char *write_buf;
-	unsigned int rds_users;
-};
-
-#define WL1273_IRQ_MASK	 (WL1273_FR_EVENT		|	\
-			  WL1273_POW_ENB_EVENT)
-
-/*
- * static unsigned int rds_buf - the number of RDS buffer blocks used.
- *
- * The default number is 100.
- */
-static unsigned int rds_buf = 100;
-module_param(rds_buf, uint, 0);
-MODULE_PARM_DESC(rds_buf, "Number of RDS buffer entries. Default = 100");
-
-static int wl1273_fm_write_fw(struct wl1273_core *core,
-			      __u8 *fw, int len)
-{
-	struct i2c_client *client = core->client;
-	struct i2c_msg msg;
-	int i, r = 0;
-
-	msg.addr = client->addr;
-	msg.flags = 0;
-
-	for (i = 0; i <= len; i++) {
-		msg.len = fw[0];
-		msg.buf = fw + 1;
-
-		fw += msg.len + 1;
-		dev_dbg(&client->dev, "%s:len[%d]: %d\n", __func__, i, msg.len);
-
-		r = i2c_transfer(client->adapter, &msg, 1);
-		if (r < 0 && i < len + 1)
-			break;
-	}
-
-	dev_dbg(&client->dev, "%s: i: %d\n", __func__, i);
-	dev_dbg(&client->dev, "%s: len + 1: %d\n", __func__, len + 1);
-
-	/* Last transfer always fails. */
-	if (i == len || r == 1)
-		r = 0;
-
-	return r;
-}
-
-#define WL1273_FIFO_HAS_DATA(status)	(1 << 5 & status)
-#define WL1273_RDS_CORRECTABLE_ERROR	(1 << 3)
-#define WL1273_RDS_UNCORRECTABLE_ERROR	(1 << 4)
-
-static int wl1273_fm_rds(struct wl1273_device *radio)
-{
-	struct wl1273_core *core = radio->core;
-	struct i2c_client *client = core->client;
-	u16 val;
-	u8 b0 = WL1273_RDS_DATA_GET, status;
-	struct v4l2_rds_data rds = { 0, 0, 0 };
-	struct i2c_msg msg[] = {
-		{
-			.addr = client->addr,
-			.flags = 0,
-			.buf = &b0,
-			.len = 1,
-		},
-		{
-			.addr = client->addr,
-			.flags = I2C_M_RD,
-			.buf = (u8 *) &rds,
-			.len = sizeof(rds),
-		}
-	};
-	int r;
-
-	if (core->mode != WL1273_MODE_RX)
-		return 0;
-
-	r = core->read(core, WL1273_RDS_SYNC_GET, &val);
-	if (r)
-		return r;
-
-	if ((val & 0x01) == 0) {
-		/* RDS decoder not synchronized */
-		return -EAGAIN;
-	}
-
-	/* copy all four RDS blocks to internal buffer */
-	do {
-		r = i2c_transfer(client->adapter, msg, ARRAY_SIZE(msg));
-		if (r != ARRAY_SIZE(msg)) {
-			dev_err(radio->dev, WL1273_FM_DRIVER_NAME
-				": %s: read_rds error r == %i)\n",
-				__func__, r);
-		}
-
-		status = rds.block;
-
-		if (!WL1273_FIFO_HAS_DATA(status))
-			break;
-
-		/* copy bits 0-2 (the block ID) to bits 3-5 */
-		rds.block = V4L2_RDS_BLOCK_MSK & status;
-		rds.block |= rds.block << 3;
-
-		/* copy the error bits to standard positions */
-		if (WL1273_RDS_UNCORRECTABLE_ERROR & status) {
-			rds.block |= V4L2_RDS_BLOCK_ERROR;
-			rds.block &= ~V4L2_RDS_BLOCK_CORRECTED;
-		} else if  (WL1273_RDS_CORRECTABLE_ERROR & status) {
-			rds.block &= ~V4L2_RDS_BLOCK_ERROR;
-			rds.block |= V4L2_RDS_BLOCK_CORRECTED;
-		}
-
-		/* copy RDS block to internal buffer */
-		memcpy(&radio->buffer[radio->wr_index], &rds, RDS_BLOCK_SIZE);
-		radio->wr_index += 3;
-
-		/* wrap write pointer */
-		if (radio->wr_index >= radio->buf_size)
-			radio->wr_index = 0;
-
-		/* check for overflow & start over */
-		if (radio->wr_index == radio->rd_index) {
-			dev_dbg(radio->dev, "RDS OVERFLOW");
-
-			radio->rd_index = 0;
-			radio->wr_index = 0;
-			break;
-		}
-	} while (WL1273_FIFO_HAS_DATA(status));
-
-	/* wake up read queue */
-	if (radio->wr_index != radio->rd_index)
-		wake_up_interruptible(&radio->read_queue);
-
-	return 0;
-}
-
-static irqreturn_t wl1273_fm_irq_thread_handler(int irq, void *dev_id)
-{
-	struct wl1273_device *radio = dev_id;
-	struct wl1273_core *core = radio->core;
-	u16 flags;
-	int r;
-
-	r = core->read(core, WL1273_FLAG_GET, &flags);
-	if (r)
-		goto out;
-
-	if (flags & WL1273_BL_EVENT) {
-		radio->irq_received = flags;
-		dev_dbg(radio->dev, "IRQ: BL\n");
-	}
-
-	if (flags & WL1273_RDS_EVENT) {
-		msleep(200);
-
-		wl1273_fm_rds(radio);
-	}
-
-	if (flags & WL1273_BBLK_EVENT)
-		dev_dbg(radio->dev, "IRQ: BBLK\n");
-
-	if (flags & WL1273_LSYNC_EVENT)
-		dev_dbg(radio->dev, "IRQ: LSYNC\n");
-
-	if (flags & WL1273_LEV_EVENT) {
-		u16 level;
-
-		r = core->read(core, WL1273_RSSI_LVL_GET, &level);
-		if (r)
-			goto out;
-
-		if (level > 14)
-			dev_dbg(radio->dev, "IRQ: LEV: 0x%x04\n", level);
-	}
-
-	if (flags & WL1273_IFFR_EVENT)
-		dev_dbg(radio->dev, "IRQ: IFFR\n");
-
-	if (flags & WL1273_PI_EVENT)
-		dev_dbg(radio->dev, "IRQ: PI\n");
-
-	if (flags & WL1273_PD_EVENT)
-		dev_dbg(radio->dev, "IRQ: PD\n");
-
-	if (flags & WL1273_STIC_EVENT)
-		dev_dbg(radio->dev, "IRQ: STIC\n");
-
-	if (flags & WL1273_MAL_EVENT)
-		dev_dbg(radio->dev, "IRQ: MAL\n");
-
-	if (flags & WL1273_POW_ENB_EVENT) {
-		complete(&radio->busy);
-		dev_dbg(radio->dev, "NOT BUSY\n");
-		dev_dbg(radio->dev, "IRQ: POW_ENB\n");
-	}
-
-	if (flags & WL1273_SCAN_OVER_EVENT)
-		dev_dbg(radio->dev, "IRQ: SCAN_OVER\n");
-
-	if (flags & WL1273_ERROR_EVENT)
-		dev_dbg(radio->dev, "IRQ: ERROR\n");
-
-	if (flags & WL1273_FR_EVENT) {
-		u16 freq;
-
-		dev_dbg(radio->dev, "IRQ: FR:\n");
-
-		if (core->mode == WL1273_MODE_RX) {
-			r = core->write(core, WL1273_TUNER_MODE_SET,
-					TUNER_MODE_STOP_SEARCH);
-			if (r) {
-				dev_err(radio->dev,
-					"%s: TUNER_MODE_SET fails: %d\n",
-					__func__, r);
-				goto out;
-			}
-
-			r = core->read(core, WL1273_FREQ_SET, &freq);
-			if (r)
-				goto out;
-
-			if (radio->band == WL1273_BAND_JAPAN)
-				radio->rx_frequency = WL1273_BAND_JAPAN_LOW +
-					freq * 50;
-			else
-				radio->rx_frequency = WL1273_BAND_OTHER_LOW +
-					freq * 50;
-			/*
-			 *  The driver works better with this msleep,
-			 *  the documentation doesn't mention it.
-			 */
-			usleep_range(10000, 15000);
-
-			dev_dbg(radio->dev, "%dkHz\n", radio->rx_frequency);
-
-		} else {
-			r = core->read(core, WL1273_CHANL_SET, &freq);
-			if (r)
-				goto out;
-
-			dev_dbg(radio->dev, "%dkHz\n", freq);
-		}
-		dev_dbg(radio->dev, "%s: NOT BUSY\n", __func__);
-	}
-
-out:
-	core->write(core, WL1273_INT_MASK_SET, radio->irq_flags);
-	complete(&radio->busy);
-
-	return IRQ_HANDLED;
-}
-
-static int wl1273_fm_set_tx_freq(struct wl1273_device *radio, unsigned int freq)
-{
-	struct wl1273_core *core = radio->core;
-	int r = 0;
-	unsigned long t;
-
-	if (freq < WL1273_BAND_TX_LOW) {
-		dev_err(radio->dev,
-			"Frequency out of range: %d < %d\n", freq,
-			WL1273_BAND_TX_LOW);
-		return -ERANGE;
-	}
-
-	if (freq > WL1273_BAND_TX_HIGH) {
-		dev_err(radio->dev,
-			"Frequency out of range: %d > %d\n", freq,
-			WL1273_BAND_TX_HIGH);
-		return -ERANGE;
-	}
-
-	/*
-	 *  The driver works better with this sleep,
-	 *  the documentation doesn't mention it.
-	 */
-	usleep_range(5000, 10000);
-
-	dev_dbg(radio->dev, "%s: freq: %d kHz\n", __func__, freq);
-
-	/* Set the current tx channel */
-	r = core->write(core, WL1273_CHANL_SET, freq / 10);
-	if (r)
-		return r;
-
-	reinit_completion(&radio->busy);
-
-	/* wait for the FR IRQ */
-	t = wait_for_completion_timeout(&radio->busy, msecs_to_jiffies(2000));
-	if (!t)
-		return -ETIMEDOUT;
-
-	dev_dbg(radio->dev, "WL1273_CHANL_SET: %lu\n", t);
-
-	/* Enable the output power */
-	r = core->write(core, WL1273_POWER_ENB_SET, 1);
-	if (r)
-		return r;
-
-	reinit_completion(&radio->busy);
-
-	/* wait for the POWER_ENB IRQ */
-	t = wait_for_completion_timeout(&radio->busy, msecs_to_jiffies(1000));
-	if (!t)
-		return -ETIMEDOUT;
-
-	radio->tx_frequency = freq;
-	dev_dbg(radio->dev, "WL1273_POWER_ENB_SET: %lu\n", t);
-
-	return	0;
-}
-
-static int wl1273_fm_set_rx_freq(struct wl1273_device *radio, unsigned int freq)
-{
-	struct wl1273_core *core = radio->core;
-	int r, f;
-	unsigned long t;
-
-	if (freq < radio->rangelow) {
-		dev_err(radio->dev,
-			"Frequency out of range: %d < %d\n", freq,
-			radio->rangelow);
-		r = -ERANGE;
-		goto err;
-	}
-
-	if (freq > radio->rangehigh) {
-		dev_err(radio->dev,
-			"Frequency out of range: %d > %d\n", freq,
-			radio->rangehigh);
-		r = -ERANGE;
-		goto err;
-	}
-
-	dev_dbg(radio->dev, "%s: %dkHz\n", __func__, freq);
-
-	core->write(core, WL1273_INT_MASK_SET, radio->irq_flags);
-
-	if (radio->band == WL1273_BAND_JAPAN)
-		f = (freq - WL1273_BAND_JAPAN_LOW) / 50;
-	else
-		f = (freq - WL1273_BAND_OTHER_LOW) / 50;
-
-	r = core->write(core, WL1273_FREQ_SET, f);
-	if (r) {
-		dev_err(radio->dev, "FREQ_SET fails\n");
-		goto err;
-	}
-
-	r = core->write(core, WL1273_TUNER_MODE_SET, TUNER_MODE_PRESET);
-	if (r) {
-		dev_err(radio->dev, "TUNER_MODE_SET fails\n");
-		goto err;
-	}
-
-	reinit_completion(&radio->busy);
-
-	t = wait_for_completion_timeout(&radio->busy, msecs_to_jiffies(2000));
-	if (!t) {
-		dev_err(radio->dev, "%s: TIMEOUT\n", __func__);
-		return -ETIMEDOUT;
-	}
-
-	radio->rd_index = 0;
-	radio->wr_index = 0;
-	radio->rx_frequency = freq;
-	return 0;
-err:
-	return r;
-}
-
-static int wl1273_fm_get_freq(struct wl1273_device *radio)
-{
-	struct wl1273_core *core = radio->core;
-	unsigned int freq;
-	u16 f;
-	int r;
-
-	if (core->mode == WL1273_MODE_RX) {
-		r = core->read(core, WL1273_FREQ_SET, &f);
-		if (r)
-			return r;
-
-		dev_dbg(radio->dev, "Freq get: 0x%04x\n", f);
-		if (radio->band == WL1273_BAND_JAPAN)
-			freq = WL1273_BAND_JAPAN_LOW + 50 * f;
-		else
-			freq = WL1273_BAND_OTHER_LOW + 50 * f;
-	} else {
-		r = core->read(core, WL1273_CHANL_SET, &f);
-		if (r)
-			return r;
-
-		freq = f * 10;
-	}
-
-	return freq;
-}
-
-/**
- * wl1273_fm_upload_firmware_patch() -	Upload the firmware.
- * @radio:				A pointer to the device struct.
- *
- * The firmware file consists of arrays of bytes where the first byte
- * gives the array length. The first byte in the file gives the
- * number of these arrays.
- */
-static int wl1273_fm_upload_firmware_patch(struct wl1273_device *radio)
-{
-	struct wl1273_core *core = radio->core;
-	unsigned int packet_num;
-	const struct firmware *fw_p;
-	const char *fw_name = "radio-wl1273-fw.bin";
-	struct device *dev = radio->dev;
-	__u8 *ptr;
-	int r;
-
-	dev_dbg(dev, "%s:\n", __func__);
-
-	/*
-	 * Uploading the firmware patch is not always necessary,
-	 * so we only print an info message.
-	 */
-	if (request_firmware(&fw_p, fw_name, dev)) {
-		dev_info(dev, "%s - %s not found\n", __func__, fw_name);
-
-		return 0;
-	}
-
-	ptr = (__u8 *) fw_p->data;
-	packet_num = ptr[0];
-	dev_dbg(dev, "%s: packets: %d\n", __func__, packet_num);
-
-	r = wl1273_fm_write_fw(core, ptr + 1, packet_num);
-	if (r) {
-		dev_err(dev, "FW upload error: %d\n", r);
-		goto out;
-	}
-
-	/* ignore possible error here */
-	core->write(core, WL1273_RESET, 0);
-
-	dev_dbg(dev, "%s - download OK, r: %d\n", __func__, r);
-out:
-	release_firmware(fw_p);
-	return r;
-}
-
-static int wl1273_fm_stop(struct wl1273_device *radio)
-{
-	struct wl1273_core *core = radio->core;
-
-	if (core->mode == WL1273_MODE_RX) {
-		int r = core->write(core, WL1273_POWER_SET,
-				    WL1273_POWER_SET_OFF);
-		if (r)
-			dev_err(radio->dev, "%s: POWER_SET fails: %d\n",
-				__func__, r);
-	} else if (core->mode == WL1273_MODE_TX) {
-		int r = core->write(core, WL1273_PUPD_SET,
-				    WL1273_PUPD_SET_OFF);
-		if (r)
-			dev_err(radio->dev,
-				"%s: PUPD_SET fails: %d\n", __func__, r);
-	}
-
-	if (core->pdata->disable) {
-		core->pdata->disable();
-		dev_dbg(radio->dev, "Back to reset\n");
-	}
-
-	return 0;
-}
-
-static int wl1273_fm_start(struct wl1273_device *radio, int new_mode)
-{
-	struct wl1273_core *core = radio->core;
-	struct wl1273_fm_platform_data *pdata = core->pdata;
-	struct device *dev = radio->dev;
-	int r = -EINVAL;
-
-	if (pdata->enable && core->mode == WL1273_MODE_OFF) {
-		dev_dbg(radio->dev, "Out of reset\n");
-
-		pdata->enable();
-		msleep(250);
-	}
-
-	if (new_mode == WL1273_MODE_RX) {
-		u16 val = WL1273_POWER_SET_FM;
-
-		if (radio->rds_on)
-			val |= WL1273_POWER_SET_RDS;
-
-		/* If this fails try again */
-		r = core->write(core, WL1273_POWER_SET, val);
-		if (r) {
-			msleep(100);
-
-			r = core->write(core, WL1273_POWER_SET, val);
-			if (r) {
-				dev_err(dev, "%s: POWER_SET fails\n", __func__);
-				goto fail;
-			}
-		}
-
-		/* rds buffer configuration */
-		radio->wr_index = 0;
-		radio->rd_index = 0;
-
-	} else if (new_mode == WL1273_MODE_TX) {
-		/* If this fails try again once */
-		r = core->write(core, WL1273_PUPD_SET, WL1273_PUPD_SET_ON);
-		if (r) {
-			msleep(100);
-			r = core->write(core, WL1273_PUPD_SET,
-					WL1273_PUPD_SET_ON);
-			if (r) {
-				dev_err(dev, "%s: PUPD_SET fails\n", __func__);
-				goto fail;
-			}
-		}
-
-		if (radio->rds_on) {
-			r = core->write(core, WL1273_RDS_DATA_ENB, 1);
-			if (r) {
-				dev_err(dev, "%s: RDS_DATA_ENB ON fails\n",
-					__func__);
-				goto fail;
-			}
-		} else {
-			r = core->write(core, WL1273_RDS_DATA_ENB, 0);
-			if (r) {
-				dev_err(dev, "%s: RDS_DATA_ENB OFF fails\n",
-					__func__);
-				goto fail;
-			}
-		}
-	} else {
-		dev_warn(dev, "%s: Illegal mode.\n", __func__);
-	}
-
-	if (core->mode == WL1273_MODE_OFF) {
-		r = wl1273_fm_upload_firmware_patch(radio);
-		if (r)
-			dev_warn(dev, "Firmware upload failed.\n");
-
-		/*
-		 * Sometimes the chip is in a wrong power state at this point.
-		 * So we set the power once again.
-		 */
-		if (new_mode == WL1273_MODE_RX) {
-			u16 val = WL1273_POWER_SET_FM;
-
-			if (radio->rds_on)
-				val |= WL1273_POWER_SET_RDS;
-
-			r = core->write(core, WL1273_POWER_SET, val);
-			if (r) {
-				dev_err(dev, "%s: POWER_SET fails\n", __func__);
-				goto fail;
-			}
-		} else if (new_mode == WL1273_MODE_TX) {
-			r = core->write(core, WL1273_PUPD_SET,
-					WL1273_PUPD_SET_ON);
-			if (r) {
-				dev_err(dev, "%s: PUPD_SET fails\n", __func__);
-				goto fail;
-			}
-		}
-	}
-
-	return 0;
-fail:
-	if (pdata->disable)
-		pdata->disable();
-
-	dev_dbg(dev, "%s: return: %d\n", __func__, r);
-	return r;
-}
-
-static int wl1273_fm_suspend(struct wl1273_device *radio)
-{
-	struct wl1273_core *core = radio->core;
-	int r;
-
-	/* Cannot go from OFF to SUSPENDED */
-	if (core->mode == WL1273_MODE_RX)
-		r = core->write(core, WL1273_POWER_SET,
-				WL1273_POWER_SET_RETENTION);
-	else if (core->mode == WL1273_MODE_TX)
-		r = core->write(core, WL1273_PUPD_SET,
-				WL1273_PUPD_SET_RETENTION);
-	else
-		r = -EINVAL;
-
-	if (r) {
-		dev_err(radio->dev, "%s: POWER_SET fails: %d\n", __func__, r);
-		goto out;
-	}
-
-out:
-	return r;
-}
-
-static int wl1273_fm_set_mode(struct wl1273_device *radio, int mode)
-{
-	struct wl1273_core *core = radio->core;
-	struct device *dev = radio->dev;
-	int old_mode;
-	int r;
-
-	dev_dbg(dev, "%s\n", __func__);
-	dev_dbg(dev, "Forbidden modes: 0x%02x\n", radio->forbidden);
-
-	old_mode = core->mode;
-	if (mode & radio->forbidden) {
-		r = -EPERM;
-		goto out;
-	}
-
-	switch (mode) {
-	case WL1273_MODE_RX:
-	case WL1273_MODE_TX:
-		r = wl1273_fm_start(radio, mode);
-		if (r) {
-			dev_err(dev, "%s: Cannot start.\n", __func__);
-			wl1273_fm_stop(radio);
-			goto out;
-		}
-
-		core->mode = mode;
-		r = core->write(core, WL1273_INT_MASK_SET, radio->irq_flags);
-		if (r) {
-			dev_err(dev, "INT_MASK_SET fails.\n");
-			goto out;
-		}
-
-		/* remember previous settings */
-		if (mode == WL1273_MODE_RX) {
-			r = wl1273_fm_set_rx_freq(radio, radio->rx_frequency);
-			if (r) {
-				dev_err(dev, "set freq fails: %d.\n", r);
-				goto out;
-			}
-
-			r = core->set_volume(core, core->volume);
-			if (r) {
-				dev_err(dev, "set volume fails: %d.\n", r);
-				goto out;
-			}
-
-			dev_dbg(dev, "%s: Set vol: %d.\n", __func__,
-				core->volume);
-		} else {
-			r = wl1273_fm_set_tx_freq(radio, radio->tx_frequency);
-			if (r) {
-				dev_err(dev, "set freq fails: %d.\n", r);
-				goto out;
-			}
-		}
-
-		dev_dbg(radio->dev, "%s: Set audio mode.\n", __func__);
-
-		r = core->set_audio(core, core->audio_mode);
-		if (r)
-			dev_err(dev, "Cannot set audio mode.\n");
-		break;
-
-	case WL1273_MODE_OFF:
-		r = wl1273_fm_stop(radio);
-		if (r)
-			dev_err(dev, "%s: Off fails: %d\n", __func__, r);
-		else
-			core->mode = WL1273_MODE_OFF;
-
-		break;
-
-	case WL1273_MODE_SUSPENDED:
-		r = wl1273_fm_suspend(radio);
-		if (r)
-			dev_err(dev, "%s: Suspend fails: %d\n", __func__, r);
-		else
-			core->mode = WL1273_MODE_SUSPENDED;
-
-		break;
-
-	default:
-		dev_err(dev, "%s: Unknown mode: %d\n", __func__, mode);
-		r = -EINVAL;
-		break;
-	}
-out:
-	if (r)
-		core->mode = old_mode;
-
-	return r;
-}
-
-static int wl1273_fm_set_seek(struct wl1273_device *radio,
-			      unsigned int wrap_around,
-			      unsigned int seek_upward,
-			      int level)
-{
-	struct wl1273_core *core = radio->core;
-	int r = 0;
-	unsigned int dir = (seek_upward == 0) ? 0 : 1;
-	unsigned int f;
-
-	f = radio->rx_frequency;
-	dev_dbg(radio->dev, "rx_frequency: %d\n", f);
-
-	if (dir && f + radio->spacing <= radio->rangehigh)
-		r = wl1273_fm_set_rx_freq(radio, f + radio->spacing);
-	else if (dir && wrap_around)
-		r = wl1273_fm_set_rx_freq(radio, radio->rangelow);
-	else if (f - radio->spacing >= radio->rangelow)
-		r = wl1273_fm_set_rx_freq(radio, f - radio->spacing);
-	else if (wrap_around)
-		r = wl1273_fm_set_rx_freq(radio, radio->rangehigh);
-
-	if (r)
-		goto out;
-
-	if (level < SCHAR_MIN || level > SCHAR_MAX)
-		return -EINVAL;
-
-	reinit_completion(&radio->busy);
-	dev_dbg(radio->dev, "%s: BUSY\n", __func__);
-
-	r = core->write(core, WL1273_INT_MASK_SET, radio->irq_flags);
-	if (r)
-		goto out;
-
-	dev_dbg(radio->dev, "%s\n", __func__);
-
-	r = core->write(core, WL1273_SEARCH_LVL_SET, level);
-	if (r)
-		goto out;
-
-	r = core->write(core, WL1273_SEARCH_DIR_SET, dir);
-	if (r)
-		goto out;
-
-	r = core->write(core, WL1273_TUNER_MODE_SET, TUNER_MODE_AUTO_SEEK);
-	if (r)
-		goto out;
-
-	/* wait for the FR IRQ */
-	wait_for_completion_timeout(&radio->busy, msecs_to_jiffies(1000));
-	if (!(radio->irq_received & WL1273_BL_EVENT)) {
-		r = -ETIMEDOUT;
-		goto out;
-	}
-
-	radio->irq_received &= ~WL1273_BL_EVENT;
-
-	if (!wrap_around)
-		goto out;
-
-	/* Wrap around */
-	dev_dbg(radio->dev, "Wrap around in HW seek.\n");
-
-	if (seek_upward)
-		f = radio->rangelow;
-	else
-		f = radio->rangehigh;
-
-	r = wl1273_fm_set_rx_freq(radio, f);
-	if (r)
-		goto out;
-
-	reinit_completion(&radio->busy);
-	dev_dbg(radio->dev, "%s: BUSY\n", __func__);
-
-	r = core->write(core, WL1273_TUNER_MODE_SET, TUNER_MODE_AUTO_SEEK);
-	if (r)
-		goto out;
-
-	/* wait for the FR IRQ */
-	if (!wait_for_completion_timeout(&radio->busy, msecs_to_jiffies(1000)))
-		r = -ETIMEDOUT;
-out:
-	dev_dbg(radio->dev, "%s: Err: %d\n", __func__, r);
-	return r;
-}
-
-/**
- * wl1273_fm_get_tx_ctune() -	Get the TX tuning capacitor value.
- * @radio:			A pointer to the device struct.
- */
-static unsigned int wl1273_fm_get_tx_ctune(struct wl1273_device *radio)
-{
-	struct wl1273_core *core = radio->core;
-	struct device *dev = radio->dev;
-	u16 val;
-	int r;
-
-	if (core->mode == WL1273_MODE_OFF ||
-	    core->mode == WL1273_MODE_SUSPENDED)
-		return -EPERM;
-
-	r = core->read(core, WL1273_READ_FMANT_TUNE_VALUE, &val);
-	if (r) {
-		dev_err(dev, "%s: read error: %d\n", __func__, r);
-		goto out;
-	}
-
-out:
-	return val;
-}
-
-/**
- * wl1273_fm_set_preemphasis() - Set the TX pre-emphasis value.
- * @radio:			 A pointer to the device struct.
- * @preemphasis:		 The new pre-amphasis value.
- *
- * Possible pre-emphasis values are: V4L2_PREEMPHASIS_DISABLED,
- * V4L2_PREEMPHASIS_50_uS and V4L2_PREEMPHASIS_75_uS.
- */
-static int wl1273_fm_set_preemphasis(struct wl1273_device *radio,
-				     unsigned int preemphasis)
-{
-	struct wl1273_core *core = radio->core;
-	int r;
-	u16 em;
-
-	if (core->mode == WL1273_MODE_OFF ||
-	    core->mode == WL1273_MODE_SUSPENDED)
-		return -EPERM;
-
-	mutex_lock(&core->lock);
-
-	switch (preemphasis) {
-	case V4L2_PREEMPHASIS_DISABLED:
-		em = 1;
-		break;
-	case V4L2_PREEMPHASIS_50_uS:
-		em = 0;
-		break;
-	case V4L2_PREEMPHASIS_75_uS:
-		em = 2;
-		break;
-	default:
-		r = -EINVAL;
-		goto out;
-	}
-
-	r = core->write(core, WL1273_PREMPH_SET, em);
-	if (r)
-		goto out;
-
-	radio->preemphasis = preemphasis;
-
-out:
-	mutex_unlock(&core->lock);
-	return r;
-}
-
-static int wl1273_fm_rds_on(struct wl1273_device *radio)
-{
-	struct wl1273_core *core = radio->core;
-	int r;
-
-	dev_dbg(radio->dev, "%s\n", __func__);
-	if (radio->rds_on)
-		return 0;
-
-	r = core->write(core, WL1273_POWER_SET,
-			WL1273_POWER_SET_FM | WL1273_POWER_SET_RDS);
-	if (r)
-		goto out;
-
-	r = wl1273_fm_set_rx_freq(radio, radio->rx_frequency);
-	if (r)
-		dev_err(radio->dev, "set freq fails: %d.\n", r);
-out:
-	return r;
-}
-
-static int wl1273_fm_rds_off(struct wl1273_device *radio)
-{
-	struct wl1273_core *core = radio->core;
-	int r;
-
-	if (!radio->rds_on)
-		return 0;
-
-	radio->irq_flags &= ~WL1273_RDS_EVENT;
-
-	r = core->write(core, WL1273_INT_MASK_SET, radio->irq_flags);
-	if (r)
-		goto out;
-
-	/* Service pending read */
-	wake_up_interruptible(&radio->read_queue);
-
-	dev_dbg(radio->dev, "%s\n", __func__);
-
-	r = core->write(core, WL1273_POWER_SET, WL1273_POWER_SET_FM);
-	if (r)
-		goto out;
-
-	r = wl1273_fm_set_rx_freq(radio, radio->rx_frequency);
-	if (r)
-		dev_err(radio->dev, "set freq fails: %d.\n", r);
-out:
-	dev_dbg(radio->dev, "%s: exiting...\n", __func__);
-
-	return r;
-}
-
-static int wl1273_fm_set_rds(struct wl1273_device *radio, unsigned int new_mode)
-{
-	int r = 0;
-	struct wl1273_core *core = radio->core;
-
-	if (core->mode == WL1273_MODE_OFF ||
-	    core->mode == WL1273_MODE_SUSPENDED)
-		return -EPERM;
-
-	if (new_mode == WL1273_RDS_RESET) {
-		r = core->write(core, WL1273_RDS_CNTRL_SET, 1);
-		return r;
-	}
-
-	if (core->mode == WL1273_MODE_TX && new_mode == WL1273_RDS_OFF) {
-		r = core->write(core, WL1273_RDS_DATA_ENB, 0);
-	} else if (core->mode == WL1273_MODE_TX && new_mode == WL1273_RDS_ON) {
-		r = core->write(core, WL1273_RDS_DATA_ENB, 1);
-	} else if (core->mode == WL1273_MODE_RX && new_mode == WL1273_RDS_OFF) {
-		r = wl1273_fm_rds_off(radio);
-	} else if (core->mode == WL1273_MODE_RX && new_mode == WL1273_RDS_ON) {
-		r = wl1273_fm_rds_on(radio);
-	} else {
-		dev_err(radio->dev, "%s: Unknown mode: %d\n",
-			__func__, new_mode);
-		r = -EINVAL;
-	}
-
-	if (!r)
-		radio->rds_on = new_mode == WL1273_RDS_ON;
-
-	return r;
-}
-
-static ssize_t wl1273_fm_fops_write(struct file *file, const char __user *buf,
-				    size_t count, loff_t *ppos)
-{
-	struct wl1273_device *radio = video_get_drvdata(video_devdata(file));
-	struct wl1273_core *core = radio->core;
-	u16 val;
-	int r;
-
-	dev_dbg(radio->dev, "%s\n", __func__);
-
-	if (core->mode != WL1273_MODE_TX)
-		return count;
-
-	if (radio->rds_users == 0) {
-		dev_warn(radio->dev, "%s: RDS not on.\n", __func__);
-		return 0;
-	}
-
-	if (mutex_lock_interruptible(&core->lock))
-		return -EINTR;
-	/*
-	 * Multiple processes can open the device, but only
-	 * one gets to write to it.
-	 */
-	if (radio->owner && radio->owner != file) {
-		r = -EBUSY;
-		goto out;
-	}
-	radio->owner = file;
-
-	/* Manual Mode */
-	if (count > 255)
-		val = 255;
-	else
-		val = count;
-
-	core->write(core, WL1273_RDS_CONFIG_DATA_SET, val);
-
-	if (copy_from_user(radio->write_buf + 1, buf, val)) {
-		r = -EFAULT;
-		goto out;
-	}
-
-	dev_dbg(radio->dev, "Count: %d\n", val);
-	dev_dbg(radio->dev, "From user: \"%s\"\n", radio->write_buf);
-
-	radio->write_buf[0] = WL1273_RDS_DATA_SET;
-	core->write_data(core, radio->write_buf, val + 1);
-
-	r = val;
-out:
-	mutex_unlock(&core->lock);
-
-	return r;
-}
-
-static __poll_t wl1273_fm_fops_poll(struct file *file,
-					struct poll_table_struct *pts)
-{
-	struct wl1273_device *radio = video_get_drvdata(video_devdata(file));
-	struct wl1273_core *core = radio->core;
-
-	if (radio->owner && radio->owner != file)
-		return EPOLLERR;
-
-	radio->owner = file;
-
-	if (core->mode == WL1273_MODE_RX) {
-		poll_wait(file, &radio->read_queue, pts);
-
-		if (radio->rd_index != radio->wr_index)
-			return EPOLLIN | EPOLLRDNORM;
-
-	} else if (core->mode == WL1273_MODE_TX) {
-		return EPOLLOUT | EPOLLWRNORM;
-	}
-
-	return 0;
-}
-
-static int wl1273_fm_fops_open(struct file *file)
-{
-	struct wl1273_device *radio = video_get_drvdata(video_devdata(file));
-	struct wl1273_core *core = radio->core;
-	int r = 0;
-
-	dev_dbg(radio->dev, "%s\n", __func__);
-
-	if (core->mode == WL1273_MODE_RX && radio->rds_on &&
-	    !radio->rds_users) {
-		dev_dbg(radio->dev, "%s: Mode: %d\n", __func__, core->mode);
-
-		if (mutex_lock_interruptible(&core->lock))
-			return -EINTR;
-
-		radio->irq_flags |= WL1273_RDS_EVENT;
-
-		r = core->write(core, WL1273_INT_MASK_SET,
-				radio->irq_flags);
-		if (r) {
-			mutex_unlock(&core->lock);
-			goto out;
-		}
-
-		radio->rds_users++;
-
-		mutex_unlock(&core->lock);
-	}
-out:
-	return r;
-}
-
-static int wl1273_fm_fops_release(struct file *file)
-{
-	struct wl1273_device *radio = video_get_drvdata(video_devdata(file));
-	struct wl1273_core *core = radio->core;
-	int r = 0;
-
-	dev_dbg(radio->dev, "%s\n", __func__);
-
-	if (radio->rds_users > 0) {
-		radio->rds_users--;
-		if (radio->rds_users == 0) {
-			mutex_lock(&core->lock);
-
-			radio->irq_flags &= ~WL1273_RDS_EVENT;
-
-			if (core->mode == WL1273_MODE_RX) {
-				r = core->write(core,
-						WL1273_INT_MASK_SET,
-						radio->irq_flags);
-				if (r) {
-					mutex_unlock(&core->lock);
-					goto out;
-				}
-			}
-			mutex_unlock(&core->lock);
-		}
-	}
-
-	if (file == radio->owner)
-		radio->owner = NULL;
-out:
-	return r;
-}
-
-static ssize_t wl1273_fm_fops_read(struct file *file, char __user *buf,
-				   size_t count, loff_t *ppos)
-{
-	int r = 0;
-	struct wl1273_device *radio = video_get_drvdata(video_devdata(file));
-	struct wl1273_core *core = radio->core;
-	unsigned int block_count = 0;
-	u16 val;
-
-	dev_dbg(radio->dev, "%s\n", __func__);
-
-	if (core->mode != WL1273_MODE_RX)
-		return 0;
-
-	if (radio->rds_users == 0) {
-		dev_warn(radio->dev, "%s: RDS not on.\n", __func__);
-		return 0;
-	}
-
-	if (mutex_lock_interruptible(&core->lock))
-		return -EINTR;
-
-	/*
-	 * Multiple processes can open the device, but only
-	 * one at a time gets read access.
-	 */
-	if (radio->owner && radio->owner != file) {
-		r = -EBUSY;
-		goto out;
-	}
-	radio->owner = file;
-
-	r = core->read(core, WL1273_RDS_SYNC_GET, &val);
-	if (r) {
-		dev_err(radio->dev, "%s: Get RDS_SYNC fails.\n", __func__);
-		goto out;
-	} else if (val == 0) {
-		dev_info(radio->dev, "RDS_SYNC: Not synchronized\n");
-		r = -ENODATA;
-		goto out;
-	}
-
-	/* block if no new data available */
-	while (radio->wr_index == radio->rd_index) {
-		if (file->f_flags & O_NONBLOCK) {
-			r = -EWOULDBLOCK;
-			goto out;
-		}
-
-		dev_dbg(radio->dev, "%s: Wait for RDS data.\n", __func__);
-		if (wait_event_interruptible(radio->read_queue,
-					     radio->wr_index !=
-					     radio->rd_index) < 0) {
-			r = -EINTR;
-			goto out;
-		}
-	}
-
-	/* calculate block count from byte count */
-	count /= RDS_BLOCK_SIZE;
-
-	/* copy RDS blocks from the internal buffer and to user buffer */
-	while (block_count < count) {
-		if (radio->rd_index == radio->wr_index)
-			break;
-
-		/* always transfer complete RDS blocks */
-		if (copy_to_user(buf, &radio->buffer[radio->rd_index],
-				 RDS_BLOCK_SIZE))
-			break;
-
-		/* increment and wrap the read pointer */
-		radio->rd_index += RDS_BLOCK_SIZE;
-		if (radio->rd_index >= radio->buf_size)
-			radio->rd_index = 0;
-
-		/* increment counters */
-		block_count++;
-		buf += RDS_BLOCK_SIZE;
-		r += RDS_BLOCK_SIZE;
-	}
-
-out:
-	dev_dbg(radio->dev, "%s: exit\n", __func__);
-	mutex_unlock(&core->lock);
-
-	return r;
-}
-
-static const struct v4l2_file_operations wl1273_fops = {
-	.owner		= THIS_MODULE,
-	.read		= wl1273_fm_fops_read,
-	.write		= wl1273_fm_fops_write,
-	.poll		= wl1273_fm_fops_poll,
-	.unlocked_ioctl	= video_ioctl2,
-	.open		= wl1273_fm_fops_open,
-	.release	= wl1273_fm_fops_release,
-};
-
-static int wl1273_fm_vidioc_querycap(struct file *file, void *priv,
-				     struct v4l2_capability *capability)
-{
-	struct wl1273_device *radio = video_get_drvdata(video_devdata(file));
-
-	dev_dbg(radio->dev, "%s\n", __func__);
-
-	strscpy(capability->driver, WL1273_FM_DRIVER_NAME,
-		sizeof(capability->driver));
-	strscpy(capability->card, "TI Wl1273 FM Radio",
-		sizeof(capability->card));
-	strscpy(capability->bus_info, radio->bus_type,
-		sizeof(capability->bus_info));
-	return 0;
-}
-
-static int wl1273_fm_vidioc_g_input(struct file *file, void *priv,
-				    unsigned int *i)
-{
-	struct wl1273_device *radio = video_get_drvdata(video_devdata(file));
-
-	dev_dbg(radio->dev, "%s\n", __func__);
-
-	*i = 0;
-
-	return 0;
-}
-
-static int wl1273_fm_vidioc_s_input(struct file *file, void *priv,
-				    unsigned int i)
-{
-	struct wl1273_device *radio = video_get_drvdata(video_devdata(file));
-
-	dev_dbg(radio->dev, "%s\n", __func__);
-
-	if (i != 0)
-		return -EINVAL;
-
-	return 0;
-}
-
-/**
- * wl1273_fm_set_tx_power() -	Set the transmission power value.
- * @radio:			A pointer to the device struct.
- * @power:			The new power value.
- */
-static int wl1273_fm_set_tx_power(struct wl1273_device *radio, u16 power)
-{
-	struct wl1273_core *core = radio->core;
-	int r;
-
-	if (core->mode == WL1273_MODE_OFF ||
-	    core->mode == WL1273_MODE_SUSPENDED)
-		return -EPERM;
-
-	mutex_lock(&core->lock);
-
-	/* Convert the dBuV value to chip presentation */
-	r = core->write(core, WL1273_POWER_LEV_SET, 122 - power);
-	if (r)
-		goto out;
-
-	radio->tx_power = power;
-
-out:
-	mutex_unlock(&core->lock);
-	return r;
-}
-
-#define WL1273_SPACING_50kHz	1
-#define WL1273_SPACING_100kHz	2
-#define WL1273_SPACING_200kHz	4
-
-static int wl1273_fm_tx_set_spacing(struct wl1273_device *radio,
-				    unsigned int spacing)
-{
-	struct wl1273_core *core = radio->core;
-	int r;
-
-	if (spacing == 0) {
-		r = core->write(core, WL1273_SCAN_SPACING_SET,
-				WL1273_SPACING_100kHz);
-		radio->spacing = 100;
-	} else if (spacing - 50000 < 25000) {
-		r = core->write(core, WL1273_SCAN_SPACING_SET,
-				WL1273_SPACING_50kHz);
-		radio->spacing = 50;
-	} else if (spacing - 100000 < 50000) {
-		r = core->write(core, WL1273_SCAN_SPACING_SET,
-				WL1273_SPACING_100kHz);
-		radio->spacing = 100;
-	} else {
-		r = core->write(core, WL1273_SCAN_SPACING_SET,
-				WL1273_SPACING_200kHz);
-		radio->spacing = 200;
-	}
-
-	return r;
-}
-
-static int wl1273_fm_g_volatile_ctrl(struct v4l2_ctrl *ctrl)
-{
-	struct wl1273_device *radio = ctrl->priv;
-	struct wl1273_core *core = radio->core;
-
-	dev_dbg(radio->dev, "%s\n", __func__);
-
-	if (mutex_lock_interruptible(&core->lock))
-		return -EINTR;
-
-	switch (ctrl->id) {
-	case  V4L2_CID_TUNE_ANTENNA_CAPACITOR:
-		ctrl->val = wl1273_fm_get_tx_ctune(radio);
-		break;
-
-	default:
-		dev_warn(radio->dev, "%s: Unknown IOCTL: %d\n",
-			 __func__, ctrl->id);
-		break;
-	}
-
-	mutex_unlock(&core->lock);
-
-	return 0;
-}
-
-#define WL1273_MUTE_SOFT_ENABLE    (1 << 0)
-#define WL1273_MUTE_AC             (1 << 1)
-#define WL1273_MUTE_HARD_LEFT      (1 << 2)
-#define WL1273_MUTE_HARD_RIGHT     (1 << 3)
-#define WL1273_MUTE_SOFT_FORCE     (1 << 4)
-
-static inline struct wl1273_device *to_radio(struct v4l2_ctrl *ctrl)
-{
-	return container_of(ctrl->handler, struct wl1273_device, ctrl_handler);
-}
-
-static int wl1273_fm_s_ctrl(struct v4l2_ctrl *ctrl)
-{
-	struct wl1273_device *radio = to_radio(ctrl);
-	struct wl1273_core *core = radio->core;
-	int r = 0;
-
-	dev_dbg(radio->dev, "%s\n", __func__);
-
-	switch (ctrl->id) {
-	case V4L2_CID_AUDIO_MUTE:
-		if (mutex_lock_interruptible(&core->lock))
-			return -EINTR;
-
-		if (core->mode == WL1273_MODE_RX && ctrl->val)
-			r = core->write(core,
-					WL1273_MUTE_STATUS_SET,
-					WL1273_MUTE_HARD_LEFT |
-					WL1273_MUTE_HARD_RIGHT);
-		else if (core->mode == WL1273_MODE_RX)
-			r = core->write(core,
-					WL1273_MUTE_STATUS_SET, 0x0);
-		else if (core->mode == WL1273_MODE_TX && ctrl->val)
-			r = core->write(core, WL1273_MUTE, 1);
-		else if (core->mode == WL1273_MODE_TX)
-			r = core->write(core, WL1273_MUTE, 0);
-
-		mutex_unlock(&core->lock);
-		break;
-
-	case V4L2_CID_AUDIO_VOLUME:
-		if (ctrl->val == 0)
-			r = wl1273_fm_set_mode(radio, WL1273_MODE_OFF);
-		else
-			r =  core->set_volume(core, core->volume);
-		break;
-
-	case V4L2_CID_TUNE_PREEMPHASIS:
-		r = wl1273_fm_set_preemphasis(radio, ctrl->val);
-		break;
-
-	case V4L2_CID_TUNE_POWER_LEVEL:
-		r = wl1273_fm_set_tx_power(radio, ctrl->val);
-		break;
-
-	default:
-		dev_warn(radio->dev, "%s: Unknown IOCTL: %d\n",
-			 __func__, ctrl->id);
-		break;
-	}
-
-	dev_dbg(radio->dev, "%s\n", __func__);
-	return r;
-}
-
-static int wl1273_fm_vidioc_g_audio(struct file *file, void *priv,
-				    struct v4l2_audio *audio)
-{
-	struct wl1273_device *radio = video_get_drvdata(video_devdata(file));
-
-	dev_dbg(radio->dev, "%s\n", __func__);
-
-	if (audio->index > 1)
-		return -EINVAL;
-
-	strscpy(audio->name, "Radio", sizeof(audio->name));
-	audio->capability = V4L2_AUDCAP_STEREO;
-
-	return 0;
-}
-
-static int wl1273_fm_vidioc_s_audio(struct file *file, void *priv,
-				    const struct v4l2_audio *audio)
-{
-	struct wl1273_device *radio = video_get_drvdata(video_devdata(file));
-
-	dev_dbg(radio->dev, "%s\n", __func__);
-
-	if (audio->index != 0)
-		return -EINVAL;
-
-	return 0;
-}
-
-#define WL1273_RDS_NOT_SYNCHRONIZED 0
-#define WL1273_RDS_SYNCHRONIZED 1
-
-static int wl1273_fm_vidioc_g_tuner(struct file *file, void *priv,
-				    struct v4l2_tuner *tuner)
-{
-	struct wl1273_device *radio = video_get_drvdata(video_devdata(file));
-	struct wl1273_core *core = radio->core;
-	u16 val;
-	int r;
-
-	dev_dbg(radio->dev, "%s\n", __func__);
-
-	if (tuner->index > 0)
-		return -EINVAL;
-
-	strscpy(tuner->name, WL1273_FM_DRIVER_NAME, sizeof(tuner->name));
-	tuner->type = V4L2_TUNER_RADIO;
-
-	tuner->rangelow	= WL1273_FREQ(WL1273_BAND_JAPAN_LOW);
-	tuner->rangehigh = WL1273_FREQ(WL1273_BAND_OTHER_HIGH);
-
-	tuner->capability = V4L2_TUNER_CAP_LOW | V4L2_TUNER_CAP_RDS |
-		V4L2_TUNER_CAP_STEREO | V4L2_TUNER_CAP_RDS_BLOCK_IO |
-		V4L2_TUNER_CAP_HWSEEK_BOUNDED | V4L2_TUNER_CAP_HWSEEK_WRAP;
-
-	if (radio->stereo)
-		tuner->audmode = V4L2_TUNER_MODE_STEREO;
-	else
-		tuner->audmode = V4L2_TUNER_MODE_MONO;
-
-	if (core->mode != WL1273_MODE_RX)
-		return 0;
-
-	if (mutex_lock_interruptible(&core->lock))
-		return -EINTR;
-
-	r = core->read(core, WL1273_STEREO_GET, &val);
-	if (r)
-		goto out;
-
-	if (val == 1)
-		tuner->rxsubchans = V4L2_TUNER_SUB_STEREO;
-	else
-		tuner->rxsubchans = V4L2_TUNER_SUB_MONO;
-
-	r = core->read(core, WL1273_RSSI_LVL_GET, &val);
-	if (r)
-		goto out;
-
-	tuner->signal = (s16) val;
-	dev_dbg(radio->dev, "Signal: %d\n", tuner->signal);
-
-	tuner->afc = 0;
-
-	r = core->read(core, WL1273_RDS_SYNC_GET, &val);
-	if (r)
-		goto out;
-
-	if (val == WL1273_RDS_SYNCHRONIZED)
-		tuner->rxsubchans |= V4L2_TUNER_SUB_RDS;
-out:
-	mutex_unlock(&core->lock);
-
-	return r;
-}
-
-static int wl1273_fm_vidioc_s_tuner(struct file *file, void *priv,
-				    const struct v4l2_tuner *tuner)
-{
-	struct wl1273_device *radio = video_get_drvdata(video_devdata(file));
-	struct wl1273_core *core = radio->core;
-	int r = 0;
-
-	dev_dbg(radio->dev, "%s\n", __func__);
-	dev_dbg(radio->dev, "tuner->index: %d\n", tuner->index);
-	dev_dbg(radio->dev, "tuner->name: %s\n", tuner->name);
-	dev_dbg(radio->dev, "tuner->capability: 0x%04x\n", tuner->capability);
-	dev_dbg(radio->dev, "tuner->rxsubchans: 0x%04x\n", tuner->rxsubchans);
-	dev_dbg(radio->dev, "tuner->rangelow: %d\n", tuner->rangelow);
-	dev_dbg(radio->dev, "tuner->rangehigh: %d\n", tuner->rangehigh);
-
-	if (tuner->index > 0)
-		return -EINVAL;
-
-	if (mutex_lock_interruptible(&core->lock))
-		return -EINTR;
-
-	r = wl1273_fm_set_mode(radio, WL1273_MODE_RX);
-	if (r)
-		goto out;
-
-	if (tuner->rxsubchans & V4L2_TUNER_SUB_RDS)
-		r = wl1273_fm_set_rds(radio, WL1273_RDS_ON);
-	else
-		r = wl1273_fm_set_rds(radio, WL1273_RDS_OFF);
-
-	if (r)
-		dev_warn(radio->dev, "%s: RDS fails: %d\n", __func__, r);
-
-	if (tuner->audmode == V4L2_TUNER_MODE_MONO) {
-		r = core->write(core, WL1273_MOST_MODE_SET, WL1273_RX_MONO);
-		if (r < 0) {
-			dev_warn(radio->dev, "%s: MOST_MODE fails: %d\n",
-				 __func__, r);
-			goto out;
-		}
-		radio->stereo = false;
-	} else if (tuner->audmode == V4L2_TUNER_MODE_STEREO) {
-		r = core->write(core, WL1273_MOST_MODE_SET, WL1273_RX_STEREO);
-		if (r < 0) {
-			dev_warn(radio->dev, "%s: MOST_MODE fails: %d\n",
-				 __func__, r);
-			goto out;
-		}
-		radio->stereo = true;
-	} else {
-		dev_err(radio->dev, "%s: tuner->audmode: %d\n",
-			 __func__, tuner->audmode);
-		r = -EINVAL;
-		goto out;
-	}
-
-out:
-	mutex_unlock(&core->lock);
-
-	return r;
-}
-
-static int wl1273_fm_vidioc_g_frequency(struct file *file, void *priv,
-					struct v4l2_frequency *freq)
-{
-	struct wl1273_device *radio = video_get_drvdata(video_devdata(file));
-	struct wl1273_core *core = radio->core;
-
-	dev_dbg(radio->dev, "%s\n", __func__);
-
-	if (mutex_lock_interruptible(&core->lock))
-		return -EINTR;
-
-	freq->type = V4L2_TUNER_RADIO;
-	freq->frequency = WL1273_FREQ(wl1273_fm_get_freq(radio));
-
-	mutex_unlock(&core->lock);
-
-	return 0;
-}
-
-static int wl1273_fm_vidioc_s_frequency(struct file *file, void *priv,
-					const struct v4l2_frequency *freq)
-{
-	struct wl1273_device *radio = video_get_drvdata(video_devdata(file));
-	struct wl1273_core *core = radio->core;
-	int r;
-
-	dev_dbg(radio->dev, "%s: %d\n", __func__, freq->frequency);
-
-	if (freq->type != V4L2_TUNER_RADIO) {
-		dev_dbg(radio->dev,
-			"freq->type != V4L2_TUNER_RADIO: %d\n", freq->type);
-		return -EINVAL;
-	}
-
-	if (mutex_lock_interruptible(&core->lock))
-		return -EINTR;
-
-	if (core->mode == WL1273_MODE_RX) {
-		dev_dbg(radio->dev, "freq: %d\n", freq->frequency);
-
-		r = wl1273_fm_set_rx_freq(radio,
-					  WL1273_INV_FREQ(freq->frequency));
-		if (r)
-			dev_warn(radio->dev, WL1273_FM_DRIVER_NAME
-				 ": set frequency failed with %d\n", r);
-	} else {
-		r = wl1273_fm_set_tx_freq(radio,
-					  WL1273_INV_FREQ(freq->frequency));
-		if (r)
-			dev_warn(radio->dev, WL1273_FM_DRIVER_NAME
-				 ": set frequency failed with %d\n", r);
-	}
-
-	mutex_unlock(&core->lock);
-
-	dev_dbg(radio->dev, "wl1273_vidioc_s_frequency: DONE\n");
-	return r;
-}
-
-#define WL1273_DEFAULT_SEEK_LEVEL	7
-
-static int wl1273_fm_vidioc_s_hw_freq_seek(struct file *file, void *priv,
-					   const struct v4l2_hw_freq_seek *seek)
-{
-	struct wl1273_device *radio = video_get_drvdata(video_devdata(file));
-	struct wl1273_core *core = radio->core;
-	int r;
-
-	dev_dbg(radio->dev, "%s\n", __func__);
-
-	if (seek->tuner != 0 || seek->type != V4L2_TUNER_RADIO)
-		return -EINVAL;
-
-	if (file->f_flags & O_NONBLOCK)
-		return -EWOULDBLOCK;
-
-	if (mutex_lock_interruptible(&core->lock))
-		return -EINTR;
-
-	r = wl1273_fm_set_mode(radio, WL1273_MODE_RX);
-	if (r)
-		goto out;
-
-	r = wl1273_fm_tx_set_spacing(radio, seek->spacing);
-	if (r)
-		dev_warn(radio->dev, "HW seek failed: %d\n", r);
-
-	r = wl1273_fm_set_seek(radio, seek->wrap_around, seek->seek_upward,
-			       WL1273_DEFAULT_SEEK_LEVEL);
-	if (r)
-		dev_warn(radio->dev, "HW seek failed: %d\n", r);
-
-out:
-	mutex_unlock(&core->lock);
-	return r;
-}
-
-static int wl1273_fm_vidioc_s_modulator(struct file *file, void *priv,
-					const struct v4l2_modulator *modulator)
-{
-	struct wl1273_device *radio = video_get_drvdata(video_devdata(file));
-	struct wl1273_core *core = radio->core;
-	int r = 0;
-
-	dev_dbg(radio->dev, "%s\n", __func__);
-
-	if (modulator->index > 0)
-		return -EINVAL;
-
-	if (mutex_lock_interruptible(&core->lock))
-		return -EINTR;
-
-	r = wl1273_fm_set_mode(radio, WL1273_MODE_TX);
-	if (r)
-		goto out;
-
-	if (modulator->txsubchans & V4L2_TUNER_SUB_RDS)
-		r = wl1273_fm_set_rds(radio, WL1273_RDS_ON);
-	else
-		r = wl1273_fm_set_rds(radio, WL1273_RDS_OFF);
-
-	if (modulator->txsubchans & V4L2_TUNER_SUB_MONO)
-		r = core->write(core, WL1273_MONO_SET, WL1273_TX_MONO);
-	else
-		r = core->write(core, WL1273_MONO_SET,
-				WL1273_RX_STEREO);
-	if (r < 0)
-		dev_warn(radio->dev, WL1273_FM_DRIVER_NAME
-			 "MONO_SET fails: %d\n", r);
-out:
-	mutex_unlock(&core->lock);
-
-	return r;
-}
-
-static int wl1273_fm_vidioc_g_modulator(struct file *file, void *priv,
-					struct v4l2_modulator *modulator)
-{
-	struct wl1273_device *radio = video_get_drvdata(video_devdata(file));
-	struct wl1273_core *core = radio->core;
-	u16 val;
-	int r;
-
-	dev_dbg(radio->dev, "%s\n", __func__);
-
-	strscpy(modulator->name, WL1273_FM_DRIVER_NAME,
-		sizeof(modulator->name));
-
-	modulator->rangelow = WL1273_FREQ(WL1273_BAND_JAPAN_LOW);
-	modulator->rangehigh = WL1273_FREQ(WL1273_BAND_OTHER_HIGH);
-
-	modulator->capability =  V4L2_TUNER_CAP_LOW | V4L2_TUNER_CAP_RDS |
-		V4L2_TUNER_CAP_STEREO | V4L2_TUNER_CAP_RDS_BLOCK_IO;
-
-	if (core->mode != WL1273_MODE_TX)
-		return 0;
-
-	if (mutex_lock_interruptible(&core->lock))
-		return -EINTR;
-
-	r = core->read(core, WL1273_MONO_SET, &val);
-	if (r)
-		goto out;
-
-	if (val == WL1273_TX_STEREO)
-		modulator->txsubchans = V4L2_TUNER_SUB_STEREO;
-	else
-		modulator->txsubchans = V4L2_TUNER_SUB_MONO;
-
-	if (radio->rds_on)
-		modulator->txsubchans |= V4L2_TUNER_SUB_RDS;
-out:
-	mutex_unlock(&core->lock);
-
-	return 0;
-}
-
-static int wl1273_fm_vidioc_log_status(struct file *file, void *priv)
-{
-	struct wl1273_device *radio = video_get_drvdata(video_devdata(file));
-	struct wl1273_core *core = radio->core;
-	struct device *dev = radio->dev;
-	u16 val;
-	int r;
-
-	dev_info(dev, DRIVER_DESC);
-
-	if (core->mode == WL1273_MODE_OFF) {
-		dev_info(dev, "Mode: Off\n");
-		return 0;
-	}
-
-	if (core->mode == WL1273_MODE_SUSPENDED) {
-		dev_info(dev, "Mode: Suspended\n");
-		return 0;
-	}
-
-	r = core->read(core, WL1273_ASIC_ID_GET, &val);
-	if (r)
-		dev_err(dev, "%s: Get ASIC_ID fails.\n", __func__);
-	else
-		dev_info(dev, "ASIC_ID: 0x%04x\n", val);
-
-	r = core->read(core, WL1273_ASIC_VER_GET, &val);
-	if (r)
-		dev_err(dev, "%s: Get ASIC_VER fails.\n", __func__);
-	else
-		dev_info(dev, "ASIC Version: 0x%04x\n", val);
-
-	r = core->read(core, WL1273_FIRM_VER_GET, &val);
-	if (r)
-		dev_err(dev, "%s: Get FIRM_VER fails.\n", __func__);
-	else
-		dev_info(dev, "FW version: %d(0x%04x)\n", val, val);
-
-	r = core->read(core, WL1273_BAND_SET, &val);
-	if (r)
-		dev_err(dev, "%s: Get BAND fails.\n", __func__);
-	else
-		dev_info(dev, "BAND: %d\n", val);
-
-	if (core->mode == WL1273_MODE_TX) {
-		r = core->read(core, WL1273_PUPD_SET, &val);
-		if (r)
-			dev_err(dev, "%s: Get PUPD fails.\n", __func__);
-		else
-			dev_info(dev, "PUPD: 0x%04x\n", val);
-
-		r = core->read(core, WL1273_CHANL_SET, &val);
-		if (r)
-			dev_err(dev, "%s: Get CHANL fails.\n", __func__);
-		else
-			dev_info(dev, "Tx frequency: %dkHz\n", val*10);
-	} else if (core->mode == WL1273_MODE_RX) {
-		int bf = radio->rangelow;
-
-		r = core->read(core, WL1273_FREQ_SET, &val);
-		if (r)
-			dev_err(dev, "%s: Get FREQ fails.\n", __func__);
-		else
-			dev_info(dev, "RX Frequency: %dkHz\n", bf + val*50);
-
-		r = core->read(core, WL1273_MOST_MODE_SET, &val);
-		if (r)
-			dev_err(dev, "%s: Get MOST_MODE fails.\n",
-				__func__);
-		else if (val == 0)
-			dev_info(dev, "MOST_MODE: Stereo according to blend\n");
-		else if (val == 1)
-			dev_info(dev, "MOST_MODE: Force mono output\n");
-		else
-			dev_info(dev, "MOST_MODE: Unexpected value: %d\n", val);
-
-		r = core->read(core, WL1273_MOST_BLEND_SET, &val);
-		if (r)
-			dev_err(dev, "%s: Get MOST_BLEND fails.\n", __func__);
-		else if (val == 0)
-			dev_info(dev,
-				 "MOST_BLEND: Switched blend & hysteresis.\n");
-		else if (val == 1)
-			dev_info(dev, "MOST_BLEND: Soft blend.\n");
-		else
-			dev_info(dev, "MOST_BLEND: Unexpected val: %d\n", val);
-
-		r = core->read(core, WL1273_STEREO_GET, &val);
-		if (r)
-			dev_err(dev, "%s: Get STEREO fails.\n", __func__);
-		else if (val == 0)
-			dev_info(dev, "STEREO: Not detected\n");
-		else if (val == 1)
-			dev_info(dev, "STEREO: Detected\n");
-		else
-			dev_info(dev, "STEREO: Unexpected value: %d\n", val);
-
-		r = core->read(core, WL1273_RSSI_LVL_GET, &val);
-		if (r)
-			dev_err(dev, "%s: Get RSSI_LVL fails.\n", __func__);
-		else
-			dev_info(dev, "RX signal strength: %d\n", (s16) val);
-
-		r = core->read(core, WL1273_POWER_SET, &val);
-		if (r)
-			dev_err(dev, "%s: Get POWER fails.\n", __func__);
-		else
-			dev_info(dev, "POWER: 0x%04x\n", val);
-
-		r = core->read(core, WL1273_INT_MASK_SET, &val);
-		if (r)
-			dev_err(dev, "%s: Get INT_MASK fails.\n", __func__);
-		else
-			dev_info(dev, "INT_MASK: 0x%04x\n", val);
-
-		r = core->read(core, WL1273_RDS_SYNC_GET, &val);
-		if (r)
-			dev_err(dev, "%s: Get RDS_SYNC fails.\n",
-				__func__);
-		else if (val == 0)
-			dev_info(dev, "RDS_SYNC: Not synchronized\n");
-
-		else if (val == 1)
-			dev_info(dev, "RDS_SYNC: Synchronized\n");
-		else
-			dev_info(dev, "RDS_SYNC: Unexpected value: %d\n", val);
-
-		r = core->read(core, WL1273_I2S_MODE_CONFIG_SET, &val);
-		if (r)
-			dev_err(dev, "%s: Get I2S_MODE_CONFIG fails.\n",
-				__func__);
-		else
-			dev_info(dev, "I2S_MODE_CONFIG: 0x%04x\n", val);
-
-		r = core->read(core, WL1273_VOLUME_SET, &val);
-		if (r)
-			dev_err(dev, "%s: Get VOLUME fails.\n", __func__);
-		else
-			dev_info(dev, "VOLUME: 0x%04x\n", val);
-	}
-
-	return 0;
-}
-
-static void wl1273_vdev_release(struct video_device *dev)
-{
-}
-
-static const struct v4l2_ctrl_ops wl1273_ctrl_ops = {
-	.s_ctrl = wl1273_fm_s_ctrl,
-	.g_volatile_ctrl = wl1273_fm_g_volatile_ctrl,
-};
-
-static const struct v4l2_ioctl_ops wl1273_ioctl_ops = {
-	.vidioc_querycap	= wl1273_fm_vidioc_querycap,
-	.vidioc_g_input		= wl1273_fm_vidioc_g_input,
-	.vidioc_s_input		= wl1273_fm_vidioc_s_input,
-	.vidioc_g_audio		= wl1273_fm_vidioc_g_audio,
-	.vidioc_s_audio		= wl1273_fm_vidioc_s_audio,
-	.vidioc_g_tuner		= wl1273_fm_vidioc_g_tuner,
-	.vidioc_s_tuner		= wl1273_fm_vidioc_s_tuner,
-	.vidioc_g_frequency	= wl1273_fm_vidioc_g_frequency,
-	.vidioc_s_frequency	= wl1273_fm_vidioc_s_frequency,
-	.vidioc_s_hw_freq_seek	= wl1273_fm_vidioc_s_hw_freq_seek,
-	.vidioc_g_modulator	= wl1273_fm_vidioc_g_modulator,
-	.vidioc_s_modulator	= wl1273_fm_vidioc_s_modulator,
-	.vidioc_log_status      = wl1273_fm_vidioc_log_status,
-};
-
-static const struct video_device wl1273_viddev_template = {
-	.fops			= &wl1273_fops,
-	.ioctl_ops		= &wl1273_ioctl_ops,
-	.name			= WL1273_FM_DRIVER_NAME,
-	.release		= wl1273_vdev_release,
-	.vfl_dir		= VFL_DIR_TX,
-	.device_caps		= V4L2_CAP_HW_FREQ_SEEK | V4L2_CAP_TUNER |
-				  V4L2_CAP_RADIO | V4L2_CAP_AUDIO |
-				  V4L2_CAP_RDS_CAPTURE | V4L2_CAP_MODULATOR |
-				  V4L2_CAP_RDS_OUTPUT,
-};
-
-static void wl1273_fm_radio_remove(struct platform_device *pdev)
-{
-	struct wl1273_device *radio = platform_get_drvdata(pdev);
-	struct wl1273_core *core = radio->core;
-
-	dev_info(&pdev->dev, "%s.\n", __func__);
-
-	free_irq(core->client->irq, radio);
-	core->pdata->free_resources();
-
-	v4l2_ctrl_handler_free(&radio->ctrl_handler);
-	video_unregister_device(&radio->videodev);
-	v4l2_device_unregister(&radio->v4l2dev);
-}
-
-static int wl1273_fm_radio_probe(struct platform_device *pdev)
-{
-	struct wl1273_core **core = pdev->dev.platform_data;
-	struct wl1273_device *radio;
-	struct v4l2_ctrl *ctrl;
-	int r = 0;
-
-	pr_debug("%s\n", __func__);
-
-	if (!core) {
-		dev_err(&pdev->dev, "No platform data.\n");
-		r = -EINVAL;
-		goto pdata_err;
-	}
-
-	radio = devm_kzalloc(&pdev->dev, sizeof(*radio), GFP_KERNEL);
-	if (!radio) {
-		r = -ENOMEM;
-		goto pdata_err;
-	}
-
-	/* RDS buffer allocation */
-	radio->buf_size = rds_buf * RDS_BLOCK_SIZE;
-	radio->buffer = devm_kzalloc(&pdev->dev, radio->buf_size, GFP_KERNEL);
-	if (!radio->buffer) {
-		pr_err("Cannot allocate memory for RDS buffer.\n");
-		r = -ENOMEM;
-		goto pdata_err;
-	}
-
-	radio->core = *core;
-	radio->irq_flags = WL1273_IRQ_MASK;
-	radio->dev = &radio->core->client->dev;
-	radio->rds_on = false;
-	radio->core->mode = WL1273_MODE_OFF;
-	radio->tx_power = 118;
-	radio->core->audio_mode = WL1273_AUDIO_ANALOG;
-	radio->band = WL1273_BAND_OTHER;
-	radio->core->i2s_mode = WL1273_I2S_DEF_MODE;
-	radio->core->channel_number = 2;
-	radio->core->volume = WL1273_DEFAULT_VOLUME;
-	radio->rx_frequency = WL1273_BAND_OTHER_LOW;
-	radio->tx_frequency = WL1273_BAND_OTHER_HIGH;
-	radio->rangelow = WL1273_BAND_OTHER_LOW;
-	radio->rangehigh = WL1273_BAND_OTHER_HIGH;
-	radio->stereo = true;
-	radio->bus_type = "I2C";
-
-	if (radio->core->pdata->request_resources) {
-		r = radio->core->pdata->request_resources(radio->core->client);
-		if (r) {
-			dev_err(radio->dev, WL1273_FM_DRIVER_NAME
-				": Cannot get platform data\n");
-			goto pdata_err;
-		}
-
-		dev_dbg(radio->dev, "irq: %d\n", radio->core->client->irq);
-
-		r = request_threaded_irq(radio->core->client->irq, NULL,
-					 wl1273_fm_irq_thread_handler,
-					 IRQF_ONESHOT | IRQF_TRIGGER_FALLING,
-					 "wl1273-fm", radio);
-		if (r < 0) {
-			dev_err(radio->dev, WL1273_FM_DRIVER_NAME
-				": Unable to register IRQ handler: %d\n", r);
-			goto err_request_irq;
-		}
-	} else {
-		dev_err(radio->dev, WL1273_FM_DRIVER_NAME ": Core WL1273 IRQ not configured");
-		r = -EINVAL;
-		goto pdata_err;
-	}
-
-	init_completion(&radio->busy);
-	init_waitqueue_head(&radio->read_queue);
-
-	radio->write_buf = devm_kzalloc(&pdev->dev, 256, GFP_KERNEL);
-	if (!radio->write_buf) {
-		r = -ENOMEM;
-		goto write_buf_err;
-	}
-
-	radio->dev = &pdev->dev;
-	radio->v4l2dev.ctrl_handler = &radio->ctrl_handler;
-	radio->rds_users = 0;
-
-	r = v4l2_device_register(&pdev->dev, &radio->v4l2dev);
-	if (r) {
-		dev_err(&pdev->dev, "Cannot register v4l2_device.\n");
-		goto write_buf_err;
-	}
-
-	/* V4L2 configuration */
-	radio->videodev = wl1273_viddev_template;
-
-	radio->videodev.v4l2_dev = &radio->v4l2dev;
-
-	v4l2_ctrl_handler_init(&radio->ctrl_handler, 6);
-
-	/* add in ascending ID order */
-	v4l2_ctrl_new_std(&radio->ctrl_handler, &wl1273_ctrl_ops,
-			  V4L2_CID_AUDIO_VOLUME, 0, WL1273_MAX_VOLUME, 1,
-			  WL1273_DEFAULT_VOLUME);
-
-	v4l2_ctrl_new_std(&radio->ctrl_handler, &wl1273_ctrl_ops,
-			  V4L2_CID_AUDIO_MUTE, 0, 1, 1, 1);
-
-	v4l2_ctrl_new_std_menu(&radio->ctrl_handler, &wl1273_ctrl_ops,
-			       V4L2_CID_TUNE_PREEMPHASIS,
-			       V4L2_PREEMPHASIS_75_uS, 0x03,
-			       V4L2_PREEMPHASIS_50_uS);
-
-	v4l2_ctrl_new_std(&radio->ctrl_handler, &wl1273_ctrl_ops,
-			  V4L2_CID_TUNE_POWER_LEVEL, 91, 122, 1, 118);
-
-	ctrl = v4l2_ctrl_new_std(&radio->ctrl_handler, &wl1273_ctrl_ops,
-				 V4L2_CID_TUNE_ANTENNA_CAPACITOR,
-				 0, 255, 1, 255);
-	if (ctrl)
-		ctrl->flags |= V4L2_CTRL_FLAG_VOLATILE;
-
-	if (radio->ctrl_handler.error) {
-		r = radio->ctrl_handler.error;
-		dev_err(&pdev->dev, "Ctrl handler error: %d\n", r);
-		goto handler_init_err;
-	}
-
-	video_set_drvdata(&radio->videodev, radio);
-	platform_set_drvdata(pdev, radio);
-
-	/* register video device */
-	r = video_register_device(&radio->videodev, VFL_TYPE_RADIO, radio_nr);
-	if (r) {
-		dev_err(&pdev->dev, WL1273_FM_DRIVER_NAME
-			": Could not register video device\n");
-		goto handler_init_err;
-	}
-
-	return 0;
-
-handler_init_err:
-	v4l2_ctrl_handler_free(&radio->ctrl_handler);
-	v4l2_device_unregister(&radio->v4l2dev);
-write_buf_err:
-	free_irq(radio->core->client->irq, radio);
-err_request_irq:
-	radio->core->pdata->free_resources();
-pdata_err:
-	return r;
-}
-
-static struct platform_driver wl1273_fm_radio_driver = {
-	.probe		= wl1273_fm_radio_probe,
-	.remove		= wl1273_fm_radio_remove,
-	.driver		= {
-		.name	= "wl1273_fm_radio",
-	},
-};
-
-module_platform_driver(wl1273_fm_radio_driver);
-
-MODULE_AUTHOR("Matti Aaltonen <[email protected]>");
-MODULE_DESCRIPTION(DRIVER_DESC);
-MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:wl1273_fm_radio");
Signature · 3 lines
Regards,

Laurent Pinchart
#13 lore raw
In reply to Dr. David Alan Gilbert
Quoted 29 lines · Dr. David Alan Gilbert
Quoted 28 lines · * Laurent Pinchart ([email protected]) wrote:
Quoted 26 lines · Dr. David Alan Gilbert
Quoted 10 lines · * Patchwork Integration ([email protected]) wrote:

Dear Dr. David Alan Gilbert:

Thanks for your patches! Unfortunately the Media CI robot detected some issues:

# Test checkpatch:./0001-media-radio-wl1273-Remove.patch checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #7:
https://lore.kernel.org/lkml/[email protected]/

Quoted 5 lines

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #61:
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 30 lines checked

I did check that, couldn't find any appropriate MAINTAINERS entry anyway

Quoted 4 lines

# Test checkpatch:./0002-ASoC-wl1273-Remove.patch checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #7:
https://lore.kernel.org/lkml/[email protected]/

Yep, said that in my cover letter; suggestions on how to refer to that URL in a better way are welcome.

Quoted 6 lines
Quoted 1 line

You can ignore those two warnings.

Thanks for confirming that.
Could you (or some other -media maintainer) pick 1/4 for linux-media please; Generally I think Lee tends only to pick the mfd specific bit up, so I need to get the specifics in through the other trees.

We can take patch 1/4 in the media tree, but merging the different pieces in an uncoordinated fashion will result in breakages in linux-next :-/

I think the simplest option would be to create a branch on top of v6.16 (or v6.17-rc1) with the 4 patches applied, and merge it in the media, mfd and sound trees. That would require Lee to drop patches 3/4 and 4/4 that he already applied to the mfd tree though.

Quoted 49 lines
Quoted 49 lines
Quoted 49 lines
Quoted 49 lines

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #71:
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 36 lines checked

# Test checkpatch:./0003-mfd-wl1273-core-Remove.patch checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #8:
https://lore.kernel.org/lkml/[email protected]/

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #55:
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 23 lines checked

# Test checkpatch:./0004-mfd-wl1273-core-Remove-the-header.patch checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #7:
https://lore.kernel.org/lkml/[email protected]/

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #35:
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 7 lines checked

Please fix your series, and upload a new version. If you have a patchwork account, do not forget to mark the current series as Superseded.

For more details, check the full report at:
https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/79088843/artifacts/report.htm .

Best regards, and Happy Hacking!
Media CI robot on behalf of the linux-media community.

---
Check the latest rules for contributing your patches at:
https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html

If you believe that the CI is wrong, kindly open an issue at
https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all to this message.

Signature · 3 lines
Regards,

Laurent Pinchart
#20 lore raw

Re: (subset) [PATCH 0/4] Remove the wl1273 FM Radio

In reply to Laurent Pinchart
Quoted 22 lines · * Laurent Pinchart ([email protected]) wrote:

Hi Lee,

Quoted 10 lines · Lee Jones
Quoted 9 lines · On Wed, 25 Jun 2025 14:32:54 +0100, [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

I noticed that the wl1273 radio had an unused symbol, but then noticed it is on Arnd's unused driver list:
https://lore.kernel.org/lkml/[email protected]/

So, delete it.
The components seem pretty separable, except for Kconfig dependencies.

Quoted 8 lines
Quoted 1 line

[...]

Applied, thanks!

[3/4] mfd: wl1273-core: Remove

      commit: efddd98938400a570bde5bc69b5ecc7e76cacbe1
[4/4] mfd: wl1273-core: Remove the header
      commit: d356033e7b1e94e0187bb0651f4a066a4646fbb9
Quoted 6 lines

Ah, that may answer the question I just posted in another reply to the cover letter.

I think patch 4/4 will break build in -next until patches 1/4 and 2/4 get merged too. Should we get 1/4 and 2/4 merged in the media and sound trees ASAP, or would you prefer a different option ?

That makes sense to me.

Dave

Quoted 5 lines
Signature · 4 lines
-- 
Regards,

Laurent Pinchart
Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
#14 lore raw
In reply to Laurent Pinchart
Quoted 32 lines · * Laurent Pinchart ([email protected]) wrote:
Quoted 31 lines · Dr. David Alan Gilbert
Quoted 29 lines · * Laurent Pinchart ([email protected]) wrote:
Quoted 19 lines · Dr. David Alan Gilbert
Quoted 10 lines · * Patchwork Integration ([email protected]) wrote:

Dear Dr. David Alan Gilbert:

Thanks for your patches! Unfortunately the Media CI robot detected some issues:

# Test checkpatch:./0001-media-radio-wl1273-Remove.patch checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #7:
https://lore.kernel.org/lkml/[email protected]/

Quoted 5 lines

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #61:
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 30 lines checked

I did check that, couldn't find any appropriate MAINTAINERS entry anyway

Quoted 7 lines
Quoted 4 lines

# Test checkpatch:./0002-ASoC-wl1273-Remove.patch checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #7:
https://lore.kernel.org/lkml/[email protected]/

Yep, said that in my cover letter; suggestions on how to refer to that URL in a better way are welcome.

You can ignore those two warnings.

Quoted 8 lines
Quoted 4 lines

Thanks for confirming that.
Could you (or some other -media maintainer) pick 1/4 for linux-media please; Generally I think Lee tends only to pick the mfd specific bit up, so I need to get the specifics in through the other trees.

We can take patch 1/4 in the media tree, but merging the different pieces in an uncoordinated fashion will result in breakages in linux-next :-/

It should be safe to go in order; so you taking patch 1/4 should move things forward.

Dave

Quoted 59 lines

I think the simplest option would be to create a branch on top of v6.16 (or v6.17-rc1) with the 4 patches applied, and merge it in the media, mfd and sound trees. That would require Lee to drop patches 3/4 and 4/4 that he already applied to the mfd tree though.

Quoted 49 lines
Quoted 49 lines
Quoted 49 lines
Quoted 49 lines

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #71:
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 36 lines checked

# Test checkpatch:./0003-mfd-wl1273-core-Remove.patch checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #8:
https://lore.kernel.org/lkml/[email protected]/

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #55:
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 23 lines checked

# Test checkpatch:./0004-mfd-wl1273-core-Remove-the-header.patch checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #7:
https://lore.kernel.org/lkml/[email protected]/

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #35:
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 7 lines checked

Please fix your series, and upload a new version. If you have a patchwork account, do not forget to mark the current series as Superseded.

For more details, check the full report at:
https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/79088843/artifacts/report.htm .

Best regards, and Happy Hacking!
Media CI robot on behalf of the linux-media community.

---
Check the latest rules for contributing your patches at:
https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html

If you believe that the CI is wrong, kindly open an issue at
https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all to this message.

Signature · 3 lines
Regards,

Laurent Pinchart
Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
#15 lore raw
Quoted 38 lines · Dr. David Alan Gilbert
Quoted 37 lines · * Laurent Pinchart ([email protected]) wrote:
Quoted 35 lines · Dr. David Alan Gilbert
Quoted 25 lines · * Laurent Pinchart ([email protected]) wrote:
Quoted 24 lines · Dr. David Alan Gilbert
Quoted 10 lines · * Patchwork Integration ([email protected]) wrote:

Dear Dr. David Alan Gilbert:

Thanks for your patches! Unfortunately the Media CI robot detected some issues:

# Test checkpatch:./0001-media-radio-wl1273-Remove.patch checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #7:
https://lore.kernel.org/lkml/[email protected]/

Quoted 5 lines

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #61:
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 30 lines checked

I did check that, couldn't find any appropriate MAINTAINERS entry anyway

Quoted 4 lines

# Test checkpatch:./0002-ASoC-wl1273-Remove.patch checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #7:
https://lore.kernel.org/lkml/[email protected]/

Quoted 4 lines
Quoted 2 lines

Yep, said that in my cover letter; suggestions on how to refer to that URL in a better way are welcome.

You can ignore those two warnings.

Thanks for confirming that.
Could you (or some other -media maintainer) pick 1/4 for linux-media please; Generally I think Lee tends only to pick the mfd specific bit up, so I need to get the specifics in through the other trees.

Quoted 6 lines
Quoted 3 lines

We can take patch 1/4 in the media tree, but merging the different pieces in an uncoordinated fashion will result in breakages in linux-next :-/

It should be safe to go in order; so you taking patch 1/4 should move things forward.

1/4 to 3/4 can be merged in any order, but 4/4 depends on the first three patches getting merged first. The simplest option is to merge 1/4 to 3/4 for v6.18 through their respective trees, and 4/4 for v6.19. To speed up merging 4/4 in v6.18 we need to coordinate between the three subsystem maintainers.

Quoted 54 lines
Quoted 54 lines

I think the simplest option would be to create a branch on top of v6.16 (or v6.17-rc1) with the 4 patches applied, and merge it in the media, mfd and sound trees. That would require Lee to drop patches 3/4 and 4/4 that he already applied to the mfd tree though.

Quoted 49 lines
Quoted 49 lines
Quoted 49 lines
Quoted 49 lines

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #71:
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 36 lines checked

# Test checkpatch:./0003-mfd-wl1273-core-Remove.patch checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #8:
https://lore.kernel.org/lkml/[email protected]/

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #55:
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 23 lines checked

# Test checkpatch:./0004-mfd-wl1273-core-Remove-the-header.patch checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #7:
https://lore.kernel.org/lkml/[email protected]/

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #35:
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 7 lines checked

Please fix your series, and upload a new version. If you have a patchwork account, do not forget to mark the current series as Superseded.

For more details, check the full report at:
https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/79088843/artifacts/report.htm .

Best regards, and Happy Hacking!
Media CI robot on behalf of the linux-media community.

---
Check the latest rules for contributing your patches at:
https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html

If you believe that the CI is wrong, kindly open an issue at
https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all to this message.

Signature · 3 lines
Regards,

Laurent Pinchart
maintainer
#30 lore raw

PATCH 1/1 checkpatch: Allow http links of any length in commit logs

In reply to [email protected]

Dave Gilbert noticed that checkpatch warns about URL links over 75 chars in length in commit logs.

Fix that.

---
 scripts/checkpatch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/checkpatch.pl +1 -1
index e722dd6fa8ef3..319cc5f858858 100755
@@ -3294,7 +3294,7 @@ sub process {
 					# file delta changes
 		      $line =~ /^\s*(?:[\w\.\-\+]*\/)++[\w\.\-\+]+:/ ||
 					# filename then :
-		      $line =~ /^\s*(?:Fixes:|$link_tags_search|$signature_tags)/i ||
+		      $line =~ /^\s*(?:Fixes:|https?:|$link_tags_search|$signature_tags)/i ||
 					# A Fixes:, link or signature tag line
 		      $commit_log_possible_stack_dump)) {
 			WARN("COMMIT_LOG_LONG_LINE",
#16 lore raw
In reply to Laurent Pinchart
Quoted 43 lines · * Laurent Pinchart ([email protected]) wrote:
Quoted 42 lines · Dr. David Alan Gilbert
Quoted 40 lines · * Laurent Pinchart ([email protected]) wrote:
Quoted 29 lines · Dr. David Alan Gilbert
Quoted 28 lines · * Laurent Pinchart ([email protected]) wrote:
Quoted 26 lines · Dr. David Alan Gilbert
Quoted 10 lines · * Patchwork Integration ([email protected]) wrote:

Dear Dr. David Alan Gilbert:

Thanks for your patches! Unfortunately the Media CI robot detected some issues:

# Test checkpatch:./0001-media-radio-wl1273-Remove.patch checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #7:
https://lore.kernel.org/lkml/[email protected]/

Quoted 5 lines

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #61:
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 30 lines checked

I did check that, couldn't find any appropriate MAINTAINERS entry anyway

Quoted 4 lines

# Test checkpatch:./0002-ASoC-wl1273-Remove.patch checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #7:
https://lore.kernel.org/lkml/[email protected]/

Yep, said that in my cover letter; suggestions on how to refer to that URL in a better way are welcome.

Quoted 6 lines
Quoted 1 line

You can ignore those two warnings.

Thanks for confirming that.
Could you (or some other -media maintainer) pick 1/4 for linux-media please; Generally I think Lee tends only to pick the mfd specific bit up, so I need to get the specifics in through the other trees.

We can take patch 1/4 in the media tree, but merging the different pieces in an uncoordinated fashion will result in breakages in linux-next :-/

Quoted 8 lines
Quoted 2 lines

It should be safe to go in order; so you taking patch 1/4 should move things forward.

1/4 to 3/4 can be merged in any order, but 4/4 depends on the first three patches getting merged first. The simplest option is to merge 1/4 to 3/4 for v6.18 through their respective trees, and 4/4 for v6.19. To speed up merging 4/4 in v6.18 we need to coordinate between the three subsystem maintainers.

I see you've picked 1/4 up in -next - thanks!
I'll give the sound folk a prod for 2/4.
For 3/4 and 4/4 probably the easiest thing if we can get 2 in is if 3/4 and 4/4 go in as a pair in 6.19.
All this coordination thing seems to be rare!

Dave

Quoted 59 lines
Quoted 54 lines
Quoted 54 lines

I think the simplest option would be to create a branch on top of v6.16 (or v6.17-rc1) with the 4 patches applied, and merge it in the media, mfd and sound trees. That would require Lee to drop patches 3/4 and 4/4 that he already applied to the mfd tree though.

Quoted 49 lines
Quoted 49 lines
Quoted 49 lines
Quoted 49 lines

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #71:
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 36 lines checked

# Test checkpatch:./0003-mfd-wl1273-core-Remove.patch checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #8:
https://lore.kernel.org/lkml/[email protected]/

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #55:
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 23 lines checked

# Test checkpatch:./0004-mfd-wl1273-core-Remove-the-header.patch checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #7:
https://lore.kernel.org/lkml/[email protected]/

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #35:
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 7 lines checked

Please fix your series, and upload a new version. If you have a patchwork account, do not forget to mark the current series as Superseded.

For more details, check the full report at:
https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/79088843/artifacts/report.htm .

Best regards, and Happy Hacking!
Media CI robot on behalf of the linux-media community.

---
Check the latest rules for contributing your patches at:
https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html

If you believe that the CI is wrong, kindly open an issue at
https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all to this message.

Signature · 3 lines
Regards,

Laurent Pinchart
Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
#5 lore raw

Re: [PATCH 2/4] ASoC: wl1273: Remove

In reply to Mark Brown
Quoted 8 lines · * Mark Brown ([email protected]) wrote:
Quoted 5 lines · On Wed, Jun 25, 2025 at 02:32:56PM +0100, [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

The wl1273 FM radio is on Arnd's unused driver list:
https://lore.kernel.org/lkml/[email protected]/
Remove the codec component.

Thanks Mark; can you pick this 2/4 up via sound for 6.18 please? (1/4 just went into -next already via media)

Thanks,

Dave

Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
#17 lore raw
In reply to Dr. David Alan Gilbert
Quoted 47 lines · Dr. David Alan Gilbert
Quoted 46 lines · * Laurent Pinchart ([email protected]) wrote:
Quoted 44 lines · Dr. David Alan Gilbert
Quoted 32 lines · * Laurent Pinchart ([email protected]) wrote:
Quoted 31 lines · Dr. David Alan Gilbert
Quoted 29 lines · * Laurent Pinchart ([email protected]) wrote:
Quoted 19 lines · Dr. David Alan Gilbert
Quoted 10 lines · * Patchwork Integration ([email protected]) wrote:

Dear Dr. David Alan Gilbert:

Thanks for your patches! Unfortunately the Media CI robot detected some issues:

# Test checkpatch:./0001-media-radio-wl1273-Remove.patch checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #7:
https://lore.kernel.org/lkml/[email protected]/

Quoted 5 lines

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #61:
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 30 lines checked

I did check that, couldn't find any appropriate MAINTAINERS entry anyway

Quoted 7 lines
Quoted 4 lines

# Test checkpatch:./0002-ASoC-wl1273-Remove.patch checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #7:
https://lore.kernel.org/lkml/[email protected]/

Yep, said that in my cover letter; suggestions on how to refer to that URL in a better way are welcome.

You can ignore those two warnings.

Quoted 8 lines
Quoted 4 lines

Thanks for confirming that.
Could you (or some other -media maintainer) pick 1/4 for linux-media please; Generally I think Lee tends only to pick the mfd specific bit up, so I need to get the specifics in through the other trees.

We can take patch 1/4 in the media tree, but merging the different pieces in an uncoordinated fashion will result in breakages in linux-next :-/

It should be safe to go in order; so you taking patch 1/4 should move things forward.

Quoted 7 lines
Quoted 5 lines

1/4 to 3/4 can be merged in any order, but 4/4 depends on the first three patches getting merged first. The simplest option is to merge 1/4 to 3/4 for v6.18 through their respective trees, and 4/4 for v6.19. To speed up merging 4/4 in v6.18 we need to coordinate between the three subsystem maintainers.

I see you've picked 1/4 up in -next - thanks!

I haven't, but Hans did :-)

Quoted 3 lines

I'll give the sound folk a prod for 2/4.
For 3/4 and 4/4 probably the easiest thing if we can get 2 in is if 3/4 and 4/4 go in as a pair in 6.19.

3/4 could go in v6.18 already, it's only 4/4 that is bothersome.

Quoted 1 line

All this coordination thing seems to be rare!

It's not the most common case indeed, but it still happens routinely.

Quoted 54 lines
Quoted 54 lines
Quoted 54 lines
Quoted 54 lines

I think the simplest option would be to create a branch on top of v6.16 (or v6.17-rc1) with the 4 patches applied, and merge it in the media, mfd and sound trees. That would require Lee to drop patches 3/4 and 4/4 that he already applied to the mfd tree though.

Quoted 49 lines
Quoted 49 lines
Quoted 49 lines
Quoted 49 lines

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #71:
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 36 lines checked

# Test checkpatch:./0003-mfd-wl1273-core-Remove.patch checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #8:
https://lore.kernel.org/lkml/[email protected]/

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #55:
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 23 lines checked

# Test checkpatch:./0004-mfd-wl1273-core-Remove-the-header.patch checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #7:
https://lore.kernel.org/lkml/[email protected]/

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #35:
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 7 lines checked

Please fix your series, and upload a new version. If you have a patchwork account, do not forget to mark the current series as Superseded.

For more details, check the full report at:
https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/79088843/artifacts/report.htm .

Best regards, and Happy Hacking!
Media CI robot on behalf of the linux-media community.

---
Check the latest rules for contributing your patches at:
https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html

If you believe that the CI is wrong, kindly open an issue at
https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all to this message.

Signature · 3 lines
Regards,

Laurent Pinchart
maintainer
#31 lore raw

Re: (subset) [PATCH 0/4] Remove the wl1273 FM Radio

In reply to [email protected]
Quoted 8 lines · On Wed, 25 Jun 2025 14:32:54 +0100, [email protected] wrote:

I noticed that the wl1273 radio had an unused symbol, but then noticed it is on Arnd's unused driver list:
https://lore.kernel.org/lkml/[email protected]/

So, delete it.
The components seem pretty separable, except for Kconfig dependencies.

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[2/4] ASoC: wl1273: Remove

      commit: a46e95c81e3a28926ab1904d9f754fef8318074d

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

#32 lore raw

Re: (subset) [PATCH 0/4] Remove the wl1273 FM Radio

Quoted 5 lines · * Mark Brown ([email protected]) wrote:
Quoted 4 lines · On Wed, 25 Jun 2025 14:32:54 +0100, [email protected] wrote:

I noticed that the wl1273 radio had an unused symbol, but then noticed it is on Arnd's unused driver list:
https://lore.kernel.org/lkml/[email protected]/

Quoted 8 lines
Quoted 4 lines

So, delete it.
The components seem pretty separable, except for Kconfig dependencies.

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks! I see that in next; so Lee can do 3/4-4/4 maybe in the following cycle or later in this one.

Dave

Quoted 24 lines

Thanks!

[2/4] ASoC: wl1273: Remove

      commit: a46e95c81e3a28926ab1904d9f754fef8318074d

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
maintainer Acked-by
#22 lore raw
In reply to Laurent Pinchart
Quoted 21 lines · Laurent Pinchart
Quoted 12 lines · On Wed, Jun 25, 2025 at 02:32:54PM +0100, [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

I noticed that the wl1273 radio had an unused symbol, but then noticed it is on Arnd's unused driver list:
https://lore.kernel.org/lkml/[email protected]/

So, delete it.
The components seem pretty separable, except for Kconfig dependencies.

That lore URL is over 75 chars, which checkpatch warns about, suggestions welcome.

Quoted 7 lines

Dave

Dr. David Alan Gilbert (4):
media: radio-wl1273: Remove
ASoC: wl1273: Remove
mfd: wl1273-core: Remove
mfd: wl1273-core: Remove the header

Quoted 6 lines

Mark, Lee, how would you like this to be merged ? I have a large patch series targetting v6.18 that depends on 1/4, and I would like to merge it in the media tree as soon as possible after -rc1 gets released. Patches 1/4, 2/4 and 3/4 are independent of each other, but patch 4/4 depends on the first three. Can we merge 1/4 in the media tree and provide a stable branch right on top of -rc1 ?

I'm also set-up pretty well to provide this. Happy either way.

If you decide to take it:

Signature · 1 line
Lee Jones [李琼斯]
maintainer
#23 lore raw
Quoted 9 lines · Lee Jones
Quoted 6 lines · Laurent Pinchart

Mark, Lee, how would you like this to be merged ? I have a large patch series targetting v6.18 that depends on 1/4, and I would like to merge it in the media tree as soon as possible after -rc1 gets released. Patches 1/4, 2/4 and 3/4 are independent of each other, but patch 4/4 depends on the first three. Can we merge 1/4 in the media tree and provide a stable branch right on top of -rc1 ?

Quoted 5 lines

I'm also set-up pretty well to provide this. Happy either way.

If you decide to take it:

Yeah, me too - I acked already and I was expecting someone else to take the series, whoever it is that's fine.

#24 lore raw
In reply to Lee Jones
Quoted 29 lines · Lee Jones
Quoted 21 lines · Laurent Pinchart
Quoted 12 lines · On Wed, Jun 25, 2025 at 02:32:54PM +0100, [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

I noticed that the wl1273 radio had an unused symbol, but then noticed it is on Arnd's unused driver list:
https://lore.kernel.org/lkml/[email protected]/

So, delete it.
The components seem pretty separable, except for Kconfig dependencies.

That lore URL is over 75 chars, which checkpatch warns about, suggestions welcome.

Quoted 7 lines

Dave

Dr. David Alan Gilbert (4):
media: radio-wl1273: Remove
ASoC: wl1273: Remove
mfd: wl1273-core: Remove
mfd: wl1273-core: Remove the header

Quoted 6 lines

Mark, Lee, how would you like this to be merged ? I have a large patch series targetting v6.18 that depends on 1/4, and I would like to merge it in the media tree as soon as possible after -rc1 gets released. Patches 1/4, 2/4 and 3/4 are independent of each other, but patch 4/4 depends on the first three. Can we merge 1/4 in the media tree and provide a stable branch right on top of -rc1 ?

Quoted 5 lines

I'm also set-up pretty well to provide this. Happy either way.

If you decide to take it:

Patch 1/4 has been queued in the media tree and should be in linux-next as commit 103b0cfc9ab6. It is based straight on v6.17-rc1. Patch 2/4 is also in linux-next, but is based on other ALSA patches. The simplest course of action would be for you to merge 3/4 for v6.18, and 4/4 for v6.19.

Signature · 3 lines
Regards,

Laurent Pinchart
maintainer
#25 lore raw
Quoted 5 lines · Laurent Pinchart

Patch 1/4 has been queued in the media tree and should be in linux-next as commit 103b0cfc9ab6. It is based straight on v6.17-rc1. Patch 2/4 is also in linux-next, but is based on other ALSA patches. The simplest course of action would be for you to merge 3/4 for v6.18, and 4/4 for v6.19.

Or given that it's a driver removal we could just get a rebase of the series against the meda tree applied? The conflicts with ASoC should be trivial to resolve.

#26 lore raw
Quoted 11 lines · Mark Brown
Quoted 5 lines · Laurent Pinchart

Patch 1/4 has been queued in the media tree and should be in linux-next as commit 103b0cfc9ab6. It is based straight on v6.17-rc1. Patch 2/4 is also in linux-next, but is based on other ALSA patches. The simplest course of action would be for you to merge 3/4 for v6.18, and 4/4 for v6.19.

Or given that it's a driver removal we could just get a rebase of the series against the meda tree applied? The conflicts with ASoC should be trivial to resolve.

I don't mind either way. I know Linus doesn't like having the same patch merged with different commit IDs, but I don't know how strict the rule is, especially when git should be able to resolve the conflict transparently.

Signature · 3 lines
Regards,

Laurent Pinchart
#27 lore raw
Quoted 9 lines · * Laurent Pinchart ([email protected]) wrote:
Quoted 8 lines · Mark Brown
Quoted 5 lines · Laurent Pinchart

Patch 1/4 has been queued in the media tree and should be in linux-next as commit 103b0cfc9ab6. It is based straight on v6.17-rc1. Patch 2/4 is also in linux-next, but is based on other ALSA patches. The simplest course of action would be for you to merge 3/4 for v6.18, and 4/4 for v6.19.

Quoted 8 lines
Quoted 3 lines

Or given that it's a driver removal we could just get a rebase of the series against the meda tree applied? The conflicts with ASoC should be trivial to resolve.

I don't mind either way. I know Linus doesn't like having the same patch merged with different commit IDs, but I don't know how strict the rule is, especially when git should be able to resolve the conflict transparently.

I still think the easiest thing is to leave 1/4 and 2/4 as you currently have them; and let Lee take 3/4 and 4/4 next time around.

Dave

Quoted 5 lines
Signature · 3 lines
Regards,

Laurent Pinchart
Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
maintainer
#28 lore raw
Quoted 14 lines · Dr. David Alan Gilbert
Quoted 13 lines · * Laurent Pinchart ([email protected]) wrote:
Quoted 11 lines · Mark Brown
Quoted 5 lines · Laurent Pinchart

Patch 1/4 has been queued in the media tree and should be in linux-next as commit 103b0cfc9ab6. It is based straight on v6.17-rc1. Patch 2/4 is also in linux-next, but is based on other ALSA patches. The simplest course of action would be for you to merge 3/4 for v6.18, and 4/4 for v6.19.

Or given that it's a driver removal we could just get a rebase of the series against the meda tree applied? The conflicts with ASoC should be trivial to resolve.

Quoted 7 lines
Quoted 4 lines

I don't mind either way. I know Linus doesn't like having the same patch merged with different commit IDs, but I don't know how strict the rule is, especially when git should be able to resolve the conflict transparently.

I still think the easiest thing is to leave 1/4 and 2/4 as you currently have them; and let Lee take 3/4 and 4/4 next time around.

It's more disjointed than I like. But it's okay. Remind me later.

Signature · 1 line
Lee Jones [李琼斯]
#29 lore raw
Quoted 21 lines · * Lee Jones ([email protected]) wrote:
Quoted 19 lines · Dr. David Alan Gilbert
Quoted 17 lines · * Laurent Pinchart ([email protected]) wrote:
Quoted 11 lines · Mark Brown
Quoted 5 lines · Laurent Pinchart

Patch 1/4 has been queued in the media tree and should be in linux-next as commit 103b0cfc9ab6. It is based straight on v6.17-rc1. Patch 2/4 is also in linux-next, but is based on other ALSA patches. The simplest course of action would be for you to merge 3/4 for v6.18, and 4/4 for v6.19.

Or given that it's a driver removal we could just get a rebase of the series against the meda tree applied? The conflicts with ASoC should be trivial to resolve.

I don't mind either way. I know Linus doesn't like having the same patch merged with different commit IDs, but I don't know how strict the rule is, especially when git should be able to resolve the conflict transparently.

Quoted 4 lines
Quoted 2 lines

I still think the easiest thing is to leave 1/4 and 2/4 as you currently have them; and let Lee take 3/4 and 4/4 next time around.

It's more disjointed than I like. But it's okay. Remind me later.

Hi Lee,
1 and 2 of this series just got merged into Linus' tree.
Thanks all!
3 and 4 can go in at your convenience.

Dave

Quoted 3 lines
Signature · 1 line
Lee Jones [李琼斯]
Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
maintainer Applied
#33 lore raw

Re: (subset) [PATCH 0/4] Remove the wl1273 FM Radio

In reply to [email protected]
Quoted 10 lines · On Wed, 25 Jun 2025 14:32:54 +0100, [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

I noticed that the wl1273 radio had an unused symbol, but then noticed it is on Arnd's unused driver list:
https://lore.kernel.org/lkml/[email protected]/

So, delete it.
The components seem pretty separable, except for Kconfig dependencies.

[...]

Applied, thanks!

[3/4] mfd: wl1273-core: Remove

      commit: 2ec8f54725b2ae4f08aeae0483410280e72877e3
[4/4] mfd: wl1273-core: Remove the header
      commit: 5576355937ad7d0ec86ca2cdf4e82cb0f70cd227

--
Lee Jones [李琼斯]