Skip to contentSkip to conversation

selftests-mm-fix-validate_addr-helper.patch removed from -mm tree

merged mm-hotfixes-stable Andrew Morton 1 participant 1 message Jun 25, 2025

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: selftests/mm: fix validate_addr() helper
has been removed from the -mm tree. Its filename was
selftests-mm-fix-validate_addr-helper.patch

This patch was dropped because it was merged into the mm-hotfixes-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Dev Jain <[email protected]>
Subject: selftests/mm: fix validate_addr() helper
Date: Fri, 20 Jun 2025 16:41:50 +0530

validate_addr() checks whether the address returned by mmap() lies in the low or high VA space, according to whether a high addr hint was passed or not. The fix commit mentioned below changed the code in such a way that this function will always return failure when passed high_addr == 1; addr will be >= HIGH_ADDR_MARK always, we will fall down to "if (addr > HIGH_ADDR_MARK)" and return failure. Fix this.

Fixes d1d86ce28d0f ("selftests/mm: virtual_address_range: conform to TAP format output")
Cc Anshuman Khandual <[email protected]>
Cc Lorenzo Stoakes <[email protected]>
Cc Ryan Roberts <[email protected]>
Cc Shuah Khan <[email protected]>

---

 tools/testing/selftests/mm/virtual_address_range.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
tools/testing/selftests/mm/virtual_address_range.c renamed from tools/testing/selftests/mm/virtual_address_range.c~selftests-mm-fix-validate_addr-helper +5 -2
@@ -77,8 +77,11 @@ static void validate_addr(char *ptr, int
 {
 	unsigned long addr = (unsigned long) ptr;
 
-	if (high_addr && addr < HIGH_ADDR_MARK)
-		ksft_exit_fail_msg("Bad address %lx\n", addr);
+	if (high_addr) {
+		if (addr < HIGH_ADDR_MARK)
+			ksft_exit_fail_msg("Bad address %lx\n", addr);
+		return;
+	}
 
 	if (addr > HIGH_ADDR_MARK)
 		ksft_exit_fail_msg("Bad address %lx\n", addr);

_

Patches currently in -mm which might be from [email protected] are

xarray-add-a-bug_on-to-ensure-caller-is-not-sibling.patch mm-call-pointers-to-ptes-as-ptep.patch mm-optimize-mremap-by-pte-batching.patch maple-tree-use-goto-label-to-simplify-code.patch