xfs: add FALLOC_FL_ALLOCATE_RANGE to supported flags mask
PATCH 1/1 xfs: add FALLOC_FL_ALLOCATE_RANGE to supported flags mask
From: Youling Tang <[email protected]>
Add FALLOC_FL_ALLOCATE_RANGE to the set of supported fallocate flags in XFS_FALLOC_FL_SUPPORTED. This change improves code clarity and maintains by explicitly showing this flag in the supported flags mask.
Note that since FALLOC_FL_ALLOCATE_RANGE is defined as 0x00, this addition has no functional modifications.
--- fs/xfs/xfs_file.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
fs/xfs/xfs_file.c +2 -1
@@ -1335,7 +1335,8 @@ xfs_falloc_allocate_range( }#define XFS_FALLOC_FL_SUPPORTED \ - (FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE | \ + (FALLOC_FL_KEEP_SIZE | \ + FALLOC_FL_ALLOCATE_RANGE | FALLOC_FL_PUNCH_HOLE | \ FALLOC_FL_COLLAPSE_RANGE | FALLOC_FL_ZERO_RANGE | \ FALLOC_FL_INSERT_RANGE | FALLOC_FL_UNSHARE_RANGE)
Signature · 1 line
2.34.1
Quoted 19 lines · Youling Tang
From: Youling Tang <[email protected]>
Add
FALLOC_FL_ALLOCATE_RANGEto the set of supported fallocate flags inXFS_FALLOC_FL_SUPPORTED. This change improves code clarity and maintains by explicitly showing this flag in the supported flags mask.Note that since
FALLOC_FL_ALLOCATE_RANGEis defined as0x00, this addition has no functional modifications.Signed-off-by Youling Tang <[email protected]>--- fs/xfs/xfs_file.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)fs/xfs/xfs_file.c +0
-0
fs/xfs/xfs_file.c xfs_falloc_allocate_range( · line 1341
Quoted 8 lines
fs/xfs/xfs_file.c +2
-1@@ -1335,7 +1335,8 @@ xfs_falloc_allocate_range( }#define XFS_FALLOC_FL_SUPPORTED \ - (FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE | \ + (FALLOC_FL_KEEP_SIZE | \ + FALLOC_FL_ALLOCATE_RANGE | FALLOC_FL_PUNCH_HOLE | \ FALLOC_FL_COLLAPSE_RANGE | FALLOC_FL_ZERO_RANGE | \ FALLOC_FL_INSERT_RANGE | FALLOC_FL_UNSHARE_RANGE)
This sounds reasonable. Could you please add it as the first flag to keep "the right order"?
Other than this nitpick, you can add:
Quoted 5 lines
fs/xfs/xfs_file.c +0
-1--2.34.1