Skip to contentSkip to conversation

mm/damon/sysfs-schemes: make damos_sysfs_action_names static

PATCH In review SeongJae Park 1 participant 2 messages Jun 27, 2025

Subsystems (2)
lore
Share & tools
lore

SeongJae Park

author maintainer
#0 lore raw

PATCH 1/1 mm/damon/sysfs-schemes: make damos_sysfs_action_names static

Commit 6812c66db976 ("mm/damon/sysfs-schemes: decouple from damos_action") in mm-unstable is defining damos_sysfs_action_names as non-static, though it is being used only inside sysfs-schemes.c file. Make it static.

Fixes 6812c66db976 ("mm/damon/sysfs-schemes: decouple from damos_action") # mm-unstable
---
 mm/damon/sysfs-schemes.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/damon/sysfs-schemes.c +1 -1
index 5243b94cec24..601360e9b521 100644
@@ -1679,7 +1679,7 @@ struct damos_sysfs_action_name {
 	char *name;
 };
 
-struct damos_sysfs_action_name damos_sysfs_action_names[] = {
+static struct damos_sysfs_action_name damos_sysfs_action_names[] = {
 	{
 		.action = DAMOS_WILLNEED,
 		.name = "willneed",

base-commit: 5de4c740b52ae67feaa1d08690e37e813b2281d5

Signature · 1 line
2.39.5
author maintainer
#1 lore raw
Quoted 10 lines · On Fri, 27 Jun 2025 09:28:06 -0700 SeongJae Park <[email protected]> wrote:

Commit 6812c66db976 ("mm/damon/sysfs-schemes: decouple from damos_action") in mm-unstable is defining damos_sysfs_action_names as non-static, though it is being used only inside sysfs-schemes.c file. Make it static.

Fixes 6812c66db976 ("mm/damon/sysfs-schemes: decouple from damos_action") # mm-unstable

I forgot noting this patch to the report, and Andrew thankfully made and merged a fix[1] that is same to this one. So this patch may be just ignored in favor of the already merged same fix. Noting it here just for a case of future readers.

[1] https://lore.kernel.org/[email protected]

Thanks,
SJ

[...]